Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2025-01-20 15:29:26 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

CA-249845: Compiling the server status reports sometime fails with Sy… (#1542)

Browse Source 
* CA-249845: Compiling the server status reports sometime fails with System.IO.IOException: The process cannot access the file because it is being used by another process

Add a retry mechanism around the File.Move, because the operation sometimes fails when there is an anti-virus running on the XenCenter machine (we are doing the move immediately after we finished writing the file and the anti-virus software might be checking the file at that point)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-249845: Compiling the server status reports sometime fails with System.IO.IOException: The process cannot access the file because it is being used by another process

Extract the move with retry into a separate function

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
This commit is contained in:
Mihaela Stoica 2017-04-21 17:29:39 +01:00 committed by Stephen Turner
parent 6681f5757d
commit 1e46c29e48
1 changed files with 28 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
XenModel/XenAPI/HTTP.cs
View File

@ -709,7 +709,7 @@ namespace XenAPI
/// <summary>
/// A general HTTP GET method, with delegates for progress and cancelling. May throw various exceptions.
/// </summary>
/// <param name="dataRxDelegate">Delegate called periodically (500 ms) with the number of bytes transferred</param>
/// <param name="dataCopiedDelegate">Delegate called periodically (500 ms) with the number of bytes transferred</param>
/// <param name="cancellingDelegate">Delegate called periodically to see if need to cancel</param>
/// <param name="uri">URI to GET from</param>
/// <param name="proxy">A proxy to handle the HTTP connection</param>
@ -729,12 +729,38 @@ namespace XenAPI
}
File.Delete(path);
File.Move(tmpFile, path);
MoveFileWithRetry(tmpFile, path);
}
finally
{
File.Delete(tmpFile);
}
}
private const int FILE_MOVE_MAX_RETRIES = 5;
private const int FILE_MOVE_SLEEP_BETWEEN_RETRIES = 100;
/// <summary>
/// Move a file, retrying a few times with a short sleep between retries.
/// If it still fails after these retries, then throw the error.
/// </summary>
public static void MoveFileWithRetry(string sourceFileName, string destFileName)
{
int retriesRemaining = FILE_MOVE_MAX_RETRIES;
do
{
try
{
File.Move(sourceFileName, destFileName);
break;
}
catch (IOException)
{
if (retriesRemaining <= 0)
throw;
System.Threading.Thread.Sleep(FILE_MOVE_SLEEP_BETWEEN_RETRIES);
}
} while (retriesRemaining-- > 0);
}
}
}