Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-11-25 06:16:37 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

CA-284914: Prechecks are re-run every time the 'Hide successful prech… (#2088)

Browse Source 
* CA-284914: Prechecks are re-run every time the 'Hide successful prechecks' is ticked/unticked

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* fix some comments
This commit is contained in:
jishengx 2018-07-26 23:11:53 +08:00 committed by Mihaela Stoica
parent f663ababd5
commit 260ec2d013
1 changed files with 31 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
View File

@ -58,6 +58,7 @@ namespace XenAdmin.Wizards.PatchingWizard
public List<Host> SelectedServers = new List<Host>(); public List<Host> SelectedServers = new List<Host>();
private readonly List<Problem> ProblemsResolvedPreCheck = new List<Problem>(); private readonly List<Problem> ProblemsResolvedPreCheck = new List<Problem>();
private AsyncAction resolvePrechecksAction; private AsyncAction resolvePrechecksAction;
private List<DataGridViewRow> allRows = new List<DataGridViewRow>();
private bool _isRecheckQueued; private bool _isRecheckQueued;
public Dictionary<Pool_update, Dictionary<Host, SR>> SrUploadedUpdates = new Dictionary<Pool_update, Dictionary<Host, SR>>(); public Dictionary<Pool_update, Dictionary<Host, SR>> SrUploadedUpdates = new Dictionary<Pool_update, Dictionary<Host, SR>>();
@ -197,6 +198,8 @@ namespace XenAdmin.Wizards.PatchingWizard
PreCheckHostRow rowHost = e.UserState as PreCheckHostRow; PreCheckHostRow rowHost = e.UserState as PreCheckHostRow;
if (rowHost != null) if (rowHost != null)
{ {
allRows.Add(rowHost);
if (checkBoxViewPrecheckFailuresOnly.Checked && rowHost.Problem != null || !checkBoxViewPrecheckFailuresOnly.Checked) if (checkBoxViewPrecheckFailuresOnly.Checked && rowHost.Problem != null || !checkBoxViewPrecheckFailuresOnly.Checked)
AddRowToGridView(rowHost); AddRowToGridView(rowHost);
} }
@ -205,6 +208,7 @@ namespace XenAdmin.Wizards.PatchingWizard
var row = e.UserState as DataGridViewRow; var row = e.UserState as DataGridViewRow;
if (row != null && !dataGridView1.Rows.Contains(row)) if (row != null && !dataGridView1.Rows.Contains(row))
{ {
allRows.Add(row);
AddRowToGridView(row); AddRowToGridView(row);
} }
} }
@ -288,6 +292,8 @@ namespace XenAdmin.Wizards.PatchingWizard
int totalChecks = groups.Sum(c => c.Value == null ? 0 : c.Value.Count); int totalChecks = groups.Sum(c => c.Value == null ? 0 : c.Value.Count);
int doneCheckIndex = 0; int doneCheckIndex = 0;
allRows.Clear();
foreach (var group in groups) foreach (var group in groups)
{ {
if (bgw.CancellationPending) if (bgw.CancellationPending)
@ -949,7 +955,31 @@ namespace XenAdmin.Wizards.PatchingWizard
private void checkBox1_CheckedChanged(object sender, EventArgs e) private void checkBox1_CheckedChanged(object sender, EventArgs e)
{ {
RefreshRechecks(); RefreshDataGridViewList();
}
private void RefreshDataGridViewList()
{
lock (_update_grid_lock)
{
dataGridView1.Rows.Clear();
foreach (var row in allRows)
{
var hostRow = row as PreCheckHostRow;
if (hostRow != null)
{
if (hostRow.Problem != null || !checkBoxViewPrecheckFailuresOnly.Checked)
{
AddRowToGridView(hostRow);
}
}
else
{
AddRowToGridView(row);
}
}
}
} }
private void dataGridView1_CellMouseMove(object sender, DataGridViewCellMouseEventArgs e) private void dataGridView1_CellMouseMove(object sender, DataGridViewCellMouseEventArgs e)