Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-11-24 22:06:59 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

CA-365905 (XSI-1215): Create a temporary file in the target download folder if the latter is in a different drive from the default temporary folder.

Browse Source 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
This commit is contained in:
Konstantina Chremmou 2022-04-22 14:07:20 +01:00
parent 1928cf3db7
commit 4496d4571d
1 changed files with 21 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
XenModel/XenAPI/HTTP.cs
View File

@ -75,9 +75,7 @@ namespace XenAPI
public override void GetObjectData(SerializationInfo info, StreamingContext context)
{
if (info == null)
{
throw new ArgumentNullException("info");
}
throw new ArgumentNullException(nameof(info));
info.AddValue("redirect", redirect);
info.AddValue("uri", uri, typeof(Uri));
@ -767,11 +765,29 @@ namespace XenAPI
public static void Get(DataCopiedDelegate dataCopiedDelegate, FuncBool cancellingDelegate,
Uri uri, IWebProxy proxy, string path, int timeoutMs)
{
string tmpFile = Path.GetTempFileName();
if (string.IsNullOrWhiteSpace(path))
throw new ArgumentException(nameof(path));
var tmpFile = Path.GetTempFileName();
if (Path.GetPathRoot(path) != Path.GetPathRoot(tmpFile))
{
//CA-365905: if the target path is under a root different from
//the temp file, use instead a temp file under the target root,
//otherwise there may not be enough space for the download
var dir = Path.GetDirectoryName(path);
if (dir == null) //path is root directory
throw new ArgumentException(nameof(path));
tmpFile = Path.Combine(dir, Path.GetRandomFileName());
File.Delete(tmpFile);
}
try
{
using (Stream fileStream = new FileStream(tmpFile, FileMode.Create, FileAccess.Write, FileShare.None),
downloadStream = HttpGetStream(uri, proxy, timeoutMs))
downloadStream = HttpGetStream(uri, proxy, timeoutMs))
{
CopyStream(downloadStream, fileStream, dataCopiedDelegate, cancellingDelegate);
fileStream.Flush();