Merge pull request #1807 from MihaelaStoica/CA-266814

CA-266814: Fix the precheck that requires shared CDs to be ejected pr…
This commit is contained in:
Gabor Apati-Nagy 2017-10-10 14:09:03 +01:00 committed by GitHub
commit 4a574a8728
4 changed files with 20 additions and 1 deletions

View File

@ -90,7 +90,7 @@ namespace XenAdmin.Diagnostics.Checks
problems.Add(new ToolsCD(this, residentVM));
VMsWithProblems.Add(residentVM.opaque_ref);
}
else if (sr != null && sr.content_type == SR.Content_Type_ISO)
else if (sr != null && sr.content_type == SR.Content_Type_ISO && (!sr.shared || Properties.Settings.Default.EjectSharedIsoOnUpdate))
{
problems.Add(new LocalCD(this, residentVM));
VMsWithProblems.Add(residentVM.opaque_ref);

View File

@ -812,5 +812,18 @@ namespace XenAdmin.Properties {
this["HelpLastUsed"] = value;
}
}
[global::System.Configuration.UserScopedSettingAttribute()]
[global::System.Diagnostics.DebuggerNonUserCodeAttribute()]
[global::System.Configuration.DefaultSettingValueAttribute("False")]
[global::System.Configuration.SettingsManageabilityAttribute(global::System.Configuration.SettingsManageability.Roaming)]
public bool EjectSharedIsoOnUpdate {
get {
return ((bool)(this["EjectSharedIsoOnUpdate"]));
}
set {
this["EjectSharedIsoOnUpdate"] = value;
}
}
}
}

View File

@ -188,5 +188,8 @@
<Setting Name="HelpLastUsed" Roaming="true" Type="System.String" Scope="User">
<Value Profile="(Default)" />
</Setting>
<Setting Name="EjectSharedIsoOnUpdate" Roaming="true" Type="System.Boolean" Scope="User">
<Value Profile="(Default)">False</Value>
</Setting>
</Settings>
</SettingsFile>

View File

@ -183,6 +183,9 @@
<setting name="HelpLastUsed" serializeAs="String">
<value />
</setting>
<setting name="EjectSharedIsoOnUpdate" serializeAs="String">
<value>False</value>
</setting>
</XenAdmin.Properties.Settings>
</userSettings>