Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2025-01-20 23:39:51 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

CA-339590: Add conditional page control refresh in HA Wizard (#2846)

Browse Source 
* CA-339590: Add conditional page control refresh in HA Wizard
* CA-339590: Remove remaining HA Wizard page control reloads
Removed PopulatePageControls method and used PopulatePage override instead.
Removed IsDirty implementation from AssignPriorities.
* CA-339590: Remove useless calls to IsDirty in AssignPriorities
Call did not serve any purposes after previous switch to PopulatePage method
* CA-339590: Remove `IsFirstLoad` check for SR scan in HAWizard
Check was not necessary for CA-339590

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
This commit is contained in:
Danilo Del Busso 2021-08-16 11:01:35 +01:00 committed by GitHub
parent af832f23cf
commit 5a0094341b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
XenAdmin/Dialogs/EditVmHaPrioritiesDialog.cs
View File

@ -81,7 +81,7 @@ namespace XenAdmin.Dialogs
{
base.OnShown(e);
assignPriorities.Connection = pool.Connection;
assignPriorities.PopulatePageControls();
assignPriorities.PopulatePage();
}
protected override void OnClosing(CancelEventArgs e)

8
XenAdmin/Wizards/HAWizard_Pages/AssignPriorities.cs
View File

@ -72,10 +72,9 @@ namespace XenAdmin.Wizards.HAWizard_Pages
}
}
internal void PopulatePageControls()
public override void PopulatePage()
{
Debug.Assert(connection != null, "Connection is null; set it to non-null before calling this method.");
UpdateMenuItems();
PopulateVMs();
haNtolIndicator.Connection = Connection;
@ -712,11 +711,6 @@ namespace XenAdmin.Wizards.HAWizard_Pages
StopNtolUpdate();
}
protected override void PageLoadedCore(PageLoadedDirection direction)
{
PopulatePageControls();
}
public override void SelectDefaultControl()
{
dataGridViewVms.Select();