Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-11-23 20:36:33 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

CP-7686: Make check-for-updates work in the presence of service packs by using the new fields from updates.xml, requiredpatches and conflictingpatches.

Browse Source 
Changed the way the dependency patches are fetched, to avoid getting an exception if
requiredpatches/conflictingpatches node has at least one child that has no uuid attribute,
also checking the child name

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
This commit is contained in:
Mihaela Stoica 2014-03-05 10:29:59 +00:00
parent 2ca98a7638
commit 5e5a8d7cb2
1 changed files with 31 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
XenModel/Actions/Updates/DownloadUpdatesXmlAction.cs
View File

@ -48,6 +48,9 @@ namespace XenAdmin.Actions
private const string PatchesNode = "patches";
private const string ConflictingPatchesNode = "conflictingpatches";
private const string RequiredPatchesNode = "requiredpatches";
private const string ConflictingPatchNode = "conflictingpatch";
private const string RequiredPatchNode = "requiredpatch";
private const string UpdateXmlUrl = @"http://updates.xensource.com/XenServer/updates.xml";
public List<XenCenterVersion> XenCenterVersions { get; private set; }
@ -155,33 +158,40 @@ namespace XenAdmin.Actions
priority = attrib.Value;
}
var conflictingPatches = new List<string>();
var requiredPatches = new List<string>();
var conflictingPatches = GetPatchDependencies(version, ConflictingPatchesNode, ConflictingPatchNode);
var requiredPatches = GetPatchDependencies(version, RequiredPatchesNode, RequiredPatchNode);
var conflictingPatchesNode = version.ChildNodes.Cast<XmlNode>().FirstOrDefault(childNode => childNode.Name == ConflictingPatchesNode);
if (conflictingPatchesNode != null)
{
conflictingPatches.AddRange(from XmlNode node in conflictingPatchesNode.ChildNodes
where node.Attributes != null
select node.Attributes.Cast<XmlAttribute>().First(attrib => attrib.Name == "uuid").Value);
}
var requiredPatchesNode = version.ChildNodes.Cast<XmlNode>().FirstOrDefault(childNode => childNode.Name == RequiredPatchesNode);
if (requiredPatchesNode != null)
{
requiredPatches.AddRange(from XmlNode node in requiredPatchesNode.ChildNodes
where node.Attributes != null
select node.Attributes.Cast<XmlAttribute>().First(attrib => attrib.Name == "uuid").Value);
}
XenServerPatches.Add(new XenServerPatch(uuid, name, description, guidance, patchVersion, url,
XenServerPatches.Add(new XenServerPatch(uuid, name, description, guidance, patchVersion, url,
patchUrl, timestamp, priority, conflictingPatches, requiredPatches));
}
}
}
// dependencies patches are listed in the xml as below:
// <conflictingpatches>
// <conflictingpatch uuid="00000000-0000-0000-0000-000000000000">
// </conflictingpatch>
// </conflictingpatches>
// <requiredpatches>
// <requiredgpatch uuid="00000000-0000-0000-0000-000000000000">
// </requiredgpatch>
// </requiredpatches>
private static List<string> GetPatchDependencies(XmlNode patchsNode, string dependenciesNodeName, string dependencyNodeName)
{
var dependenciesNode = patchsNode.ChildNodes.Cast<XmlNode>().FirstOrDefault(childNode => childNode.Name == dependenciesNodeName);
if (dependenciesNode == null)
return null;
var dependencies = new List<string>();
dependencies.AddRange(from XmlNode node in dependenciesNode.ChildNodes
from XmlAttribute attrib in node.Attributes
where node.Name == dependencyNodeName && node.Attributes != null && attrib.Name == "uuid"
select attrib.Value);
return dependencies;
}
private void GetXenServerVersions(XmlDocument xdoc)
{
if (!_checkForServerVersion)