Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-11-23 20:36:33 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

CP-5750: Avoid creating new ToolstripMenuItems every time an action is updated,

Browse Source 
but choose instead which ones to display.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
This commit is contained in:
Konstantina Chremmou 2013-08-19 13:17:33 +01:00
parent 4b6871d4af
commit 620e268a6b
1 changed files with 20 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
XenAdmin/TabPages/HistoryPage.cs
View File

@ -371,6 +371,10 @@ namespace XenAdmin.TabPages
private DataGridViewTextBoxCell dateCell = new DataGridViewTextBoxCell();
private DataGridViewDropDownSplitButtonCell actionCell = new DataGridViewDropDownSplitButtonCell();
private ToolStripMenuItem cancelItem = new ToolStripMenuItem(Messages.CANCEL);
private ToolStripMenuItem dismissItem = new ToolStripMenuItem(Messages.ALERT_DISMISS);
private ToolStripMenuItem goToItem = new ToolStripMenuItem(Messages.HISTORYPAGE_GOTO);
public event Action<DataGridViewActionRow> DismissalRequested;
public event Action<IXenObject> GoToXenObjectRequested;
@ -380,6 +384,11 @@ namespace XenAdmin.TabPages
public DataGridViewActionRow(ActionBase action)
{
Action = action;
cancelItem.Click += ToolStripMenuItemCancel_Click;
dismissItem.Click += ToolStripMenuItemDismiss_Click;
goToItem.Click += ToolStripMenuItemGoTo_Click;
MinimumHeight = DataGridViewDropDownSplitButtonCell.MIN_ROW_HEIGHT;
Cells.AddRange(expanderCell, statusCell, messageCell, locationCell, dateCell, actionCell);
RefreshSelf();
@ -387,7 +396,17 @@ namespace XenAdmin.TabPages
public void RefreshSelf()
{
var actionItems = GetActionItems(Action);
var actionItems = new List<ToolStripItem>();
if (!Action.IsCompleted && Action.CanCancel)
actionItems.Add(cancelItem);
if (Action.IsCompleted)
actionItems.Add(dismissItem);
var obj = Action.GetRelevantXenObject();
if (obj != null)
actionItems.Add(goToItem);
actionCell.RefreshItems(actionItems.ToArray());
statusCell.Value = Action.GetImage();
@ -406,35 +425,6 @@ namespace XenAdmin.TabPages
dateCell.Value = HelpersGUI.DateTimeToString(Action.Started.ToLocalTime(), Messages.DATEFORMAT_DMY_HM, true);
}
private List<ToolStripItem> GetActionItems(ActionBase action)
{
var items = new List<ToolStripItem>();
if (!action.IsCompleted && action.CanCancel)
{
var cancel = new ToolStripMenuItem(Messages.CANCEL);
cancel.Click += ToolStripMenuItemCancel_Click;
items.Add(cancel);
}
if (action.IsCompleted)
{
var dismiss = new ToolStripMenuItem(Messages.ALERT_DISMISS);
dismiss.Click += ToolStripMenuItemDismiss_Click;
items.Add(dismiss);
}
var obj = action.GetRelevantXenObject();
if (obj != null)
{
var goTo = new ToolStripMenuItem(Messages.HISTORYPAGE_GOTO);
goTo.Click += ToolStripMenuItemGoTo_Click;
items.Add(goTo);
}
return items;
}
private void ToolStripMenuItemCancel_Click(object sender, EventArgs e)
{
Action.Cancel();