Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-11-21 17:11:29 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Hide from designer TabPage properties that are not meaningful at design time. Minor tidy up.

Browse Source 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
This commit is contained in:
Konstantina Chremmou 2023-09-08 15:41:25 +01:00
parent 9b2204d3df
commit 7b41c3a82c
10 changed files with 43 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
XenAdmin/Controls/AD/LoggedInLabel.cs
View File

@ -28,6 +28,7 @@
* SUCH DAMAGE.
*/
using System.ComponentModel;
using System.Drawing;
using System.Windows.Forms;
using XenAPI;
@ -39,6 +40,9 @@ namespace XenAdmin.Controls
public partial class LoggedInLabel : UserControl
{
private IXenConnection connection;
[Browsable(false)]
[DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
public IXenConnection Connection
{
get

1
XenAdmin/MainWindow.Designer.cs generated
View File

@ -588,7 +588,6 @@ namespace XenAdmin
//
resources.ApplyResources(this.loggedInLabel1, "loggedInLabel1");
this.loggedInLabel1.BackColor = System.Drawing.Color.Transparent;
this.loggedInLabel1.Connection = null;
this.loggedInLabel1.Name = "loggedInLabel1";
//
// labelFiltersOnOff

3
XenAdmin/TabPages/DockerDetailsPage.cs
View File

@ -37,6 +37,7 @@ using XenAPI;
using XenAdmin.Model;
using System.Xml;
using System.Collections;
using System.ComponentModel;
namespace XenAdmin.TabPages
{
@ -49,6 +50,8 @@ namespace XenAdmin.TabPages
private Host host;
private string cachedResult;
[Browsable(false)]
[DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
public DockerContainer DockerContainer
{
get

3
XenAdmin/TabPages/DockerProcessPage.cs
View File

@ -30,6 +30,7 @@
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Xml;
using System.Windows.Forms;
using XenAdmin.Actions;
@ -61,6 +62,8 @@ namespace XenAdmin.TabPages
public override string HelpID => "TabPageDockerProcess";
[Browsable(false)]
[DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
public DockerContainer DockerContainer
{
get

2
XenAdmin/TabPages/NICPage.cs
View File

@ -57,6 +57,8 @@ namespace XenAdmin.TabPages
private readonly CollectionChangeEventHandler PIF_CollectionChangedWithInvoke;
[Browsable(false)]
[DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
public Host Host
{
get

6
XenAdmin/TabPages/NetworkPage.cs
View File

@ -30,6 +30,7 @@
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Windows.Forms;
using XenAPI;
@ -44,9 +45,12 @@ namespace XenAdmin.TabPages
private static readonly log4net.ILog log = log4net.LogManager.GetLogger(System.Reflection.MethodBase.GetCurrentMethod().DeclaringType);
// We don't rebuild the controls while the tab is not visible, but instead queue it up later for when the page is displayed.
private bool refreshNeeded = false;
private bool refreshNeeded;
private IXenObject _xenObject;
[Browsable(false)]
[DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
public IXenObject XenObject
{
get

2
XenAdmin/TabPages/PvsPage.cs
View File

@ -71,6 +71,8 @@ namespace XenAdmin.TabPages
public override string HelpID => "TabPagePvs";
[Browsable(false)]
[DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
public IXenConnection Connection
{
get

2
XenAdmin/TabPages/SnapshotsPage.cs
View File

@ -115,6 +115,8 @@ namespace XenAdmin.TabPages
}
}
[DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
[Browsable(false)]
public VM VM
{
set

28
XenAdmin/TabPages/UpsellTabPage.cs
View File

@ -28,6 +28,7 @@
* SUCH DAMAGE.
*/
using System.ComponentModel;
using XenAdmin.Core;
@ -35,31 +36,28 @@ namespace XenAdmin.TabPages
{
public partial class UpsellTabPage : BaseTabPage
{
protected UpsellTabPage(string title, string blurb)
protected UpsellTabPage()
{
InitializeComponent();
base.Text = title;
BlurbText = blurb;
LearnMoreUrl = InvisibleMessages.UPSELL_LEARNMOREURL_TRIAL;
}
public string BlurbText
protected string BlurbText
{
set => upsellPage1.BlurbText = value;
}
public string LearnMoreUrl
protected string Title
{
set => upsellPage1.LearnMoreUrl = value;
set => Text = value;
}
}
public class ADUpsellPage : UpsellTabPage
{
public ADUpsellPage()
: base(Messages.ACTIVE_DIRECTORY_TAB_TITLE, string.Format(Messages.UPSELL_BLURB_AD, BrandManager.ProductBrand))
{
Title = Messages.ACTIVE_DIRECTORY_TAB_TITLE;
BlurbText = string.Format(Messages.UPSELL_BLURB_AD, BrandManager.ProductBrand);
}
public override string HelpID => "TabPageADUpsell";
@ -68,8 +66,10 @@ namespace XenAdmin.TabPages
public class HAUpsellPage : UpsellTabPage
{
public HAUpsellPage()
: base(Messages.HIGH_AVAILABILITY, Messages.UPSELL_BLURB_HA)
{ }
{
Title = Messages.HIGH_AVAILABILITY;
BlurbText = Messages.UPSELL_BLURB_HA;
}
public override string HelpID => "TabPageHAUpsell";
}
@ -77,8 +77,10 @@ namespace XenAdmin.TabPages
public class WLBUpsellPage : UpsellTabPage
{
public WLBUpsellPage()
: base(Messages.WORKLOAD_BALANCING, Messages.UPSELL_BLURB_WLB)
{ }
{
Title = Messages.WORKLOAD_BALANCING;
BlurbText = Messages.UPSELL_BLURB_WLB;
}
public override string HelpID => "TabPageWLBUpsell";
}

17
XenAdmin/TabPages/UsbPage.cs
View File

@ -43,6 +43,8 @@ namespace XenAdmin.TabPages
public partial class UsbPage : BaseTabPage
{
private Host _host;
private HostUsbRow selectedRow;
private bool InBuildList;
public UsbPage()
{
@ -56,6 +58,8 @@ namespace XenAdmin.TabPages
public override string HelpID => "TabPageUSB";
[Browsable(false)]
[DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
public IXenObject XenObject
{
get
@ -80,7 +84,6 @@ namespace XenAdmin.TabPages
}
}
public bool InBuildList = false;
private void BuildList()
{
Program.AssertOnEventThread();
@ -121,11 +124,6 @@ namespace XenAdmin.TabPages
}
}
protected override void OnVisibleChanged(EventArgs e)
{
base.OnVisibleChanged(e);
}
public override void PageHidden()
{
UnregisterHandlers();
@ -133,12 +131,12 @@ namespace XenAdmin.TabPages
base.PageHidden();
}
void Host_PropertyChanged(object sender, PropertyChangedEventArgs e)
private void Host_PropertyChanged(object sender, PropertyChangedEventArgs e)
{
RefreshAllItems();
}
void UsbCollectionChanged(object sender, EventArgs e)
private void UsbCollectionChanged(object sender, EventArgs e)
{
BuildList();
}
@ -153,7 +151,7 @@ namespace XenAdmin.TabPages
}
}
internal void UnregisterHandlers()
private void UnregisterHandlers()
{
if (_host != null)
{
@ -169,7 +167,6 @@ namespace XenAdmin.TabPages
}
}
private HostUsbRow selectedRow = null;
private void dataGridViewUsbList_SelectionChanged(object sender, EventArgs e)
{
selectedRow = null;