From 9a9f117dd87674f67a7181cc79df944a4d6ddcc1 Mon Sep 17 00:00:00 2001 From: Gabor Apati-Nagy Date: Tue, 8 Dec 2015 11:38:10 +0000 Subject: [PATCH] CA-189084: Control domain memory alerts not getting generated in Xencenter. Added logging to catch {} --- XenAdmin/SettingsPanels/PerfmonAlertEditPage.cs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/XenAdmin/SettingsPanels/PerfmonAlertEditPage.cs b/XenAdmin/SettingsPanels/PerfmonAlertEditPage.cs index 951be65ea..088332cee 100644 --- a/XenAdmin/SettingsPanels/PerfmonAlertEditPage.cs +++ b/XenAdmin/SettingsPanels/PerfmonAlertEditPage.cs @@ -267,7 +267,10 @@ namespace XenAdmin.SettingsPanels physicalUtilisationAlert.Populate(perfmonDefinition); } } - catch { } + catch (Exception ex) + { + log.Error("Unexpected error during populating controls for Alerts. Exception swallowed.", ex); //Adding this to pre-existing empty catch block to log it at least + } // Dom0 memory usage is stored in the other_config of the Dom0 vm not on the host (or any other XenObject) try @@ -295,7 +298,7 @@ namespace XenAdmin.SettingsPanels } catch (Exception ex) { - log.Error("Unexpected error during populating controls for Dom0 Memory Usage alert. Leaving it as is.", ex); + log.Error("Unexpected error during populating controls for Dom0 Memory Usage alert. Exception swallowed.", ex); //Any error here will cause the controls not being populated, but they will be still usable. } }