Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-11-23 20:36:33 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Apply code review suggestions

Browse Source 
- Use `Nullable.HasValue` and `Nullable.Value` to handle `DateTime?` type returned by `LicenseCssExpiry`
- Check UTC time when checking CSS license expiry

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
This commit is contained in:
Danilo Del Busso 2023-07-17 09:33:34 +01:00
parent b8a3a7cdeb
commit cd920531c8
No known key found for this signature in database
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
XenAdmin/Dialogs/LicenseManager/LicenseStatus.cs
View File

@ -361,9 +361,8 @@ namespace XenAdmin.Dialogs
{ {
entitlements.Add(Messages.LICENSE_NOT_ELIGIBLE_FOR_SUPPORT); entitlements.Add(Messages.LICENSE_NOT_ELIGIBLE_FOR_SUPPORT);
} }
} }
else if (CurrentState == HostState.Free)
if (CurrentState == HostState.Free)
{ {
entitlements.Add(Messages.LICENSE_NOT_ELIGIBLE_FOR_SUPPORT); entitlements.Add(Messages.LICENSE_NOT_ELIGIBLE_FOR_SUPPORT);
} }

4
XenModel/XenAPI-Extensions/Host.cs
View File

@ -353,10 +353,10 @@ namespace XenAPI
{ {
var cssExpiry = LicenseCssExpiry(); var cssExpiry = LicenseCssExpiry();
if (cssExpiry != null) if (cssExpiry.HasValue)
{ {
// User can circumvent this by changing system date // User can circumvent this by changing system date
return DateTime.Now > cssExpiry; return DateTime.UtcNow > cssExpiry.Value;
} }
return false; return false;