Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-11-25 06:16:37 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

CA-364330 wraps cyptoexception in try catch to show appropriate message (#2968)

Browse Source 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
This commit is contained in:
CitrixChris 2022-03-10 14:16:13 +00:00 committed by GitHub
parent ff76729940
commit f0f0de0076
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
XenModel/Actions/Updates/DownloadAndUpdateClientAction.cs
View File

@ -222,22 +222,23 @@ namespace XenAdmin.Actions
throw new Exception(Messages.UPDATE_CLIENT_INVALID_CHECKSUM ); throw new Exception(Messages.UPDATE_CLIENT_INVALID_CHECKSUM );
} }
bool valid; bool valid = false;
// Check digital signature of .msi try
using (var basicSigner = X509Certificate.CreateFromSignedFile(outputPathAndFileName))
{ {
using (var cert = new X509Certificate2(basicSigner)) // Check digital signature of .msi
using (var basicSigner = X509Certificate.CreateFromSignedFile(outputPathAndFileName))
{ {
try using (var cert = new X509Certificate2(basicSigner))
{ {
valid = cert.Verify(); valid = cert.Verify();
} }
catch (Exception e)
{
throw new Exception(Messages.UPDATE_CLIENT_FAILED_CERTIFICATE_CHECK, e);
}
} }
} }
catch (Exception e)
{
throw new Exception(Messages.UPDATE_CLIENT_FAILED_CERTIFICATE_CHECK, e);
}
if (!valid) if (!valid)
throw new Exception(Messages.UPDATE_CLIENT_INVALID_DIGITAL_CERTIFICATE); throw new Exception(Messages.UPDATE_CLIENT_INVALID_DIGITAL_CERTIFICATE);