Commit Graph

6738 Commits

Author SHA1 Message Date
Konstantina Chremmou
e1c808eb8f Corrections as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-22 16:44:32 +00:00
Konstantina Chremmou
e29b8b39d5 Removed dependency on IonicZip. Use the corresponding classes of .NET Framework.
Also renamed the archive classes because they were named after the 3rd
party library used and were confusing.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-18 16:53:30 +00:00
Konstantina Chremmou
8804038dc4 Removed code for bz2 because it has never been used/exposed in the UI.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-18 12:20:59 +00:00
Konstantina Chremmou
3a59c2490c Replaced static field with optional parameter to switch verbose debugging off.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-18 11:22:41 +00:00
Konstantina Chremmou
a98d516bbe Removed delegate definitions and some unused code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-17 14:49:35 +00:00
Konstantina Chremmou
a77f3c3994 Corrections per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-16 17:36:17 +00:00
Konstantina Chremmou
a3569aa875 CP-41048: Add each SR to the SrPicker as soon as its scan finishes, without waiting for the other scans to finish.
The scans run in parallel in batches of three to avoid flooding the session.
Also, prevent firing the SelectedIndexChanged event multiple times when populating the NewDisk dialog.
Renamed the SrPicker control on the latter (because SrListBox is a different type of control).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-15 16:48:53 +00:00
Konstantina Chremmou
0b954112bb Extended copyright check.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-14 09:45:34 +00:00
Konstantina Chremmou
5252272853 Changed the order of some of the initial and final operations.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-14 09:45:34 +00:00
Konstantina Chremmou
d1132f5823 Removed undocumented and buggy command line functionality. Moved command line arguments handling to the main window.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-14 09:45:34 +00:00
Konstantina Chremmou
6644ef920a CP-41108: Replaced the separate splash screen executable with a form within the application executable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-14 09:45:33 +00:00
Konstantina Chremmou
1102ac80e2 Moved settings loading, and proxy and authentication module configuration to the Settings class as it's more relevant there.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-11 14:24:22 +00:00
Konstantina Chremmou
cc808dff1d Moved methods showing/hiding objects to the config provider as they are more relevant there.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-11 14:11:48 +00:00
Konstantina Chremmou
167ccf4904 Moved colour definition close to where it is used. Fixed leak where new underline fonts where created but not disposed.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-11 14:10:31 +00:00
Danilo Del Busso
ebcef64a24
Merge pull request #3062 from danilo-delbusso/bug/credentials_CA-371356
CA-371356 [XSI-1327]: Add option to prevent resetting pwd prompt function on disconnection
2022-10-28 09:44:13 +01:00
Konstantina Chremmou
de6a4f89c1
Merge pull request #3033 from danilo-delbusso/bug/prevent-host-reset
Prevent host reset when moving between wizard pages using `SelectMultipleVMDestinationPage`
2022-10-27 10:58:54 +01:00
Danilo Del Busso
9c07ed4707
Normalise whitespace in XenConnection.cs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-10-20 14:26:35 +01:00
Danilo Del Busso
0b5d259745
CA-371356: Add option to prevent resetting pwd prompt function on connection disconnection
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-10-20 14:26:32 +01:00
Danilo Del Busso
77bd034e8d
CA-359965: Consider physical_utilisation value when checking for free space in thinly provisioned SRs (#3028)
* CA-359965: Consider `physical_utilisation` value when checking for free space in thinly provisioned SRs

* CA-359965: Fix miscellaneous formatting issues

* Made SrPickerItem show the SR by default. Removed virtual method that was never overriden.

* Use slightly more intuitive name for property; also inverted its logic.

* Renamed VdiCreationCanProceed to the more specific CanFitDisks since it only deals with sizes.

* Re-arranged classes in file.

* Refactored SrPickerItem:

- Merged CanBeEnabled and DisabledReason properties to method CanBeEnabled(out disabledREason)
  to avoid running the same checks twice.
- Pass the disk instead of the size into extension method SR.CanFitDisks
  so that the correct size can be used for each storage (thin vs. non-thin provision).

* Correction as per code review and some tweaks to make the checks clearer and more efficient.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-10-11 09:26:54 +01:00
Konstantina Chremmou
a4e7462948 Fixed issue where the version on the update dropdown was not refreshed if a new update was found.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-10-07 13:20:56 +01:00
Konstantina Chremmou
94d4360218 Removed NewDiskDialog constructor as it was not particularly useful. 2022-10-07 09:19:10 +01:00
Konstantina Chremmou
83a1a74e02 Disable the Rescan button on the SR storage page when the SR is detached because the operation fails anyway.
Also, some tidy up so the checks are clearer.
2022-10-07 09:19:10 +01:00
Konstantina Chremmou
940b1580b9 Fixes issue where the Finish page of the NewVM wizard was not showing the selected home server correctly. 2022-10-07 09:19:10 +01:00
Konstantina Chremmou
0d70266173 CP-40748: Upgrade log4net to 2.0.15
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-10-04 11:00:12 +01:00
Konstantina Chremmou
e5d1a1bf03 Bumped pipeline version to 4.5.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-10-04 11:00:12 +01:00
Konstantina Chremmou
9f781a5876 CA-370847: Unable to collect status report for multiple servers
Linq.Intersect was failing to combine server capabilities because the helper
class did not implement GetHashCode.
2022-09-26 10:05:01 +01:00
Konstantina Chremmou
74487155fa
Merge pull request #3053 from xenserver/master
Merge master into feature/vtpm
2022-09-16 14:27:56 +01:00
Konstantina Chremmou
4d6fd38809 Bumped branding to v4.7. 2022-09-16 10:03:08 +01:00
Konstantina Chremmou
71a8fde3c6 Wording and layout modifications for clarity.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-15 16:26:47 +01:00
Konstantina Chremmou
126bf9131c Use the correct xapi tag for vTPM support.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-13 16:35:32 +01:00
Konstantina Chremmou
8e850b42e3 Updated C# SDK (xapi 22.26.0-1.xs8).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-13 16:35:32 +01:00
Konstantina Chremmou
d7124c9dcc Indentation/whitespace normalization.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
eedcfbe59d CP-40350: Hide vtpm capability if the feature flag is off.
Also, some refactoring and addition of null checks.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
9e00a633f3 Create vTPMs as non-unique by default. Added title and description to create/destroy vTPM actions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
fc5ccf77be Warn the user when exporting VMs with vTPMs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
bbc4ccdd52 Allow vTPM assignment when creating a VM.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
f7d96e21fd UEFI and UEFI secure boot modes are now fully supported, hence remove experimental warning.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
709a12f15a Allow vTPM management only on real VMs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
d94c55533c Renamed VM method is_a_real_vm to IsRealVm.
The new name complies with C# conventions and allows distinguishing it from xapi field names.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
00c3a87dad
Merge pull request #3046 from kc284/feature/vtpm
vTPM original implementation
2022-09-01 13:52:34 +01:00
Konstantina Chremmou
7768b71b2a Address review comments.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-08-31 11:06:40 +01:00
Konstantina Chremmou
fa955466ee Removed duplicate registration of events. Restored missing event registration.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-08-31 11:06:40 +01:00
Konstantina Chremmou
7144528f6b CP-39938: Flag a partially applied hotfix with red only if homogeneous application is required.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-08-22 12:45:37 +00:00
Danilo Del Busso
4f91b8a7e0
Merge pull request #3036 from danilo-delbusso/improvement/RPU_CP-39929
CP-39929: Improvements on the RPU/Updates wizard
2022-08-22 11:58:30 +00:00
Konstantina Chremmou
476648636b CP-40642: Hide templates with platform["vtpm"]=true
Also, some corrections to the template comparer on the NewVM wizard's Template page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-08-19 17:11:50 +01:00
Konstantina Chremmou
1a786b38bf CP-39688: Added vTPM manager for creating and removing vTPMs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-08-19 17:11:50 +01:00
Konstantina Chremmou
9381388722 CP-40350: New vtpm capability in the server status report.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-08-19 15:12:46 +01:00
Konstantina Chremmou
5d75200735 CP-39533: Added indication on the general tab that a vTPM is attached to a VM.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-08-19 15:12:46 +01:00
Konstantina Chremmou
0daed5eff6 SDK drop exposing new API fields and calls for vTPM.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-08-19 15:12:46 +01:00
Konstantina Chremmou
76a9295bee CP-40641: Bumped branding to v4.6.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-08-19 09:45:51 +01:00