Commit Graph

2916 Commits

Author SHA1 Message Date
Mihaela Stoica
cab6a051b8 Merge branch 'REQ-477' into master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenModel/XenAPI/PCI.cs
#	XenModel/XenModel.csproj
2018-04-04 09:59:29 +01:00
Konstantina Chremmou
5d4a9270eb Simplified class hierarchies for the SrDescriptors. Among others, we avoid the presence of irrelevant key-value pairs in the DeviceConfig .
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-04 08:03:28 +01:00
Mihaela Stoica
2943b048fa CP-17099: Remove unused function
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-04 08:03:28 +01:00
Mihaela Stoica
6a8b65b21e CP-17099: Do the double probe for HBA
- The LVMOHBAWarningDialog class has been changed to display the type of the existing SR and the requested type (that will be used for formatting)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-04 08:03:28 +01:00
Konstantina Chremmou
585f7a848f Cleared some more warnings with regards to xml documentation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 13:00:27 +01:00
Konstantina Chremmou
c96fd646d3 Removed unused event (event handler content was commented out).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 13:00:27 +01:00
Konstantina Chremmou
583513f9e4 CA-202377: Removed the QueuedBackgroundWorker from the NewDisk dialog (unused)
and the vApps dialog (not particularly needed because we only query the cache
and do not make any server side calls).
Also, removed unhooked event handlers from the NewDisk dialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 13:00:27 +01:00
Konstantina Chremmou
78511b0a02 Replaced Java-like documentation of class members with C# xml documentation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 13:00:27 +01:00
Konstantina Chremmou
7655011158 Compliance with C# conventions: normally interface names start with an I.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 13:00:27 +01:00
Vetrivel Chinnasamy
587144d3bf L10N: Translation Updates (#2020)
* L10N: Translation Updates
2018-04-03 11:57:09 +01:00
Konstantina Chremmou
6adcd2b83f Some more code simplifications.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Konstantina Chremmou
4b0aa132d2 Simplified the FibreChannelProbeAction and compacted the methods and helper classes for parsing the results for the various SR types.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Konstantina Chremmou
4452318d1d Moved the classes FibreChannelDevice and FibreChannelProbeParsing to XenModel.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Konstantina Chremmou
959e43480c CP-17099: Double probe for iSCSI - minor refactoring to reduce code duplication.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Mihaela Stoica
fc42be5bee CP-17099: Do the probe_ext for HBA
- Move the scan for HBA devices after the Provisioning page
- Fix the device-config for HBA (removed uri)
- Add probe_ext in FibreChannelProbeAction and the method to process the result

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-03 11:24:40 +01:00
Mihaela Stoica
e294e903fd CP-17099: Do the double probe for iSCSI
When we scan the LUN to see if there are any existing SRs, we need to do an additional probe if the probe for the desired type didn't find any SRs.
E.g. if  GFS2 is selected and no GFS2 SR was found on the LUN, then we need to also check if there is a LVM over iSCSI SR, and if there is one we will offer to reattach it (as LVM over iSCSI) or format it as GFS2

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-03 11:24:40 +01:00
Joey
48782eac44 CA-286458: Fix latestcr XC requirement when apply CR update (#2010)
* CA-286458: Fix latestcr XC requirement when apply CR update

Using minimum_xc_version attribute in xenserver version to
determine which xencenter version is required.

* CA-286458: change MinimumXcVersion type to Version

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-03-29 11:13:13 +01:00
Mihaela Stoica
fcb6399535 CP-17099: Changes following code review
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-28 17:07:15 +01:00
Mihaela Stoica
6ad6b4efc7 CP-17099: Use SR.probe_ext for GFS2 over iSCSI to populate the lists of IQNs and LUNs on the New SR wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-28 17:07:15 +01:00
Mihaela Stoica
d3fa68e210 CA-286582: Hide the Provisioning method page if the feature is not present or disabled
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-28 17:07:15 +01:00
serenc
b7d3a2b3b5 CP-17099: Add gfs2 SR probe
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-03-28 11:34:42 +01:00
vetrivelc
c910f7d41b L10N: Translation Updates 2018-03-27 13:47:39 +01:00
Joey
d80240b891 CA-281652: Add VM_REQUIRES_GPU failure reason (#1997)
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-03-26 11:04:12 +01:00
jishengx
ebadba53c3 CA-286339: The prompt information on RPU prechecks should be accurate (#2009)
* CA-286339: The prompt information on RPU prechecks should be accurate

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* fix some comments
2018-03-26 10:55:24 +01:00
Jisheng Xing
8e64c917e2 fix review comments
modify the judgement of SR-IOV network

fix review comments

fix review comments

judge the resolve result and modify the link status of VLAN on SR-IOV
2018-03-26 16:33:11 +08:00
Jisheng Xing
ba0cfdbf59 CA-286129: add or filter out SR-IOV network when creating VM or importing XVA
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-26 16:32:53 +08:00
Jisheng Xing
f41a61ac73 CA-286278: VLAN network on top of SRIOV also belongs to SR-IOV
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-26 16:32:38 +08:00
Jisheng Xing
59ba1db95f CA-286136: modify the SR-IOV related display 2018-03-23 14:44:59 +08:00
Jisheng Xing
6cf968a209 CA-286129: allow VIF to be updated to a SRIOV VF 2018-03-23 14:44:58 +08:00
Jisheng Xing
73eefe33b5 CA-286136: modify SR-IOV related info display
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-23 14:44:57 +08:00
jishengx
a22cb38835 CP-26363: Display the remaining VF numbers in NIC TabPage (#1982)
* CP-26363: Display the remaining VF numbers in NIC TabPage

* correct the link status of Networking TabPage

* show the warning when creating SR-IOV network

* fix some comments

* modify the action

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-23 14:44:56 +08:00
jishengx
e7bfb78c00 CP-26884 + CP-27199: Add network-sriov info in OVF file when exporting vm + Block VF assignment to VM according to recommendations: a (#1980)
* CP-26884: add network-sriov info in OVF file when exporting vm

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* CP-27199: Block VF assignment to VM according to recommendations

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* fix some comments

* revert the Messages.resx
2018-03-23 14:44:51 +08:00
jishengx
9cfac68d8d CP-25990: Enable Create VLAN on SR-IOV network (#1975)
* CP-25990: Enable Create VLAN on SR-IOV network

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* fix review comments
2018-03-23 14:43:51 +08:00
Jisheng Xing
7dd99857cd CP-26391: Display the SR-IOV network status on Networking Tab Page
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-23 14:41:55 +08:00
Jisheng Xing
35acc262ee CP-27188: Filter out the SR-IOV network when configuring IP address
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-23 14:41:54 +08:00
jishengx
6f4fa43c03 CP-26362: Enable create SR-IOV network (#1952)
* update the XenAPI according to the Jason-RPC

* CP-26362: Enable create SR-IOV network

* fix review comments

* fix the judgement on SR-IOV details page

* disable the finish button

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-23 14:27:04 +08:00
Jisheng Xing
530462ad41 CP-26491: modify IsPhysical function and Properties dialog according to SR-IOV 2018-03-23 14:26:03 +08:00
jishengx
c966e25cc1 CP-26000: Add SR-IOV column in Networking and NIC TabPage (#1903) 2018-03-23 14:24:51 +08:00
jishengx
b2c74ff261 CP-25982: add wizard to enable SR-IOV network (#1887) 2018-03-23 14:24:10 +08:00
Konstantina Chremmou
29cdf221bc Cleared some level 4 warnings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-22 15:07:32 +00:00
Mihaela Stoica
a61dd0c5c0 Fix NullReferenceException in the Patching wizard, on pressing the Finish button)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-22 10:32:41 +00:00
Michael
cb0ee70012
Merge pull request #1986 from MihaelaStoica/CA-285268
CA-285268: Patching Wizard improvement: Read metadata from the update…
2018-03-21 17:30:59 +08:00
Michael Zhao
7c8b2f6d40 CA-271850: Increase the timeout of session for querying MaximumTolerableHostFailures. 2018-03-20 07:09:34 +00:00
Michael
ebb918296b CA-284226: Optimize performance of menu Start-on-Server and Migrate-to-Server (#1985)
* CA-284226: Reduce unnecessary CanExecute() calls.

* CA-284226: Optimize the performance of menu Migrate to Server and Start on Server.

* Fix an error in updating Migrate menu with WLB, which lead to crash.

* Clear the worker queue when menu is closed.

Signed-off-by: Michael Zhao <michael.zhao@citrix.com>

* Fix comments.
2018-03-20 07:07:19 +00:00
Mihaela Stoica
45ad13133d Use the new methods PageLeaveCore and PageLoadedCore in ChooseSrProvisioningPage
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-19 14:08:32 +00:00
Mihaela Stoica
f7b27ec222
Merge pull request #1994 from xenserver/REQ-477
Merge REQ-477 into master
2018-03-19 13:23:19 +00:00
Mihaela Stoica
713877b49e CA-285268: Code simplification
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-16 14:00:07 +00:00
jishengx
0c13d8786d CA-274082: Check status of SR uploaded updates during update installa… (#1937)
* CA-274082: Check status of SR uploaded updates during update installation
* fix review comments

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-14 12:19:14 +00:00
Mihaela Stoica
f64fd58970 CA-285268: Patching Wizard improvement: Read metadata from the update file, instead of relying on the file name to match the update name in cfu
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-14 12:12:18 +00:00
Konstantina Chremmou
d69f2ddda3 Enforce treating warnings as errors in Debug mode too as it is going to save
us a lot of broken builds. Fixed bug where the HostPlanAction.CurrentHost was
always null (as the private field was never set).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00