Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2025-01-22 00:00:40 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,460 Commits 12 Branches 48 Tags 186 MiB
030e07390c
Commit Graph

4088 Commits

Author SHA1 Message Date
Konstantina Chremmou
b2dc968ab1 CP-38895: Check version annotations when using API fields or methods. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-03 14:35:45 +00:00
Darren Matthews
151841ce5e L10N : Translation Updates & Resx sync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2022-03-03 14:35:30 +00:00
Danilo Del Busso
101d6f0a00 CP-36392: Use value in empty setters 
Mostly to remove warning from SonarQube, so exception is only thrown in DEBUG mode

Address code surrounding previously emptied setters
Avoids throwing exceptions when not needed
Move default `VerticalTabs` fields outside of constructor

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-02-24 11:53:44 +00:00
Danilo Del Busso
2c5373323c CP-36392: Inherit IDisposable to avoid confusion 
Classes didn't extend IDisposable
Also used null propagation to tidy up method body

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-02-24 11:53:44 +00:00
Danilo Del Busso
a310fa60cf CP-36392: Remove all unnecessary using s 
Ignores XenAPI

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-02-24 11:53:44 +00:00
Darren Matthews
c7c60849b3 L10N : Resx Sync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2022-02-24 11:53:31 +00:00
Konstantina Chremmou
d0944cf19c A new row should be added only when it is not found. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-23 12:38:02 +00:00
Konstantina Chremmou
ff76729940 Hide the client update button by default. Added null check. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-21 15:56:06 +00:00
Konstantina Chremmou
99452959c3 Further tweaks as per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-17 12:52:30 +00:00
Konstantina Chremmou
b050adaeaa Some corrections and tidy up. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
0d9a204661 CP-31587 moves validate msi exception messages to messages.resx. Sets update client button to hidden on launch. 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
5845bab13f CP-31587 Implements reviewer's comments. 
Moves dialog strings to messages.resx. Corrects button colours, hides update client option to avoid highlighting when disabled. Revmoves unessessary comments.

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
d8b1d5737d CP-31587 added comfirmation dialog to manageupdates page 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
755411a970 CP-31587 implements confirmation check before updating client 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
75f9b402ec CP-31587 added a checksum check to download and install client action 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
c1c8c3d1c3 Adds updates check started/completed event handlers 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
0a0533a59f CP-31587 improved DownloadAnUpdateClientAction 
Made variables more accurate, removed unnessessary code

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
aa59e8f475 CP-31587 Created new download and install action that downloads the file from updates.xml url and stores in in temp folder with progress dialog 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Konstantina Chremmou
ca37331c8d CA-362709, CA-362711: Reworked the logic for allowing full disk copy when creating a VM from a snapshot or custom template. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-14 14:35:51 +00:00
Konstantina Chremmou
321389455e Refactoring: compacted Role.ValidRoleList() and Role.CanPerform() overloads. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-03 11:59:17 +00:00
Konstantina Chremmou
6aec4ea281 CP-38893: Make internal roles unavailable for selection. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-03 11:59:17 +00:00
Konstantina Chremmou
50dd22f4da CA-362868: POOL_CA_CERTIFICATE_* alerts are issued on the certificate and not on the pool. 
Also, moved the function retrieving the XenObject from the alert to the Message class extensions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-31 14:56:12 +00:00
Konstantina Chremmou
d6f91526d2 Restored friendly name and description for CVSM. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-31 14:56:12 +00:00
Konstantina Chremmou
1580a89594
Merge pull request #2931 from kc284/settings 
Minor refactoring; null check; tidy up
 2022-01-27 13:34:20 +00:00
Konstantina Chremmou
bae03aff8b Fixed issue where the settings from previous installations were not imported. Added more documentation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-24 19:55:38 +00:00
Konstantina Chremmou
b4afd3ce4c CA-261979: Use utf-8 encoding for logging (or on localised systems the log files may contain illegible characters). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-24 15:22:28 +00:00
Danilo Del Busso
f07b3d4e05 CP-37850: Update RPU005 to version 4.0 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-24 15:22:07 +00:00
Konstantina Chremmou
ba8cf7f782
Merge pull request #2934 from xenserver/feature/CP-38483 
CP-38483: Unbundle putty from  Citrix Hypervisor Center
 2022-01-24 15:21:32 +00:00
Konstantina Chremmou
f29e267670 Some corrections and refactoring on the external console feature. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-17 14:09:34 +00:00
Danilo Del Busso
c9bb9c1f0c CA-362353: Add file existence check when launching SSH console 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-17 14:09:34 +00:00
Danilo Del Busso
66d1c6624b CA-362355: Remove SSH console location check if paths haven't changed 
Avoids users not being able to save other options if the selected SSH console location isn't valid

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-17 14:09:34 +00:00
Danilo Del Busso
322edd3536 CA-362352: Save SSH Console settings changes on startup 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-17 14:09:34 +00:00
Danilo Del Busso
34876461fc CA-362354: Account for non-exe files when saving SSH client path 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-17 14:09:34 +00:00
Konstantina Chremmou
2c18b7c7ed Tidy up: moved method to Settings and renamed it. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-13 11:04:13 +00:00
Konstantina Chremmou
8086359d2d Minor refactoring. Show more logging. Null check. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-13 11:01:59 +00:00
Danilo Del Busso
9ebcdaabd7 CP-38530: Remove reference to PuTTY in LegalNoticesDialog 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-07 10:04:43 +00:00
Danilo Del Busso
6a52322035 CP-38530: Remove PuTTY from build scripts and wix installer 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-07 10:04:43 +00:00
Konstantina Chremmou
7ca120eb76 Fixed DialogResult and ButtonType for buttons (dialog was not closing on Esc or from control box). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-06 10:50:13 +00:00
Konstantina Chremmou
489069b36b Control behaviour corrections: 
- When radio buttons share the same container, only one needs to be checked.
- Do not set the owning control to null, or the balloon does not hide when asked to.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-06 10:50:13 +00:00
Konstantina Chremmou
57b07a9c7b Set roaming to true. Corrected setting type. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-06 10:50:13 +00:00
Konstantina Chremmou
879191424c Added hotkeys. Corrected tab indices. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
b66685a927 CP-38529: Remove method calling PuTTY in GeneralTabPage 
Method is not useful anymore. This commit only removes the PuTTY-related code.

Other docker-related unused code is ignored as it should be removed separately.

Whitespace diffs are tabs -> spaces and automatic VS2019 reformatting

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
d27eaa3bbd CP-38529: Use pre-installed SSH clients to launch VM console 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
8801b6bdf9 CP-38529: Check SSH client settings on launch 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
495dcd66d4 CP-38529: Make PluginManager public in MainWindow.cs 
To allow to open the Options page from other forms

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
3956502063 CP-38529: Add External Tools options page 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
971ae0d064 CP-38529: Add SSH client settings 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Darren Matthews
702ce7ce0f L10N : Resx resync and Translation Updates 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2022-01-05 11:38:40 +00:00
Danilo Del Busso
48dd60486a
Merge pull request #2889 from danilo-delbusso/CA-359124 
CA-359124 & CA-360426: Add snapshot VIFs to mapping during cross pool migration & fix VIF mapping in cross pool migration
 2022-01-05 12:13:40 +01:00
Konstantina Chremmou
b50ba18b38 Show the snapshot's name for the extra VIFs belonging to snapshots. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-12-23 16:40:05 +01:00
Konstantina Chremmou
f6db9820a1 Retrieve VM snapshots from the cache instead of making an API call to the server. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-12-23 16:40:05 +01:00
Danilo Del Busso
16d7f74158
CP-36392: Misc fixes to flagged Bugs (#2907) 
* CP-36392: Add several `null` checks

All were flagged by SonarQube

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Specify `namespace` for `SettingsUpdate`

Added to `XenAdmin`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Collapse useless condition check

Also use pattern matching for type cast

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Specify `namespace` for `ProduceConsumerQueue`

Add to `XenAdmin.Actions`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Rename field in `BugToolPageSelectCapabilties` to avoid name clash

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Add explicit `null` check

While the `null` check in `GraphDetailsDialog.cs` is not strictly necessary, it has been added to fix a SonarQube issue

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Remove unused field in `WlbPoolConfiguration.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Replace useless self-assignment with ad-hoc method

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Simplify dictionary key assignment in `WlbScheduledTask.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Fix minor formatting issues

Add newline at end of file, and reformat content of if statement

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Tidy up latest flagged bugs changes

- Fix whitespace/braces in a few affected files
- Add missing null check in `ValueMaps.cs`
- Check for args length in `RbacCollectorProxy.cs`
- Fix logic in `MainWindow.cs` to revert to previous behaviour

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Tidy up setter in `ChangeableList.cs`

Also update whitespace inconsitencies in `PerfmonAlertEditPage.cs` and `VMHAEditPage.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-21 15:53:46 +00:00
Konstantina Chremmou
4a6b2b1e1b
CA-343229: Some modifications: 
- Fixed issue whereby logging out the current user did not log out other
  sessions of the currentUser opened from outside the application.
- Improved prompts shown to the user when changing roles.
- Corrected percentage reporting.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-12-17 11:08:31 +00:00
Danilo Del Busso
53bf485a14
Replace negative term with log(ging) out user 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-17 11:06:56 +00:00
Danilo Del Busso
f1fcb64b55
CA-343229: Forcefully log out all users when changing their role 
- Move _statusUpdaterLock to top of class, rename it, and set as `readonly`
- Extract logout and confirmation prompts into separate methods
- Add list of users that are being manipulated to action titles
- Group logout actions into one `MultileAction` to avoid multiple RBAC prompts being shown
- Tell user they're going to also disconnect other users when logging out current user together with others

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-17 11:06:55 +00:00
Konstantina Chremmou
c19fb06bf7 CP-38473: Block RPU if the pool has hosts with certificate key length less than 2048 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-12-16 11:34:23 +00:00
CitrixChris
05cbae25ce
CP-32667 Added download action to CHC (#2912) 
Added the interface option to download and install updates for client updates. Disabled by default until CP-31587 does the proper checks

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2021-12-16 10:34:00 +00:00
Danilo Del Busso
e169f0bfcc
Amend indentation in changes for CA-359124 & CA-360426 
Refactor all tabs into 4x spaces

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-14 13:29:31 +00:00
Danilo Del Busso
7e007cd6ef
CA-360426: Fix VIF to Network mapping during cross pool migration 
Amend mapping so it reflects xapi calls, keeping VIF -> Network mapping and removing Network -> Network mapping

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-14 13:27:22 +00:00
Danilo Del Busso
bee0b881d4
CA-359124: Add snapshot VIFs to mapping during cross pool migration 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CA-359124: Add VM snapshots VIFs to network mapping wizard page

This is not entirely necessary, since the mapping in the background is actually Network -> Network.
However, this is closer to the intent of the page.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CA-359124: Tidy up methods in `VmCrossPoolMigrateACtion.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-14 13:25:58 +00:00
Konstantina Chremmou
a0a706e9bb Merge branch 'master' into vm-copy-credentials_CA-359712 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/ImportWizard/ImportWizard.cs
#	XenModel/Actions/VM/VMCopyAction.cs
 2021-12-02 22:14:48 +00:00
Konstantina Chremmou
cace3036cf
Merge pull request #2854 from danilo-delbusso/CA-339273 
CA-339273: Add source server/pool info to descriptions of actions that move/copy/import resources
 2021-12-02 21:01:20 +00:00
Konstantina Chremmou
2af5758424
Merge pull request #2842 from danilo-delbusso/master 
CA-350411: Add conditional page control refresh in Import Wizard
 2021-12-02 21:01:00 +00:00
Konstantina Chremmou
e9fa5674c3 CA-339273: Some corrections and minor refactoring. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-12-02 11:20:49 +00:00
Konstantina Chremmou
eef4e5f995 CP-38427 issue 1: Do not allow enabling TLS verification during RPU. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-30 22:46:43 +00:00
Konstantina Chremmou
051c205899 CA-350411 part 2: Add conditional page control refresh in Import Wizard 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-24 15:35:00 +00:00
Konstantina Chremmou
355321faea Made ovfModeOnly an optional parameter. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-24 15:35:00 +00:00
Konstantina Chremmou
89620bff4b Restored RBAC check on source connection. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-24 09:58:43 +00:00
Konstantina Chremmou
a327390e4a Further refactoring of CopyVM- and CopyTemplateCommand to reduce repetitive code. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-24 09:58:43 +00:00
Konstantina Chremmou
e265e86cfa Refactored and renamed class WizardPermission and the code areas using it. Corrections to RBAC messages. Sorted Messages.resx. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-24 09:58:43 +00:00
CitrixChris
8281ae5c05
CA-359809 improved illegal character message (#2898) 
* CA-359809 improved illegal character message

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 cleared whitespace, improve code readability

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 implemented reviewer comments.

Moved Path validator to XenModel Project where other language files have already been set up.
Improved error messages.

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 improved string localisation, Code tidy

Cannot became can not, messages file alphabetised, improved readability with using xenmodel as opposed to direct call

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 changed can not to cannot

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2021-11-22 12:02:26 +00:00
Konstantina Chremmou
c2f92aa02a
Merge pull request #2903 from danilo-delbusso/CP-36392-Bugs 
CP-36392: Address statically flagged trivial issues that can cause bugs
 2021-11-17 11:36:48 +00:00
Danilo Del Busso
f2fdf31a5a
CP-36392: Avoid multiple enumerations in LicenseStatus.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-17 09:01:25 +00:00
Danilo Del Busso
3e861411db
CP-36392: Invert if statements to reduce nesting in HostMemoryControls and changeControlDomainMemoryCommand 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-16 11:42:18 +00:00
Danilo Del Busso
47510f5b07
CP-36392: Reassign expiryGroups after ordering 
regression from db2c00d5

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-16 11:39:50 +00:00
Konstantina Chremmou
5078c4db0d CP-38086: Block upgrade for PV guests. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/Branding.resx
#	XenAdmin/Diagnostics/Checks/PVGuestsCheck.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenModel/BrandManager.cs
#	XenModel/Utils/Helpers.cs
 2021-11-15 15:49:39 +00:00
Danilo Del Busso
6ed9e28da1
Move RBAC page addition to separate method in ExportApplianceWizard.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 12:04:04 +00:00
Danilo Del Busso
09c26d7936
Move CheckRbacPermissions to superclass 
Also decouple the `ErrrorDialog` creation from the method.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 12:01:29 +00:00
Danilo Del Busso
cfff0722c7
CP-36392: Limit ex-readonly public lists to {get;} usages only 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:11:41 +00:00
Danilo Del Busso
6f7faefce1
CP-36392: Replace complex method with single LINQ calls in DRFailoverWizardStoragePage 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:09:11 +00:00
Danilo Del Busso
68b54682ae
CP-36392: Move param checks outside of RepairSRDialog.cs's constructor 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:05:08 +00:00
Danilo Del Busso
31702c9e43
CP-36392: Add null checks for ControlDomainMemoryDialog's constructor params 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:00:50 +00:00
Danilo Del Busso
cc917e2a66
CP-36392: Simplify if and else if blocks to reduce nesting in AddServerDialog.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:57:08 +00:00
Danilo Del Busso
1acce3638c
CP-36392: Move vms null and Count checks outside of WlbRecommendations.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

damni

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:52:06 +00:00
Danilo Del Busso
396bcb0e35
CP-36392: Make type field readonly in QueryElement.cs 
field is used in `GetHashCode`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:46:12 +00:00
Danilo Del Busso
494f78966d
CP-36392: Address logic issue in FilterLocationToolStripDropDownButton.cs 
As suggested during review:

> The check after the `&&` should go in a nested if block: if we are in a split second where the cache has not been populated yet, there should be no item added, however, this code will add a `p` item.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:43:50 +00:00
Danilo Del Busso
02439d5303
CP-36382: Replace _nameCell with ad-hoc _xenObject readonly field 
To ensure that the field in the `GetHasCode` call is `readonly`
Also remove unused constructor

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:36:42 +00:00
Danilo Del Busso
5d5d971c74
CP-36329: Remove redundant verbatim in WlbRecommendations.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:29:21 +00:00
Danilo Del Busso
47884376a3
CP-36392: Fix typo in VNCTabView.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:29:19 +00:00
Danilo Del Busso
caf608344e
CP-36392: remuve redundant iteration in ResumeVMOnHostToolStripMenuItem.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:24:17 +00:00
Danilo Del Busso
b6a70e2ffc
CP-36392: Add null check for _vmOptList in WlbOptimizePoolAction.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:18:55 +00:00
Danilo Del Busso
45512b4cde
CP-36392: Add removed null check in WlbOptiomizePool.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:18:09 +00:00
Danilo Del Busso
6ce0a4b49d
CP-36392: Remove repetitive count and null check 
Check is performed within the constructor of `WlbRecommendations`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-03 16:07:36 +00:00
Danilo Del Busso
0924563cff
CA-350411: Add conditional page control refresh in Import Wizard 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CA-350411: Tidy up local variables within ImportWizard

* Use of local variables for readibility.
* Fixed ordering issue which caused if block to check for condition too late.
* Add connection and type of import checks before adding/removing boot options page

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CA-350411: Update visibility settings in fields needed for fix

Fields were either read-only, or private. Internal accessor settings allows for external modification and checks.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CA-350411: Add checks for the `ImportSourcePage` and `GlobalSelectHost` page types

Also remove unused methods in `NetworkPickerPage.cs` and `StoragePickerPage.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-03 10:42:08 +00:00
Danilo Del Busso
2978f60f8a
CP-36392: Improve readability of latest changes 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-03 10:23:21 +00:00
Konstantina Chremmou
688fe99e3e CA-359969: Do not rebuild the list if the scanning of the SRs has not finished yet. Removed unused code. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-02 16:53:48 +00:00
Danilo Del Busso
f5149a415f
CA-359709: Add error message for RBAC failure in BugToolWizard 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-28 13:55:29 +01:00
Danilo Del Busso
ae1efbd54d Add method to add API methods checks to RBAC page 
Also minor refactor of wizards that were using the same logic

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-28 13:48:24 +01:00
Danilo Del Busso
02d4434572 CA-359709: Add RBAC check to BugToolWizard.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-28 13:48:24 +01:00
Danilo Del Busso
c5f1544fd9
CP-359712: Add RBAC check to VM/template copy dialogs 
Also remove unused constructors, and simplify getters

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-28 11:19:47 +01:00
Danilo Del Busso
bba97278e1
CA-359712: Add RBAC check page to VM copy/clone in CrossPoolMigrateWizard 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-27 14:34:10 +01:00
Danilo Del Busso
38701d148e
Merge branch 'master' of https://github.com/xenserver/xenadmin into pr/2903 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenModel/Actions/GetDataSourcesAction.cs
 2021-10-27 13:24:23 +01:00
Konstantina Chremmou
c44f6496df CA-360011: Allow full disk copy only if all VDIs of the snapshot/custom template allow it. 2021-10-26 16:55:18 +01:00
Konstantina Chremmou
f2d81d5744
Merge pull request #2869 from danilo-delbusso/CP-36392 
CP-36392: Address Security Features and Code Smells
 2021-10-26 16:54:34 +01:00
Konstantina Chremmou
23ec669698 The message Messages.UPSELL_BLURB_TRIAL was displayed twice on the AD, HA, and Users tabpage for unlicensed pool. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-10-26 00:47:08 +01:00
Konstantina Chremmou
45fe1f436b CA-359795: Fixed issue whereby a double error was shown when a non-privileged user attempted to apply a licence. 
Removed ApplyLicenseEditionCommand as it was unnecessary (there was no
button/menuitem calling it). Use the ApplyLicenseEditionAction instead.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-10-26 00:47:08 +01:00
Konstantina Chremmou
5c66471db0 CA-359793: Fixed stray label showing while entering maintenance mode. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/EvacuateHostDialog.cs
 2021-10-26 00:47:08 +01:00
Konstantina Chremmou
588f976a9b CA-359744: Do not add a host label if the host has disappeared from the cache. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-10-26 00:47:08 +01:00
Konstantina Chremmou
6b7cd1d9e5 Corrected calculation of datasource units (CA-359068). New/Edit Graph dialog enhancements. 
- CA-359068¨Match the whole datasource name (previously the wrong one was picked
  for disk read/write latency).
- New/edit Graph dialog: differentiate between enabled/disabled datasources and
  visible/hidden (known/unknown units; the latter may mean no data).
- Some refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-10-12 12:28:42 +01:00
Danilo Del Busso
69722d93bd
CP-36392: Rename key constants in WlbReportSubscription.cs to avoid field clash 
Names are amibguous
Also made the fields `const`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-05 11:56:15 +01:00
Danilo Del Busso
3a69fa0f8c
CP-36392: Add readonly to fields used in GetHashCode 
Also tidy up some code

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-05 11:39:17 +01:00
Danilo Del Busso
2352dcc4bf
CP-36392: Remove unused KeySet.cs 
File isn't used and contains 2 minor bug SonarQube flags

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-05 10:13:25 +01:00
Danilo Del Busso
4e4747ecb8
CP-36392: Remove misleading readonly in collection/array fields 
`reaonly` should be used for items that can't be modified. The changed collections/arrays are modified, so `readonly` is misleading

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 16:27:42 +01:00
Danilo Del Busso
db2c00d54d
CP-36392: Cast operands of divisions to not lose precision 
Cast to `decimal` or `float` to keep floating-point precision

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 16:22:29 +01:00
Danilo Del Busso
dcbaf5d1a4
CP-36392: Amend calls that generate unused return values 
Mixture of correctly implementing `Trim()` calls, and removing calls that generate useless ephemeral variables.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:42:40 +01:00
Danilo Del Busso
a5ddcf1b97
CP-36392: Refactor loops into if blocks 
Loops are effectively used as if statements. Changed to improve readability.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:42:10 +01:00
Danilo Del Busso
408cf98add
CP-36392: Add miscellaneous null checks 
Also tidy up code
Also remove method in `SnapshotTreeView.cs` that wasn't used, which necessitated a null check

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:42:07 +01:00
Danilo Del Busso
02aa50f7a8
CP-36392: Refactor conditions that result in unreachable code blocks 
Also tidy up surrounding code

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:42:04 +01:00
Danilo Del Busso
cfc7bd0ef9
CP-36392: Update RebootPlanAction.cs to lock on a dedicated object instance 
Use dedicated instance to avoid deadlocks or lock contention
Also fix typo and rename `private` variable

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:42:03 +01:00
Danilo Del Busso
df53a4cd98
CP-36392: Refactor useless null checks in actions constructors 
Also remove useless `this` usage

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:41:59 +01:00
Danilo Del Busso
0623717627
CP-36392: Replace custom Utils method with direct calls 
`ThrowIfEnumerableParameterNullOrEmpty` adds complexity

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:09:00 +01:00
Danilo Del Busso
2d1e6dcb92 CP-36392: Remove base calls directly based on the object reference. 
Two objects will never have the same hash since base methods are based on direct object reference

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-01 11:56:36 +01:00
Danilo Del Busso
825c795ea4 CP-36392: Refactor for loop into FirstOrDefault expression 
Improves readability

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-01 11:56:36 +01:00
Danilo Del Busso
f908abe28d CP-36392: Refactor useless for loop into if statement in ConsolePanel.cs 
For loop is acting as if block

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-01 11:56:36 +01:00
Danilo Del Busso
3ffd370d81 CP-36392: Remove unused conditional structure in VNCTabView 
If check is virtually useless here

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-01 11:56:35 +01:00
Danilo Del Busso
aa038cf0fc CP-36392: Remove condition that always evaluates to false 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-01 11:56:35 +01:00
Danilo Del Busso
f7c6984e6c CP-36392: Update CanRunCore to reflect logic as described in comment 
Also addresses unreachable code block
Also use `var` keywoard to tidy up code

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-01 11:56:35 +01:00
Danilo Del Busso
3c70dacecc CP-36392: Change condition that always evaluates to false in WlbOptimizePoolAction 
Also tidy up code within constructor

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-01 11:56:34 +01:00
Danilo Del Busso
0ffee712b7 CP-36392: Add null check to connection call in ExternalPluginAction.cs 
Also remove `null` check that always resolves to true
Also tidy up code

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-01 11:56:34 +01:00
Konstantina Chremmou
a2d829b93c CA-359092: Clarify SMB storage option in NewSR wizard 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-09-24 11:20:13 +01:00
Danilo Del Busso
2f176caf46 CP-38219: Update RPU005 to version 3.0 
Also exclude Yangtze or greater from hotfix check

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-24 11:19:36 +01:00
Konstantina Chremmou
de8acfff24 Use the DEPRECATION_URL as the default value for the Details link of the DeprecationBanner 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/TabPages/BallooningPage.cs
 2021-09-23 10:44:43 +01:00
Konstantina Chremmou
cfbfea2830 Minor ProblemWithMoreInfo refactoring. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-09-23 10:44:43 +01:00
Konstantina Chremmou
d59a61991e CP-36908: Remove support for xscontainer supp-pack from stockholm. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Commands/PauseDockerContainerCommand.cs
#	XenAdmin/Commands/RestartDockerContainerCommand.cs
#	XenAdmin/Commands/ResumeDockerContainerCommand.cs
#	XenAdmin/Commands/StartDockerContainerCommand.cs
#	XenAdmin/Commands/StopDockerContainerCommand.cs
#	XenAdmin/Controls/DeprecationBanner.cs
#	XenAdmin/TabPages/GeneralTabPage.cs
#	XenModel/Utils/Helpers.cs
 2021-09-23 10:44:43 +01:00
Konstantina Chremmou
d740e83620 CP-38018: Report mismatch between pool and host certificate verification in an undismissable way 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-09-23 10:44:30 +01:00
Konstantina Chremmou
55fd07f8ba Minor refactoring. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-09-23 10:44:30 +01:00
Danilo Del Busso
f3d0b1f302
CP-36392: Rename _selectedNodes to _internalSelectedNodes 
To avoid getter naming confusion
Also rename `_seletedNodesWrapper` to `_selectedNodes`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-20 09:35:24 +01:00
Danilo Del Busso
bb765e2b0f
CP-36392: Dispose '_webClient' when it is no longer needed 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-20 09:35:23 +01:00
Danilo Del Busso
12faf4413b
CP-36392: Refactor getter so that it doesn't clash with private field 'selectedCD' 
- Remove private field
- Modify `SelectCD` call to take in parameter

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-20 09:35:22 +01:00
Danilo Del Busso
24e1b146ae
CP-36392: Refactor property names so they have unique names in SummaryPanel.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-20 09:35:21 +01:00
Danilo Del Busso
a61f61d66f
CP-36392: Remove duplicate field in MultipleDvdIsoList.cs 
Also remove `VM` from designer

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-20 09:35:19 +01:00
Danilo Del Busso
157fe77f8f
CP-36392: Add comment to ignored catch blocks 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CP-36392: Add missing comments to ignored catch blocks

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-20 09:35:17 +01:00
Danilo Del Busso
32571300bb Add variable to null check when importing OVF files from web server 
Also modify `int` into `var`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-17 14:55:09 +01:00
Danilo Del Busso
46b83bf3a4 Prevent null reference when importing OVF files from web server 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-17 14:55:09 +01:00
Konstantina Chremmou
7d9bbbc68b XSI-1107/CA-237939: Do not offer full disk copy when creating a VM from a snapshot. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-09-17 14:54:56 +01:00
Konstantina Chremmou
1936b74030 CA-294901: Reworked rubric for home server assignment because previous work on it broke the template case. 
Also, no need to use a different message for single and multiple VMs or templates.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-09-17 14:54:56 +01:00
Danilo Del Busso
6aedaa7742
CP-36392: Refactor setter so that it actually refers to the field 'sendScanCodes' 
Removed private method is only referenced within the public setter

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-17 11:22:47 +01:00
Konstantina Chremmou
cacdb2ef34 Typos. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-09-07 11:12:56 +01:00
Konstantina Chremmou
5ee8230834 Merge remote-tracking branch 'upstream/master' into feature/REQ-403 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Alerts/Types/CertificateAlert.cs
#	XenAdmin/Commands/DisconnectWlbServerCommand.cs
#	XenAdmin/Commands/ViewWorkloadReportsCommand.cs
#	XenAdmin/TabPages/GeneralTabPage.cs
#	XenModel/PoolJoinRules.cs
 2021-09-01 14:43:23 +01:00
Konstantina Chremmou
6f7a82017f CP-38073: Corrected resx file for the Chinese language. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-08-31 14:09:08 +01:00