Commit Graph

204 Commits

Author SHA1 Message Date
Konstantina Chremmou
29cdf221bc Cleared some level 4 warnings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-22 15:07:32 +00:00
Kun Ma
f28322e5db CA-270999: Add registration to RestartManager
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2018-03-06 09:36:05 +00:00
Konstantina Chremmou
fb8434819d Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-11-30 13:56:32 +00:00
Joey
8932d983db
Merge pull request #1839 from GaborApatiNagy/master_CA-270499
CA-270499: The license text on the title bar is flickering
2017-10-31 14:06:46 +00:00
Gabor Apati-Nagy
dc95d8ded0 CA-270499: The license text on the title bar is flickering
Fixed flickering that occurred due to the repetitive re-setting of the label's text.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-10-27 14:34:45 +01:00
Michael Zhao
ba7615e104 CA-270498: Link Help docs to new added USB-passthrough pages. 2017-10-27 13:11:20 +08:00
Michael Zhao
b093082bcd REQ-158: Merge master to fix conflicts. 2017-10-24 18:51:24 +08:00
Michael
16b52d1c3f CP-25081: UI improvements for USB passthrough (#1811)
* CP-25081: UI improvements for USB passthrough

* CP-25081: Show text when AttachUsbDialog list is empty.

* Fix comments.

* Improve the presentation of warnings in USBEditPage.

* Update warning text of attach usb dialog.

* Simplify the layout of Attach USB Dialog.

* Check if USB devices plugged before showing UI.

* Fix comments.

* Fix comments.

* Improve code.
2017-10-17 09:57:50 +01:00
Ji Jiang
225474f913 CA-268683: Turn on disable HA on unlicensed pool
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-10-11 14:58:10 +01:00
Michael
e8cb4ad7d6 CP-24412 & CP-24333: USB device list filter in Attach dialog. (#1789)
* CP-24412: Apply a filter before adding USBs to candidate list in Attach Dialog.

* CP-24333: Apply HA restraint.

* CP-24412: Fix a merge error.

* CP-24412: implement actions to attach/detach/passthrough.

* CP-24412: Add license check before making UI components visible.

* CP-24412: Change layout of new components to Dpi.

* Fixed all comments.

* Fix comments.

* fixed comments
2017-10-10 09:05:22 +01:00
Gabor Apati-Nagy
39026f300e CP-24707: Add license status information to the title bar for pool and hosts (#1783)
* CP-24707: Add license status information to the title bar for pool and hosts

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CP-24707: Add license status information to the title bar for pool and hosts

Show expired licenses as Unlicensed in the Header

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CP-24707: Add license status information to the title bar for pool and hosts

Improvements, fixes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CP-24707: Add license status information to the title bar for pool and hosts

More code to make it nicer

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CP-24707: Add license status information to the title bar for pool and hosts

More code to make it even more nicer

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-09-28 16:10:41 +01:00
kunm
912475a4eb CP-24331 & CP-24135: Add UI support for usb-passthrough on both Host & VM (#1766)
* CP-24331: Add UI for UsbTab and VM Usb Property

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Update XenAPI reference

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Add AttachUsbDialog

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Refine UI changes

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Discard UsbList and little refining to code

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Refine UI code

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Refine USBEditPage

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Refine USBEditPage

Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-09-27 13:37:17 +01:00
Konstantina Chremmou
514c33140b Converted remaining extension get and set properties of the API classes to methods
in order to prevent them from being serialised alongside the API properties.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-05 02:15:38 +01:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Gabor Apati-Nagy
48134dfd14 Merge pull request #1723 from xenserver/REQ-473
Merge from REQ-473
2017-08-09 10:47:01 +01:00
Konstantina Chremmou
ad7e2fa6a6 CA-257927: Changed ChangeableList.RemoveAll method to fire the CollectionChangedEvent
once for all the items to be removed, passing in their list as argument. This method,
and the method Clear calling it, are used for alerts, updates, events and connections,
hence changed the handling of the CollectionChanged event in these cases to expect
either a single item or a collection. In the case of alerts, updates and events
this means that we can rebuild the whole list instead of removing single rows which
causes the application to hang for big numbers of items.
2017-07-24 14:48:02 +01:00
Mihaela Stoica
713f84cf54 CP-22472: Add new XenCenter metadata file to the server status report: changes following code review
- Added more items to the metadata; the content is now slightly different between the SSR produced in XenCenter and the one from the HealthCheck;
- Encode the metadata string before sending it to the Health Check;
- Always suppress history for the action that sends the proxy settings;
- Renamed some of the new classes;
- Also refactored the actions that send data to the HealthCheck service.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Mihaela Stoica
54ab9307d2 CP-22472: Add new XenCenter metadata file to the server status report
- XenCenter sends its telemetry info to the HealthCheck service
- The HealthCheck service saves this metadata in its settings file and includes it in the health check upload

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Mihaela Stoica
2c37367155 CP-22472: Add new XenCenter metadata file to the server status report
- this adds the telemetry file to the server status report produced in XenCenter

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Mihaela Stoica
77b73c8d16 CP-22471: Add information on XenCenter help usage to the user settings
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-13 13:42:26 +01:00
Gabor Apati-Nagy
f1a20c279e Merge pull request #1603 from MihaelaStoica/CA-253936
CA-253936: Fix proxy authentication in the XenServerHealthCheck service
2017-05-31 14:37:02 +01:00
Mihaela Stoica
f752f05a1d CA-242134: Remove the VMPP code
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-25 15:37:05 +01:00
Mihaela Stoica
ad6631f698 CA-253936: Fix proxy authentication in the XenServerHealthCheck service
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-23 16:57:38 +01:00
Gabor Apati-Nagy
72ceeb2de3 CA-249084: Removed obsolete functionality
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 16:01:20 +01:00
Mihaela Stoica
dc56379dc3 CA-232996: Storage menu doesn't refresh in XenCenter for destroy and forget
Update the toolbar when an SR action is completed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-24 10:40:55 +00:00
Konstantina Chremmou
07c0ad25cf CA-248087: Updated API bindings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-03-23 12:20:07 +00:00
Mihaela Stoica
19f1460865 CA-137249: Strange 'Completed' text shows while enabling or disabling HA
Suppress updates to the status when the PureAsyncAction runs the action to populate the ApiMethodsToRoleCheck

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-16 13:31:51 +00:00
Mihaela Stoica
eb9ed4cda0 Merge pull request #1469 from letsboogey/rdpconsole8
CA-245546 - Only the active RDP console is resized when the main XenC…
2017-03-07 14:56:19 +00:00
Letsibogo Ramadi
29a683afc3 CA-245546 - Only the active RDP console is resized when the main XenCenter window is resized 2017-03-03 17:29:19 +00:00
Mihaela Stoica
ed3668d68d Merge pull request #1457 from letsboogey/rdpconsole8
CP-20881 - Implement RDP console resize when toggling the full screen…
2017-03-02 10:36:31 +00:00
Letsibogo Ramadi
27918a1c02 CP-20881 - Implement RDP console resize when toggling the full screen mode
In addition to ticket requirements, the console size is updated when the console is:
- resized in undocked mode
- resized manually by dragging window edges
- resized by dragging the panel splitter

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-03-01 17:48:42 +00:00
Mihaela Stoica
7a04e5186e Merge remote-tracking branch 'upstream/CAR-2214' into master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	Jenkinsfile
	XenModel/Actions/Updates/DownloadAndUnzipXenServerPatchAction.cs
	XenModel/Actions/Updates/DownloadUpdatesXmlAction.cs
2017-02-28 10:30:02 +00:00
Sharath Babu
32836a4b49 CA-241810: [VMSS] VM scheduled snapshot options visible on XC on host with Dundee XS
Updating DundeeOrGreater check with FalconOrGreater

Signed-Off-By: Sharath Babu <sharath.babu@citrix.com>
2017-02-06 11:38:26 +05:30
Sharath Babu
0800e361c6 Merge branch 'master' of https://github.com/xenserver/xenadmin into VMSS 2017-02-04 13:59:58 +05:30
Mihaela Stoica
c35eae23be CP-19607: Unregister event handlers when the tab pages are hidden
Implemented a generic mechanism to allow tab pages to unregister their event handlers when they are hidden (when a tab page gets deselected)
Also changed VMStoragePage to derive from BaseTabPage, so it could use the same mechanism.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-25 12:38:33 +00:00
Sharath Babu
ee4b2818f6 Merge remote-tracking branch 'xenserver/CAR-2205' into xenserver/VMSS
Signed-Off-by: Sharath Babu <Sharath.Babu@citrix.com>
2017-01-25 13:01:54 +05:30
Konstantina Chremmou
489d8684e4 Merge remote-tracking branch 'upstream/master' into CAR-2214
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/branding.sh
#	mk/archive-unsigned.sh
#	mk/build.sh
#	mk/bumpBuildNumber.sh
#	mk/copy-build-output.sh
#	mk/declarations.sh
#	mk/tests-checks-cover.sh
#	mk/tests-checks.sh
2017-01-24 14:46:57 +00:00
Konstantina Chremmou
88b4104dac Moved the ProxyAuthenticationMethod enum to the HTTP class so the VNCControl can compile.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-01-20 14:47:04 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Frederico Mazzone
f964fa88c6 Merge branch 'master' into CAR-2214
Conflicts:
	XenAdmin/Core/Registry.cs
	XenModel/Actions/Updates/DownloadUpdatesXmlAction.cs
2016-12-23 14:10:43 +00:00
Mihaela Stoica
329f084a7e Merge branch 'CAR-2184' to master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/XenAPI-Extensions/SR.cs
2016-10-18 10:18:47 +01:00
Mihaela Stoica
e6fbcfdb5d CA-224567: PVS Site renaming plus some other improvements
- Correction in the text on the PVS Cache configuration page
- Added help IDs for all new dialogs and the PVS tab
- Help button on the Enable PVS read caching dialog, plus some adjustments in the controls sizes on this dialog
- Removed minimize and maximize buttons from the PVS servers dialog, and added the help button

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-17 13:02:59 +01:00
Konstantina Chremmou
7a74096d3b CA-157786: Added general tab for VDIs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-14 13:51:51 +01:00
Konstantina Chremmou
0b3d3abfcc Code repetition.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-14 12:21:59 +01:00
Frezzle
3522e2980d [CP-19111] Added ability to choose Basic or Digest authentication for proxy server
2 new radio buttons in Connection Options page, for Basic and Digest; Digest is the default as it's the most secure.
New proxy authentication method setting, which is used to configure XenAPI's HTTP class and the .NET AuthenticationManager (which handles which authentication schemes can be used by the .NET web classes).
The new setting is also transferred and used by the Health Check service.

The bug noted in CA-214653 also occurs here, but the work-around on PR#1201 for that bug will also work for this.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-10-12 19:09:35 +01:00
Mihaela Stoica
f2b1443064 Merge branch 'master' into CAR-2184
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2016-09-26 13:26:31 +01:00
Mihaela Stoica
151e6f42fb CP-17920: Show the PVS tab only when the supplemental pack is installed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-23 14:51:19 +01:00
mcintyre94
dd42394a25 CP-16922: Implement GUI for enabling PVS read caching (#1179)
* CP-16922: UI changes to PvsPage to replace the single configure button with a separate enable and disable one, per the design doc

* CP-16922: Intermediate checkin - command + dialog implemented, but PVS page has some layout problems.

* CP-16922:  Implement GUI for enabling PVS read caching and marking/unmarking VMs for prepopulation

Fix the broken layout by reverting MainWindow.resx (which shouldn't have changed) back to the previous commit. Also removed duplicate properties button code.

*  CP-16922: PVS Page changes, to properly display all VMs (not just ones with proxy), only populating proxy columns if there is a proxy set.

* CP-16922: Use a CommandButton for the enable button, connected to the same command as the VM main menu button, and using the table selection as its selection manager.

* CP-16922: Delete the old enable button click behaviour (because it now has a proper command), was causing the dialog to show up twice

* CP-16922: Properly list VMs by hiding those that should be hidden (in addition to non-VMs, also hide the __gui__ prefix and others covered by Show function). Also fixes a bug in NewVMGroupVMsPage discovered when fixing this - it would show VMs that should be hidden if you used the search bar.


* CP-16922: Use ButtonText on the Command to set the text on the PVS enable button

* CP-16922: Add the disable PVS read-caching command, and its associated proxy destroy action. Both based off enable equivalents (main difference is no dialog for now). Not used yet but will be in main window menu + disable button

* CP-16922: Add disable PVS read-caching to the main window menu (under enable), with the disable command attached to it


* CP-16922: Add support for disabling PVS read-caching for selected hosts via the PVS tab page by converting the disable button into a CommandButton in the same way as the enable button, using its own command + selection manager (because Selection Managers only bind to one control)

* CP-16922: Design - adding the "read caching enabled" column from the design, so that we display both whether caching is enabled and whether the VM is currently cached. If it's disabled all other values are missing.


* CP-16922: Add the PVS site column per the design to show the site a VM's PVS Proxy is on if it has a proxy


* CP-16922: Add an event handler for VMs changing so that newly provisioned VMs immediately show up in the PVS tab page


* CP-16922: Support for properly remembering the selection when the VM list is refreshed. A new method returns the list of VMs for the selected rows, and we can then check if the VM for the row being added is in this list. If there was no previous selection then we still select the first row by default.


* CP-16922: Remove prepopulate, which is being removed from the design. The next XAPI version will remove it, so just pass False as prepopulate for now, and remove the option from the dialog and PVS tab page.


* CP-16922: Improve UI appearance for a missing Storage Repository. Per the design, if there is no SR show the message None (memory only) instead of an empty cell

* CP-16922: Improved sorting behaviour. All columns (except VM name, which always uses it) use the VM tag as a sorting fallback (since they all have duplicates). New default sort which sorts by caching enabled first (yes before no), and then VM tag as a tiebreaker. Support for remembering the current sort on refresh, ie when a value changes.

* CP-16922: Refactoring to use a VM extension method to get the PVSProxy (or null if none exists) for a VM. This was used in the PVS Page + commands which are now much simpler.


* CP-16922: Move where the SelectionChanged event handler is set when refreshing the PVS table, so that the command buttons are updated correctly.

* CP-16922: Improvements to PVS read-caching dialog. Set accept/cancel buttons properly + adjust tab values, so focus acts as expected


* CP-16922: Remove the images from the menu for Enable/Disable PVS read-caching, most commands in the menu don't have one

* CP-16922: Sorting out the strings for the actions + ParallelAction calls, and moving them into the resx. Also reverting wrong MainWindow.resx changes.

* CAR-2184: XAPI changes. I've made the minimal possible changes to PvsPage to ensure it compiles, but it's had a lot of feature work (CP-16922) that supersedes this, these small changes should keep that merge painless.


* CAR-2184 XAPI: Reverse the unrelated changes, only keep the PVS ones.

* CP-16922: Merge latest XAPI changes, notably changes to Pvs_site.create

* CP-16922: Change tab show/hide logic for PVS tab, show it even if there are no PVS sites.

* CP-16922: Implement GUI for enabling PVS read caching

Design changes - remove the storage repo column and replace it with status, which is populated with a friendly version of the pvs_proxy_status enum. Also populate site list using site.name_label

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

*  CP-16922: Implement GUI for enabling PVS read caching

Adjusting the CanExecute of Enable PVS read-caching command to require at least one PVS site to be created. Since the PVS tab can show up without any sites, we need this because we can't create a proxy without a site.

* CP-16922: Code review changes.

Tidied up messages, and ensured actions run async properly, and without exiting before their task.

* CP-16922: Code review changes.

Update dialog resx, wider combobox on dialog, update action descriptions before setting RelatedTask, add friendly message body for PVS error notifications.
2016-09-22 15:08:15 +01:00
Konstantina Chremmou
565f95291d CA-100083 (part of): Set minimum width of the main window's tab control to 40% to
avoid buttons on the console tab overlapping. Removed some panels from the console
tab to reduce control nesting.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-17 01:23:55 +01:00
Mihaela Stoica
9df8b0494c CP-18407: Rename PVS farm to PVS site
- Rename everything to PVS site

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-09 12:01:59 +01:00