Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-12-22 16:36:03 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
5,369 Commits 12 Branches 48 Tags 186 MiB
1789abb901
Commit Graph

1151 Commits

Author SHA1 Message Date
Michael Z
1513a789ca CP-28614: Rebranding to Citrix Hypervisor, auto-replacement. 2018-07-19 16:12:55 +01:00
vetrivelc
8ef1764c84 L10N: Translation Updates & CA-293780 2018-07-19 11:05:16 +01:00
Michael
8c4727d67b CP-28787: Change some "XenServer" to neutral references. (#2142) 
* CP-28787: Change some XenServer to neutral references.

Signed-off-by: Michael Zhao <fengyang.zhao@citrix.com>
 2018-07-19 10:50:49 +01:00
Konstantina Chremmou
d639708781 CA-293863: Do not update the done and in-progress actions on the worker thread. 
Also, do not log error every time the output panel is updated.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-16 11:50:42 +01:00
Mihaela Stoica
9accb3c69f Merge branch 'master' into REQ-672 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenAdmin/XenAdmin.csproj
 2018-07-13 13:14:36 +01:00
Konstantina Chremmou
9157db94ac CA-293764: Added new property XenObject to the Checks, which returns the Pool 
or Host accordingly. Extended comparison of Problems to also take account of
the XenObject the Check was performed on, otherwise the Problems get mixed
up when there are homonymous members across pools.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-13 12:39:33 +01:00
serenc
0bec35629a CA-293337: Pass device-config from probe to PBD.create 
Signed-off-by: serenc <seren.corbett@citrix.com>
 2018-07-12 14:57:14 +01:00
Mihaela Stoica
15aee105f0 CA-293669:Code optimisation 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-07-12 14:45:23 +01:00
Mihaela Stoica
f09683be7c CA-293669: Block the installation of an old-format patch if the pool is partially upgraded and the master is Ely or greater 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-07-12 14:45:23 +01:00
Konstantina Chremmou
542cf63428 Improved the RBAC message on the Patching wizard to provide more info on the 
minimum required role. Do not deselect a pool on the RPU wizard if it fails
the RBAC check; let the user decide either to reconnect with more privileges
or deselect it.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-12 13:36:27 +01:00
Mihaela Stoica
12dc85f830 CA-293687: Remove redundant check 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-07-11 12:59:52 +01:00
Mihaela Stoica
eeb671d960 CA-293687: After a host has been upgraded, perform a check for updates before calculating the minimal patches 
(to ensure that XC has the latest c-f-u data, as it's possible that the user hasn't configured XenCenter to automatically check for updates)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-07-11 12:59:52 +01:00
Mihaela Stoica
f59c6a4815 In the RPU wizard, run the HA and automated updates license checks on SelectedMasters, to ensure that they are run even if the master does not need to be upgraded or updated 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-07-11 12:59:52 +01:00
Mihaela Stoica
046c4e1c7b CA-293682: In the RPU wizard, only check the batch hotfix license restriction for Dundee or greater hosts 
... because pre-Dundee hosts dont't have this license flag, but they might have it after the upgrade.

Also added a bit more logging in the function that generates the update plan actions

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-07-11 12:59:52 +01:00
serencorbett1
63d09dd117 CP-28431: Block updates/upgrades from Kolkata if clustering enabled (#2124) 
* CP-28431: Block updates and upgrades from Kolkata onwards if clustering enabled
* CP-28431: Rename files and change from Pool Check to [Host] Check
* CP-28431: Change description message

Signed-off-by: Seren Corbett <seren.corbett@citrix.com>
 2018-07-09 10:59:09 +01:00
Konstantina Chremmou
624a228715 Corrected the logic deciding whether a supplemental pack is applicable on a host. 
(This looks like a better fix for CA-236547 too).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-08 22:43:21 +01:00
Konstantina Chremmou
c11b692958 CA-293158: Reworked the logic enabling/disabling and selecting servers depending 
on the update mode, so that the right set of hosts is passed on to the prechecks
page for partially upgraded pools that are to be updated to a new version with
hotfixes. Also, corrected code that was mixing the logic of changing the enabled
 state of a row with the checked state.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-08 22:43:21 +01:00
Konstantina Chremmou
91563ebd54 No need to catch and rethrow exception as it's logged anyway; a couple of more optimisations. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-08 22:43:21 +01:00
Konstantina Chremmou
0aa43018a4 Removed ManualModeSelected property in favour of the existing ManualUpgrade; moved the latter in the class using it. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-08 22:43:21 +01:00
Konstantina Chremmou
8851139a11 Reverted the AutomatedUpdatedLicenseCheck to derive from HostPostLivenessCheck or 
the liveness warning is not issued if the pool is disconnected. HAOffCheck tidy up.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-08 22:43:21 +01:00
Mihaela Stoica
a511124b82 CA-293311: RPU wizard: Only check the maintenance mode on hosts that need to be upgraded (and check host liveness on the hosts where we will only apply updates) 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-07-06 16:03:28 +01:00
Mihaela Stoica
1ac88b7cec CA-293311: RPU wizard: In a partially upgraded pool, apply the hotfixes on the upgraded hosts before upgrading the remaining slaves 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-07-06 16:03:28 +01:00
Mihaela Stoica
7c1484d6c7 CA-293099: If the update that we are trying to apply is already applied, then show that in the wizard. 
Also sort Messages.resx and call ReplaceProgressStep instead of AddProgressStep in the DownloadPatchPlanAction class (when the download is skipped)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-07-04 16:08:22 +01:00
Konstantina Chremmou
b08e91a470 Do not create a new background worker every time the checks are refreshed; queue 
a new check on the existing one instead. Moved the background worker to the designer
of the class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-04 12:09:37 +01:00
Konstantina Chremmou
c2ae0a6069 Placed the CFU availability and the automated updates licence checks under the same group as requested per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-04 12:09:37 +01:00
Konstantina Chremmou
63e4ced7fe Run the CFU availability check together with the check for the automated updates licence. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-04 12:09:37 +01:00
Jisheng Xing
076c9dfb96 declare VMs with SR-IOV VFs as non-agile 
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-07-04 12:03:03 +01:00
Mihaela Stoica
167c5132a3 CA-293099: When installing updates in the automated updates mode (including new version and RPU), ignore the UPDATE_ALREADY_APPLIED errors and allow the process to continue witth the remaining actions. 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-07-03 11:09:14 +01:00
Konstantina Chremmou
54e341c315 Added some null safety checks. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-02 17:37:52 +01:00
Konstantina Chremmou
80aef805bf CA-293046: If a host has been updated and eventually rebooted, toolstack does not need to be restarted. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-02 17:37:52 +01:00
Konstantina Chremmou
6b2a9c3944 CA-293153: Moved the logic calculating the resolved precheck actions to be 
reverted to the new class UpdateUpgradeWizard which serves as base for the
Patching and the RPU wizards. Pass the list of resolved problems to the
automated updates page and not the actions, so as to prevent premature (i.e.
on creation as opposed to on start) addition to the global list shown on
the Events page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-02 17:37:52 +01:00
Konstantina Chremmou
5728a84e33 Renamed method UnwindChanges to CreateUnwindChangesAction to avoid cofusion, because the method only creates the action and does not run it. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-02 17:37:52 +01:00
Konstantina Chremmou
8ff639bfe9 Reset the background workers list when the page is loaded, but not when it's cancelled. Dispose of them when the page is disposed. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-02 17:37:52 +01:00
Konstantina Chremmou
3107c111f0 CA-293153: The logic calculating the resolved precheck actions to be reverted 
is now in one place, namely the PatchingWizard_PrecheckPage.UnwindChangesActions.
The pages following this page use now this list instead of the problems
encountered, so we ensure that the update/upgrade plans do not include the
unwind action if no resolution of problems took place on the prechecks page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-02 17:37:52 +01:00
Konstantina Chremmou
741bfaa864 CA-293092: Enhanced the logic of the SuccessfulDescription in the defining 
class so the caller won't have to worry about it.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-02 17:37:52 +01:00
Konstantina Chremmou
7ea811e942 Renamed method SolveImmediately to GetSolutionAction because the old name was misleading: the method creates the action, it doesn't run it. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-02 17:37:52 +01:00
Konstantina Chremmou
dc8b2379c2 CA-292908: Fixed calculation of process percentage so the progress bar reaches 100% at the end of a successful update process. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-02 17:37:52 +01:00
Konstantina Chremmou
233dc66026 Moved checkbox closer to the datagridview, where it belongs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-02 17:37:52 +01:00
Konstantina Chremmou
9a54258601 When updating multiple pools with the same patch and the download for the first pool is in progress, log that the download is on hold for the others. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-02 17:37:52 +01:00
Konstantina Chremmou
ca6458ac84 Do not repatriate VMs if there are none to repatriate. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-07-02 17:37:52 +01:00
Mihaela Stoica
e59b5dcb2b CA-293119: Add the pending master reboot precheck to all wizard modes 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-07-02 15:24:09 +01:00
Ji Jiang
2edacbf43f CA-293092: Add HostCheck class to fix check.Host null exception 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-06-29 14:27:10 +01:00
Konstantina Chremmou
f16cc7f770 Made UploadPatchAction and UploadSupplementalPackAction report progress of uploaded bytes. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-28 12:25:56 +01:00
Konstantina Chremmou
3e71da4e0a Do not trigger the Action.Change event when the PercentComplete or the Description 
are set unless the new value is actually different. Small efficiency improvements
to the DownloadPatch action and plan action.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-28 12:25:56 +01:00
Konstantina Chremmou
86ea06696e CA-293009: Show the message for reconnecting storage after the host is rebooted. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-28 12:25:56 +01:00
Konstantina Chremmou
8d6b615841 Check and plug PBDs for VMs only if and when there are VMs to migrate; do not log 
a message in this case as the SRs are reconnected after reboot and this may lead
to duplicate messages. Also, simplified check-and-plug methods for PBDs to avoid
repetition of iterations.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-27 07:58:55 +01:00
Konstantina Chremmou
8a6c661f30 Fixed broken test. Small logging and window title improvements. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-26 22:15:11 +01:00
Konstantina Chremmou
2c07869599 CA-292363: Do not show the DownloadAndUnzipXenServerPatchAction in action history. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-26 22:15:11 +01:00
Konstantina Chremmou
d3f761b070 Reworked the logging for the plan actions. (#2109) 
* Deprecate set but unused Status property in favour of ProgressDescription.
* Deprecate set but unused TitlePlan property.
* Deprecated property Title in favour of ProgressDescription.
* Removed unused plan RebootHostPlanAction.
* Updated event declaration.
* Removed property Visible. The plan is to have the actions log their history as soon as some is available.
* Reworked the logging for the plan actions. The main change is the replacement of
the ProgressDescription with a stack where all the steps of an action are stored,
i.e. the action is responsible for its history, not the worker running it.
* Lock the progress history before accessing it.
* Better handling of error logging and user cancellation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-26 14:04:51 +01:00
Ji Jiang
41e358a8fa CP-28583: Remove host-level selection in Update wizard 
1) Always pool level selection of hosts, except uploading sup pack file
from disk.
2) Revert homogeneity precheck change recently. It won't happen in new version
update any more.
3) User can never update slaves to a higher version than master, so delete
master_version_not_compatible_problem.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-06-26 12:45:59 +01:00
Mihaela Stoica
1bd439a2af CP-28279: Corrections to the plan actions 
- In the RPU case, re-enable the host after the upgrade is done, as the host will be put back into maintenance mode when needed during the update process.
- The VMs should not be repatriated during the RPU
- When a host is rebooted, it needs to be disabled first (even if an evacuation is not needed), otherwise the reboot won't happen

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 17:12:39 +01:00
Mihaela Stoica
2023f93199 CP-28279:When installing the updates in the RPU wizard, we need to get the minimal patches for the first upgraded host (usualy the master), not for the whole pool, because the pool is of mixed versions at this stage. 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 11:31:18 +01:00
Konstantina Chremmou
03b5e9a0c4 Moved logic for calculating the progress increment into the UpdateProgressBackgroundWorker. 
Renamed HostPlanActions class to HostPlan to avoid confusion with the HostPlanAction class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-25 11:31:18 +01:00
Konstantina Chremmou
37d9bc4b3b Moved all the code for the manual upgrade into the UpgradeManualHostPlanAction and removed the IsManual property. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-25 11:31:18 +01:00
Konstantina Chremmou
09de5fbcd6 Code repetition. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-25 11:31:18 +01:00
Konstantina Chremmou
73fd7df880 Use existing extension method to retrieve the host's running VMs. Removed field 
Dialogs needed only by test code; use existing wrappers of Windows APIs instead.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-25 11:31:18 +01:00
Konstantina Chremmou
50b78ddd83 Moved NonModalThreeButtonDialog out of the RpuUpgradePage because it is pretty generic and can be reused. 
Removed unnecessary null check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-25 11:31:18 +01:00
Mihaela Stoica
0d3c475439 CP-28279: Fix the AutoScaleMode 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 11:31:18 +01:00
Mihaela Stoica
e8d2b9e493 CP-28279: Use different messages for RPU (for reporting success or failure) 
- Also corrected the function that creates the update plan action in RPU: when running a retry, these actions shouldn't be regenerated.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 11:31:18 +01:00
Mihaela Stoica
7ed8a2ba44 CP-28279: Add updates installations to the RPU wizard 
- Some methods have been moved/added to the base class to facilitate the calculation of the plan actions in the RPU case.
- Also fixed the calculation of the progress bar value.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 11:31:18 +01:00
Mihaela Stoica
a99ae50f57 CP-28279: Change the upgrade page of the RPU wizard to inherit from the class AutomatedUpdatesBasePage 
- Methods have been added to the base class to deal with the manual upgrade mode

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 11:31:18 +01:00
Mihaela Stoica
3201ed3329 CP-28279: Fix the layout of the AutomatedUpdatesBasePage 
(by putting everything on a TableLayoutPanel)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 11:31:18 +01:00
Konstantina Chremmou
e7683fcf0b CP-28492: Evacuate the VMs before the first reboot and repatriate them after the last one. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-22 17:40:53 +01:00
Konstantina Chremmou
cfb1c0f4d7 CA-291402: Do not display a plan action before it is actually running; this prevents skipped actions from being displayed. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-22 17:40:53 +01:00
Konstantina Chremmou
907e991745 Renamed file to match class name. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-22 17:40:53 +01:00
Ji Jiang
6d070d3cfc CP-28425: Add automated updates license precheck in RPU wizard 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-06-22 17:20:11 +01:00
Ji Jiang
ccf6f97732 CP-28280: Add CFU availability precheck to RPU wizard comments fix 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-06-22 12:02:19 +01:00
Ji Jiang
9ae8340913 CP-28280: Add CFU availability precheck to RPU wizard 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-06-22 12:02:19 +01:00
Jisheng Xing
b6e1ad6b83 fix typos and rename a function 2018-06-21 14:54:47 +01:00
Mihaela Stoica
3c300accce CP-28279: Make the base AutomatedUpdatesBasePage class abstract 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-20 11:15:35 +01:00
Mihaela Stoica
73f6ebdf5c CP-28279: Add a base class for Automated Updates (this will be later used for the RPU as well) 
The base class contains all the code for creating and starting the background workers, displaying the progress of the actions, handling failures and retries.
The derived classes override the property for label at the top of the page and the method that generates the plan actions.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-20 11:15:35 +01:00
Konstantina Chremmou
6513abc09e The check for hosts that are unlicensed for automated updates should be on all pool hosts as there maybe individual restrictions (for example via a feature flag). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-19 17:20:08 +01:00
Mihaela Stoica
da9e5a5cab CP-28284: Implement IEquatable in PlanAction 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-19 13:34:37 +01:00
Mihaela Stoica
59b9b695db CP-28284: Changes following code review 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-19 13:34:37 +01:00
Mihaela Stoica
631d7656a2 CP-28284: Corrections 
- ensure that an action is only added once to the DoneActions and InProgressActions
- reset the wizard buttons (Cancel, Finish) when a retry is started

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-19 13:34:37 +01:00
Mihaela Stoica
920da093e0 CP-28284: Only show the error icon and text when all the workers have finished 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-19 13:34:37 +01:00
Mihaela Stoica
eca6081f48 CP-28284: Show the plan actions indented under the pool name 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-19 13:34:37 +01:00
Mihaela Stoica
7fa9d0b94f CP-28284: Updates wizard: Add a "pause and resume" mechanism to handle failures 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-19 13:34:37 +01:00
Konstantina Chremmou
d9ee664d53 CA-289629: launch confirmation dialog within a using block. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-18 21:59:38 +01:00
Mihaela Stoica
da2c96ad1c CP-28426: RPU wizard: add user option for automatically applying updates - changes following code review 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-18 16:28:28 +01:00
Mihaela Stoica
dd19f3a0b7 CP-28426: RPU wizard: add user option for automatically applying updates 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-18 16:28:28 +01:00
jishengx
cf20ac13c4 CA-289629: prompt host may need to be rebooted to enable SR-IOV (#2092) 
CA-289629: prompt host may need to be rebooted to enable SR-IOV

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-06-18 12:36:12 +01:00
Joey
abe97def1e CP-28286: Support resume from a partially upgraded pool via Update wi… (#2095) 
* CP-28286: Support resume from a partially upgraded pool via Update wizard

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>

* CP-28286: Fix comments of the previous commit

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-06-18 10:46:41 +01:00
Mihaela Stoica
318f20f65f CP-28282: Preliminary work: move the disk space calculation inside the precheck 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-13 17:22:52 +01:00
Mihaela Stoica
8fff0b2b10
Merge pull request #2093 from kc284/REQ-672 
Separate displayed update information per pool. Minor layout corrections and removal of unused LinkLabel.
 2018-06-08 16:54:11 +01:00
Konstantina Chremmou
49823f9dd9 Do not show the successful completion message before the update is actually completed. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-08 16:41:06 +01:00
Konstantina Chremmou
73e7b66fa4 Do not change the page top blurb depending on the process outcome. Improved error messages. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-08 16:15:55 +01:00
Konstantina Chremmou
2e2ae7c196 Separate displayed update information per pool. Minor layout corrections and removal of unused LinkLabel. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-08 13:42:06 +01:00
Mihaela Stoica
15edb13997
Merge pull request #2089 from kc284/REQ-672 
First batch of changes for CP-28281
 2018-06-08 11:32:26 +01:00
Konstantina Chremmou
11a9785dba Log the patch clean-up actions on the screen in case of a failure. Order the shown actions per pool. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 16:34:13 +01:00
Konstantina Chremmou
1b4a862fd0 Further corrections to the load/leave page workflow and object selection ensuring correct enablement of the Next button. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
20d74a64c9 Unregister handlers when leaving or cancelling the page and invoke on the current 
control instead of the main window (may cure CA-289721).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
b36993228c Moved index retrieval in Invoke and corrected index sanity check. Update the combobox 
and unregister item event in a try-finally block (may cure CA-289721); suspend-resume
layout when updating the datagridview.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
3f8feb4bdd Removed invocations where we are already on the UI thread. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
2e07781e6b Simplify the logic toggling the enabled state of the Next button depending on the selection. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
621fce4d70 Fixed regression whereby the vm-host mapping was lost when proceeding to the next page and returning to the destination selection page. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
355621f183 Simplified event signature. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
1d905fc18c Simplified logic when fetching the failure reason; capitalised constant names so they're more visible. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
2c3c4bf5ca Renamed methods so it's more obvious what they do. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00
Konstantina Chremmou
887428872a Logic corrections. Show the name of the patch being removed each time. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:12:17 +01:00
Konstantina Chremmou
57ab2ced2b CA-289335: If there is no other network available, pick the management network for the migration of VDIs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-06 16:06:41 +01:00
Konstantina Chremmou
c643351e6c CP-28281: Change the order in which the updates are applied to a pool, namely apply all updates on a host before continuing with the next host. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-05 22:26:16 +01:00
Konstantina Chremmou
723510b853 Removed class Updates.UpgradeSequence. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-05 11:50:34 +01:00
Konstantina Chremmou
d58131910b Corrected logic checking the host is up to date. Renamed method because the old name was not descriptive of the output. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-04 12:40:30 +01:00
Konstantina Chremmou
b0cdc74188 The code in the BackgroundWorker's ProgressChanged and RunWorkerCompleted event handlers does not need invoking as it's already on the UI thread. 
Also, some logic simplification.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-29 13:50:46 +01:00
Konstantina Chremmou
18f2ff0785 Typo. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-29 10:46:14 +01:00
Mihaela Stoica
c2b42fa107 CA-289335: Refactoring to avoid setting the SelectedItem twice 
- also avoids iterating through the combobox items again to determine which item to select

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-24 16:23:04 +01:00
Mihaela Stoica
5d0b760a96 CA-288751: Fix the RBAC checks for probe_ext 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-24 13:00:05 +01:00
Mihaela Stoica
01c8a7ed83 CA-289150: Use a local variable to avoid calculating DistinctHosts twice 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-17 14:33:31 +01:00
Mihaela Stoica
171284ff34 CP-28094: Rationalise device-config keys with SMAPIv1 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-05-16 17:18:12 +01:00
Konstantina Chremmou
085b4d4f6e CA-248353: Do not use a hardcoded string or integer to reference DataGridView columns or ToolStripMenuItems. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-15 13:17:04 +01:00
Konstantina Chremmou
79684617eb CA-248353: Reference the column object directly instead of trying to retrieve it using a hardcoded string as a key. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-15 13:17:04 +01:00
Konstantina Chremmou
3fc14c5344 Disable creation of SR-IOV network if the feature is disabled. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-05-09 12:38:26 +01:00
Vetrivel Chinnasamy
998cea2ec2 L10N: Kolkata Bug Fixes (#2052) 
* L10N: UI Truncation Fixes

* L10N: Bug fix truncation issue JA

* L10N: Removed the help image in SC Wizard page

* L10N: Update to zh-CN XenWizrd Base
 2018-04-25 18:19:03 +01:00
Mihaela Stoica
8a16c794c1
Merge pull request #2046 from vetrivelc/master 
L10N:CA-281877,CA-283587,CA-286950,CA-287318 Fix Updates
 2018-04-20 11:38:52 +01:00
Vetrivel Chinnasamy
0cf3d404ee L10N:CA-281877,CA-283587,CA-286950,CA-287318 Fix Updates 2018-04-20 18:28:09 +08:00
jishengx
aa276dc8f5 CA-286449: Filter out SR-IOV network when importing OVF (#2037) 
CA-286449: Filter out SR-IOV network when importing OVF

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-04-19 15:51:33 +01:00
vetrivelc
4ac8f99bae L10N: Localization File updates 2018-04-19 18:07:23 +05:30
Konstantina Chremmou
04a29dd3a0 Message correction. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-17 13:32:05 +01:00
vetrivelc
ea1baf33e7 L10N: CA-281877 JA & SC fix 2018-04-17 15:25:29 +05:30
vetrivelc
7c3c95f74b L10N: Fixes CA-283585,CA-283587,CA-287318,CA-286950,CA-287342,CA-281877 UI/Truncation Issues 2018-04-17 12:11:23 +05:30
vetrivelc
b57d7d13bf L10N:CA-287607 Translation Updates 2018-04-17 10:08:42 +05:30
Mihaela Stoica
2af3de8e7f CA-287430: Fixed the issue where the "Install Update" page of the patching wizard does not show the information on the host reboot steps. 
- use the plan action's ProgressDescription property to display the steps in RestartHostPlanAction (evacuate host, reboot host, bring babies back);
- the plan action should not be visible if the restart is skipped;

- The change to the DownloadAndUnzipXenServerPatchAction is to ensure that the download progress description is updated on the wizard with the correct description (in automated updates mode, via DownloadPatchPlanAction); DownloadPatchPlanAction is using the ActionChanged event to update its description based on the  action's DownloadProgressDescription property, but the ActionChanged event is called when the PercentComplete is updated, so this needs to happen after DownloadProgressDescription has been updated.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-04-10 11:08:18 +01:00
Konstantina Chremmou
82dc176c44 CA-287498: Removed left over calls to the base class method which were causing an infinite loop. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-09 09:58:40 +01:00
Mihaela Stoica
1925fc9ec4 CA-285215: Cancel button should be enabled on the Patching wizard when the update installation is in progress 
- also fixing an error on the patching wizard where a null reference exception is thrown if, when the wizard is cancelled, the host where an update has been uploaded is not connected anymore

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-04-09 08:47:26 +01:00
Mihaela Stoica
cab6a051b8 Merge branch 'REQ-477' into master 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenModel/XenAPI/PCI.cs
#	XenModel/XenModel.csproj
 2018-04-04 09:59:29 +01:00
Konstantina Chremmou
5d4a9270eb Simplified class hierarchies for the SrDescriptors. Among others, we avoid the presence of irrelevant key-value pairs in the DeviceConfig . 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-04 08:03:28 +01:00
Mihaela Stoica
2943b048fa CP-17099: Remove unused function 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-04-04 08:03:28 +01:00
Mihaela Stoica
6a8b65b21e CP-17099: Do the double probe for HBA 
- The LVMOHBAWarningDialog class has been changed to display the type of the existing SR and the requested type (that will be used for formatting)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-04-04 08:03:28 +01:00
Konstantina Chremmou
585f7a848f Cleared some more warnings with regards to xml documentation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-03 13:00:27 +01:00
Konstantina Chremmou
7655011158 Compliance with C# conventions: normally interface names start with an I. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-03 13:00:27 +01:00
Vetrivel Chinnasamy
587144d3bf L10N: Translation Updates (#2020) 
* L10N: Translation Updates
 2018-04-03 11:57:09 +01:00
Konstantina Chremmou
6adcd2b83f Some more code simplifications. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-03 11:24:40 +01:00
Konstantina Chremmou
4b0aa132d2 Simplified the FibreChannelProbeAction and compacted the methods and helper classes for parsing the results for the various SR types. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-03 11:24:40 +01:00
Konstantina Chremmou
4452318d1d Moved the classes FibreChannelDevice and FibreChannelProbeParsing to XenModel. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-03 11:24:40 +01:00
Konstantina Chremmou
959e43480c CP-17099: Double probe for iSCSI - minor refactoring to reduce code duplication. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-04-03 11:24:40 +01:00
Mihaela Stoica
fc42be5bee CP-17099: Do the probe_ext for HBA 
- Move the scan for HBA devices after the Provisioning page
- Fix the device-config for HBA (removed uri)
- Add probe_ext in FibreChannelProbeAction and the method to process the result

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-04-03 11:24:40 +01:00
Mihaela Stoica
e294e903fd CP-17099: Do the double probe for iSCSI 
When we scan the LUN to see if there are any existing SRs, we need to do an additional probe if the probe for the desired type didn't find any SRs.
E.g. if  GFS2 is selected and no GFS2 SR was found on the LUN, then we need to also check if there is a LVM over iSCSI SR, and if there is one we will offer to reattach it (as LVM over iSCSI) or format it as GFS2

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-04-03 11:24:40 +01:00
Mihaela Stoica
fcb6399535 CP-17099: Changes following code review 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-03-28 17:07:15 +01:00
Mihaela Stoica
6ad6b4efc7 CP-17099: Use SR.probe_ext for GFS2 over iSCSI to populate the lists of IQNs and LUNs on the New SR wizard 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-03-28 17:07:15 +01:00
Mihaela Stoica
d3fa68e210 CA-286582: Hide the Provisioning method page if the feature is not present or disabled 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-03-28 17:07:15 +01:00
serenc
b7d3a2b3b5 CP-17099: Add gfs2 SR probe 
Signed-off-by: serenc <seren.corbett@citrix.com>
 2018-03-28 11:34:42 +01:00
vetrivelc
c910f7d41b L10N: Translation Updates 2018-03-27 13:47:39 +01:00
Jisheng Xing
8e64c917e2 fix review comments 
modify the judgement of SR-IOV network

fix review comments

fix review comments

judge the resolve result and modify the link status of VLAN on SR-IOV
 2018-03-26 16:33:11 +08:00
Jisheng Xing
ba0cfdbf59 CA-286129: add or filter out SR-IOV network when creating VM or importing XVA 
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-03-26 16:32:53 +08:00
Jisheng Xing
59ba1db95f CA-286136: modify the SR-IOV related display 2018-03-23 14:44:59 +08:00
Jisheng Xing
73eefe33b5 CA-286136: modify SR-IOV related info display 
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-03-23 14:44:57 +08:00
jishengx
a22cb38835 CP-26363: Display the remaining VF numbers in NIC TabPage (#1982) 
* CP-26363: Display the remaining VF numbers in NIC TabPage

* correct the link status of Networking TabPage

* show the warning when creating SR-IOV network

* fix some comments

* modify the action

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-03-23 14:44:56 +08:00
jishengx
9cfac68d8d CP-25990: Enable Create VLAN on SR-IOV network (#1975) 
* CP-25990: Enable Create VLAN on SR-IOV network

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* fix review comments
 2018-03-23 14:43:51 +08:00
jishengx
6f4fa43c03 CP-26362: Enable create SR-IOV network (#1952) 
* update the XenAPI according to the Jason-RPC

* CP-26362: Enable create SR-IOV network

* fix review comments

* fix the judgement on SR-IOV details page

* disable the finish button

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
 2018-03-23 14:27:04 +08:00