Commit Graph

1271 Commits

Author SHA1 Message Date
Gabor Apati-Nagy
5826395f00 Merge pull request #123 from MihaelaStoica/CA-138822
CA-138822: Improvements to the Host/Pool Storage tab, following on from ...
2014-07-15 14:42:38 +01:00
Gabor Apati-Nagy
fcb40b6c2a Merge pull request #122 from MihaelaStoica/CA-118423
CA-118423: Fix the issue where a non-management bond was shown as discon...
2014-07-15 14:01:49 +01:00
Gabor Apati-Nagy
29fa59e1f9 Merge pull request #119 from MihaelaStoica/CA-139888
CA-139888: Changing window size should not change the number of items mi...
2014-07-15 13:50:54 +01:00
Gabor Apati-Nagy
8aa0dcb1a0 CA-137306: Missing resources
-Added friendly names for RRDd logs

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-07-15 11:43:36 +01:00
Mihaela Stoica
231898fab0 Merge pull request #128 from GaborApatiNagy/xs64bit-fixed-CA-137047
CA-137047: StorageXenMotion not offering all hosts in drop down menu
2014-07-14 18:04:58 +01:00
Gabor Apati-Nagy
72e88af867 CA-137047: StorageXenMotion not offering all hosts in drop down menu
+1 change after code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-07-14 18:02:48 +01:00
Gabor Apati-Nagy
b78cb5d8fe CA-137047: StorageXenMotion not offering all hosts in drop down menu
Some changes after code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-07-14 17:53:34 +01:00
Gabor Apati-Nagy
134f621db9 CA-137047: StorageXenMotion not offering all hosts in drop down menu
-Fixed Home server's commands to try to use both versions of migration when deciding to enable or disable the menu item

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-07-14 17:53:20 +01:00
Mihaela Stoica
9dfeba8be3 Merge pull request #124 from GaborApatiNagy/netmask
CA-116005: validation of the SN mask doesn't appear to be working correctly on the last two values of the mask.
2014-07-14 16:25:40 +01:00
Mihaela Stoica
80348d854e CA-108379: Hotfix prechecks encourage VMs to be suspended unnecessarily if HA is enabled - Fixed
- Added three Warning classes (HAEnabledWarning, WLBEnabledWarning, HostNotLiveWarning), used in the Pre-checks page of the Install wizard (also in the Rolling Pool Upgrade wizard) to indicate that a check was skipped and the reason why.
- If HA or WLB is on, we show this as an error in the "HA and WLB status" check and the "VM migration status" checks will be skipped (with a warning displayed) for all the hosts in the pool.
- Similarly, if a host if unreachable, we show this as an error in the "Host liveness status" check and the following checks for that host will be skipped (and warning displayed).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-14 16:00:43 +01:00
Mihaela Stoica
963f21b074 CA-138293: Added CPU information (number of vCPUs and cores-per-socket) to the VM General tab
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-14 15:17:47 +01:00
Gabor Apati-Nagy
e3c2b66feb CA-116005: validation of the SN mask doesn't appear to be working correctly on the last two values of the mask.
-Unit tests added for Subnetwork mask validation (31 tests)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-07-11 12:37:32 +01:00
Mihaela Stoica
005cb8e709 CA-138822: Improvements to the Host/Pool Storage tab, following on from the TRIM work
- Make "Reclaim freed space" a CommandButton (will appear as disabled if the command cannot execute)
- Add tooltip to "Reclaim freed space" button to show the reason it is disabled
- Hide "Reclaim freed space" button on old servers
- Allow multiselect
- "Reclaim freed space" button enabled if at least one SR can be trimmed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-11 12:24:58 +01:00
Gabor Apati-Nagy
205ffe16d9 CA-116005: validation of the SN mask doesn't appear to be working correctly on the last two values of the mask.
-New IPv4 subnet mask validator added.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-07-11 11:41:38 +01:00
Stephen Turner
9825ffc41f Merge pull request #121 from GaborApatiNagy/login_originator_CA-140330
CA-140330: Use originator in session.login_with_password
2014-07-10 16:14:57 +01:00
Mihaela Stoica
aaa31357fa CA-118423: Fix the issue where a non-management bond was shown as disconnected in XenCenter because the NICs tab was not refreshed when the properties of the new bond changed.
- Register a PIF CollectionChanged event, so the page is refreshed when a bond is added / deleted.
- Register the PIF PropertyChanged event to each PIF when the grid is populated; this ensures that all the PIFs displayed will be refreshed when their properties change.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-10 15:41:33 +01:00
Gabor Apati-Nagy
fe37c06ab6 CA-140330: Use originator in session.login_with_password
-Calling new overload of the session.login_with_password() XAPI function (+originator field). This lets XenServer to group all sessions from a given XenCenter instance.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-07-10 14:58:36 +01:00
Stephen Turner
8deb94d290 Merge pull request #120 from MihaelaStoica/CA-139588
CA-139588: Try to prevent Index was out of range exception by invoking o...
2014-07-10 14:44:26 +01:00
Mihaela Stoica
58b240bcde CA-139888: Changing window size should not change the number of items minimized in Outlook-style navigation panel
This fixes the following problem:
When the main window is resized, we set the minimum width of the right side panel (Panel2MinSize) to half the size of the window so that the tab contents are visible. This is fine on most situations, but on a higher screen resolution (e.g. 1920x1080) the following problem occurs:
- starting with the main window at minimum size, when the window is maximized, the Panel2MinSize is set to half window's size (e.g. 960)
- when the main window is restored back to the minimum size, the split container is not resized because there is a conflict between Panel2MinSize and the size of the window itself (Panel1MinSize + Panel2MinSize > window's width)
- therefore the navigation panel is not visible and also the content of the tab control may appear out of scale.

To fix this, we set the Panel2MinSize to half of the window's minimum width. This way the right side panel will always fit in the window, including when it is restored to minimum size.
This also fixes [CA-137956] - Restoring Maximised XenCenter does not resize the main panel properly.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-10 12:04:32 +01:00
Gabor Apati-Nagy
a0d31920c5 Merge pull request #118 from xenserver/xs64bit
Xs64bit
2014-07-10 11:17:13 +01:00
Mihaela Stoica
eeb86b7956 CA-139588: Try to prevent Index was out of range exception by invoking on the event thread
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-09 14:55:19 +01:00
Gabor Apati-Nagy
fdbfbb3453 Merge pull request #113 from MihaelaStoica/CA-139888
CA-139888: Changing window size should not change the number of items mi...
2014-07-09 09:50:11 +01:00
Mihaela Stoica
c51dc67cb0 CA-139888: Changing window size should not change the number of items minimized in Outlook-style navigation panel
When the navigation panel is resized, we need to preserve the height of the bottom panel, by recalculating the splitter distance.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-08 12:54:03 +01:00
Gabor Apati-Nagy
bc3b23af4f Merge pull request #109 from MihaelaStoica/xs64bit
CA-137485: Updated XenModel with the new API bindings with serializable ...
2014-07-04 17:13:01 +01:00
Mihaela Stoica
1e755a1e5d Merge pull request #112 from GaborApatiNagy/xs64bit-installer_fix_bundle
CA-139890: Installer shouldn't download the .NET installer without askin...
2014-07-04 17:10:02 +01:00
Gabor Apati-Nagy
426910b4a0 CA-139890: Installer shouldn't download the .NET installer without asking but bundle it instead
-Bundling the redistributable Microsoft .NET Framework 4 (Web Installer) into our exe XenCenter installer
2014-07-04 15:44:36 +01:00
Mihaela Stoica
220311829b CA-137485: Improvements to the Exception serialization unit tests
As per code review, wherever there is an 'if' in the unit tests there should be an assertion for the 'else' branch as well

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-04 14:44:38 +01:00
Gabor Apati-Nagy
c36d8dd645 Merge pull request #110 from MihaelaStoica/CA-138928
CA-138928: Added "reclaim freed space" option to the main menu
2014-07-04 14:11:59 +01:00
Gabor Apati-Nagy
077cf39366 Merge pull request #111 from MihaelaStoica/CA-137470
CA-137470: Fixed unhandled exception raised by pressing space key on gri...
2014-07-04 14:11:36 +01:00
Mihaela Stoica
042f7f2927 CA-138928: Added "reclaim freed space" option to the main menu
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-04 13:36:41 +01:00
Mihaela Stoica
8e19193a2a CA-137470: Fixed unhandled exception raised by pressing space key on gridview of License Manager.
- Added a 'refresh grid' parameter to UpdateRow() which indicates if a sort and refresh of the grid is necessary.
- A sort and refresh is not needed when the user selects a server by pressing the space key or by mouse, but it is needed when the information displayed has changed, for example when the license has changed.
- Also solved a possible null reference exception in CheckableDataGridViewController.ReplaceStoredRow(), by returning -1 if the index is not within the rows range.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-04 11:10:46 +01:00
Mihaela Stoica
35877640e0 CA-137485: Updated XenModel with the new API bindings with serializable exceptions
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-03 10:00:05 +01:00
Gabor Apati-Nagy
bdf097bc51 Merge pull request #108 from MihaelaStoica/xs64bit
Added HelpID for File System usage alert
2014-07-02 13:19:44 +01:00
Gabor Apati-Nagy
cf0ab55bfd Merge pull request #102 from MihaelaStoica/CA-136783
CA-136783: Fixed the errors in the Updates window, where clicking "Go to Web Page" opens a wrong link
2014-07-02 13:18:29 +01:00
Mihaela Stoica
7d348fca5e CA-136783: Changed the log level from error to debug for some of the logged messages.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-02 13:13:37 +01:00
Mihaela Stoica
b5450f3888 Added HelpID for File System usage alert
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-02 12:10:34 +01:00
Gabor Apati-Nagy
210d35b45d Merge pull request #100 from MihaelaStoica/CA-137305
CA-137305: When creating a VM, ensure that the vGPUs are unset if not needed
2014-07-01 16:25:15 +01:00
Gabor Apati-Nagy
f3ce457510 Merge pull request #103 from MihaelaStoica/CA-137308
CA-137308: Checkpoint doesn't disappear follow deletion when switching t...
2014-07-01 16:24:54 +01:00
Stephen Turner
73b38569d5 Merge pull request #101 from MihaelaStoica/CA-108676
CA-108676:  Put the Heartbeat and event.next sessions on their own ConnectionGroups
2014-07-01 11:40:32 +01:00
Stephen Turner
4292169435 Merge pull request #99 from MihaelaStoica/CA-115742
CA-115742: VM name and description change not allowed via XenCenter for ...
2014-07-01 11:35:25 +01:00
Gabor Apati-Nagy
ec35a2519f Merge pull request #104 from ushamandya/xs64bit
CP-5436: Modified the 'Updates' section and removed Licensing topics for...
2014-06-30 17:38:46 +01:00
Usha Mandya
2946d811e5 CP-5436: Modified the 'Updates' section and removed Licensing topics for Tech Preview 2014-06-30 17:24:47 +01:00
Mihaela Stoica
4755200d98 CA-137308: Checkpoint doesn't disappear follow deletion when switching to logs mode - FIXED
Force an update of the selected tab when switching back from Notification view, as some tabs ignore the update events when not visible (e.g. Snapshots, HA)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-30 16:38:48 +01:00
Mihaela Stoica
4f341aed60 CA-136783: Fixed the errors in the Updates window, where clicking "Go to Web Page" opens a wrong link
- When clicking the action button on the grid, execute the action on the item that has been clicked, instead on using the grid's selected item, which may have not been updated yet.
- On multiselect (if the multiselect is allowed for the action), if the clicked item is in the grid's selection list, then execute the action on the whole list, otherwise on the clicked item only.
- This applies to both Updates and Alerts windows.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-30 14:49:16 +01:00
Mihaela Stoica
3cb4807737 CA-108676: Put the Heartbeat and event.next sessions on their own ConnectionGroups.
Also make sure that the MeddlingAction's cancel session gets disposed.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-30 14:21:42 +01:00
Mihaela Stoica
d69df44cf1 CA-137305: When creating a VM, ensure that the vGPUs are unset if not needed.
If a VM is created from snapshot which has a vGPU and "No" vGPU is selected  then the newly created VM shouldn't have a vGPU.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-30 09:44:19 +01:00
Mihaela Stoica
5e13fd1d01 CA-115742: Removed unused variable.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-26 10:19:35 +01:00
Mihaela Stoica
06e0ddacb7 CA-115742: VM name and description change not allowed via XenCenter for VM Admin - FIXED
The error has been caused by the shadow multiplier field on Advanced Settings page: XenCenter thinks that the values has changed, and tries to save it, but this is not allowed for VM Admin users.
The solution is:
- use -1 as the signal value for unparseable string, instead of 1.0, which is actually a valid value;
- display the existing value without formatting it to 2 deciaml places;
Also corrected the validation function, as the shadow multiplier has to be greater than or equal to 1, not 0.1.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-25 12:18:24 +01:00
Stephen Turner
7d2e113130 Merge pull request #97 from MihaelaStoica/CP-8547
CP-8547: Add button in XenCenter to initiate space reclamation on an SR.
2014-06-24 15:29:08 +01:00
Mihaela Stoica
1ff55016c8 CP-8547: Add button in XenCenter to initiate space reclamation on an SR: Changes following code review.
- Added check for null for sm.features in SR.SupportsTrim;
- Better error messages;
- Moved error messages from Messages to FriendlyNames;
- Removed the check for actions in progress from TrimSRCommand.CanExecute().

-

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-24 14:48:31 +01:00