Commit Graph

111 Commits

Author SHA1 Message Date
Gabor Apati-Nagy
01ba7e04da CA-145686: (Fix for) Deadlock in license manager
Revert "CA-139588: Try to prevent Index was out of range exception by invoking on the event thread"

This reverts commit eeb86b7956.
2014-09-22 13:53:54 +01:00
Hui Zhang
53e15ecd73 CA-143869: ZH-CN: Buttons are truncated on Workload Balancing Configuration
Fix the display issues of Chinese version XenCenter/WLB:
When WLB Configuration Dialog size is changing,
1. OK and Cancel buttons are truncated,
2. OK and Cancel buttons do not keep at the bottom/right corner of the dialog.

Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
2014-08-19 09:42:03 +08:00
Hui Zhang
51fa464e33 CA-142045: Buttons are truncated on Workload Balancing Configuration for New Pool wizard.
Fix the display issues when WLB Configuration Dialog size is changing:
1. OK and Cancel buttons are truncated.
2. OK and Cancel buttons do not keep at the bottom/right corner of the dialog.
3. The height of the SplitContainer does not track the change of the height of the dialog.

Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
2014-08-18 14:53:36 +08:00
Gabor Apati-Nagy
fd9b88a2f4 CA-141168: EN: Improvement: Textbox lines seem overlap in "Set Maser Password" and "Change Master Password" dialog.
-Modified layout to avoid overlapping and dynamic movement of input fields/buttons when an error message is being displayed.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-08-07 12:05:59 +01:00
Mihaela Stoica
cb7dcc81f4 CA-136173: Getting several notifications for one user-level action (e.g. Updating network operation creates 4 entries in the Notifications/Events view)
- Set the pool details in the action to allow proper filtering by location on the Events page
- Also, when possible, set the Host property: when setting the SR in the action, we also set the Host to SR.Home

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-21 11:40:26 +01:00
Mihaela Stoica
3c051654d6 CA-136173: Getting several notifications for one user-level action (e.g. Updating network operation creates 4 entries in the Notifications/Events view)
-  Suppress reporting of success and failure for sub-actions:
The suppress history flag is set when the action is created and if is false (by default) the action is added to the history (the Events list).
In order to suppress history for the subactions, we need change all actions used in Edit pages so their constructor can set the SuppressHistory flag and then use these constructors with suppressHistory = true on all the implementations of IEditPage.SaveSettings() where an action is created
(then we need to remember to do the same everytime we introduce a new page and / or "save" action).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-21 11:19:04 +01:00
Gabor Apati-Nagy
205ffe16d9 CA-116005: validation of the SN mask doesn't appear to be working correctly on the last two values of the mask.
-New IPv4 subnet mask validator added.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-07-11 11:41:38 +01:00
Mihaela Stoica
eeb86b7956 CA-139588: Try to prevent Index was out of range exception by invoking on the event thread
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-09 14:55:19 +01:00
Mihaela Stoica
8e19193a2a CA-137470: Fixed unhandled exception raised by pressing space key on gridview of License Manager.
- Added a 'refresh grid' parameter to UpdateRow() which indicates if a sort and refresh of the grid is necessary.
- A sort and refresh is not needed when the user selects a server by pressing the space key or by mouse, but it is needed when the information displayed has changed, for example when the license has changed.
- Also solved a possible null reference exception in CheckableDataGridViewController.ReplaceStoredRow(), by returning -1 if the index is not within the rows range.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-04 11:10:46 +01:00
Mihaela Stoica
b8531be374 CP-8120 Rolling Pool Upgrade wizard: add precheck for vCPU configuration.
- Renamed “Checking can evacuate host status” precheck group to “Checking VM migration status”
- Prechecks page – check that all VMs have valid vCPU settings (i.e. number of vCPUs is a multiple of number of cores per socket).
- This check is included in the ‘Checking VM migration status” group
- If a VM has invalid vCPU settings, the precheck will display the problem with a solution to “Fix vCPU configuration” which opens the VM Properties dialog on the CPU page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-06 13:50:13 +01:00
Gabor Apati-Nagy
12d1a53c44 Merge pull request #46 from Zhengchai/cp-7527
CP-7527: Restore WLB for Creedence XenCenter changes.
2014-04-30 13:25:39 +01:00
zheng chai
e10125fbce CP-7527: Restore WLB for Creedence XenCenter changes.
Signed-off-by: zheng chai <zheng.chai@citrix.com>
2014-04-22 19:14:53 +08:00
Stephen Turner
75bb8fa8f0 [CA-115256] Add null check as suggested by code review 2014-04-16 09:13:20 +01:00
Stephen Turner
75464110de Improvement to check-in for [CA-115256]: remove unused dependency 2014-04-15 17:49:03 +01:00
Stephen Turner
5d722be866 Improvement to check-in for [CA-115256]: move logic out of the display into the LicenseRow 2014-04-15 17:46:56 +01:00
Stephen Turner
afbfbaf803 [CA-115256] Don't show the Buy Licenses link for pre-Clearwater servers 2014-04-15 17:07:21 +01:00
Konstantina Chremmou
f0cf20ec43 CA-127510: Reworked the logic of differentiating between tasks started by this instance
of XenCenter and tasks started from outside and cancelling the former when exiting
or disconnecting from the pool.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-03-11 14:30:01 +00:00
Konstantina Chremmou
d26bbaf8da CA-95786: Corrections to previous commit - show both the marketing name and the version on XenCenter's About box.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-02-18 17:38:11 +00:00
Konstantina Chremmou
de2ad77970 CA-95786: Show product microversion in XenCenter's About box (taken from XenServer
unless manually overridden in XenCenter). Renamed field.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-02-18 14:53:00 +00:00
Konstantina Chremmou
f5bee7102c Refactored MainWindow to derive from IMainWindow rather than implement a field deriving
from this interface.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-01-22 12:39:32 +00:00
Konstantina Chremmou
6e4c39ac96 CA-123576: Also reconstruct the plugin menu items when a plugin is enabled/disabled.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-01-02 09:10:57 +00:00
Konstantina Chremmou
b3fc67a4d8 CA-123576: Step 1 - stop toggling the enabled state of the Windows menu item when non-modal forms are launched.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-12-30 14:47:01 +00:00
Konstantina Chremmou
a5c89e429b CA-85971: Removed method selecting control in tab by name. Retained ability only for the Name, Description and Iqn TexBox on the GeneralEditPage; in one of the other cases it didn't make a difference, in another (LogDestinationEditPage) it was causing a bug and in yet another (BootOptionsEditPage) the controls had already been renamed. Also some positioning changes.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-12-30 13:01:00 +00:00
Konstantina Chremmou
3b25591d71 CA-85971: Removed method selecting tab by name. Made all pages of VerticallyTabbedDialog private.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-12-22 17:17:04 +00:00
Konstantina Chremmou
d335372575 CA-85971: Removed method selecting tab by index.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-12-22 15:28:00 +00:00
Konstantina Chremmou
c411df3426 Converted British spelling to American.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-12-13 13:51:16 +00:00
Konstantina Chremmou
1c3ecc281b CA-122834 Don't show GPU tab for non-vGPU servers
Also GPU page on Pool properties dialogs should not be shown for non vGPU pools.
# HG changeset patch
# User Mihaela Stoica <Mihaela.Stoica@citrix.com>
# Date 1385743406 0
#      Fri Nov 29 16:43:26 2013 +0000
# Node ID e28f9921a0a17efb1e3a8d185acf18b5b6e116b1
# Parent  59229250db34dd4cc1f34fbdab055467a1570f87

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-12-11 10:45:28 +00:00
Konstantina Chremmou
5d04edae99 CP-6093: The Window menu item on the top MainWindow menu should be disabled when
no forms are open. Since there is no event notifying about the Application.OpenForms
changing, created a new base class for all XenCenter dialogs and wizards with a
static event to which the main windw can subscribe.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-23 16:03:21 +00:00
Konstantina Chremmou
649f86bc1d Unregister registered CollectionChanged event on disposal.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-23 12:01:54 +00:00
Konstantina Chremmou
22ec1d9ac5 CP-6093: Redesign of the CloseXenCenterWarningDialog to use the same controls as
the events page. This renders the old custom history controls obsolete, hence
removed them. Moved ActionBase extension methods to XenAdmin.Core namespace.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-23 11:59:49 +00:00
Konstantina Chremmou
0d7c6eb5f4 CP-6215: Do not allow HA for vGPU VMs.
# HG changeset patch
# User Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
# Date 1384333341 0
#      Wed Nov 13 09:02:21 2013 +0000
# Node ID 8f10c3e041ebb2295f0692fcc6d733e7654906d0
# Parent  2f55fef6f39ab916f2ab8604926621aeb6dfc41c

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-14 12:38:00 +00:00
Konstantina Chremmou
402e2458ce CP-6382: Added GPU page to the Pool properties dialog (PR-1675)
# HG changeset patch
# User Mihaela Stoica <Mihaela.Stoica@citrix.com>
# Date 1381486465 -3600
#      Fri Oct 11 11:14:25 2013 +0100
# Node ID ae162fb56bac4f1c2f7cc4c47b640a6933ea6deb
# Parent  48644db7dcf80d93efb9d6e86e982b95894cbd9d

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-14 10:35:48 +00:00
Gabor Apati-Nagy
cb572c86dc [CP-4950]: CAR-100: Report whether running in 32- or 64-bit mode 2013-11-13 17:56:23 +00:00
Konstantina Chremmou
99abced1fb Merge branch 'master' of git://hg.uk.xensource.com/carbon/trunk/xenadmin 2013-11-01 09:32:21 +00:00
Konstantina Chremmou
3fd296fbec CA-105791: Step 3 - Changed the action links colour and added underlining. I did
this by susbstituting the FlickerFreeListBox with a DataGridView, which also fixes
the selection bug, plus we don't have to do custom drawing or costly string
measurements. This change will also aid the fix of CA-20870.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-01 09:27:28 +00:00
Konstantina Chremmou
d50181638f CA-105791: Step 2 - Removed virtual member call from constructor. Populate VMs
list when the dialog is shown rather than constructed. Somc code tidy.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-01 09:27:19 +00:00
Konstantina Chremmou
a64cf267e6 CA-105791: Step 1 - Move the event handlers of the actions run from the base class
DialogWithProgress to the derived classes EvacuateHostDialog and RepairSRDialog;
leave in the base class only the code updating the common controls.
2013-11-01 09:27:08 +00:00
Gabor Apati-Nagy
97bba30f0a [CA-107921] Fixed: "Connect to Server" windows is displayed continuously with message "Synchronizing with <Host name> " even though server is connected. 2013-10-28 11:04:41 +00:00
Konstantina Chremmou
fd284e57af CP-6093: Removed mentions of the logs tab and the updates manager from XenCenter.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-10-08 14:51:39 +01:00
Konstantina Chremmou
64e14bbc63 CP-6267: Stop jumping to the Events window when an action has started.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-10-08 11:03:29 +01:00
Konstantina Chremmou
165ceaaefe CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User vetrivelc <vetrivel.chinnasamy@citrix.com>
# Date 1378451961 -19800
# Node ID cb7aab1ca88e76ca253a588935fad659ae794600
# Parent  1259116a56bc4aca1ea23612066e5f7257e6c1d0
Reverted the row span value change in VMProtectionPoliciesDialog.zh-CN.resx file.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 14:49:45 +01:00
Konstantina Chremmou
122f29da73 CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User vetrivelc <vetrivel.chinnasamy@citrix.com>
# Date 1378449941 -19800
# Node ID 1259116a56bc4aca1ea23612066e5f7257e6c1d0
# Parent  27b9287295ba345825b17de509397e79bbb61962
Fix: CA-112233

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 14:49:18 +01:00
Konstantina Chremmou
853f9841fc CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User vetrivelc <vetrivel.chinnasamy@citrix.com>
# Date 1378365378 -19800
# Node ID b9b474904f50fa662b81340026322a863050dff1
# Parent  84e0784265b85b45b7052739c814204225d845fa
Fix: CA-114381

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 14:48:16 +01:00
Konstantina Chremmou
8b65117322 CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User vetrivelc <vetrivel.chinnasamy@citrix.com>
# Date 1378311085 -19800
# Node ID 84e0784265b85b45b7052739c814204225d845fa
# Parent  24332b319e417873881b4e262e9ffa01687ea1dc
Bug Fix:CA-111776

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 14:47:03 +01:00
Konstantina Chremmou
1a90ae5c90 CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User vetrivelc <vetrivel.chinnasamy@citrix.com>
# Date 1378298988 -19800
# Node ID 24332b319e417873881b4e262e9ffa01687ea1dc
# Parent  28eb1719f7f648773bd707c3cb81bb537d8f78d8
Fix:CA-114532,CA-114330

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 14:46:38 +01:00
Konstantina Chremmou
706d158c42 CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
# Date 1378122578 -3600
# Node ID 28eb1719f7f648773bd707c3cb81bb537d8f78d8
# Parent  931d568b9b0f00809b9acbe31462423dfaf8a8d4
CA-113230: Improvements of previous fix.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 14:46:04 +01:00
Konstantina Chremmou
1905077b29 CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User vetrivelc <vetrivel.chinnasamy@citrix.com>
# Date 1377611382 -19800
# Node ID 48b8a4b6552228aeda9558d89249b5a30d0f7c9e
# Parent  b7339ed67dfc5a8cfba84c6fc2bc9f1c15a14317
Bug Fix:CA-114206,CA-114480,CA-114330,CA-112444

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 14:44:14 +01:00
Konstantina Chremmou
82b8c9b2c7 CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User vetrivelc <vetrivel.chinnasamy@citrix.com>
# Date 1377176239 -19800
# Node ID 7a067ac0c37be286f06c3091379b33f668d31c62
# Parent  efafac7f89d00524a5787a5a227a4aecec0b34cf
Bug Fix:CA-114326,CA-114330.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 14:42:25 +01:00
Konstantina Chremmou
3260c375f2 CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User vetrivelc <vetrivel.chinnasamy@citrix.com>
# Date 1377167722 -19800
# Node ID efafac7f89d00524a5787a5a227a4aecec0b34cf
# Parent  583abe3dc86764b07314ae86d4feb48a89c6a7e1
Bug Fix:CA-114276,CA-114332,CA-114330,CA-114266.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 14:41:59 +01:00
Konstantina Chremmou
864eeb48ee CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User vetrivelc <vetrivel.chinnasamy@citrix.com>
# Date 1377071789 -19800
# Node ID 5bd4ebbd0553c160917192dd4546bb19a2a5a64d
# Parent  e305aa4ddfecb3337cffb43bc711d9b580c79e1f
Bug Fix:CA-114276,CA-114264

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 14:40:02 +01:00