- Converted them to proper AsyncActions to facilitate further refactoring.
- Moved SaveCustomFieldsAction to the same folder as the above.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
- Bumped branding to v4.11.
- Reverted VS version in the solution file.
- Removed brand override registry entry.
- Converted HealthCheck warning pop-up to info pop-up.
- Moved status report actions to a separate folder.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Remove credentials controls from `BugToolPageDestination`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* Explicitly call dispose in `BugToolPageDestination.cs`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* Tidy up code in `BugToolPageDestination.cs`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* Move `StatusReportRow` to its own file
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* Move `ClientSideDataRow` and `HostStatusRow` to own files
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Update order of pages in `BugToolWizard`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Update action and create row for packaging status report in BugTool wizard
Instead of creating a new action, this males ZipStatusReportAction inherit StatusReportAction
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Allow for pending `StatusReportAction` to be cancelled
This avoids the need for a running action to update the status. i.e. an action that has been registered but hasn't started running can be cancelled, too.
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Update content of `ACTION_SYSTEM_STATUS_SUCCESSFUL` message
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Add link to `labelBlurb` in `BugToolPageRetrieveData.cs`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Add report packaging logic to `BugToolPageRetrieveData.cs`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Open CIS URL when clicking on `linkLabelBlurb`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Report packaged data amount in `ZipStatusReportAction`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* Remove unused `using`s
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* Minor layout tweaks.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Renamed folder and namespace to match the ones for the other wizards.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Renamed wizard's private fields. Some code efficiency corrections.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Keep the row classes as private within the BugToolPageRetrieveData class.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Removed leftover unused action.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Tidy up status report messages. Use more relevant icon.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Made blurb localisable.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Renamed private fields.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Simplified the stages of the compilation of the status report.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Renamed row classes again to match the action names.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Simplify reporting the progress of the zipping action.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Recursive call is not necessary. Tweaked message.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* Sort strings
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* Update copyright notices
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
---------
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Co-authored-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, renamed the placeholder because msbuild converts spaces to underscores
and in debug mode the settings path is different from the one expected.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
- Corrections to the layout of the LegalNoticesDialog and the AboutDialog.
- Dispose the LegaNoticesDialog when the AboutDialog is closed.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Also renamed the archive classes because they were named after the 3rd
party library used and were confusing.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
The scans run in parallel in batches of three to avoid flooding the session.
Also, prevent firing the SelectedIndexChanged event multiple times when populating the NewDisk dialog.
Renamed the SrPicker control on the latter (because SrListBox is a different type of control).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CA-359965: Consider `physical_utilisation` value when checking for free space in thinly provisioned SRs
* CA-359965: Fix miscellaneous formatting issues
* Made SrPickerItem show the SR by default. Removed virtual method that was never overriden.
* Use slightly more intuitive name for property; also inverted its logic.
* Renamed VdiCreationCanProceed to the more specific CanFitDisks since it only deals with sizes.
* Re-arranged classes in file.
* Refactored SrPickerItem:
- Merged CanBeEnabled and DisabledReason properties to method CanBeEnabled(out disabledREason)
to avoid running the same checks twice.
- Pass the disk instead of the size into extension method SR.CanFitDisks
so that the correct size can be used for each storage (thin vs. non-thin provision).
* Correction as per code review and some tweaks to make the checks clearer and more efficient.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
The new name complies with C# conventions and allows distinguishing it from xapi field names.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, some corrections to the template comparer on the NewVM wizard's Template page.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also:
- Use new date format for logs
- Specify option parameter names
- Do not show timestamp for host name log
- Do not show timestamp for null/whitespace only lines
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
