Commit Graph

30 Commits

Author SHA1 Message Date
Danilo Del Busso
23391e7293
Improve variable naming in RdpClient.cs
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-27 13:43:29 +01:00
Danilo Del Busso
9ea0a53447
Catch HRESULT E_FAIL exceptions for IRDPClient.Connect calls
The `Connect` method returns `E_FAIL` if it is called while the control is already connected or in the connecting state. This can be hit when a lot of connections are being opened at the same time, and it's there as a failsafe.

Also adds `IsAttemptingConnection` as a new field

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:47:02 +01:00
Konstantina Chremmou
d7b519a53c Updated copyright notice on files.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-30 16:24:16 +00:00
Konstantina Chremmou
07f2de6786 Use C# naming conventions. Removed some code redundancies.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-12 10:32:57 +01:00
Danilo Del Busso
157fe77f8f
CP-36392: Add comment to ignored catch blocks
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CP-36392: Add missing comments to ignored catch blocks

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-09-20 09:35:17 +01:00
Konstantina Chremmou
abf4ae3f35 CP-36392 pt.1: Removed unused using directives.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-07 10:04:47 +01:00
Konstantina Chremmou
90e6cb0dc9 Memory leak when disposing of the RdpControl.
The rdpControl was set to null too soon and by the time the timer ticked it had
no chance to be disposed of at all. Also, the timer itself was not disposed of.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-01-06 11:28:32 +00:00
Konstantina Chremmou
99572da0fb Corrections to the logging of Win32 exceptions. Minor refactoring.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
968701cf8e Removed property MenuShortcuts in favour of MenuShortcutsEnabled.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
fb8434819d Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-11-30 13:56:32 +00:00
Gabor Apati-Nagy
5b2ef0e7eb CA-271775: Showing an info message if XC falls back to an earlier RDP version
Eg. Windows 7 users (pre-updates)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-11-13 16:51:56 +00:00
Gabor Apati-Nagy
74cf3d03b3 Revert "CA-247333 - Remove rdpclient6 code after April 2017 when it will become redundant"
This reverts commit 5e458ac234.
2017-11-06 11:28:07 +00:00
Letsibogo Ramadi
b437b530a5 Revert "CA-247333 - Remove rdpclient6 code after April 2017 when it will become redundant"
This reverts commit cca0ab5d89.
2017-11-06 11:27:49 +00:00
Letsibogo Ramadi
cca0ab5d89 CA-247333 - Remove rdpclient6 code after April 2017 when it will become redundant
-Removed rdpControl because it is always identical to rdpClient9
-Renamed rdpClient9 to just rdpClient because we use only one
client so there is no need to distinguish, and it can easily be updated
to future versions.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-20 11:33:52 +01:00
Letsibogo Ramadi
5e458ac234 CA-247333 - Remove rdpclient6 code after April 2017 when it will become redundant 2017-06-14 17:22:42 +01:00
Anoob Soman
a0c34c28bf CP-21130: Extend KeyEvent to supply translated key symbol
QEMU EXT_KEY_EVENT expects key symbol and key scan code to
be sent. This commit extends KeyEvent to supply translated key symbol,
as well as scan code.

Signed-off-by: Anoob Soman <anoob.soman@citrix.com>
2017-05-02 17:16:23 +01:00
Letsibogo Ramadi
91a6b6dcf8 Merge pull request #1547 from letsboogey/master
CA-249856 - XenCenter Keyboard shortcuts not working properly on VM c…
2017-04-25 15:55:51 +01:00
Mihaela Stoica
42df02734a CA-249856: Fix console position and focus rectangle drawing on resize
Also ensuring that if the UpdateSessionDisplaySettings function (which we use for resize) is not supported, then we display the console centered in the parent window and with scrollbars if needed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-04-25 14:07:29 +01:00
Letsibogo Ramadi
3ea6d56983 CA-249856 - XenCenter Keyboard shortcuts not working properly on VM console when remote desktop mode 2017-04-24 15:52:56 +01:00
Letsibogo Ramadi
0381de85a4 CA-249627 - NPE while accessing XenCenter console on a RDP established & then disconnected guest VM 2017-04-07 11:41:59 +01:00
Letsibogo Ramadi
27918a1c02 CP-20881 - Implement RDP console resize when toggling the full screen mode
In addition to ticket requirements, the console size is updated when the console is:
- resized in undocked mode
- resized manually by dragging window edges
- resized by dragging the panel splitter

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-03-01 17:48:42 +00:00
Letsibogo Ramadi
8d2cbfc87c CP-20727 - Use new version of the rdpclient 2017-02-27 17:24:25 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Mihaela Stoica
05880fdaa2 RDP client control: Changed Connected property type to boolean.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-12 15:06:09 +01:00
Mihaela Stoica
8aadc063d4 CA-137236: Fix XenCenter Console crash when switching to remote desktop on Windows Server 2003 SP2
- Reverted "CP-4951: CAR-100: Remove Rdp2 console" because Rdpclient 6.0 is not included in Windows Server 2003 SP2;
- Redone the fix for CA-123779 (Unhandled exception in Console Tab View), by moving RDPSetSettings() call inside a try..catch block, so we handle any exception thrown while setting the rdp client properties.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-10 17:12:16 +01:00
Mihaela Stoica
8626a6e854 CA-123779: Fixed unhandled exception in Console Tab View.
Moved RDPSetSettings inside try..catch block, so we handle any exception thrown while setting the rdp client properties.
Also did some refactoring, removing redundant variable rdpClient6.
2014-01-21 16:39:23 +00:00
Gabor Apati-Nagy
5764b2a1c9 CP-4951: CAR-100: Remove Rdp2 console
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2013-11-26 13:55:54 +00:00
Gabor Apati-Nagy
c344e74b95 Revert "CP-4951: CAR-100: Remove Rdp2 console"
This reverts commit df9345d2c4.
2013-11-26 11:19:34 +00:00
Gabor Apati-Nagy
df9345d2c4 CP-4951: CAR-100: Remove Rdp2 console
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2013-11-25 18:28:57 +00:00
Mihaela Stoica
bd36a85bff CP-4816: Initial commit to git repo
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-06-24 12:41:48 +01:00