Commit Graph

7179 Commits

Author SHA1 Message Date
Danilo Del Busso
23482a6be1
CA-380545: Do not use RemoveFolder for Desktop folder
It's meant to delete empty folders on uninstall but it's not applicable in this case, and caused issued if users don't have the correct rights.

Also rename the IDs to better match content

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-25 11:32:43 +01:00
Danilo Del Busso
675775cb01
CA-380355: Ensure shortcut is only created if user selects option in installer
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-25 08:30:10 +01:00
Konstantina Chremmou
fcc51a0c2d CP-43264: Handle new alert for CSS agreement expiry. Also:
For alerts that have an action link show this before the dismiss item.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-24 21:21:48 +01:00
Konstantina Chremmou
291199182e Minor refactoring.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-24 21:21:48 +01:00
Konstantina Chremmou
2c3e4fd140 Sorted the fields and properties and added members for Repositories.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-24 21:21:48 +01:00
Danilo Del Busso
461b6c97b5
CP-43000: Fix Post82X call in Host extension
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-24 15:52:21 +01:00
Danilo Del Busso
382785e3f1
CP-43000: Sort strings in InvisibleMessages
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-19 16:03:51 +01:00
Danilo Del Busso
6fa8cfa10b
CP-43000: Update link and text shown in the hosts' general tabs
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-19 15:55:37 +01:00
Danilo Del Busso
75faf093a9
CP-43000: Rename IsummaryPanelView to ISummaryPanelView
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-19 15:54:25 +01:00
Danilo Del Busso
b7a9716bb8
CP-43000: Show both support and license statuses in License Manager
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-19 15:54:22 +01:00
Danilo Del Busso
184bf9831a
CP-43000: Separate support and license warnings in License Manager
Contains placeholder values

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-19 15:54:19 +01:00
Konstantina Chremmou
a422eb9986
CP-43000: Moved the Buy Licenses link to a different column.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-19 15:54:16 +01:00
Konstantina Chremmou
f9198e477d
Added option for three columns on the GeneralTabPage panels. Refactored methods adding entries.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-19 15:54:13 +01:00
Konstantina Chremmou
1e89de1c7c
Layout tweaks.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-19 15:54:11 +01:00
Danilo Del Busso
83139d938e
Fix license date format definition string
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-19 15:54:08 +01:00
Danilo Del Busso
cd920531c8
Apply code review suggestions
- Use `Nullable.HasValue` and `Nullable.Value` to handle `DateTime?` type returned by `LicenseCssExpiry`
- Check UTC time when checking CSS license expiry

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-19 15:54:06 +01:00
Danilo Del Busso
b8a3a7cdeb
CP-43000: Add trial edition and CSS expiry warnings to GeneralTabPage
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-19 15:54:04 +01:00
Danilo Del Busso
ceaa9abd66
CP-43000: Add trial edition and CSS expiry warnings to LicenseManager
Also:
- Increase size of `LicenseManager` to accommodate larger text
- Add upsell URL to existing warning for pool size restrictions

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-19 15:54:01 +01:00
Danilo Del Busso
a086ac30ed
CP-43000: Add new license purchase URL to InvisibleMessages
Also merge duplicate strings into unique `LICENSE_BUY_URL` string

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-19 15:53:57 +01:00
Danilo Del Busso
066a59a0b4
CP-43000: Add friendly name for trial edition
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-19 15:53:54 +01:00
Danilo Del Busso
3bf6a88f9c
CP-43000: Add Host extension methods to check if upselling messages are needed
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-19 15:53:52 +01:00
Konstantina Chremmou
c439f3de41
Merge pull request #3175 from xenserver/feature/merge
Merge branch 'feature/merge' -> master
2023-07-19 15:32:22 +01:00
Konstantina Chremmou
1d21ceef93 Bumped pipeline version to v4.8.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-19 15:32:06 +01:00
Danilo Del Busso
d3a811d566 CA-378758: Ensure all hosts in pool hit HOST_NOT_ENOUGH_FREE_MEMORY before preventing migration
If pool any of the hosts in a pool hit the `HOST_NOT_ENOUGH_FREE_MEMORY` when calling `VM.assert_can_migrate`, XenCenter would prevent migration even if other hosts had enough memory to accommodate the VM.

Likely a result of the fact that other `VM.assert_can_migrate` failures are a consequence of pool-wide configurations. This is an exception.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-19 13:42:15 +01:00
Konstantina Chremmou
aa6703cc5f Bumped branding to v4.17.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-19 12:29:33 +01:00
Konstantina Chremmou
693286425f Corrections following the merge from master.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-12 16:35:21 +01:00
Konstantina Chremmou
9950996db2
Merge pull request #3171 from xenserver/master
Merge master into feature/merge
2023-07-12 10:19:07 +01:00
Konstantina Chremmou
387d030a4f Updated SDK to v23.15.0. Updated code as this drop deprecates certain Session constructors.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-12 09:56:06 +01:00
Konstantina Chremmou
00246d7429 Disallow connection to havana servers.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-12 09:55:42 +01:00
Danilo Del Busso
60a5580d20
Dispose of timer when creating new port polling Timer
This avoids having too many timers running at the same time.

One could for instance update the `EnableRDPPolling` property from the `Options` dialog and start several concurrent `Timer`s

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-12 09:22:00 +01:00
Konstantina Chremmou
00668e8d53
Merge pull request #3166 from kc284/wlb_images
CP-43770: Removed images from the WLB credentials dialog (plus some refactoring and layout tweaks)
2023-07-11 11:36:09 +01:00
Danilo Del Busso
84e294b4b7
Tidy up XSVNCScreen: fix whitespace
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:54:14 +01:00
Danilo Del Busso
559843f549
Tidy up XSVNCScreen: use explicit modifiers
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:54:13 +01:00
Danilo Del Busso
9618c11ba5
Tidy up XSVNCScreen: fix typos
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:54:13 +01:00
Danilo Del Busso
baea368447
Tidy up XSVNCScreen: fix missing uses of null propagation
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:54:12 +01:00
Danilo Del Busso
85414de2c2
Tidy up XSVNCScreen: Fix naming in file
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:54:11 +01:00
Danilo Del Busso
133cd456c6
Tidy up XSVNCScreen: use null propagation and conditional access
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:54:10 +01:00
Danilo Del Busso
4cfb129f6d
Tidy up XSVNCScreen: fix typo
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:54:10 +01:00
Danilo Del Busso
d28ec66a2b
Tidy up XSVNCScreen: remove cast with pattern variable
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:54:10 +01:00
Danilo Del Busso
56274d7298
Tidy up XSVNCScreen: merge conditional expression
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:54:09 +01:00
Danilo Del Busso
a55cc8ea7a
Tidy up XSVNCScreen: remove redundant type arguments
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:54:09 +01:00
Danilo Del Busso
d0e63e7bd7
Tidy up XSVNCScreen: remove redundant explicit delegate creation
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:54:08 +01:00
Danilo Del Busso
a79eaa0bcc
Tidy up XSVNCScreen: use var when possible
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:54:08 +01:00
Danilo Del Busso
67dd31fc44
Tidy up XSVNCScreen: remove redundant base() call
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:54:07 +01:00
Danilo Del Busso
2287672e44
Tidy up XSVNCScreen: use expression-bodied properties
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:54:07 +01:00
Danilo Del Busso
bcb3fdc00a
Tidy up XSVNCScreen: use built-in type references
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:54:06 +01:00
Danilo Del Busso
5ba0a42bd5
Tidy up XSVNCScreen: remove redundant initializers
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:54:06 +01:00
Danilo Del Busso
53fba195a7
Tidy up XSVNCScreen: remove this when unnecessary
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:54:06 +01:00
Danilo Del Busso
b8eb2b5549
CA-379640: Do not reset remote consoles if they're still attempting connection to a VM
This prevents `AccessViolationException`s being called, as they're hit when two instances of `AxMSTSCLib.AxMsRdpClient9` call `Connect` on the same IP + Port combination, which results in the same memory being accessed in unmanaged code.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:54:05 +01:00
Danilo Del Busso
9ea0a53447
Catch HRESULT E_FAIL exceptions for IRDPClient.Connect calls
The `Connect` method returns `E_FAIL` if it is called while the control is already connected or in the connecting state. This can be hit when a lot of connections are being opened at the same time, and it's there as a failsafe.

Also adds `IsAttemptingConnection` as a new field

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-11 10:47:02 +01:00