Commit Graph

31 Commits

Author SHA1 Message Date
CitrixChris
8281ae5c05
CA-359809 improved illegal character message (#2898)
* CA-359809 improved illegal character message

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 cleared whitespace, improve code readability

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 implemented reviewer comments.

Moved Path validator to XenModel Project where other language files have already been set up.
Improved error messages.

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 improved string localisation, Code tidy

Cannot became can not, messages file alphabetised, improved readability with using xenmodel as opposed to direct call

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 changed can not to cannot

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2021-11-22 12:02:26 +00:00
Konstantina Chremmou
67d1ddd1d1 Merge remote-tracking branch 'upstream/master' into feature/hyperman
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/Branding.resx
#	Jenkinsfile
#	XenAdmin/Alerts/Types/GuiOldAlert.cs
#	XenAdmin/Alerts/Types/LicenseAlert.cs
#	XenAdmin/Commands/RestartToolstackCommand.cs
#	XenAdmin/Diagnostics/Problems/HostProblem/HostNotSafeToUpgradeWarning.cs
#	XenAdmin/Dialogs/AllowUpdatesDialog.cs
#	XenAdmin/Dialogs/OptionsPages/ConfirmationOptionsPage.cs
#	XenAdmin/Dialogs/RepairSRDialog.cs
#	XenAdmin/Dialogs/UpsellDialog.cs
#	XenAdmin/Plugins/UI/TabPageCredentialsDialog.cs
#	XenAdmin/Program.cs
#	XenAdmin/Wizards/ConversionWizard/ConversionNetworkPage.cs
#	XenAdmin/Wizards/CrossPoolMigrateWizard/CrossPoolMigrateDestinationPage.cs
#	XenAdmin/Wizards/NewSRWizard_Pages/SrWizardType.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_FirstPage.cs
#	XenCenterLib/XSVersionAttribute.cs
#	XenModel/BrandManager.cs
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx
2021-05-25 15:51:42 +01:00
Konstantina Chremmou
abf4ae3f35 CP-36392 pt.1: Removed unused using directives.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-07 10:04:47 +01:00
Konstantina Chremmou
a0e2967792 CP-31105: Replaced the hardcoded name patterns in the resource files with format placeholders.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-31 11:50:32 +01:00
Mihaela Stoica
a5d7bdc0ec CA-352678: Diagnostic token is not needed for uploads to CIS from the SSR wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2021-03-17 15:30:59 +00:00
Konstantina Chremmou
60da6080f9
Refactored three button dialog (#2627)
* ThreeButtonDialog simplification step1: Help name.
* ThreeButtonDialog simplification step2: Window title.
* ThreeButtonDialog simplification step3: Removed class Details.
* ThreeButtonDialog simplification step4: Removed unnecessary (and wrong) class.
* ThreeButtonDialog simplification step5: Compacted TDButton constructors.
* ThreeButtonDialog simplification step6: Removed purposeless methods.
* ThreeButtonDialog simplification step7: Refactored constructor logic.
* ThreeButtonDialog simplification step8: Icon normalisation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-22 14:47:03 +01:00
Konstantina Chremmou
ceccfcbe79 CA-325439: Pre-populate download locations. Validation corrections on the server status report wizard.
- Moved path validation checks from the wizard to its last page (planning
to remove XenWizardBase.FinishCancelled in future).
- If the directory did not exist, the user saw a message about inability
to write a file which was misleading. Check directory existence explicitly.
- Populate the last wizard page on load rather than on construction to
avoid unnecessary validations.
- Save in the settings the report output directory, not the filename.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-19 14:06:28 +01:00
Konstantina Chremmou
ee648135f6 Since it is easy to forget calling the base class method at the beginning of the
PageLoaded override in derived classes, enforce it by wrapping the page specific
code in a new virtual method, which the derived classes can override and PageLoaded
can call after its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
7a1b1a6dcc Since it is easy to forget calling the base class method at the end of the PageLeave
override in derived classes, enforce it by wrapping the page specific code in
a new virtual method, which the derived classes can override and PageLeave can
call before its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
fb8434819d Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-11-30 13:56:32 +00:00
Letsibogo Ramadi
10bb65d2f2 CA-236150 - Funny label on status report wizard
Changed label to a LinkLabel instead of RichTextBox. Also fixed similar bug on the healthcheck enrollment dialog.
2017-02-15 13:51:19 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Mihaela Stoica
0115461f66 CA-216752: Not all wizards progress through to the next page by pressing the Enter key
- Added SelectDefaultControl() to more wizard pages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-21 13:33:04 +00:00
Konstantina Chremmou
b9b00ca4cd CA-149814: Added short description to fill in the redundant space on the top of the
FolderBrowser dialogs. Fixed text which caused label to look unaligned. Prevent
crash when attempting to launch the DownloadAppliance dialog with "http://" as URI.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-22 08:31:58 +01:00
Mihaela Stoica
da9e99b1cb CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix ActionProgressDialog usages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 13:17:42 +01:00
Mihaela Stoica
fc5ebd2d40 CP-15401: Move HiddenFeatures to a new class
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-01-28 21:43:15 +00:00
Cheng Zhang
6b2490dea7 CP-15401: Hide upload option by reg key
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-25 16:23:31 +08:00
Rob Hoes
a887faa5f1 –CA-186237: Add link to citrix.com to SSR wizard
Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
2016-01-20 12:03:18 +00:00
Mihaela Stoica
01f5081511 CA-180576: Provide a option to give case number when uploading a report
- rearranged the controls (removed group box, indented upload-related controls)
- also changed the progress bar style for the upload action to Marquee, as the Blocks style did not show any progress and it looked like the upload hasn't started

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-11-24 10:44:55 +00:00
Gabor Apati-Nagy
ffaced4b86 Merge pull request #724 from MihaelaStoica/CA-186232
CA-186232: Fix the "Test credentials" button in the Health Check dialog
2015-11-04 20:00:21 +00:00
Mihaela Stoica
02b4a8fbb7 CA-186232: Trim the username before using it
- Add Trim() to the instances where we check if the username is null or empty and also where we use it for authentication
- This applies to both XenServer username and Citrix username

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-11-04 12:06:52 +00:00
Mihaela Stoica
af7852c7a0 CA-180576: Provide a option to give case number when uploading a report from the Server Status Report wizard
- added Case Number edit box on the Destination page of the wizard
- valid case number needs to be 9 or less digits

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-11-03 15:48:14 +00:00
Mihaela Stoica
53b01c425c CP-13077: Changes to the Health Check feature to work properly with RBAC
Changed all the health check actions to perform the necessary role checks
- HealthCheckAuthenticationAction: changed so it does not save the tokens, so no role checks required in this action (all the checks are performed in SaveHealthCheckSettingsAction)
- GetHealthCheckAnalysisActions: added role checks

On the Health Check Overview dialog, a pool is displayed as read-only if connected as a user with roles that don't permit changing the health check settings:
- the following actions are not available: enroll, edit settings, disable health check, request upload, get analysis result
2015-09-03 11:49:53 +01:00
Mihaela Stoica
44e18df03d CP-12156: Obtain and display the result of the CIS analysis of the last uploaded report
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-08-27 00:30:02 +01:00
Mihaela Stoica
998c037bd3 CP-12679: Upload the report from the Server Status Report wizard
- fix the error when the upload is attempted even if the checkbox is not ticked
2015-08-20 13:20:35 +01:00
Mihaela Stoica
a9be9846ff CP-13073: Rename Call Home to Health Check in code
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-07-29 08:44:41 +01:00
Mihaela Stoica
8480bb63bf CP-12679: Upload the report from the Server Status Report wizard
- show action progress dialog for the authentication action

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-07-20 15:15:46 +01:00
Mihaela Stoica
96f9b9c6ac CP-12679: Upload the report from the Server Status Report wizard
- make pre product key (used for authentication) configurable via registry entries

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-07-20 15:15:45 +01:00
Mihaela Stoica
85d67a63a7 CA-12164: Server Status Report wizard: Add option to upload the server status report to CIS
- changes following code review
- renamed some controls.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-06-30 11:53:11 +01:00
Mihaela Stoica
f0e7f5328f CA-12164: Server Status Report wizard: Add option to upload the server status report to CIS
- add the option on the destination page of the wizard
- for authentication purposes, MyCitrix credentials are required.
- these credentials are only used to obtain an upload token that will be used for the upload.
- the upload token expires in 24 hours and is not saved in the xapi database.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-06-25 23:51:11 +01:00
Mihaela Stoica
bd36a85bff CP-4816: Initial commit to git repo
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-06-24 12:41:48 +01:00