Commit Graph

1513 Commits

Author SHA1 Message Date
Konstantina Chremmou
240fa78333 CP-39687: Exporting VMs with vTPMs to XVA package is now supported.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-04-25 13:39:54 +01:00
Konstantina Chremmou
4ead4a8bfe CA-376334: Do not show UEFI secure boot mode if UEFI is disabled.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-04-12 09:54:35 +01:00
Konstantina Chremmou
2c28824594 CA-294901: Reworded (again) so that we don't give the impression that the VMs' affinity will be set.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-04-11 22:15:02 +01:00
Konstantina Chremmou
efce18eff9 CA-376330: If the boot mode radios are invisible do not check them or show the warning if they are disabled.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-04-11 13:26:19 +01:00
Konstantina Chremmou
9d6d1a185d Simplified SrAction by splitting it to four different actions. Fixed RBAC permissions when detaching SR and destroying PBDs.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-04-03 13:55:02 +01:00
Konstantina Chremmou
dfeb347485 Removed integrated storage link code. The feature was removed long ago.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-30 16:38:56 +01:00
Konstantina Chremmou
1b8fd8eb48 CA-375668: Report bytes uncompressed instead of percentage when uncompressing a gzip.
GZipStream does not support Position.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-08 09:51:06 +00:00
Konstantina Chremmou
8cf8e6289a
Merge pull request #3086 from danilo-delbusso/FCoE-CP-41737
CP-41737: Add FCoE deprecation warnings
2023-03-06 15:25:25 +00:00
Konstantina Chremmou
4034a48ee3 Reordered templates on the NewVM wizard:
- Moved Windows Server templates to a different category.
- Show templates in reverse alphabetical (typically release) order.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-06 15:24:41 +00:00
Konstantina Chremmou
5828c03e8d CA-375173: Create the VDI and VBD records before closing the new disk dialog. Also:
Fixed issue where the SR was not preselected when editing an existing disk and no scans were taking place.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 15:36:13 +00:00
Danilo Del Busso
c13ba4082d
CP-41737: Consider upgrade version in PoolHasFCoESrWarning
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-28 08:07:29 +00:00
Danilo Del Busso
727612b68b
Apply code review suggestions
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-28 08:07:28 +00:00
Danilo Del Busso
04e209bd37
CP-41737: Add FCoE SR deprecation warning to New SR wizard
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-28 08:07:28 +00:00
Danilo Del Busso
11328e86b9
CP-41737: Add FCoE SR deprecation warning in RPU wizard
Support for Software FCoE deprecation has been announced in 8.2 CU1

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-28 08:07:27 +00:00
Danilo Del Busso
6cdf37a22c
Tidy up minor code smells in RollingUpgradeWizardPrecheckPage
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-28 08:07:27 +00:00
Danilo Del Busso
af23635a20 CA-375366: Delete ZIP file generated while checking write permissions in BugToolPageDestination.cs
Also contains minor whitespace tidy up

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-24 18:09:52 +00:00
Konstantina Chremmou
f139334ac3 CP-40842: Changed icons for status report rows.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-24 18:09:42 +00:00
Konstantina Chremmou
f885be7e4d
Merge pull request #3094 from xenserver/feature/vtpm
Merge feature/vtpm into master
2023-02-13 15:33:50 +00:00
Danilo Del Busso
6f6bddd755
CP-40842: Remove CIS upload from Server Status Report wizard (#3087)
* Remove credentials controls from `BugToolPageDestination`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Explicitly call dispose in `BugToolPageDestination.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Tidy up code in `BugToolPageDestination.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Move `StatusReportRow` to its own file

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Move `ClientSideDataRow` and `HostStatusRow` to own files

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Update order of pages in `BugToolWizard`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Update action and create row for packaging status report in BugTool wizard

Instead of creating a new action, this males ZipStatusReportAction inherit StatusReportAction

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Allow for pending `StatusReportAction` to be cancelled

This avoids the need for a running action to update the status. i.e. an action that has been registered but hasn't started running can be cancelled, too.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Update content of `ACTION_SYSTEM_STATUS_SUCCESSFUL` message

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Add link to `labelBlurb` in `BugToolPageRetrieveData.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Add report packaging logic to `BugToolPageRetrieveData.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Open CIS URL when clicking on `linkLabelBlurb`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Report packaged data amount in `ZipStatusReportAction`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Remove unused `using`s

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Minor layout tweaks.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed folder and namespace to match the ones for the other wizards.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed wizard's private fields. Some code efficiency corrections.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Keep the row classes as private within the BugToolPageRetrieveData class.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Removed leftover unused action.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Tidy up status report messages. Use more relevant icon.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Made blurb localisable.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed private fields.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Simplified the stages of the compilation of the status report.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed row classes again to match the action names.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Simplify reporting the progress of the zipping action.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Recursive call is not necessary. Tweaked message.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Sort strings

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Update copyright notices

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

---------

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Co-authored-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2023-02-13 13:47:21 +00:00
Konstantina Chremmou
f30afbe1d2 XSI-1362/CA-373773: Reworked the logic for selecting boot mode when creating a VM.
The new logic takes also account of platform:secure-boot=auto.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-31 16:20:13 +00:00
Konstantina Chremmou
d7b519a53c Updated copyright notice on files.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-30 16:24:16 +00:00
Konstantina Chremmou
dcbfe2c8fa Corrected user visible copyright and uses of vendor names.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-30 16:24:16 +00:00
Konstantina Chremmou
6c3dc7b703 CP-41433: Updated some uses of the company name.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-25 12:50:49 +00:00
Konstantina Chremmou
72f411b950 CP-41433: Legacy console name is not applicable any more.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-25 12:50:49 +00:00
Konstantina Chremmou
ca021b95dd CP-41433: Do not rebrand released versions.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-25 12:50:49 +00:00
Konstantina Chremmou
fbe8c60336 Merge remote-tracking branch 'upstream/feature/vtpm'
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

# Conflicts:
#	XenAdmin/MainWindow.cs
#	XenAdmin/Properties/Resources.resx
#	XenModel/Utils/Helpers.Versions.cs
#	XenModel/XenAPI/Pool.cs
2023-01-10 15:17:23 +00:00
Konstantina Chremmou
a29eb998ae
Merge pull request #3065 from kc284/master
CP-41048: Add each SR to the SrPicker as soon as its scan finishes, without waiting for the other scans to finish.
2022-12-05 15:00:01 +00:00
Konstantina Chremmou
421831f312 CP-41048: Do not scan SRs automatically when adding to the SrPicker. Added button to scan on demand.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-12-02 00:55:27 +00:00
Konstantina Chremmou
a77f3c3994 Corrections per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-16 17:36:17 +00:00
Konstantina Chremmou
6644ef920a CP-41108: Replaced the separate splash screen executable with a form within the application executable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-14 09:45:33 +00:00
Danilo Del Busso
ebcef64a24
Merge pull request #3062 from danilo-delbusso/bug/credentials_CA-371356
CA-371356 [XSI-1327]: Add option to prevent resetting pwd prompt function on disconnection
2022-10-28 09:44:13 +01:00
Konstantina Chremmou
de6a4f89c1
Merge pull request #3033 from danilo-delbusso/bug/prevent-host-reset
Prevent host reset when moving between wizard pages using `SelectMultipleVMDestinationPage`
2022-10-27 10:58:54 +01:00
Danilo Del Busso
0b5d259745
CA-371356: Add option to prevent resetting pwd prompt function on connection disconnection
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-10-20 14:26:32 +01:00
Danilo Del Busso
77bd034e8d
CA-359965: Consider physical_utilisation value when checking for free space in thinly provisioned SRs (#3028)
* CA-359965: Consider `physical_utilisation` value when checking for free space in thinly provisioned SRs

* CA-359965: Fix miscellaneous formatting issues

* Made SrPickerItem show the SR by default. Removed virtual method that was never overriden.

* Use slightly more intuitive name for property; also inverted its logic.

* Renamed VdiCreationCanProceed to the more specific CanFitDisks since it only deals with sizes.

* Re-arranged classes in file.

* Refactored SrPickerItem:

- Merged CanBeEnabled and DisabledReason properties to method CanBeEnabled(out disabledREason)
  to avoid running the same checks twice.
- Pass the disk instead of the size into extension method SR.CanFitDisks
  so that the correct size can be used for each storage (thin vs. non-thin provision).

* Correction as per code review and some tweaks to make the checks clearer and more efficient.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-10-11 09:26:54 +01:00
Konstantina Chremmou
940b1580b9 Fixes issue where the Finish page of the NewVM wizard was not showing the selected home server correctly. 2022-10-07 09:19:10 +01:00
Konstantina Chremmou
9f781a5876 CA-370847: Unable to collect status report for multiple servers
Linq.Intersect was failing to combine server capabilities because the helper
class did not implement GetHashCode.
2022-09-26 10:05:01 +01:00
Konstantina Chremmou
74487155fa
Merge pull request #3053 from xenserver/master
Merge master into feature/vtpm
2022-09-16 14:27:56 +01:00
Konstantina Chremmou
71a8fde3c6 Wording and layout modifications for clarity.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-15 16:26:47 +01:00
Konstantina Chremmou
126bf9131c Use the correct xapi tag for vTPM support.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-13 16:35:32 +01:00
Konstantina Chremmou
d7124c9dcc Indentation/whitespace normalization.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
eedcfbe59d CP-40350: Hide vtpm capability if the feature flag is off.
Also, some refactoring and addition of null checks.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
fc5ccf77be Warn the user when exporting VMs with vTPMs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
bbc4ccdd52 Allow vTPM assignment when creating a VM.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
f7d96e21fd UEFI and UEFI secure boot modes are now fully supported, hence remove experimental warning.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
d94c55533c Renamed VM method is_a_real_vm to IsRealVm.
The new name complies with C# conventions and allows distinguishing it from xapi field names.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Danilo Del Busso
4f91b8a7e0
Merge pull request #3036 from danilo-delbusso/improvement/RPU_CP-39929
CP-39929: Improvements on the RPU/Updates wizard
2022-08-22 11:58:30 +00:00
Konstantina Chremmou
476648636b CP-40642: Hide templates with platform["vtpm"]=true
Also, some corrections to the template comparer on the NewVM wizard's Template page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-08-19 17:11:50 +01:00
Danilo Del Busso
60cd8b9f88
CP-39929: Fix incorrect timestamp shown in RPU/Update wizards
Also:
- Use new date format for logs
- Specify option parameter names
- Do not show timestamp for host name log
- Do not show timestamp for null/whitespace only lines

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-08-15 15:57:55 +01:00
Danilo Del Busso
c2dc35359f
CP-39929: Enable MaximizeBox for PatchingWizard
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-08-15 15:47:59 +01:00
Danilo Del Busso
158be06d8d
CP-39929: Remove useless new line after appending error string
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-08-15 13:11:40 +01:00