Commit Graph

3223 Commits

Author SHA1 Message Date
Konstantina Chremmou
68ac5a50e4 CA-33357: FIxed tab order.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-10 15:24:47 +01:00
Gabor Apati-Nagy
0ae3f6e2c4 CA-217862: Unit test fix
to reflect that NULL is expected in this case

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-10 14:01:36 +01:00
Gabor Apati-Nagy
9f7a635da1 Merge remote-tracking branch 'github_xenadmin/REQ-156' into REQ-156
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Core/Updates.cs
2016-08-10 12:50:45 +01:00
Gabor Apati-Nagy
7c78644a86 Merge pull request #1102 from kc284/REQ-156
CA-217847: Fixed issue where servers were marked as unable to be upda…
2016-08-10 11:01:33 +01:00
Gabor Apati-Nagy
f9d8b4dea9 CA-217862: Batch updates: Install dundee released hotfixes in Batch fails when pool slave is not reachable and pool partially upgraded
Partially upgraded pools are not supported. If the versions of servers mismatch in a pool, Automatic updating will be disabled with the appropriate info message.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-10 10:48:22 +01:00
Konstantina Chremmou
12b44cfece Merge pull request #1093 from MihaelaStoica/CA-217388
CA-217388: Hotfix Install wizard shows update as already uploaded whe…
2016-08-10 09:11:37 +01:00
Konstantina Chremmou
5f75c0dd74 CA-217847: Fixed issue where servers were marked as unable to be updated automatically
even when automatic mode was supported for them. The problem was that the xenserver
versions were not retrieved from the DownloadUpdatesXmlAction once the latter had run.
Also, minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-09 16:53:02 +01:00
Konstantina Chremmou
62543bcf26 Merge pull request #1094 from MihaelaStoica/CA-210549
CA-210549: Make MultipleAction and ParallelAction cancellable
2016-08-09 15:13:58 +01:00
Mihaela Stoica
4046ce0f95 Merge pull request #1096 from GaborApatiNagy/master_batch_new2
CA-217382: Batch updates: Install batch updates is not showing low di…
2016-08-09 14:17:48 +01:00
Konstantina Chremmou
208d4aa1f9 Merge pull request #1099 from GaborApatiNagy/CA-217844
CA-217844: Handling Automatic update not supported
2016-08-09 14:05:12 +01:00
Gabor Apati-Nagy
db4e5e6d6b Merge pull request #1097 from kc284/REQ-156
CA-217843 + some other issues on the PatchingWizard_SelectPatchPage
2016-08-09 13:50:18 +01:00
Gabor Apati-Nagy
7289a771fb CA-217844: Handling Automatic update not supported
Fixed tooltip following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-09 13:40:39 +01:00
Konstantina Chremmou
5ccea31130 CA-217846: Removed full stop from tooltip.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-09 12:51:18 +01:00
Konstantina Chremmou
016c39bdaa CA-217843: AS requested per code review, hide originally the controls related to
automatic mode to avoid flickering during page load.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-09 12:45:35 +01:00
Mihaela Stoica
ea52f34d65 Merge pull request #1100 from mcintyre94/CA-150200
CA-150200: EN: Duplicate hotkeys for “Storage” and “Show Columns” under Citrix XenCenter
2016-08-09 10:37:41 +01:00
Callum McIntyre
93518392a8 CA-150200: EN: Duplicate hotkeys for “Storage” and “Show Columns” under Citrix XenCenter.
Remove the old value, leaving only the new one

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-09 10:31:55 +01:00
Mihaela Stoica
f914f03c21 CA-210549: Make MultipleAction and ParallelAction cancellable
- Fixed the way we calculate PercentComplete for ParallelAction: use the sum of actions in actionsByConnection and actionsWithNoConnection instead of subActions.Count, to avoid waiting for the completion of actions that we never start, because we exclude actions with disconnected connections from actionsByConnections
2016-08-09 10:03:11 +01:00
Gabor Apati-Nagy
e28ca1ded1 CA-217844: Handling Automatic update not supported
If there is no <minimalpatches /> tag, the version is not supported. This check has priority over licensed state when displaying the reason why a server is not supported.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-08 18:30:54 +01:00
Gabor Apati-Nagy
16afbd3bed CA-217382: Batch updates: Install batch updates is not showing low disk space error in pre-checks when host dom0 is full
Fixes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-08 18:05:42 +01:00
Mihaela Stoica
77336bdd44 Merge pull request #1095 from kc284/CA-33357
CA-33357: Improvements: show the disk name on the New VM storage page…
2016-08-08 17:04:01 +01:00
Gabor Apati-Nagy
21bcf546d2 Merge pull request #1098 from mcintyre94/CA-150200
CA-150200: EN: Duplicate hotkeys for “Storage” and “Show Columns” under Citrix XenCenter.
2016-08-08 15:26:20 +01:00
Callum McIntyre
0b67303f77 CA-150200: EN: Duplicate hotkeys for “Storage” and “Show Columns” under Citrix XenCenter.
New hotkey for "Show columns" is alt+C

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-08 15:10:51 +01:00
Konstantina Chremmou
e9ca8b529a CA-217843 best effort: Run RestoreDismissedUpdates action asynchronously to prevent UI hiccups.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-08 14:37:47 +01:00
Mihaela Stoica
529e921e24 Merge pull request #1078 from kc284/CA-147657
CA-147657 plus some refactoring
2016-08-08 13:47:59 +01:00
Konstantina Chremmou
c30938ff12 CA-217843: Fixed various issues on the select patch page: control tab order; some
hotkeys; button enabled state; some memory leaks; added spinner while check for
updates is in progress; added alternative text for when automatic mode is not available.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-08 11:41:42 +01:00
Gabor Apati-Nagy
f93a977ddf CA-217382: Batch updates: Install batch updates is not showing low disk space error in pre-checks when host dom0 is full
Implemented pre-check to check whether there is enough free disk space
before starting updating a pool.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-05 18:05:09 +01:00
Konstantina Chremmou
9d05bcdce5 CA-33357: Improvements: show the disk name on the New VM storage page so it is
more obvious to the user that they can edit it. To this purpose change the button
Properties to Edit (and do the same on the Networking page for consistence). Also
show the name of the disk (ellipsized if too long) on the wizard's finish page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-05 16:02:03 +01:00
Mihaela Stoica
56038e3eba CA-210549: Make MultipleAction and ParallelAction cancellable
- The multiple action is cancellable if is at least one sub action is not completed
- When a multiple action is cancelled, we try to cancel all sub actions that are not completed
- Also changed the way we calculate the percent complete for the parent action, to report partial progress of the sub actions

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-05 15:46:07 +01:00
Konstantina Chremmou
1065ca14eb Merge pull request #1088 from MihaelaStoica/CA-217449
CA-217449 &  CA-173661 - Control domain memory alert fixes
2016-08-05 12:27:31 +01:00
Mihaela Stoica
7186860cc2 CA-217390: Hotfix wizard: Add null reference check in the function that builds the list of post-update tasks.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-04 15:31:34 +01:00
Mihaela Stoica
dc24aa7fcc CA-217388: Hotfix Install wizard shows update as already uploaded when it is not actually uploaded because there wasn't enough space
- Add a new update to the list of uploaded updates only when the upload action has completed successfully.
- Do not perform the disk space check if there is nothing to upload (update has already been uploaded).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-04 15:10:36 +01:00
Mihaela Stoica
c3f85c7a99 Merge pull request #1091 from GaborApatiNagy/master_batch_new2
CA-216854: Fixed error messages shown
2016-08-04 14:31:19 +01:00
Mihaela Stoica
5a7e4185a9 Merge pull request #1092 from kc284/bugfix
CA-104472: Refactoring and removal of duplicate code. This also fixes…
2016-08-04 09:59:25 +01:00
Konstantina Chremmou
dbef554ac0 CA-104472: Refactoring and removal of duplicate code. This also fixes descrepancies
in the calculation of the never-expiring licence ("greater than 3653 days" in
LicenceAlert and LicenceStatus vs "greater than or equal to 3653 days" elsewhere).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-03 21:07:04 +01:00
Gabor Apati-Nagy
0ae6568a60 CA-216854: Fixed error messages shown
Now the wizard shows localized and friendly error messages instead of error codes

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-03 17:15:57 +01:00
Mihaela Stoica
d7ba62e025 Merge pull request #1090 from GaborApatiNagy/master_batch_new2
CA-217232: Batch updates: Install Dundee released hotfixes in Batch f…
2016-08-02 18:04:59 +01:00
Gabor Apati-Nagy
90653493c5 CA-217232: Batch updates: Install Dundee released hotfixes in Batch fails with wrong message in hotfix wizard
Despite the update sequences are correct by host, when they are flattened, the original order (order in minimal patches) was not considered properly, so a missing patch was scheduled for later in the sequence than it should have been, thus the upgrade failed with a precheck-error.

This bug occurs when we are given
* a pool of more than one host,
* with (at least) patchA not installed on 2 or more hosts
* patchA requires patchR that is not installed on at least one of the above hosts (but not not on all)
* the host that is missing patchR is ahead of other hosts in pool.Hosts.Cache

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-02 16:58:24 +01:00
Mihaela Stoica
2c8b542e44 Merge pull request #1089 from GaborApatiNagy/master_batch_new2
CA-216935: Fixed a bug that can occur when multiple pools are being u…
2016-08-02 16:09:48 +01:00
Gabor Apati-Nagy
48ef276c06 CA-216935: Fixed a bug that can occur when multiple pools are being updated with the same update and one of the prechecks happen before the other pool is finished applying the update
The PatchPrechecksOnMultipleHostsInAPoolPlanAction did not filter the patchmappings by masterhost, so with some probability, it could choose the wrong mapping (pool_patch object for the same update, but in different pool). This bug is being fixed in this commit, other changes only renamed (for more consistent naming) a class and removed an unused field.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-02 14:30:20 +01:00
Mihaela Stoica
35fb115358 CA-173661: Control domain memory alert setting not showing up in the tab subtitle on Host Properties dialog
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-01 12:24:25 +01:00
Mihaela Stoica
bd497356f6 CA-217449: Dom0 VM properties should not be visible in XenCenter
- The "Alarm Settings" action on Alerts page should open host's properties dialog for Dom0 alerts
- Also added help id for the Control Domain Memory Usage alert
2016-08-01 12:21:19 +01:00
Gabor Apati-Nagy
8e30dc32b7 Merge pull request #1087 from Frezzle/CA-214622
CA-214622: Confusing info shown on Install Update screen
2016-08-01 11:41:20 +01:00
Frezzle
c97787f8f4 Merge pull request #1086 from kc284/master
Fixed issue on the New SR wizard where the SR type details panel was not populated when the default checked button was invisible.
2016-07-28 15:02:46 +01:00
Frezzle
9dd0c41e7a [CA-214622] XenCenter Install update Wizard Confusing Info shown on Install update screen
Changed message to "Deleting update installation file ..." to match wording in previous page of the wizard.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-28 13:50:09 +01:00
Konstantina Chremmou
e8a009678f Fixed issue on the New SR wizard where the SR type details panel was not populated
when the default checked button was invisible.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-28 13:16:49 +01:00
Mihaela Stoica
aa78621897 Merge pull request #1069 from kc284/master
CA-136768: Fixed bad layout of buttons at the top of the snapshots ta…
2016-07-26 14:43:33 +01:00
Mihaela Stoica
54849d4f5e Merge pull request #1084 from GaborApatiNagy/master_CA-213728
CA-213728: Going to Home Server tab can change home server
2016-07-25 16:45:45 +01:00
Gabor Apati-Nagy
3ca0db4b98 Merge pull request #1072 from Frezzle/CA-209198
CA-209198: Allowed to attempt to install hotfix when it is already applied
2016-07-25 15:04:21 +01:00
Gabor Apati-Nagy
f6139c713a CA-213728: Going to Home Server tab can change home server
Even though the correct row have been selected by the time the grid becomes visible, it is not displayed properly. This change set fixes the problem by selecting the row again.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-25 14:31:55 +01:00
Mihaela Stoica
e1c78203d5 Merge pull request #1083 from GaborApatiNagy/master_CA-213278
CA-213281, CA-213278: OK fixed
2016-07-25 14:22:09 +01:00