Commit Graph

2750 Commits

Author SHA1 Message Date
Konstantina Chremmou
d9aeeb15e5 Rewriting of the Snapshot Schedule dialog for performance optimisation.
Merged the PolicyHistory control into the dialog; removed legacy column from
the policies datagridview; put retrieval of messages on a background thread
to avoid UI freezing if there is a huge number of messages; retrieve messages
only when the VMSS collection changes and not every time the run history grid
is repopulated; sorted out button enabled state.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-07 11:02:07 +01:00
Konstantina Chremmou
1f2b550f4d Renamed controls and moved about methods in view of merging the run history controls into this dialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-06 13:22:29 +01:00
Konstantina Chremmou
9ce11ddf55 Renamed controls and placed them on a panel in view of merging them into the ScheduledSnapshotsDialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-06 13:15:47 +01:00
Gabor Apati-Nagy
5ef13705a5 CA-263044: [XSO-765] Install Update fails because it tries to install the hotfix to one pool twice
Fixed a bug that caused XenCenter to try to apply an update (that the user manually selected) multiple times and therefore failed. This was only present when the Select All button was used.
2017-09-05 18:38:20 +01:00
Konstantina Chremmou
514c33140b Converted remaining extension get and set properties of the API classes to methods
in order to prevent them from being serialised alongside the API properties.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-05 02:15:38 +01:00
Konstantina Chremmou
71301eb332 Removed the extension Properties from the VMSS class. Removed the GetVMSSAlertsAction;
it's not needed as it does not make server calls. Some more refactoring and corrections
here and there.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-04 23:07:22 +01:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Konstantina Chremmou
da3cd070ee Removed VIF.RateLimited property because usage on the VIFDialog shows it is
occasionally preferable to access the qos_algorithm_type directly.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:23 +01:00
Konstantina Chremmou
4825b60a60 Moved UI logic from the VM extensions to the SnapshotsPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:23 +01:00
Konstantina Chremmou
85d398d067 Moved the SR.GetIcon() method to XenAdmin where it belongs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:23 +01:00
Konstantina Chremmou
880d56b30f Renamed method so it's more obvious what it does.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:23 +01:00
Mihaela Stoica
dc2968b3d4 CP-24215: Add null checks when we log the minimal patches
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-09-01 15:34:58 +01:00
Mihaela Stoica
6a2f77c9f6 CA-264439: Change the XenCenter version check to return just a warning in the RPU wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-08-31 09:51:20 +01:00
Ji Jiang
d478115ec6 CA-248292: Fix btn truncation in VM storage page
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-08-30 13:38:53 +01:00
Mihaela Stoica
69007dbaec CP-24213: Some fixes in the Patching wizard
- Change the "Web page" column alignment to TopLeft, to match the other columns
- When trying to find an alert from a filename, use the patch name instead of the alert name, because now the alert name can also be a version name

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-08-30 09:31:05 +01:00
Mihaela Stoica
85d57f558f CP-24215: If the Automated Updates mode goes to a new version, also apply this version's minimum patches
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-08-29 17:00:58 +01:00
Mihaela Stoica
c59a3d14c4 CP-24213: Show CUs as updates
CUs are available as both updates and upgrades, but they should be presented as updates where possible.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-08-25 10:56:04 +01:00
Mihaela Stoica
86d2acee7f Merge branch 'master' into REQ-411
Conflicts:
	CFUValidator/CFUValidator.cs
	CFUValidator/OutputDecorators/XenCenterUpdateDecorator.cs
	CFUValidator/OutputDecorators/XenServerUpdateDecorator.cs
	XenAdmin/TabPages/ManageUpdatesPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Actions/Updates/XenCenterVersion.cs
	XenModel/Actions/Updates/XenServerVersion.cs
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2017-08-23 16:32:39 +01:00
Stephen Turner
89f51e90a1 CA-258782 Remove thin provisioning code (#1728)
* CA-258782 Remove thin provisioning code

* Revert file that shouldn't have been touched

* Remove line that was only present for debugging
2017-08-22 16:40:08 +01:00
Mihaela Stoica
8089617eaf CP-24087: Parse the error parameters of the UPDATE_PRECHECK_FAILED_UNKNOWN_ERROR precheck failure (#1740)
When the update precheck fails with UPDATE_PRECHECK_FAILED_UNKNOWN_ERROR, we try to find the actual error in the failure's parameters (in the form of an xml string containing the error code) and display that error instead of the "unknown error".

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-08-22 16:09:47 +01:00
Mihaela Stoica
67b18665f5 Merge pull request #1737 from vetrivelc/master
L10N:CA-261954,CA-261973 & CA-261977
2017-08-21 12:16:16 +01:00
Vetrivel Chinnasamy
21eff4d819 L10N:CA-261954,CA-261973 & CA-261977 2017-08-21 16:19:39 +05:30
Gabor Apati-Nagy
8514ddf21e CA-261107: Metadata file osVersion is showing same value for XenCenter on different windows versions
Added app manifest to explicitly target XC to all windows versions from Vista to Windows 10 so that the Environment variables will reflect the correct Windows versions. Note that "Manifesting the .exe for Windows 8.1 or Windows 10 will not have any impact when run on previous operating systems." [1]

[1] https://msdn.microsoft.com/en-gb/library/windows/desktop/dn481241.aspx

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-08-18 13:40:36 +01:00
Hui Zhang
d8c248fa76 CP-23604: Add IGMP snooping toggle.
Add the toggle to enable/disable IGMP snooping.
Display the property if the pool is licensed
and the network backend is OVS.

Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
2017-08-16 12:32:18 +08:00
Gabor Apati-Nagy
5a7e6651cd CA-260304: WLB Configuration parameters can not be reset in XenCenter 7.2
Fixed the regression

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-08-15 12:20:25 +01:00
Gabor Apati-Nagy
48134dfd14 Merge pull request #1723 from xenserver/REQ-473
Merge from REQ-473
2017-08-09 10:47:01 +01:00
Ji Jiang
6bfbbc7aa8 CA-141166: Fix truncation issue on HA wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-07-31 09:09:54 +01:00
Mihaela Stoica
5b75b5f25d CA-260365: Hide the build number from the General Tab for Ely and newer hosts (to cover the Honolulu case)
Also restrict the use of build number as an integer to pre-Ely hosts (because a Honolulu host has a non-numeric build number and XenCenter doesn't know the difference between Ely and Honolulu)
And a small update to the pool join rule to match what we have in Honolulu XenCenter (check the database schema regardless of the version)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-27 14:47:12 +01:00
Konstantina Chremmou
ad7e2fa6a6 CA-257927: Changed ChangeableList.RemoveAll method to fire the CollectionChangedEvent
once for all the items to be removed, passing in their list as argument. This method,
and the method Clear calling it, are used for alerts, updates, events and connections,
hence changed the handling of the CollectionChanged event in these cases to expect
either a single item or a collection. In the case of alerts, updates and events
this means that we can rebuild the whole list instead of removing single rows which
causes the application to hang for big numbers of items.
2017-07-24 14:48:02 +01:00
Konstantina Chremmou
bfcdfd982f The event registered on the HistoryPage is ConnectionsManager.History.CollectionChanged,
not ConnectionsManager.XenConnections.CollectionChanged.
2017-07-24 14:48:02 +01:00
Letsibogo Ramadi
2fb35c8faa CA-235459 - G11n:SC: The numeric tag for “Disks” and “Network” is ove… (#1693)
* CA-235459 - G11n:SC: The numeric tag for “Disks” and “Network” is overlap on the search window.

* CA-235459 - G11n:SC: The numeric tag for “Disks” and “Network” is overlap on the search window.

- use col widths from resource file instead of hardcoded values

* CA-235459 - G11n:SC: The numeric tag for “Disks” and “Network” is overlap on the search window.

- safer implementation

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-07-21 16:15:29 +01:00
Letsibogo Ramadi
c44f89bf05 CA-249823 - Accept zip files in Updates Wizard (#1667)
* CA-249823 - Accept zip files in Updates Wizard
* CA-258326 - Improve implementation of CA-248823(Accept zip files in Updates Wizard)
* Small unrelated bugfix: Stop selectFromDiskRadioButton being checked when
restoring dismissed updates.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-07-21 15:56:27 +01:00
Mihaela Stoica
5e2fe55771 CA-260214: Update the uuid of the RPU hotfix (#1704)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-20 12:32:03 +01:00
vetrivelc
a9e5198c7e L10N : Translation updates and bug fixes 2017-07-19 15:09:10 +05:30
vetrivelc
d829654203 Merge branch 'master' of https://github.com/xenserver/xenadmin 2017-07-19 14:22:53 +05:30
Mihaela Stoica
8bdbb122c8 CA-259276: Error when trying to install an update via JA XenCenter
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-06 14:16:06 +01:00
vetrivelc
5abd456a28 L10N: Translation Product tag Correction Checkins 2017-07-06 11:29:02 +05:30
vetrivelc
78fc06d0af L10N : Issue Fixing 2017-07-05 17:10:43 +05:30
Letsibogo Ramadi
7f9b6e65a3 CP-22472 - Add new XenCenter metadata file to the server status report
Change OSCulture to show language currently installed on UI instead of
default language selected at OS installation stage
2017-07-05 11:19:07 +01:00
Gabor Apati-Nagy
51c08c7433 Merge pull request #1666 from MihaelaStoica/CP-21161
CP-21161: Do not call the disk-space plugin cleanup functions on Ely …
2017-07-04 15:37:34 +01:00
Mihaela Stoica
ad0cd9ef00 CP-22472: Add copyright notice
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-04 13:18:59 +01:00
vetrivelc
d624d93865 L10N:CP-23040,CP-23012 Traanslation Checkin 2017-07-04 10:39:46 +05:30
Ji Jiang
5654b4eb89 CA-258321: Incorrect CFU user agent
Fixed user agent string for CFU.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-07-03 17:54:57 +01:00
Mihaela Stoica
dd92f0e6a6 CP-22472: Add more metadata
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Mihaela Stoica
0fbe225fa4 CP-22472: Add new XenCenter metadata file to the server status report: changes following code review
- Add an empty string (instead of 'null') if the IP address is null
- Only include the XC uptime in the SSR produced in XenCenter
- Also changed the name of the metadata file that is included in the SSR

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Mihaela Stoica
713f84cf54 CP-22472: Add new XenCenter metadata file to the server status report: changes following code review
- Added more items to the metadata; the content is now slightly different between the SSR produced in XenCenter and the one from the HealthCheck;
- Encode the metadata string before sending it to the Health Check;
- Always suppress history for the action that sends the proxy settings;
- Renamed some of the new classes;
- Also refactored the actions that send data to the HealthCheck service.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Mihaela Stoica
54ab9307d2 CP-22472: Add new XenCenter metadata file to the server status report
- XenCenter sends its telemetry info to the HealthCheck service
- The HealthCheck service saves this metadata in its settings file and includes it in the health check upload

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Mihaela Stoica
2c37367155 CP-22472: Add new XenCenter metadata file to the server status report
- this adds the telemetry file to the server status report produced in XenCenter

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Letsibogo Ramadi
a5c895da0c Merge pull request #1672 from MihaelaStoica/CA-257760
CA-257760: Strip leading and trailing spaces from the filename in the…
2017-07-03 10:32:24 +01:00
Letsibogo Ramadi
24454ad6a7 Merge pull request #1674 from MihaelaStoica/CA-39992
CA-39992: Add "Repair Storage" action to the PBD_PLUG_FAILED_ON_SERVE…
2017-07-03 10:25:39 +01:00
Mihaela Stoica
743e9938da Merge pull request #1665 from minglumlu/private/mingl/CA-254479
CA-254479,CA-223802,XSO-672: distinct the VM IP addresses which are r…
2017-07-03 09:59:18 +01:00
Mihaela Stoica
813228eed6 CA-39992: Add "Repair Storage" action to the PBD_PLUG_FAILED_ON_SERVER_START alert
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-30 16:24:29 +01:00
Mihaela Stoica
bdbe40187a CA-257760: Strip leading and trailing spaces from the filename in the Import wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-29 16:19:39 +01:00
Gabor Apati-Nagy
c0edd4c587 CA-224724: VBD edit page: show 'position in use' message on the dropdown items
requested changed by code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-29 12:04:16 +01:00
Gabor Apati-Nagy
33c95f5e6f CA-224724: VBD edit page: show 'position in use' message on the dropdown items
requested changed by code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-29 12:04:16 +01:00
Gabor Apati-Nagy
5df4d174c0 CA-224724: VBD edit page: show 'position in use' message on the dropdown items
This commit changes the dropdown control to not only show the available
positions, but also mark the ones that are already being used.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-29 12:04:16 +01:00
minglumlu
3a7d1c1cd9 CA-254479,CA-223802,XSO-672: distinct the VM IP addresses which are retrieved from XAPI. 2017-06-28 10:08:16 +08:00
Mihaela Stoica
c061b0f57d CA-257574: Manage vApps dialog is unusable with a vApp containing a l… (#1664)
* CA-257574: Manage vApps dialog is unusable with a vApp containing a large number of VMs

- In the VMAppliancesDialog, change event handlers to reduce the number of refreshes when something changes: only reload the appliances when the VM_appliance collection change; if a relevant property is changed (in VM_appliance or VM), then update only the affected rows.
- Improve the way we assign VMs to a group (AssignVMsToVMApplianceAction and AssignVMsToPolicyAction): only update the VMs that really changed.
- Also improve the way we update the VM startup options and HA restart priorities on a set of VMs

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-257574: Manage vApps dialog is unusable with a vApp containing a large number of VMs: changes following code review

- reverted the changes to the AssignVMsToGroup actions that added the additional constructor
- changed the AssignVMsToGroup actions to calculate the set difference between two lists more efficiently
- added code to deregister PropertyChanged events on VM_appliances
- removed getCurrentSettings() method as it is not needed, GetChangedSettings can be used in all cases

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-27 17:32:46 +01:00
Mihaela Stoica
537e569a62 CP-21161: Do not call the disk-space plugin cleanup functions on Ely and above hosts
- Ensure that the disk-space plugin functions are not called on Ely or greater hosts, except for the 'get_avail_host_disk_space' function, which is still needed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-27 13:48:54 +01:00
Gabor Apati-Nagy
10e2aff2e4 CA-257553: Unexpected error on the Memory tab while running an "Instant VM create" action
Calling Rebuild() from the event thread now

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-22 15:49:15 +01:00
Vetrivel Chinnasamy
1fce4298e5 L10N: Fix CA-255548 & translation updates (#1660) 2017-06-22 09:19:58 +01:00
Mihaela Stoica
15d748925a Merge pull request #1641 from letsboogey/CA-220169
CA-220169 - Network heartbeat status initially shows 'Error' after en…
2017-06-21 17:02:36 +01:00
Mihaela Stoica
bfab94f923 Merge pull request #1653 from letsboogey/CA-177402
CA-177402 - XenCenter doesnt show migrate option on selecting multipl…
2017-06-21 10:11:45 +01:00
Letsibogo Ramadi
a579ac9196 CA-177402 - XenCenter doesnt show migrate option on selecting multiple Suspended VMs
Enable CrossPoolMove for a single VM too

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-20 15:00:49 +01:00
Letsibogo Ramadi
c1635fba58 CA-220169 - Network heartbeat status initially shows 'Error' after enabling HA
Renaming and minor refactoring

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-20 14:56:26 +01:00
Stephen Turner
eda73f1dff Fix several usage errors identified by Lexica 2017-06-20 14:29:22 +01:00
Gabor Apati-Nagy
46edc78e50 Merge pull request #1654 from MihaelaStoica/CA-241298
CA-241298: Do not offer to install tools if the VM runs on a slave in…
2017-06-20 13:27:04 +01:00
Konstantina Chremmou
d88fc10e3f Merge pull request #1649 from letsboogey/CA-247333
CA-247333 - Remove rdpclient6 code after April 2017
2017-06-20 13:19:52 +01:00
Letsibogo Ramadi
a17063ec7d CA-177402 - XenCenter doesnt show migrate option on selecting multiple Suspended VMs
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-20 12:29:03 +01:00
Gabor Apati-Nagy
ee2f1ef920 Merge branch 'master' of https://github.com/xenserver/xenadmin into CA-243675
Conflicts:
	XenModel/Messages.resx
2017-06-20 11:40:03 +01:00
Letsibogo Ramadi
cca0ab5d89 CA-247333 - Remove rdpclient6 code after April 2017 when it will become redundant
-Removed rdpControl because it is always identical to rdpClient9
-Renamed rdpClient9 to just rdpClient because we use only one
client so there is no need to distinguish, and it can easily be updated
to future versions.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-20 11:33:52 +01:00
Mihaela Stoica
410e77d94e CA-241298: Do not offer to install tools if the VM runs on a slave in a partial upgraded pool
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-16 16:49:06 +01:00
Letsibogo Ramadi
ddd481fff0 CA-177402 - XenCenter doesnt show migrate option on selecting multiple Suspended VMs
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-16 14:38:22 +01:00
Gabor Apati-Nagy
71ed9d8955 Merge pull request #1651 from kc284/master
CA-257209: The VNCControl has been deprecated.
2017-06-16 14:12:41 +01:00
Mihaela Stoica
7cd7be6d03 Merge pull request #1648 from GaborApatiNagy/master_fixbuild
CA-255547: WLB code in XenCenter: Remove all code targetting <= 6.1 XenServers
2017-06-16 09:43:53 +01:00
Konstantina Chremmou
39f3e9ea1e CA-257209: The VNCControl has been deprecated. 2017-06-16 08:55:38 +01:00
Gabor Apati-Nagy
9806491863 CA-243675: No Clear error message when proxy server which is configured is not running
Mention proxy in the suggestion that is shown when a connection fails

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-15 17:54:27 +01:00
Gabor Apati-Nagy
c19ee0bf13 CA-255547: WLB code in XenCenter: Remove all code targetting <= 6.1 XenServers
Fixed build by removing unused fields that caused the Release build to fail. Removed more dead code.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-15 16:11:05 +01:00
Gabor Apati-Nagy
9b336ec3c6 CA-255547: WLB code in XenCenter: Remove all code targetting <= 6.1 XenServers
Put back code that shouldn't have been removed

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-15 16:09:32 +01:00
Mihaela Stoica
cd71c4fe1c CA-249858: Fix build warning as error
(The member 'CanExecute()' does not hide an inherited member. The new keyword is not required)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-15 08:31:47 +01:00
Konstantina Chremmou
062938878d Merge pull request #1602 from GaborApatiNagy/master_CA-220047
CA-220047: Show proper precheck error when a VM cannot be migrated
2017-06-15 08:24:06 +01:00
Letsibogo Ramadi
5e458ac234 CA-247333 - Remove rdpclient6 code after April 2017 when it will become redundant 2017-06-14 17:22:42 +01:00
Letsibogo Ramadi
be6b2ebcb3 Merge pull request #1630 from kc284/master
One more take to CA-231518
2017-06-14 13:37:13 +01:00
Gabor Apati-Nagy
5fe4b8ba09 Merge pull request #1639 from GaborApatiNagy/CA-255547
CA-255547: WLB code in XenCenter: Remove all code targetting <= 6.1 XenServers
2017-06-14 10:02:36 +01:00
Gabor Apati-Nagy
4e8541fb91 Merge pull request #1642 from MihaelaStoica/CA-249858
CA-249858: XenCenter gives different messages for migrate VM at diffe…
2017-06-13 16:53:19 +01:00
Mihaela Stoica
a79e156cf5 CA-249858: Moved the Trim call
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-13 16:47:43 +01:00
Mihaela Stoica
77b73c8d16 CP-22471: Add information on XenCenter help usage to the user settings
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-13 13:42:26 +01:00
Mihaela Stoica
8f6c345c66 CA-249858: XenCenter gives different messages for migrate VM at different screens when pool connected with vm-operator user
Expose the reasons why a cross pool migration command cannot execute.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-13 13:12:01 +01:00
Letsibogo Ramadi
f1d2dc2cf8 CA-220169 - Network heartbeat status initially shows 'Error' after enabling HA
Network HB initially shown as error because it takes time for the status to be
read from xha by xapi. This adds a delay to allow the status to be updated
before XC displays it.
2017-06-13 11:17:49 +01:00
Mihaela Stoica
ffe7ff9520 Merge pull request #1632 from xenserver/REQ-378
Feature "REQ-378: Support Chinese Language E-mail Performance Alerts"
2017-06-13 10:51:42 +01:00
Gabor Apati-Nagy
597762b884 CA-255547: WLB code in XenCenter: Remove all code targetting <= 6.1 XenServers
Removed code that is no longer needed. Also removed an obsolete unit test.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-12 16:49:37 +01:00
Konstantina Chremmou
2504779480 CA-23158: Some layout improvements and logic changes.
- Moved the top warning out of the filter toolstrip and into the same tableLayoutPanel
as the dataGridVew to avoid hardcoding the dataGridview location in the code.
- Corrected linkLabel colour for compliance. Changed icon to match the icon
of the bottom information label.
- When checking for updates disable the linklabel instead of hiding the whole
warning to avoid empty space or the dataGridView jumping up and down.
- The check button in the middle should be available when the check link is
available.
- Avoid toggling explicitly the enabled state of controls; it can be taken
care of within the check for updates event handlers.
- Other minor layout improvements (control positioning).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-06-11 11:11:32 +01:00
Konstantina Chremmou
31b98c51e5 Refactored duplicate method.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-06-11 11:11:31 +01:00
Konstantina Chremmou
9776c1e2c2 CA-23158: On alert dismissal remove single rows instead of rebuilding the datagridview,
thus solving the resizing issue of the Actions column. Also, register an action
before starting running it.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-06-11 11:11:31 +01:00
Gabor Apati-Nagy
6185b24b37 CA-147943: Scrollbar for list of hotfixes installed in a pool doesn't have scrollbar the first time it is expanded
General tab (Pool): In the list of updates, added a space after each comma
to let the control wrap the text into multiple lines. This way the text is
no longer cut, therefore no additional scrollbar is needed.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-08 17:32:34 +01:00
Gabor Apati-Nagy
5f8db75e7c CA-220047: Show proper precheck error when a VM cannot be migrated
Changed the pre-check error message to refer to the absence of the Tools
when that is suspected to be the case.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-08 16:12:26 +01:00
Gabor Apati-Nagy
bb5235ca40 Merge pull request #1633 from MihaelaStoica/CP-21130
CP-21130: Move the test for InvernessOrGreater outside the VNCGraphic…
2017-06-08 11:16:12 +01:00
Mihaela Stoica
4bf86842ba CP-21130: Move the test for InvernessOrGreater outside the VNCGraphicsClient class
- This is needed because this class is shared with the VNCControl solution which doesn't have access to the Helpers class

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-08 09:38:09 +01:00
minl1
2105cbf1a4 cp-21685/cp-22367: Linx/YinheKylin linux XenCenter ICON support 2017-06-07 21:01:01 +08:00
Anoob Soman
add1b5d1ab CP-21130: Restrict support for EXT_KEY_EVENT to Inverness 2017-06-06 16:34:53 +01:00
Anoob Soman
108f3b5aae Merge branch 'master' into vnc_improvements_v2 2017-06-06 16:27:24 +01:00
Gabor Apati-Nagy
0311f7dd72 CA-220047: Show proper precheck error when a VM cannot be migrated
A bit of refactoring as requested by the reviewers

I decided not remove the NullReferenceExceptions and throw the Failures
immediately in order to avoid the additional error handling that seems to be unnecessary there. However, the reason I've decided to keep it as is is that it would change what gets logged and the performance gain would not be noticeable anyway. Furthermore, the current implementation (try-catchall) catches any other exceptions providing fallback to the default Failure.
2017-06-05 10:15:18 +01:00
Gabor Apati-Nagy
de97577430 CA-255551: [SCTX-2553] Automated Updates - Slaves rebooted before Master - XenCenter 7.1.1
Due to a regression (introduced by [1]), XenCenter will not run delayed actions in the correct host-order at all times. This can cause the master to be not the first host to be rebooted what may result in connections being lost to slaves should the API change between restarts/updates in a way that it would not be compatible to the previous version. This would make the wizard fail and users would have to restart their master host manually to make it connect to its slaves again.

This commit fixes the order of the hosts when executing the delayed actions.

[1]: 15827512e1

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-01 21:20:19 +01:00
Mihaela Stoica
5291c3aa7d Merge pull request #1613 from minli1/feature/Asianux-Turbo-Linux-support/master
req-398/req-440: ICON support for Asianux Linux and Turbo Linux.
2017-06-01 14:30:25 +01:00
Mihaela Stoica
dce68b58c9 CA-242134: Remove Host.IsXCP extension (#1618)
* CA-242134: Remove Host.IsXCP extension

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-242134: Remove Host.IsXCP extension

- retain the host.license_params condition

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-31 16:58:52 +01:00
Mihaela Stoica
cf1f630486 Merge pull request #1619 from xenserver/management-on-vlan
REQ-42 feature merge
2017-05-31 15:23:28 +01:00
Gabor Apati-Nagy
f1a20c279e Merge pull request #1603 from MihaelaStoica/CA-253936
CA-253936: Fix proxy authentication in the XenServerHealthCheck service
2017-05-31 14:37:02 +01:00
Mihaela Stoica
bd8ac0d769 Merge pull request #1617 from geosharath/management-on-VLAN-B2B
B2B master to management-on-vlan
2017-05-31 12:02:51 +01:00
Konstantina Chremmou
af647fbf52 Merge pull request #1608 from MihaelaStoica/removeVMPP
Remove vmpp
2017-05-31 08:43:12 +01:00
minl1
c146747798 CP-21662:replace the icon for new vm template(asianux and turbo linux) in Xencenter 2017-05-31 13:19:47 +08:00
Mihaela Stoica
1bae482bc5 CA-242134: Remove the VMPP code: changes following code review
- removed unused methods and properties from the NewPolicyWizard class
- made the wizard pages private in the NewPolicyWizard class
- removed unused constructor from the NewPolicySnapshotTypePage class
- removed unused property from the PolicyHistory class
- removed the public properties TreeView and DataGridView from the SnapshotsPage
- removed the PolicyType from the PolicyAlert class and the constructor that is no longer used
- removed unused property from the VMSS class

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-30 15:08:01 +01:00
Mihaela Stoica
49be0ffada CA-242134: Remove the OpenLicenseFileDialog class and its usage
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-26 14:54:51 +01:00
Letsibogo Ramadi
75a325056c CA-252871 - Updates order is not preserved on Exporting updates to a file
Applies sort order of DataGridView to the unfiltered list of updates before
exporting all to file, thereby preserving the update order in the file
2017-05-26 12:54:46 +01:00
Mihaela Stoica
71600b20de CA-242134: Rename some of the classes and files, following the removal of the VMPP support
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-25 16:29:27 +01:00
Mihaela Stoica
f752f05a1d CA-242134: Remove the VMPP code
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-25 15:37:05 +01:00
Letsibogo Ramadi
fb5438282d CA-205187 - L10n: JA/SC: The websites are not shown as hyperlink on t… (#1591)
* CA-205187 - L10n: JA/SC: The websites are not shown as hyperlink on the “Health Check Privacy Statement” window

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>

* CA-205187 - L10n: JA/SC: The websites are not shown as hyperlink

Fixed tab order

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>

* CA-205187 - L10n: JA/SC: The websites are not shown as hyperlink

Added Japanese privacy policy

* CA-205187 - L10n: JA/SC: The websites are not shown as hyperlink

Fixed regression in tab order
2017-05-24 15:14:01 +01:00
Mihaela Stoica
ad6631f698 CA-253936: Fix proxy authentication in the XenServerHealthCheck service
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-23 16:57:38 +01:00
Gabor Apati-Nagy
02025aa2b4 CA-220047: Show proper precheck error when a VM cannot be migrated
Detect both VM_LACKS_FEATURE and VM_LACKS_FEATURE_SUSPEND, show proper error message on the pre-check page in the Install Updates Wizard

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-05-22 11:17:42 +01:00
Mihaela Stoica
443f01fa55 Merge pull request #1601 from xenserver/master
Merge master into management-on-vlan
2017-05-22 10:38:26 +01:00
Letsibogo Ramadi
ef68d07c47 CA-249849 - Using arrows to select license in license manager are the… (#1588)
* CA-249849 - Using arrows to select license in license manager are the wrong way

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>

* CA-249849 - Using arrows to select license in license manager are the wrong way round

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>

* CA-249849 - Using arrows to select license in license manager

Reverted tab order for radiobutton groupbox as per review comments
2017-05-18 12:25:04 +01:00
Mihaela Stoica
6288ace0f5 Merge pull request #1594 from xenserver/release/falcon/staging
Merge release/falcon/staging into master
2017-05-17 12:45:36 +01:00
Gabor Apati-Nagy
47f7690536 Merge pull request #1590 from MihaelaStoica/CA-244663
CA-244663: In the Migrate VM wizard, add storage mappings for the VDI…
2017-05-16 13:54:13 +01:00
Mihaela Stoica
6440226ee3 Merge pull request #1587 from letsboogey/master
CA-250234 - XenCenter hit with NullReferenceException at HAPage
2017-05-16 11:56:33 +01:00
Mihaela Stoica
e50187b85e Merge pull request #1593 from GaborApatiNagy/master_CA-252923
CA-252923: Update apply on slave host fails with pool_patch or pool_update not found
2017-05-16 11:52:22 +01:00
Gabor Apati-Nagy
eb45d14a8a Merge pull request #1576 from MihaelaStoica/CA-251630
CA-251630: XenCenter update wizard incorrectly states that some hosts…
2017-05-15 13:59:19 +01:00
Gabor Apati-Nagy
d55af4e5a7 CA-252923: Update apply on slave host fails with pool_patch or pool_update not found
In rare cases, the GetMaster could return null, causing the update progress to fail with "Pool_patch or Pool_update not found". (when the Cache hasn't been populated by the execution gets here)
This commit drops GetMaster and uses a pre-saved masterUuid instead of waiting for the Cache what would be the other way to solve this issue.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-05-12 16:10:36 +01:00
Mihaela Stoica
d2f3c0c116 CA-244663: In the Migrate VM wizard, add storage mappings for the VDIs belonging to the VM's snapshots
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-11 16:42:41 +01:00
vetrivelc
21a7a74408 L10N: CA-250470,CA-250471,CA-250472,CA-250473,CA-250893,CA-250894 Localized UI fixes 2017-05-11 19:36:14 +05:30
Letsibogo Ramadi
adde3dc044 CA-250234 - XenCenter hit with NullReferenceException at HAPage
More robust check for null connection

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-05-10 16:40:12 +01:00
Mihaela Stoica
1bc43eda7d Merge pull request #1586 from GaborApatiNagy/master_updates
CA-252877: Precheck actions not reverted on upgrading to new XenServer version using an update
2017-05-10 12:35:00 +01:00
Letsibogo Ramadi
63cd499cbd CA-250234 - XenCenter hit with NullReferenceException at HAPage.Rebuild()
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-05-10 12:32:15 +01:00
Gabor Apati-Nagy
d14f0d6b49 CA-252877: Precheck actions not reverted on upgrading to new XenServer version using an update
Automated Updates now undo pre-check actions once it's finished wit the updates

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-05-10 12:21:11 +01:00
Mihaela Stoica
d015ba223e Merge pull request #1575 from letsboogey/master
CA-251526 - Change template order in New VM wizard
2017-05-10 11:33:03 +01:00
Letsibogo Ramadi
0c7cf8678b CA-251526 - Change template order in New VM wizard
Moved "Legacy Windows" template to the bottom of the Windows templates
to discourage users from selecting it and avoid it being selected by default
at the top of the list as was the case.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-05-10 11:30:16 +01:00
Gabor Apati-Nagy
5eff76be28 CA-252877: Precheck actions not reverted on upgrading to new XenServer version using an update
Automated Updates now undo pre-check actions once it's finished wit the updates

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-05-10 10:06:41 +01:00
Konstantina Chremmou
652e446245 Merge pull request #1585 from MihaelaStoica/CA-242134
CA-242134: Remove the code targetting <= 6.1 XenServers
2017-05-10 08:14:23 +01:00
Gabor Apati-Nagy
d9a8b646ea Merge pull request #1578 from MihaelaStoica/CA-253047
CA-253047: Wrong prechecks are performed in Automated Updates mode if…
2017-05-09 20:21:36 +01:00
Mihaela Stoica
31c26aef22 Merge branch 'master' into CA-242134 2017-05-09 16:31:04 +01:00
Mihaela Stoica
a31c31eb07 CA-242134: Remove licensing code targeting pre-Clearwater hosts
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-08 13:40:48 +01:00
Mihaela Stoica
68aa91bcaa CA-242134: Remove code targeting pre-Clearwater hosts and unnecessary ClearwaterOrGreater checks
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-05 15:35:25 +01:00
Mihaela Stoica
78ad827cc4 CA-242134: Remove TampaOrGreater, its usages and unreachable code
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-05 14:31:43 +01:00
Mihaela Stoica
496a400ae4 Merge pull request #1582 from xenserver/release/falcon/staging
Merge release/falcon/staging to master
2017-05-05 12:45:31 +01:00
vetrivelc
16d7d6fa89 L10N:Revised Falcon Help Files 2017-05-05 16:41:56 +05:30
Mihaela Stoica
d9f6016933 CP-242134: Remove pre-Clearwater hotfixes
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-05 10:45:10 +01:00
Mihaela Stoica
cd2cff7d91 Merge pull request #1579 from xenserver/release/falcon/staging
Merge release/falcon/staging to master
2017-05-04 15:22:53 +01:00
Mihaela Stoica
dd861cfeed CA-253047: Wrong prechecks are performed in Automated Updates mode if an update has been previously uploaded
Reset the PrecheckPage.PoolUpdate property on leaving the SelectPatch page, because it needs to be null for the Automated Updates mode and for the single update mode it will be updated on leaving the Upload page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-04 15:14:06 +01:00
vetrivelc
bf58ff1ec0 L10N:Falcon Localized Help Files Checkin 2017-05-04 19:40:06 +05:30
Mihaela Stoica
6e4c5d3548 CA-251630: XenCenter update wizard incorrectly states that some hosts need rebooting and requires suspending VMs
Perform all the prechecks on applicable hosts only (i.e. the hosts that don't have the update applied already), with the following exceptions:
- The HA check, which is performed on the pool master
- The server-side precheck (PatchPrecheckCheck) which will still be performed on all servers in the pool and will show the warning if the update has already been applied on some servers

This commit also adds an override to the HAOffCheck.SuccessfulCheckDescription to show the pool name instead of the master's if the check is successful.
Also, in the PatchPrecheckCheck, I had moved the code that checks if the patch is already applied to the very beginning (before the host liveness check), so it will return the warning that the server will be skipped even if the server is not reachable

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-04 14:32:36 +01:00
Mihaela Stoica
cd9ef6f509 Merge pull request #1565 from letsboogey/bug_thursday
CA-250235 - XC is allowing user to configure Health check even with W…
2017-05-03 12:48:41 +01:00
Letsibogo Ramadi
042915f5be CA-250235 - XC is allowing user to configure Health check even with Wrong XenServer Credentials 2017-05-03 12:23:06 +01:00