The dialog is launched non-modally, hence showing the grip automatically has no effect.
Also, made the dialog slightly bigger.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* Hid properties from the designer and renamed them because they give the wrong impression.
* Fixed some inefficiencies around the NetworkComboboxItem.
- Move NetworkComboBoxItem into the NetworkComboBox class.
- Moved XenAdmin.Dialogs.NetworkComboBoxItem into the VIFDialog class and made it
private to avoid ambiguousness with the public XenAdmin.Controls.NetworkComboBox.NetworkComboboxItem.
- Create a NetworkComboBoxItem only if needed and assign its name at construction time.
- Add method to select a NetworkComboBoxItem and property to return the SelectedNetwork.
* CA-339233: Do not allow selection of networks while they're locked.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CA-343763: Corrected the handling of VMSS alert priority/severity according to CA-342874.
- Distinguish between warnings and errors.
- Made PolicyAlert derive from MessageAlert to conform with other alert types.
- Replaced EventType column by a simple image column because it adds to clatter
without really offering useful information.
* Correction as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- CP-34862: Do not allow nomination of new master if a pool secret rotation or
other pool operations are in progress.
- CA-292642: Fixed button enablement after resolving VM problem.
- CA-284126: Added button to rescan running VMs on the server.
- Removed annoying, focus stealing, modal action progress dialog. When scanning
for VMs show a spinner on the control instead.
- Fixed crash when the host combobox was updated due to cache changes.
- Logging in an elevated session was happening on the UI thread.
- Show the role elevation dialog before launching the host evacuation dialog or
we end up with showing the user an unpopulated control.
- Stop deriving from animated progress dialog because it makes it difficult to
get the resizing right when adding more controls.
- Stop using the progress bar for the VM solution actions; rely simply on the
action's description and the VM's icon in the gridView.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* Replaced LicenseWarningDialog with a simple WarningDialog.
* Replaced VcpuWarningDialog with a simple WarningDialog.
* Replaced RemoveCrashdumpsWarningDialog with a simple WarningDialog.
* Replaced UsbUsageDialog with a simple WarningDialog.
* Replaced WlbDeleteReportSubscriptionDialog with a simple WarningDialog. Added null checks to event invocation.
* Replaced DisableWlbDialog with a simple Warning dialog.
* Replaced ConnectionRefusedDialog with a simple Error dialog.
* Replaced UserDeviceDialog with a simple Warning dialog.
* Replaced RevertDialog with a simple Warning dialog.
* Removed unused dialogs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Although it may look tidy to log the settings in the OptionsDialogPages that
expose them to the user, in reality it makes for unnecessarily complicated code
design as it places business logic in UI code and mixes the class dependencies.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Replaced remaining instances of SystemIcons. SystemIcons.Information of size
32x32 were excepted as we don't have the right size icon yet.
- The question mark icon is used for help, not for asking questions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, stop boxing Bitmap into Image so as to avoid casting wherever it is called.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Added controls to display the error in case authentication fails.
- Use the same control(LinkLabel) to show the rubric either when new
authentication is needed or an existing one can be used.
- Moved privacy policy statement next to the checkbox because it looked crammed.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
The result was that numbers were changing suddenly; in cases of slow connections,
a user could make a selection before the scan was over.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Simplified SudoElevationResult.
- Renamed SudoDialogDelegate to ElevatedSessionDelegate so that it makes more sense
for projects not referencing WinForms.
- Call directly the RoleElevationDialog within XenAdmin without using the ElevatedSessionDelegate.
- Minor modernisation in AsyncAction.
- Launch GraphDetailsDialog in a using block.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
This fixes various workflow bugs and disallows re-attaching GFS2 SR if clustering
is disabled.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, merged the methods calculating the virtualisation status and its friendly
string so as to simplify the logic.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Override the polymorphic methods of XenTabPage on the ballooning wizard;
No need to exposed the memory values outside the VMMemoryControlsEdit class.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Replace with help links where necessary or convenient. Also:
- Registered unused event.
- Minor refactoring to: make the InstallToolsCommand.CanExecute clearer; use
local methods.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- It was not possible to apply different settings to multiple hosts
at the same time.
- Server calls were made on the UI thread.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Otherwise the connection dialog remains open even after a connection that required
entering a new password succeeded.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Handle validation for OVF files with a name different from the containing
OVA package. Other corrections to wrong validation logic.
- Show validation warnings on a dialog that can be turned off.
- Clean up extracted files after an OVA package has been imported.
- Plus code refactoring and simplification.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Removed AsyncServerTime class as it adds complexity and the risk of
getting an outdated time.
- Simplified event signatures and compacted nested method calls.
- Fixed typo and removed unused code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Use the base class connection property instead of an own field.
- Do not fix fonts an window location; it's done in the parent class.
- Corrected event registration and duplicate handling.
- Launch modal forms in using blocks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Fixed button enablement on the IntraPoolCopy page.
- Regression on the NewDiskDialog were selection was considered valid
even if the SR was disabled.The SrSelectionChanged and SelectedIndexChanged
were fired in the wrong order. To fix this the event SrSelectionChanged
is removed (in reality after the refactoring in 5b79b1dc94
it became obsolete).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Check for the module existence when the process is created, not when
loading the plugin.
- Removed snapin max and min version as the specification documents them
as not implemented (CA-40580).
- Refactored Registry class to avoid code repetition and ensure that all
opened keys are closed.
- Added null checks and compacted the code parsing the plugin xml.
- Modernized properties.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, compacted the code parsing command line parameters; removed class
and cli option MessageBoxTest as it adds to code complexity, plus that
the application is not meant to be used as testing infrastructure.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Removed DebugHelp. The user settings are normally not meant for debugging code.
- Moved HelpId logic from the main window to the tab pages.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, corrected the RBAC permission check after stopping using the conversion plugin.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Poll for the appliance version because the service may take a while to
start after an IP address is obtained.
- More flexible IP address look up.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
