Commit Graph

3617 Commits

Author SHA1 Message Date
mcintyre94
7f2ecb6eab [CA-233454] PVS tab doesn't show a new VM when it's created (#1314)
* [CA-233454] PVS tab doesn't show a new VM when it's created

Refined the rules for not adding a VM to the table, if it is a template (thus not_a_real_vm), and it has the __gui__ prefix (thus hidden), we still add it, but hide it.
When its name is changed (to remove the __gui__ prefix), we update its name and re-calculate whether it should be visible (in the case of a new VM this will be true once the __gui__ prefix is gone). Also resort the table if a node changes from hidden to visible, because it appears as an addition to the table.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

* [CA-233454] Update criteria for VM visibility to include is_a_real_vm

is_a_template is changed before the name_label removes the __gui__ prefix, so this works with no other changes to the vm property changed event.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

* [CA-233454] Update when the VMs are shown in the PVS list

New observable property IsBeingCreated for VMs, set to true when they're made a hidden object, and false when they're removed from hidden objects (both in CreateVMAction). In the PVS Page when this is set to false, we re-evaluate whether a VM can be shown. This means that new VMs show here at the same time they're added to the tree (only different is tree refresh time), instead of far earlier (and before their networks were added).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

* [CA-233454] Set IsbeingCreated in the CreateVMFastAction

* [CA-233454] Properly support the VM Fast Create action

Further changes to CreateVMFastAction, to ensure it works with PVS tab - use the __gui__ prefix when the VM is created and then change it back just before showing.

* [CA-233454] Small logic adjustments/tidying up
2016-11-30 12:24:02 +00:00
Konstantina Chremmou
b3c558d246 Stop creating the isos. Restructured output.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-11-30 01:35:52 +00:00
Konstantina Chremmou
3a4191bc34 Removed ref repo.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-11-29 16:04:06 +00:00
Mihaela Stoica
185e9b952b Merge pull request #1318 from kc284/vnc
Removed loose .pdb files. Package the VNCControl.msi as a tar.bz2.
2016-11-29 16:00:58 +00:00
Konstantina Chremmou
57b2a6e7ec Package the VNCControl.msi as a tar.bz2.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-11-29 14:34:45 +00:00
Konstantina Chremmou
039c052e32 Remove loose pdb files from the output as they are now packaged.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-11-29 14:31:43 +00:00
mcintyre94
dea71a0afe Merge pull request #1316 from kc284/remove-ref
Switched repo for xenadmin-branding from hg.uk to bitbucket
2016-11-28 13:02:17 +00:00
Konstantina Chremmou
0f7df22f4d Changed the location of the branding repo.
Corrected code reverting to trunk if this is not an official branch.
2016-11-28 10:57:12 +00:00
Konstantina Chremmou
c0e4babed7 Refactored duplicate check for the SKIP_TESTS variable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-11-25 18:22:49 +00:00
Gabor Apati-Nagy
9c4628f216 CA-229365: Install Update Wizard: Fixed commas in the blurb
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-25 17:40:15 +00:00
Mihaela Stoica
0cdce9dfaf Merge pull request #1311 from GaborApatiNagy/master_CA-232294
CA-232294: Can't connect if an Add Server dialog has been cancelled before
2016-11-25 15:27:24 +00:00
Mihaela Stoica
ba62aa9aa2 Merge pull request #1313 from GaborApatiNagy/CA-232944
CA-232944: Displaying server name as well
2016-11-25 14:22:54 +00:00
Gabor Apati-Nagy
a71e0e9f3d CA-232944: Displaying server name as well
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-25 14:18:40 +00:00
Gabor Apati-Nagy
8160066d29 CA-232944: Displaying server name as well
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-25 10:47:40 +00:00
Mihaela Stoica
c437d10bc8 Merge pull request #1310 from mcintyre94/CA-232963
[CA-232963] XC hangs after restarting toolstack while viewing PVS tab
2016-11-24 17:17:33 +00:00
Gabor Apati-Nagy
0c07daf42d CA-232294: Can't connect if an Add Server dialog has been cancelled before
This commit is to fix the following: "when right clicking a disconnected pool the context menu gives you the option to connect, this opens a window to enter credentials. if you close this window (either by cancel or the X), next time when you right click and click connect, nothing happens. you have to restart XenCenter to connect to the pool"

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-24 17:01:53 +00:00
Stephen Turner
526a8372eb Merge pull request #1309 from MihaelaStoica/CP-17276
CP-17276: Out of Memory exception when XenCenter exceeds the maximum …
2016-11-24 16:59:44 +00:00
Callum McIntyre
1046cf2fb8 [CA-232963] XC hangs after restarting toolstack while viewing PVS tab
Changed the collection handlers to use ProgramInvokeHandler in the same way as other tabs, instead of Program.Invoke which caused the hang.
2016-11-24 16:51:48 +00:00
Mihaela Stoica
6f28a7bfb1 CP-17276: Out of Memory exception when XenCenter exceeds the maximum number of GDI handles
Changed the tree builder so that the tree nodes rely on the TreeView's font. If the nodes have their NodeFont != null, then a tree update causes new fonts to be generated for each node and when fonts are being created faster than they could be cleaned up, we reach the GLI handles limit of 10000 (which causes the Out of Memory exception).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-24 16:35:51 +00:00
Mihaela Stoica
0c05feb8cf Merge pull request #1308 from GaborApatiNagy/master
CA-229009: VDI is not deleted for the updates
2016-11-24 10:50:28 +00:00
Gabor Apati-Nagy
5cd032525c CA-229009: VDI is not deleted for the updates
If batch updating fails in a pool, this code will do the clean up by
running the appropriate (next in the queue) RemoveUpdateFilesFromMaster action. In addition to Pool_update.clean(), Pool_update.destroy() will be called when needed.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-24 10:40:06 +00:00
Mihaela Stoica
ad5669e718 Merge pull request #1280 from mcintyre94/CA-149812
[CA-149812] EN: Duplicate hotkeys about “Dismiss All” and “Dismiss Selected" tabs.
2016-11-24 10:15:13 +00:00
Mihaela Stoica
f05ca9e21f Merge pull request #1286 from mcintyre94/CA-227813
[CA-227813] Fixing some messages
2016-11-24 10:14:23 +00:00
Gabor Apati-Nagy
d2f36ca538 Merge pull request #1305 from MihaelaStoica/master
CA-233286: Error while running the package-and-sign script
2016-11-23 18:02:18 +00:00
Mihaela Stoica
2ef6bb245c CA-233286: Error while running the package-and-sign script
Use executables from WIX_BIN instead of the default Wix candle/lit/light exes

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-23 16:24:18 +00:00
Gabor Apati-Nagy
0c5194c57c Merge pull request #1304 from kc284/remove-ref
Output the installers unpacked alongside the packed versions.
2016-11-22 16:00:25 +00:00
Konstantina Chremmou
37a45934e2 Output the installers unpacked alongside the packed versions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-11-22 11:29:40 +00:00
Konstantina Chremmou
e4999ef618 Merge pull request #1297 from mcintyre94/CA-148763
[CA-148763] Add hotkeys to "Apply" and "Add new Server" dialog buttons
2016-11-21 12:22:39 +00:00
Konstantina Chremmou
446a17d76a Merge pull request #1299 from mcintyre94/CA-150027
[CA-150027] Missing hotkey for “Rolling Pool Upgrade…” after right cl…
2016-11-21 12:00:00 +00:00
Mihaela Stoica
8f40550655 Merge pull request #1301 from kc284/build
Restored falling back to trunk for xenadmin until we switch the brand…
2016-11-18 11:31:42 +00:00
Konstantina Chremmou
571ebf9cce Restored falling back to trunk for xenadmin until we switch the branding repos to a different internal location.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-11-18 11:29:06 +00:00
Konstantina Chremmou
b18c982531 Merge pull request #1300 from kc284/build
Get the git branch from the environment variable and do not fall back…
2016-11-18 00:34:54 +00:00
Konstantina Chremmou
dfad3217dc Get the git branch from the environment variable and do not fall back to trunk
if it can't be found.Use GIT_LOCAL_BRANCH instead of GIT_BRANCH to retrieve the
branch name without the remote.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-11-18 00:15:47 +00:00
Callum McIntyre
2d9969bba1 [CA-150027] Missing hotkey for “Rolling Pool Upgrade…” after right clicking Pool.
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-17 17:07:47 +00:00
Callum McIntyre
c512fe8542 [CA-149812] Set Dismiss All as the default option on Updates page 2016-11-17 15:35:27 +00:00
Konstantina Chremmou
2e6b2d8995 CA-145890: added new Page to the options dialog where the user can configure how
confirmations are displayed. Added checkboxes to the dialogs requesting confirmation
of dismissal of notifications so the user can opt to skip this step.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-11-17 13:35:31 +00:00
Callum McIntyre
2a21e9ee97 Revert "[CA-227813] Update WLB_ERROR_4021"
This reverts commit 13c04c1286.

Previous message was fine, changing it back.
2016-11-17 12:03:12 +00:00
Callum McIntyre
480f518825 [CA-148763] Add hotkeys to "Apply" and "Add new Server" dialog buttons 2016-11-17 11:47:51 +00:00
Stephen Turner
bb81024fd6 Merge pull request #1295 from ushamandya/master
Adding a new topic for PVS Read Cache
2016-11-16 16:05:34 +00:00
Usha Mandya
a15d09dab8 Adding a new topic for PVS Read Cache 2016-11-16 14:52:01 +00:00
Gabor Apati-Nagy
53659d0ed1 Merge pull request #1294 from MihaelaStoica/master
Sort Messages.resx
2016-11-16 13:56:58 +00:00
Mihaela Stoica
0ca11798e4 Merge pull request #1293 from GaborApatiNagy/CA-230461
CA-230461: NullReferenceException during batch update when no check-for-updates has been performed
2016-11-16 13:56:10 +00:00
Gabor Apati-Nagy
838303b3b3 CA-230461: NullReferenceException during batch update when no check-for-updates has been performed
Removed unneeded overload and it's usage

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-16 13:53:29 +00:00
Mihaela Stoica
600ab2418e Merge pull request #1291 from kc284/build
Tidy up the pdb files in an archive (todo: remove them once the main …
2016-11-16 12:38:00 +00:00
Mihaela Stoica
3d00db7264 Sort Messages.resx
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-16 12:35:09 +00:00
Gabor Apati-Nagy
34169dd256 CA-230461: NullReferenceException during batch update when no check-for-updates has been performed
Much better way to update/download the CFU

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-16 12:26:26 +00:00
Konstantina Chremmou
518f542e06 Tidy up the pdb files in an archive (todo: remove them once the main build system
has started consuming the tar). Leave spell check only in the production build.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-11-15 15:41:11 +00:00
Mihaela Stoica
6d85457e6d Merge pull request #1288 from mcintyre94/CA-229350
[CA-229350] PVS allows Memory Only even when no control domain memory available
2016-11-15 13:03:32 +00:00
Mihaela Stoica
a4953f9502 Merge pull request #1285 from stephen-turner/CA-218719
CA-218719: Context menu: confusing "(empty)" pool item when there are…
2016-11-15 12:47:30 +00:00
Callum McIntyre
8e542c199f [CA-229350] Correct the minimum dom0 memory required to enable Memory Only 2016-11-15 12:19:43 +00:00