* CA-274082: Check status of SR uploaded updates during update installation
* fix review comments
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
us a lot of broken builds. Fixed bug where the HostPlanAction.CurrentHost was
always null (as the private field was never set).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
PageLoaded override in derived classes, enforce it by wrapping the page specific
code in a new virtual method, which the derived classes can override and PageLoaded
can call after its own logic.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
override in derived classes, enforce it by wrapping the page specific code in
a new virtual method, which the derived classes can override and PageLeave can
call before its own logic.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
WizardContentUpdater is invoked and information flows from the SelectInstallMethod
page to the following pages.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
happen for calls returning a XenRef<T> when the server is using the JsonRpc
v1.0 and we have an error, in which case the result is null. Similarly, return
DateTime.MinValue when the datetime string is null (or in general unparasable).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
For this purpose, the evacuate-reboot-bringbabiesback triplet was replaced by a
new RestartHostPlanAction, which allows fallback to toolstack restart if live
patching has succeeded. Also, created new abstract class HostPlanAction to
reduce code duplication.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
List in order to enforce the order of checks (the Dictionary is not guaranteed to
keep the order the items are added). Also, extra null check.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
in the Host extensions. Moved method TryResolveWithTimeout to the Connection class
where it is more relevant. Removed wrapper methods WaitForReboot and WaitForAgent
as they were not particularly useful.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
alongside the wizard progress buttons. For this purpose, the separate UpdateControls
method was removed and the logic was moved in the EnableNext method. The OnPageUpdated
method that fires this is now called every time the checks start.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also fixed regression within the Masrshalling methods to account for null
values, however I did not reinstate the checks for keys, because Hashtable
returns null if the key does not exist instead of throwing an exception.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CA-283656: Linked SM and SR
* CA-283656: Checks new SR_MULTIPATHABLE capability
* CA-283656: Changed properties into methods
* CA-283656: Change key
Signed-off-by: serenc <seren.corbett@citrix.com>
and only update the necessary fields from the OVF values; this is preferrable
to using the constructor from the Hashtable because the latter requires
unnecessary conversions to and from strings, and also fields missing from the
Hashtable are reset to null. Hardcoded strings are also error prone: the VBD
class does not have any field such as 'attachable' or 'vm_name_label' and the
fields 'storage-lock' and 'status-code' are in reality called 'storage_lock'
and 'status_code'.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- a new method to update an object from a Hashtable setting only the fields
contained in the Hashtable.
- an improvement on the class constructor from Hashtable whereby the fields
are initialised and only the ones contained in the Hashtable are set (this
is also an improvement towards CA-97777).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
instead of using the constructor from the Hashtable because this requires
unnecessary conversions to and from strings, and also fields missing from the
Hashtable are reset to null. Hardcoded strings are also error prone: the VBD
class does not have fields such as 'attachable' or 'vm_name_label'.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
instead of using the constructor from the Hashtable because this requires
unnecessary conversions to and from strings, and also fields missing from the
Hashtable are reset to null. Hardcoded strings are also error prone: the VDI
class has the field 'sharable', not 'shareable'.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
instead of using the constructor from the Hashtable because this requires
unnecessary conversions to and from strings and also fields missing from the
Hashtable are reset to null.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- no need to register the XenObjects events with the ArchiveMaintainer since
what the handler does is not specific to this class; this can be done on the
Performance page where the events are also registered.
- set directly the ArchiveMaintainer's XenObject to the new value without
setting it intermediately to null as this causes a full data download event
if the object has not changed.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
