Commit Graph

979 Commits

Author SHA1 Message Date
Konstantina Chremmou
307b97e1d6 Refactored the Command Enabled|Disabled Tooltip to avoid multiple calculation of whether the command can be executed.
Also, use CommandButtons instead of normal buttons on the SrStorage TabPage.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-10 23:44:21 +00:00
Konstantina Chremmou
0598e6342d Merge remote-tracking branch 'upstream/master' into feature/REQ-797 2021-01-19 11:01:02 +00:00
Konstantina Chremmou
e325548a75 CA-349836: Reworked handling of manifest and signature for appliance import/export.
- Moved the code to the ExportApplianceAction so it's easier to modify the
  action's description.
- Fixed issue where the user's option for adding signature/manifest to a plain
  OVF package was ignored.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-18 01:34:25 +00:00
Konstantina Chremmou
4f564979e1 CA-345349: Verify the exported disk using DiscUtils and fail the whole export if one disk export failure occurs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-13 14:34:15 +01:00
Konstantina Chremmou
38c88b5692 CA-64500: Offer the option to start the vApp or VM automatically after an OVF/OVA import.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-13 14:34:15 +01:00
Konstantina Chremmou
1e6197022e
CA-339233: Do not allow selection of networks while they're locked. (#2733)
* Hid properties from the designer and renamed them because they give the wrong impression.
* Fixed some inefficiencies around the NetworkComboboxItem.
- Move NetworkComboBoxItem into the NetworkComboBox class.
- Moved XenAdmin.Dialogs.NetworkComboBoxItem into the VIFDialog class and made it
  private to avoid ambiguousness with the public XenAdmin.Controls.NetworkComboBox.NetworkComboboxItem.
- Create a NetworkComboBoxItem only if needed and assign its name at construction time.
- Add method to select a NetworkComboBoxItem and property to return the SelectedNetwork.
* CA-339233: Do not allow selection of networks while they're locked.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:34:03 +01:00
Konstantina Chremmou
6f44821e40 Import refactoring 4: Simplifications and corrections, including:
- Improvements to progress reporting (CA-65894).
- Added some logging.
- Use the connection cache instead of making server calls.
- Moved some methods to the string utilities and added unit tests.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
42b06251bc Export refactoring 4: Some improvements to progress reporting (CA-65894). Added some logging.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
23892df15d Moved the OVF actions to XenModel and removed what was left from XenOvfTransport.
Previously this was not possible due to XenModel-XenOvfTransport cyclical references.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
18c407d992 Removed controls for Transfer VM configuration.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
e3d6db3a80 Removed support for long retired XVA v1 packages.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
25b61ea129
CA-343763: Corrected the handling of VMSS alert priority/severity according to CA-342874. (#2730)
* CA-343763: Corrected the handling of VMSS alert priority/severity according to CA-342874.

- Distinguish between warnings and errors.
- Made PolicyAlert derive from MessageAlert to conform with other alert types.
- Replaced EventType column by a simple image column because it adds to clatter
  without really offering useful information.

* Correction as per code review.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-06 14:51:14 +01:00
Konstantina Chremmou
d93e40065a Various fixes on the EvacuateHostDialog (includes CA-292642, CA-284126, CP-34862).
- CP-34862: Do not allow nomination of new master if a pool secret rotation or
  other pool operations are in progress.
- CA-292642: Fixed button enablement after resolving VM problem.
- CA-284126: Added button to rescan running VMs on the server.
- Removed annoying, focus stealing, modal action progress dialog. When scanning
  for VMs show a spinner on the control instead.
- Fixed crash when the host combobox was updated due to cache changes.
- Logging in an elevated session was happening on the UI thread.
- Show the role elevation dialog before launching the host evacuation dialog or
  we end up with showing the user an unpopulated control.
- Stop deriving from animated progress dialog because it makes it difficult to
  get the resizing right when adding more controls.
- Stop using the progress bar for the VM solution actions; rely simply on the
  action's description and the VM's icon in the gridView.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-06 11:27:32 +01:00
Konstantina Chremmou
b34a5d54cf CP-34862: Do not allow enabling HA when a pool secret rotation is pending.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-06 11:27:32 +01:00
Konstantina Chremmou
f3da384a6a Configuring HA on the TabPage should offer the same UX as when using the Menu Items.
- Use CommandButtons on the HA TabPage for configuring/disabling HA.
- Added menu item to disable HA.
- There is no point in hiding the buttons on the HA TabPage when the corresponding
  menu items are available. They should rather offer the same user experience.
- Added RBAC page to the HaWizard to avoid unnecessary SR scanning only to be told
  that one cannot proceed.
- Show RBAC error dialog if the user does not have permission to launch the
  EditVmPriorities dialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-06 11:27:32 +01:00
Konstantina Chremmou
db7582a397 CP-34862: Do not allow enabling clustering when a pool secret rotation is pending.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-06 11:27:32 +01:00
Konstantina Chremmou
aec6b395ff CA-343956: Fixed issues on the VM storage TabPage:
- Disabled button tooltips did not disappear when the DataGridView selection was cleared.
- The disabled Activate/Deactivate button had no tooltip for template disks.
- Minor improvement to the tooltip of the Delete button.
- The Add button was using the enablement logic of the AttachVirtualDiskCommand.
- Use CommandButtons to avoid logic duplication.
- Hide the CommandButton.Command from the designer as it's mostly assigned programmatically.
- Increased the minimum width of the non-autosizable columns so they remain visible.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-02 11:59:55 +01:00
Konstantina Chremmou
c4754c0251 Removed exception that was never thrown (referring to obsolete licensing restriction).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-09-08 10:34:08 +01:00
Konstantina Chremmou
822394597f Corrected button text. Fixed duplicate hotkey in the host right click menu.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-08-24 16:49:23 +01:00
Konstantina Chremmou
e3896239df CA-339305: XenCenter was hanging when update alerts were removed very fast, and other issues:
- Use a plain list to store update alerts and, where possible, fire a collection
  change event only after a bulk change and not every time a single object is added
  or removed.
- Fixed issue where dismissed updates were stored in the config of all connected
  pools, even of those where the update did not apply.
- Corrected RBAC checks for update dismissal.
- Fixed enabled state of dismiss buttons.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-08-21 16:08:20 +01:00
Konstantina Chremmou
2e66ec9133 Merge remote-tracking branch 'upstream/master' into feature/REQ-819
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/OptionsPages/SecurityOptionsPage.cs
2020-08-11 13:35:39 +01:00
Konstantina Chremmou
a076cc59a2
Dialog deletion (#2701)
* Replaced LicenseWarningDialog with a simple WarningDialog.
* Replaced VcpuWarningDialog with a simple WarningDialog.
* Replaced RemoveCrashdumpsWarningDialog with a simple WarningDialog.
* Replaced UsbUsageDialog with a simple WarningDialog.
* Replaced WlbDeleteReportSubscriptionDialog with a simple WarningDialog. Added null checks to event invocation.
* Replaced DisableWlbDialog with a simple Warning dialog.
* Replaced ConnectionRefusedDialog with a simple Error dialog.
* Replaced UserDeviceDialog with a simple Warning dialog.
* Replaced RevertDialog with a simple Warning dialog.
* Removed unused dialogs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 11:29:01 +01:00
Konstantina Chremmou
ca3e9c0219 Removed unused SaveSessionCommand and consequently refactored SaveAndRestoreDialog constructor.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 11:27:29 +01:00
Konstantina Chremmou
2755f71dcf CA-341423: Added a new filter value for VMs with only the management agent installed so they can be easier to find.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 10:42:20 +01:00
Konstantina Chremmou
5526a3f7d1 CP-34045: Removed max resolution and max displays columns.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-28 10:01:09 +01:00
Aaron Robson
05c8809539 CP-34000: decimal network and disk access rate unit calculations
Though this was shown in units like kB/s and MB/s (decimal units) it was calculated in
binary terms i.e. 1MB/s was treated as 1024kB/s instead of the expected 1000kB/s.

Updated translations for the units to be of the form 'MB/s' instead of 'MBps'.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2020-07-18 07:55:34 +01:00
Konstantina Chremmou
9d7cf72c78 CP-33781: Added admin exit procedure warnings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-17 16:04:10 +01:00
Konstantina Chremmou
5c1a982659 CP-33771: Added an item to the pool menu for triggering a secret rotation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-17 16:04:10 +01:00
Konstantina Chremmou
db041099ef CA-339271: Improved action description. Also:
Added cancelling ability to MoveVM action; made some simplifications.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-19 14:04:59 +01:00
Talons Lee
b09d3cb8e7 CP-33715: add gooroom os icon
Signed-off-by: Talons Lee <xin.li@citrix.com>
2020-06-15 22:37:50 +01:00
Konstantina Chremmou
d8cbf38cd8 CA-339306: Warn the user that removing a server from a pool removes also domain information.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-19 13:25:53 +01:00
Konstantina Chremmou
fc9d617f27 CA-338830: Pool join checks should not allow slave with enabled clustering to join.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-19 13:25:53 +01:00
Konstantina Chremmou
8a478011d9 CA-339370: Assign the new VM's name at a late stage to reduce duplicate names. Some simplifications.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-19 07:49:23 +01:00
Konstantina Chremmou
bd04229d89 CA-339312: Explain why a host cannot be removed from the pool.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-12 15:27:12 +01:00
Konstantina Chremmou
a84053cf8d CA-337323 : SR.scan on the SrPicker was happening silently without any indication on the UI (enhanced fix for CA-280299).
The result was that numbers were changing suddenly; in cases of slow connections,
a user could make a selection before the scan was over.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-04 14:30:24 +01:00
Konstantina Chremmou
8d6686b63f CA-337280: Creation of GFS2 SRs with CHAP authentication is not supported.
This is also a better fix for CA-335356.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-01 15:27:18 +01:00
Konstantina Chremmou
5927d52349 CA-336024, CA-322705: Rewrote the LVMoISCI frontend of the NewSR wizard
This fixes various workflow bugs and disallows re-attaching GFS2 SR if clustering
is disabled.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-01 15:27:18 +01:00
Konstantina Chremmou
fd497a1370 Added outlook style status labels showing the number of various types of notifications.
The labels are additionally clickable and navigate to the corresponding panel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-30 08:30:30 +01:00
Konstantina Chremmou
0fa374313f Corrected dialog title.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-30 08:30:30 +01:00
Konstantina Chremmou
bf5c66598c Merge remote-tracking branch 'upstream/master' into feature/REQ-716
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.cs
2020-04-29 16:47:48 +01:00
Konstantina Chremmou
17b6c28978 Merged master into feature/REQ-453 and resolved conflicts.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdminTests/UnitTests/TimeUtilTests.cs
#	XenCenterLib/TimeUtil.cs
2020-04-26 04:11:14 +01:00
Konstantina Chremmou
9bf7e80fe9 Merged branch master into feature/REQ-716 and resolved conflicts.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/BallooningDialog.cs
#	XenAdmin/Dialogs/WarningDialogs/InstallToolsWarningDialog.cs
2020-04-24 15:37:01 +01:00
Konstantina Chremmou
d80bbfb151
Merge pull request #2656 from xenserver/feature/read-caching
Merge feature/read-caching branch to master
2020-04-24 11:47:26 +01:00
Konstantina Chremmou
dcc87f4710 CP-32713: Show an error message if the user attempts an update using the base installation ISO.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-22 10:33:22 +01:00
Konstantina Chremmou
cf0da96b87 CA-187943: Revised warning messages to take account the selected affinity.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-20 19:07:31 +01:00
Konstantina Chremmou
d198b693d1 Replaced InstallToolsWarningDialog with a ThreeButtonDialog. Removed methods duplicating command execution logic.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-17 16:23:06 +01:00
Konstantina Chremmou
dfb49c97a1 CP-32687, CP-32689: Remove "Install PV Tools" options from stockholm onwards.
Replace with help links where necessary or convenient. Also:
- Registered unused event.
- Minor refactoring to: make the InstallToolsCommand.CanExecute clearer; use
  local methods.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-17 16:23:06 +01:00
Mihaela Stoica
66d192b1d8 CP-32985: Changes following code review
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2020-04-16 10:26:17 +01:00
Mihaela Stoica
71a09385c3 CP-32985: XenCenter control to turn read caching on / off per SR
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2020-04-16 10:26:17 +01:00
Konstantina Chremmou
c6c725c37d CA-338012: Corrected error messages for RBAC restrictions and intermediate certificate errors.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-15 14:30:00 +01:00