Commit Graph

88 Commits

Author SHA1 Message Date
Konstantina Chremmou
67d1ddd1d1 Merge remote-tracking branch 'upstream/master' into feature/hyperman
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/Branding.resx
#	Jenkinsfile
#	XenAdmin/Alerts/Types/GuiOldAlert.cs
#	XenAdmin/Alerts/Types/LicenseAlert.cs
#	XenAdmin/Commands/RestartToolstackCommand.cs
#	XenAdmin/Diagnostics/Problems/HostProblem/HostNotSafeToUpgradeWarning.cs
#	XenAdmin/Dialogs/AllowUpdatesDialog.cs
#	XenAdmin/Dialogs/OptionsPages/ConfirmationOptionsPage.cs
#	XenAdmin/Dialogs/RepairSRDialog.cs
#	XenAdmin/Dialogs/UpsellDialog.cs
#	XenAdmin/Plugins/UI/TabPageCredentialsDialog.cs
#	XenAdmin/Program.cs
#	XenAdmin/Wizards/ConversionWizard/ConversionNetworkPage.cs
#	XenAdmin/Wizards/CrossPoolMigrateWizard/CrossPoolMigrateDestinationPage.cs
#	XenAdmin/Wizards/NewSRWizard_Pages/SrWizardType.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_FirstPage.cs
#	XenCenterLib/XSVersionAttribute.cs
#	XenModel/BrandManager.cs
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx
2021-05-25 15:51:42 +01:00
Konstantina Chremmou
3f4737c57a Upgraded log4net to 2.0.12.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-09 09:16:01 +01:00
Konstantina Chremmou
abf4ae3f35 CP-36392 pt.1: Removed unused using directives.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-07 10:04:47 +01:00
Konstantina Chremmou
a0e2967792 CP-31105: Replaced the hardcoded name patterns in the resource files with format placeholders.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-31 11:50:32 +01:00
Konstantina Chremmou
c4b076bd97 Removed unused code alongside strings in need of branding.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-31 11:50:32 +01:00
Darren Matthews
a8988276be L10n : Resx resync and translation update
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2021-03-02 09:44:29 +00:00
Konstantina Chremmou
9a5c664eb0 CA-350574: Corrections to signing an appliance.
Also, removed listing of CryptoServiceProviders from the settings.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-01-12 12:14:31 +00:00
Konstantina Chremmou
bbad0e5cf8 Disable schema validation as it shows false warnings for multiple VM appliances.
It thinks that the element VirtualSystem is an invalid child element of
VirtualSystemCollection, which is not the case.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-01-04 16:23:11 +00:00
Konstantina Chremmou
3f5b11048f CA-349855: Reworked the disk validation to prevent false warnings about missing disk linkages.
Also, removed the known file extensions from the Settings because they are not
user or application settings.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-18 01:34:25 +00:00
Konstantina Chremmou
1c4178c7fe CA-347480: Improved ability to cancel an import/export while compressing/uncompressing the files, or packaging into/extracting from an OVA file.
Also, remove another couple of unused methods from the OVF class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-18 01:34:25 +00:00
Konstantina Chremmou
e325548a75 CA-349836: Reworked handling of manifest and signature for appliance import/export.
- Moved the code to the ExportApplianceAction so it's easier to modify the
  action's description.
- Fixed issue where the user's option for adding signature/manifest to a plain
  OVF package was ignored.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-18 01:34:25 +00:00
Konstantina Chremmou
f24a81bd28 CA-89896: Enabled cancellation during OVA packaging/extraction and file compression/decompression.
Also removed some more unused methods.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-13 14:34:15 +01:00
Konstantina Chremmou
6f44821e40 Import refactoring 4: Simplifications and corrections, including:
- Improvements to progress reporting (CA-65894).
- Added some logging.
- Use the connection cache instead of making server calls.
- Moved some methods to the string utilities and added unit tests.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
e3d6db3a80 Removed support for long retired XVA v1 packages.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
cdd650d40e Fixed 3rd party library references in the solution project files.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-09-08 10:34:08 +01:00
Konstantina Chremmou
d045d180a0
Merge pull request #2696 from xenserver/master
Bring branch dotnet48 up to date with master
2020-06-15 15:43:52 +01:00
Konstantina Chremmou
6dde286cc5 Stop suppressing code analysis messages.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-22 00:19:40 +01:00
Konstantina Chremmou
41afa2a753 CP-32921: Target .NET Framework 4.8 and build using VS2019 tools.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-19 23:10:41 +01:00
Konstantina Chremmou
9e458373b0 Missing copyright; typos found from spell check; added terms to ignore list.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-04 12:40:20 +00:00
Konstantina Chremmou
1bcec343f1 Merge remote-tracking branch 'upstream/feature/REQ-803' 2020-02-13 11:43:17 +00:00
Darren Matthews
07d475b6cd L10N : Translation update and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-02-03 13:51:15 +00:00
Konstantina Chremmou
576d2d5a83 CA-271455 regression: clean temporary OVF packages extracted from OVAs, but not original OVF packages.
Also, remove obsolete lines that delete touch files (they are not created any more).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-29 10:07:36 +00:00
Konstantina Chremmou
f7391e991b
CA-156873, CP-31105 (partial): Apply common branding and versioning to assemblies; branding refactoring
Added brand management files and refactored the following brand variables:
* BRANDING_XENSERVER_UPDATE_URL
* BRANDING_PERF_ALERT_MAIL_LANGUAGE_DEFAULT
* BRANDING_SEARCH
* BRANDING_UPDATE
* BRANDING_BACKUP
* BRANDING_LEGACY_PRODUCT_BRAND
* ISO
* BRANDING_VERSION_5_6
* BRANDING_VERSION_6_2
* BRANDING_VERSION_6_0
* BRANDING_VERSION_6_5
* BRANDING_VERSION_7_0
* BRANDING_VERSION_7_1_2
* BRANDING_VERSION_8_0
* BRANDING_VERSION_8_1
* BRANDIND_COPYRIGHT
* BRANDING_COPYRIGHT_2

Also: Try passing the timestamp server as parameter
2020-01-22 14:47:39 +00:00
Konstantina Chremmou
bfc8141391 CA-318468, CA-271455: Reworked OVF validation and OVA package extraction during import.
- Handle validation for OVF files with a name different from the containing
  OVA package. Other corrections to wrong validation logic.
- Show validation warnings on a dialog that can be turned off.
- Clean up extracted files after an OVA package has been imported.
- Plus code refactoring and simplification.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-16 16:26:30 +00:00
Konstantina Chremmou
072397ac2a Refactoring and deletion of dead code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
ed30f1e3c3 Do not use audit or trace log.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
667e9e8caf Log the stack trace when an exception is encountered and don't use the *Format() counterpart of the logging method for it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
fad80c778b Avoid duplicate logging; compact multiple logging calls.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
f4265732ca Do not localise log entries or ellipsise names. Log exception stack traces where applicable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Lin Liu
eb309a1af2 CA-329435: Multiple vGPU settings are not preserved when importing OVA/OVF format file
Signed-off-by: Lin Liu <lin.liu@citrix.com>
2019-11-07 09:49:54 +00:00
Konstantina Chremmou
94beeb8f28 CA-329436: Prevent OVF import from crashing when the HardwareVirtualSection>System section lacks a VirtualSystemType tag.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-24 09:19:22 +01:00
Mihaela Stoica
8b41a214b2
Merge pull request #2521 from xenserver/feature/REQ-756
Merge feature/REQ-756 into master
2019-09-27 13:18:21 +01:00
Darren Matthews
4a3fd35b51 L10N: Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-09-25 15:17:19 +01:00
Konstantina Chremmou
ca72f25ebe Merge remote-tracking branch 'upstream/master' into feature/REQ-756
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.Designer.cs
#	XenAdmin/MainWindow.resx
#	XenAdmin/Properties/Resources.resx
2019-09-13 13:17:32 +01:00
Konstantina Chremmou
d22b212afa Renamed property as there are clashes with a child class (will have to be refactored in future). Treat warnings as errors in all projects.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-22 14:03:30 +01:00
Konstantina Chremmou
bf6f06457e Added travis file so as to run developer checks on PRs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-15 14:31:06 +01:00
Konstantina Chremmou
e0b9a68b40 Replaced check-roaming.sh tool with an Nunit test and expanded it to include more assemblies.
Corrected the scope of two OvfApi settings as a result of the test run.
Also, sync-ed settings and app.config for XenOvfApi and XenOvfapiTransport.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-15 14:31:06 +01:00
Konstantina Chremmou
57b8d8f5cb Do not expose the Ovf project's settings to the other projects in the solution.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-14 11:07:16 +01:00
Konstantina Chremmou
0024bb9f09 Removed almost 500 lines of empty xml docs. Fixed enum docs and typos.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-14 11:07:16 +01:00
Konstantina Chremmou
536cb18837 CA-322526: Made the ImportOptions page sensitive to PBD changes in the cache. Improved combobox selection functionality.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-14 11:07:16 +01:00
Konstantina Chremmou
fd95530e4f CA-294511: Rewrote the OVA appliance abstraction class to include:
- Verification of appliance files in chunks to avoid StreamTooLong exception.
- Disposal of HashAlgorithms and X509Certificates after use.
- General code simplification.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-13 10:18:15 +01:00
Konstantina Chremmou
4844bac1e8 CP-30451: Unit test restructuring and modifications for better use of the Nunit3 framework.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 16:34:59 +01:00
Konstantina Chremmou
a3731ecef7 Removed empty resource files.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-31 15:24:28 +00:00
Darren Matthews
0f6f7c0ec4 L10N: Translation updates and resx resync (#2363)
L10N: Translation updates and resx resync

Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-01-10 14:03:27 +00:00
Mihaela Stoica
703630ea36 Merge remote-tracking branch 'upstream/master' into feature/REQ-396
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenAdmin/Alerts/Types/MessageAlert.cs
#	XenModel/XenAPI/Message.cs
#	XenModel/XenAPI/VM.cs
2018-12-12 16:02:03 +00:00
Aaron Robson
6353043b15 CP-27819: Switch to Visual Studio 2017 (into master) (#2305)
* CP-27819: Manually setting the ToolsVersion to 15.0 (VS2017) in all .csproj files for consistency and to attempt to enforce consistency of dev environments with the explicitness of the msbuild scripts as used in the build environments.
Auto updated as many of the .sln and .csproj files as VS2017 was willing to do https://docs.microsoft.com/en-us/visualstudio/ide/reference/upgrade-devenv-exe?view=vs-2017 and included changes to the gitignore to ensure that the update report and backup files are not included in the repo.

* CP-27819: Tidying up by removing FileUpgradeFlags, OldToolsVersion and UpgradeBackupLocation nodes from the .csproj files as they are produced as hints for how to revert project upgrades for which we can use version control.

* CP-27819: Removing redundant "ManifestCertificateThumbprint" and "ManifestTimestampUrl" nodes from project files "mk\sign.bat" has been used for this purpose for some time now.

* CP-27819: Updated readme to reflect that VS2017 is now in use.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-09 11:23:32 +00:00
Aaron Robson
fbb8864a51
Merge pull request #2276 from xenserver/master
Merge master into feature branch
2018-10-18 15:08:54 +01:00
Darren Matthews
2ce509efb3 L10N: Translation updates along with Interface resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-28 14:00:14 +01:00
Tim Liu
25c0787238 CP-28677: XC: Exported OVFs contain UEFI metadata
1. Add count check
2. Refine the code by linq (both export & import)
3. Create new desc rather than using the generic one
4. Add backward compatibility when importing

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-28 10:42:48 +01:00
Tim Liu
92d786d051 CP-28677: XC: Exported OVFs contain UEFI metadata
Extended xenBootOrder to xenBootParams

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-28 10:42:48 +01:00