Commit Graph

2813 Commits

Author SHA1 Message Date
Mihaela Stoica
66eab6d8cb Merge pull request #1384 from letsboogey/master
CA-169475 - G11n: SC&JA: Didn't provide AM/PM on date info under “Cre…
2017-01-17 12:47:47 +00:00
Letsibogo Ramadi
d83bc64cef CA-169475 - G11n: SC&JA: Didn't provide AM/PM on date info under “Created On” list
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-17 10:37:55 +00:00
Sharath Babu
866968c063 CA-227792: unable to change policy type and modify VMs list at the same time
Signed-Off-by: Sharath Babu <sharath.babu@citrix.com>
2017-01-17 12:02:54 +05:30
Gabor Apati-Nagy
978f85233c CA-176169: Added copyright statement to files which it was missing from
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-16 20:14:56 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Mihaela Stoica
27a2a1d88c Merge pull request #1380 from letsboogey/master
CA-148598 - EN: Missing and duplicate hotkeys on "Alerts" pane under …
2017-01-16 16:28:05 +00:00
Letsibogo Ramadi
75db446168 CA-151449 - EN: Missing hotkeys on Pool Properties ->GPU wizard.
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-16 15:08:58 +00:00
Letsibogo Ramadi
c7f5dd90d1 CA-148598 - EN: Missing and duplicate hotkeys on "Alerts" pane under Server Properties dialog.
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-16 13:41:40 +00:00
Konstantina Chremmou
9b9d0bb353 Merge pull request #1354 from GaborApatiNagy/master
CA-214628: .NET Image limit causes exception
2017-01-16 11:47:13 +00:00
Usha Mandya
e82d26fd7e Merge branch 'master' of https://github.com/xenserver/xenadmin 2017-01-12 15:02:34 +00:00
Usha Mandya
5906581df3 Minor update to the RBAC topic 2017-01-12 14:51:32 +00:00
sri harsha tagore k
cb0a0e2267 L10N:Translations check-ins 2017-01-12 13:22:48 +00:00
Gabor Apati-Nagy
a1a411b9df CA-214628: .NET Image limit causes exception
Further changes

* implemented similar logic for the Commands too as those are keep on getting updates so affected
* moved these static fields to a class (at Images)
* used the same casing as in Resources once they have been moved

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-11 13:56:45 +00:00
Mihaela Stoica
84df0d5f80 CA-239210: Fixed the tab order on the Select Servers page
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-11 11:48:58 +00:00
Mihaela Stoica
b418a8a170 CA-226900: Do not allow selection of individual pool members when installing a hotfix
This change does not apply to supplemental packs, as we should be able to install supp packs to individual hosts in a pool.
Also, if the wizard is installing an update from disk and we cannot match it in updates.xml, then we will continue to allow host selection, because we can't tell whether it is a supp pack or a hotfix.

Plus fixing the bug where the "Select All" button is enabled even when all the selectable servers/pools are selected

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-11 11:32:57 +00:00
Usha Mandya
387492fff1 CP-20269: Updated XC Help to accommodate PVS feature name change 2017-01-09 15:23:40 +00:00
sri harsha tagore k
08edd54ac1 L10N:Translations check-ins 2017-01-06 12:46:19 +00:00
Mihaela Stoica
3f89610f75 CP-20245: Wording changes for change of feature name to PVS-Accelerator
- changes following the renaming of the RRDs

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-04 14:41:56 +00:00
Mihaela Stoica
e45accbe55 CP-20245: Wording changes for change of feature name to PVS-Accelerator
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-04 14:41:56 +00:00
Frederico Mazzone
f964fa88c6 Merge branch 'master' into CAR-2214
Conflicts:
	XenAdmin/Core/Registry.cs
	XenModel/Actions/Updates/DownloadUpdatesXmlAction.cs
2016-12-23 14:10:43 +00:00
Konstantina Chremmou
cbdf7d3742 Merge pull request #1334 from MihaelaStoica/CA-216752
CA-216752: Not all wizards progress through to the next page by press…
2016-12-22 09:14:29 +00:00
sri harsha tagore k
41335a1ca1 L10N:TRanslations checkins 2016-12-21 16:21:09 +00:00
sri harsha tagore k
fcda47d3a0 L10N:Translations check-ins
Cherry-picked: ff6a3984d5a97313903a4d230bca15e54674976e [ff6a398]
Author: sri harsha tagore k <sriharshatagore.karpurapu@citrix.com>
2016-12-21 16:20:30 +00:00
Gabor Apati-Nagy
5a117334af CA-214628: .NET Image limit causes exception
Changed code at a a few places where it made sense to limit how many times XenCenter asks the Resource Manager for a new instance(*1) of the same(*2) image.
*1: RM returns a new object each time
*2: they are the same as we don't change the locale of a thread and also we don't localise these images - by design

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-21 13:57:50 +00:00
Mihaela Stoica
0115461f66 CA-216752: Not all wizards progress through to the next page by pressing the Enter key
- Added SelectDefaultControl() to more wizard pages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-21 13:33:04 +00:00
Mihaela Stoica
ed4981b5a8 Merge pull request #1348 from GaborApatiNagy/CA-236547
CA-236547: Unexpected error while applying hotfix on multiple Xenservers of different version
2016-12-21 11:32:28 +00:00
Gabor Apati-Nagy
7ce6d50ed0 CA-236547: Unexpected error while applying hotfix on multiple Xenservers of different version
Reset both before any upload as the upload is going to set the correct one anyway

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-21 10:37:06 +00:00
Mihaela Stoica
eecec89a08 Merge pull request #1352 from GaborApatiNagy/CA-234494
CA-234494: System template cross-pool copy fails with Internal error:assert_can_migrate: inter_pool_metadata_transfer returned nonempty list
2016-12-20 16:19:02 +00:00
Gabor Apati-Nagy
06812f4da1 CA-234494: System template cross-pool copy fails with Internal error: assert_can_migrate: inter_pool_metadata_transfer returned nonempty list
Added a check for default_template as a workaround an issue where the allowed_operations of a default template _initially_ indicated that cross pool migration was allowed.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-20 14:30:27 +00:00
Konstantina Chremmou
e176194a06 Merge pull request #1339 from GaborApatiNagy/master_CA-211363
CA-211363: Replace 'User name' labels with 'Username'
2016-12-20 09:44:25 +00:00
Gabor Apati-Nagy
9bd776c83d CA-236547: Unexpected error while applying hotfix on multiple Xenservers of different version
Fixing the error, so the hotfix installation will fail as and where it is expected

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-19 18:00:42 +00:00
Gabor Apati-Nagy
bff70c5c6a CA-211363: Replace 'User name' labels with 'Username'
Second round of renaming

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-16 18:36:35 +00:00
Gabor Apati-Nagy
751ba4956d Merge pull request #1303 from kc284/CA-104329
CA-104329: Removed calculation which might cause lag from the page lo…
2016-12-16 11:13:05 +00:00
sri harsha tagore k
7e13917939 L10N:TRanslations check-ins
CA-235084/CA-235085/CA-235080/CA-235081 fixes
2016-12-16 11:01:53 +00:00
sri harsha tagore k
5bb479ec4e L10N:TRanslations check-in
CA-235023 fix
2016-12-16 10:59:45 +00:00
sri harsha tagore k
c2ef32e1eb L10N:TRanslation check-in
CA-236062 fix
2016-12-16 10:58:07 +00:00
sri harsha tagore k
27b2646071 L10N:Translations check-in
CA-236354 and CA-236060 fix
2016-12-16 10:57:27 +00:00
Gabor Apati-Nagy
c5c2906cb1 Merge pull request #1333 from MihaelaStoica/CA-235381
CA-235381: XenCenter should not allow users to edit the PVS cache sto…
2016-12-13 11:34:54 +00:00
Mihaela Stoica
ce554a7cd3 Merge pull request #1335 from GaborApatiNagy/CP-20065
CP-20065: Change "Automatic Update" to "Automated Updates"
2016-12-13 11:16:04 +00:00
Mihaela Stoica
30c30e85bb CA-235381: XenCenter should not allow users to edit the PVS cache storage if it is in use
- Replaced the information tooltip with a warning icon and label at the bottom of the page.
- Added some null checks

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-13 11:09:23 +00:00
Mihaela Stoica
3b0d7f7c32 Merge pull request #1328 from GaborApatiNagy/CA-207011
CA-207011: Don't allow XC to create more than one SMB ISO SR on the same share
2016-12-13 10:49:05 +00:00
Konstantina Chremmou
f165cef307 CA-104329: Do not re-iterate through the datagridview rows to retrieve the VMs'
restart settings when leaving the page. Get the already calculated value from the
tolerance indicator instead.
2016-12-13 09:10:26 +00:00
Konstantina Chremmou
bad9ef8cca Enforce a minimum size for the groupbox so its title does not appear ellipsized.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-12-13 09:10:26 +00:00
Konstantina Chremmou
38bc4848bb CA-104329: Removed calculation which might cause lag from the page loading step;
have the wizard do it before we get there. Also, replaced the labels in such way
that, if there should be lag, the user will not see the draft message used only
on the designer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-12-13 09:10:26 +00:00
Gabor Apati-Nagy
9d5e71326c CP-20065: Change "Automatic Update" to "Automated Updates"
changed more messages following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-12 18:12:01 +00:00
Usha Mandya
b937945d7a Adding the updated CHM 2016-12-12 11:00:35 +00:00
Gabor Apati-Nagy
5ed6a7c8ff CP-20065: Change "Automatic Update" to "Automated Updates"
more renaming

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-10 15:01:25 +00:00
Gabor Apati-Nagy
b0ca08ae6d CP-20065: Change "Automatic Update" to "Automated Updates"
made naming more consistent

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-10 14:44:15 +00:00
Gabor Apati-Nagy
5b6bedea48 CP-20065: Change "Automatic Update" to "Automated Updates"
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-10 14:19:37 +00:00
Gabor Apati-Nagy
122e6ae012 CA-207011: Don't allow XC to create more than one SMB ISO SR on the same share
fixed the name of a method

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-09 15:27:22 +00:00
Mihaela Stoica
508f638b3a CA-216752: Not all wizards progress through to the next page by pressing the Enter key
- Added a new method in XenTabPage which the derived classes can implement to select a default control after the page is loaded.
- Added a new wizard test that runs through the wizard by pressing the Enter key and checks if it has landed on the right page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-08 14:52:21 +00:00
Mihaela Stoica
1156d57787 CA-235381: XenCenter should not allow users to edit the PVS cache storage if it is in use
- On the PVS Cache Configuration dialog, disable the cache storage fields with an information tooltip stating that this PVS cache storage cannot be changed because it is in use.
- Also set the minimum width for the splitter panels, to avoid display issues when the splitter is moved and either of the panels becomes unusable.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-07 17:45:50 +00:00
Gabor Apati-Nagy
5f24a4e084 CA-211363: Replace 'User name' labels with 'Username'
According to the Microsoft style guide XC to use 'username' for UI fields and use 'user name' when it's being referred to.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-07 11:12:58 +00:00
Gabor Apati-Nagy
517b4cc45b CA-207011: Don't allow XC to create more than one SMB ISO SR on the same share
This commit uses the same logic that is used for NFS ISOs.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-06 11:27:53 +00:00
Gabor Apati-Nagy
5826a87551 Merge pull request #1325 from MihaelaStoica/CA-234827
CA-234827: Destination dropdown menu content is blurred with overlapp…
2016-12-02 16:19:45 +00:00
Mihaela Stoica
1d92986aa7 CA-234827: Added check for ErroDescription.Count
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-02 15:47:42 +00:00
sri harsha tagore k
821f42e1f2 L10N:Translations check-ins 2016-12-02 20:13:49 +05:30
Mihaela Stoica
765dee4fe7 CA-234827: Destination dropdown menu content is blurred with overlapping 'Action: vm.assert_can_migrate' text in Migrate VM wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-02 13:52:32 +00:00
Gabor Apati-Nagy
b56cd8d08a Merge pull request #1321 from MihaelaStoica/CA-234628
CA-234628: Errors with no title in XenCenter
2016-12-02 09:20:40 +00:00
Mihaela Stoica
a1d878725d CA-231500: XenCenter allows you to open multiple windows from change role button
Show the "Change role" dialog as modal. This way we avoid other issues, like removing the user while the "Change role" dialog is open.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-01 17:08:51 +00:00
Mihaela Stoica
f64923cea0 CA-234628: Errors with no title in XenCenter
Set the suppressHistory flag to true for the parallel action that we run periodically to check the Health Check analysis result

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-01 16:23:44 +00:00
Konstantina Chremmou
3e94c6c5c9 CA-145890: switched roaming on for the new settings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-12-01 11:14:01 +00:00
Mihaela Stoica
1aaa310c50 Merge pull request #1287 from kc284/master
CA-145890: added new Page to the options dialog where the user can co…
2016-12-01 09:39:22 +00:00
Mihaela Stoica
a4480df442 Merge pull request #1315 from GaborApatiNagy/CA-229365
CA-229365: Install Update Wizard: Fixed commas in the blurb
2016-11-30 12:53:54 +00:00
mcintyre94
7f2ecb6eab [CA-233454] PVS tab doesn't show a new VM when it's created (#1314)
* [CA-233454] PVS tab doesn't show a new VM when it's created

Refined the rules for not adding a VM to the table, if it is a template (thus not_a_real_vm), and it has the __gui__ prefix (thus hidden), we still add it, but hide it.
When its name is changed (to remove the __gui__ prefix), we update its name and re-calculate whether it should be visible (in the case of a new VM this will be true once the __gui__ prefix is gone). Also resort the table if a node changes from hidden to visible, because it appears as an addition to the table.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

* [CA-233454] Update criteria for VM visibility to include is_a_real_vm

is_a_template is changed before the name_label removes the __gui__ prefix, so this works with no other changes to the vm property changed event.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

* [CA-233454] Update when the VMs are shown in the PVS list

New observable property IsBeingCreated for VMs, set to true when they're made a hidden object, and false when they're removed from hidden objects (both in CreateVMAction). In the PVS Page when this is set to false, we re-evaluate whether a VM can be shown. This means that new VMs show here at the same time they're added to the tree (only different is tree refresh time), instead of far earlier (and before their networks were added).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

* [CA-233454] Set IsbeingCreated in the CreateVMFastAction

* [CA-233454] Properly support the VM Fast Create action

Further changes to CreateVMFastAction, to ensure it works with PVS tab - use the __gui__ prefix when the VM is created and then change it back just before showing.

* [CA-233454] Small logic adjustments/tidying up
2016-11-30 12:24:02 +00:00
Gabor Apati-Nagy
9c4628f216 CA-229365: Install Update Wizard: Fixed commas in the blurb
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-25 17:40:15 +00:00
Mihaela Stoica
0cdce9dfaf Merge pull request #1311 from GaborApatiNagy/master_CA-232294
CA-232294: Can't connect if an Add Server dialog has been cancelled before
2016-11-25 15:27:24 +00:00
Gabor Apati-Nagy
a71e0e9f3d CA-232944: Displaying server name as well
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-25 14:18:40 +00:00
Gabor Apati-Nagy
8160066d29 CA-232944: Displaying server name as well
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-25 10:47:40 +00:00
Mihaela Stoica
c437d10bc8 Merge pull request #1310 from mcintyre94/CA-232963
[CA-232963] XC hangs after restarting toolstack while viewing PVS tab
2016-11-24 17:17:33 +00:00
Gabor Apati-Nagy
0c07daf42d CA-232294: Can't connect if an Add Server dialog has been cancelled before
This commit is to fix the following: "when right clicking a disconnected pool the context menu gives you the option to connect, this opens a window to enter credentials. if you close this window (either by cancel or the X), next time when you right click and click connect, nothing happens. you have to restart XenCenter to connect to the pool"

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-24 17:01:53 +00:00
Callum McIntyre
1046cf2fb8 [CA-232963] XC hangs after restarting toolstack while viewing PVS tab
Changed the collection handlers to use ProgramInvokeHandler in the same way as other tabs, instead of Program.Invoke which caused the hang.
2016-11-24 16:51:48 +00:00
Mihaela Stoica
6f28a7bfb1 CP-17276: Out of Memory exception when XenCenter exceeds the maximum number of GDI handles
Changed the tree builder so that the tree nodes rely on the TreeView's font. If the nodes have their NodeFont != null, then a tree update causes new fonts to be generated for each node and when fonts are being created faster than they could be cleaned up, we reach the GLI handles limit of 10000 (which causes the Out of Memory exception).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-24 16:35:51 +00:00
Gabor Apati-Nagy
5cd032525c CA-229009: VDI is not deleted for the updates
If batch updating fails in a pool, this code will do the clean up by
running the appropriate (next in the queue) RemoveUpdateFilesFromMaster action. In addition to Pool_update.clean(), Pool_update.destroy() will be called when needed.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-24 10:40:06 +00:00
Mihaela Stoica
ad5669e718 Merge pull request #1280 from mcintyre94/CA-149812
[CA-149812] EN: Duplicate hotkeys about “Dismiss All” and “Dismiss Selected" tabs.
2016-11-24 10:15:13 +00:00
Callum McIntyre
c512fe8542 [CA-149812] Set Dismiss All as the default option on Updates page 2016-11-17 15:35:27 +00:00
Konstantina Chremmou
2e6b2d8995 CA-145890: added new Page to the options dialog where the user can configure how
confirmations are displayed. Added checkboxes to the dialogs requesting confirmation
of dismissal of notifications so the user can opt to skip this step.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-11-17 13:35:31 +00:00
Callum McIntyre
480f518825 [CA-148763] Add hotkeys to "Apply" and "Add new Server" dialog buttons 2016-11-17 11:47:51 +00:00
Usha Mandya
a15d09dab8 Adding a new topic for PVS Read Cache 2016-11-16 14:52:01 +00:00
Gabor Apati-Nagy
838303b3b3 CA-230461: NullReferenceException during batch update when no check-for-updates has been performed
Removed unneeded overload and it's usage

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-16 13:53:29 +00:00
Gabor Apati-Nagy
34169dd256 CA-230461: NullReferenceException during batch update when no check-for-updates has been performed
Much better way to update/download the CFU

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-16 12:26:26 +00:00
Mihaela Stoica
6d85457e6d Merge pull request #1288 from mcintyre94/CA-229350
[CA-229350] PVS allows Memory Only even when no control domain memory available
2016-11-15 13:03:32 +00:00
Mihaela Stoica
a4953f9502 Merge pull request #1285 from stephen-turner/CA-218719
CA-218719: Context menu: confusing "(empty)" pool item when there are…
2016-11-15 12:47:30 +00:00
Callum McIntyre
8e542c199f [CA-229350] Correct the minimum dom0 memory required to enable Memory Only 2016-11-15 12:19:43 +00:00
Callum McIntyre
b3e334654f [CA-229350] PVS allows Memory Only even when no control domain memory available
We now disable the Memory Only option if the available dom0 memory is less than the minimum the spinner supports (1Gb)
2016-11-14 14:59:57 +00:00
Mihaela Stoica
ab033700ad Merge pull request #1269 from mcintyre94/CA-228051
[CA-228051] XenCenter allows user to create unusable PVS Proxy cache config
2016-11-11 17:08:13 +00:00
Mihaela Stoica
244b4059b5 Merge pull request #1284 from GaborApatiNagy/master_errormessages
CA-227719: XenCenter to use new pre-check error messages
2016-11-11 17:05:41 +00:00
Stephen Turner
ebd408a227 CA-218719: Context menu: confusing "(empty)" pool item when there are no connected pools 2016-11-11 17:04:08 +00:00
Callum McIntyre
b255b3146b [CA-228051] Add a new string since we still need the "not configured" one, and remove the unused EnableableComboBox change 2016-11-11 17:02:04 +00:00
Callum McIntyre
ce9d8fd409 [CA-228051] XenCenter should notify user if the PVS Cache config is incomplete
Changes as discussed on the ticket: No longer disable the rows when they have a warning in the dialog, support warning about storage configuration as well as PVS configuration, and also include these warnings in the PVS page table.
2016-11-11 17:02:04 +00:00
Callum McIntyre
2edb044b96 [CA-228051] XenCenter allows user to create unusable PVS Proxy cache config
A site's configuration needs to be completed outside of XenCenter, and when it isn't done we shouldn't allow VMs to enable PVS read caching on that site. We now disable sites that aren't configured in the enable read caching dialog, using an EnableableComboBox. I've also changed the DrawMode of that ComboBox component, OwnerDrawFixed more appropriately sizes the dropdown container when the number of items is small.
2016-11-11 17:00:11 +00:00
Gabor Apati-Nagy
1e93481dff CA-227719: XenCenter to use new pre-check error messages
fixed copy paste problem...

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-11 16:47:49 +00:00
Gabor Apati-Nagy
fe828463cf CA-227719: XenCenter to use new pre-check error messages
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-11 16:02:43 +00:00
mcintyre94
081a6302d3 Merge pull request #1273 from MihaelaStoica/CA-148427
CA-148427: XC logs get populated with wrong message even when the use…
2016-11-11 15:30:58 +00:00
Callum McIntyre
fed20f9c41 [CA-149812] Change to D for date, A for all, C for selected. Use same hotkeys on all three of the similar pages. 2016-11-11 14:37:11 +00:00
Mihaela Stoica
91287ce460 Merge pull request #1274 from mcintyre94/CA-228054
[CA-228054] Performance graph datasources aren't sorted naturally
2016-11-11 09:47:54 +00:00
Sharath Babu
6b64efb9a6 CA-213563: VM policy cannot be changed to snapshot with
quiesce after installing vss tools

Enabling snapshot policy type to be changed to quiesce from
other snapshot policy types if the selected VMs are
quiesce snapshot capable.

Signed-off-by: Sharath Babu <sharath.babu@citrix.com>
2016-11-11 06:12:35 +05:30
Mihaela Stoica
ceaa7460e4 Merge pull request #1281 from GaborApatiNagy/CA-229009&CA-229019
CA-229019 and CA-229009
2016-11-10 17:52:24 +00:00
Gabor Apati-Nagy
7790c8e51d CA-229019: XenCenter behavior on installing already uploaded update
Code review follow up commit

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 17:46:07 +00:00
mcintyre94
34eb42802c Merge pull request #1276 from MihaelaStoica/CA-192747
CA-192747: Default name for the performance graphs
2016-11-10 17:32:10 +00:00
Mihaela Stoica
bef415cc98 Merge pull request #1277 from GaborApatiNagy/CA-227719
CA-229185: XenCenter: Dundee and Creedence hosts should be disabled for Ely updates in 'Select Servers'
2016-11-10 17:20:03 +00:00
Gabor Apati-Nagy
b0588d980a CA-229009: VDI is not deleted for the updates
XenCenter will now remove VDIs that couldn't been introduced.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 17:18:51 +00:00
Gabor Apati-Nagy
4fad0d309a CA-229019: XenCenter behavior on installing already uploaded update
The Pool_update does not always covers all the VDIs XenCenter creates. These orphaned ones have to be deleted as well.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 17:15:40 +00:00
Callum McIntyre
db2b824242 [CA-149812] EN: Duplicate hotkeys about “Dismiss All” and “Dismiss Selected” tabs.
Moved to A for Dismiss All, and E for Dismiss Selected. Since this frees D (the toolstrip menu split button uses one of these, so was previously always D), moved Filter by Date from A to D.
2016-11-10 16:45:57 +00:00
mcintyre94
103f2793f2 Merge pull request #1275 from MihaelaStoica/CA-228179
CP-19664: Added the RPU hotfix for Dundee
2016-11-10 15:19:43 +00:00
Mihaela Stoica
d76c450c41 CP-19664: Update RPU hotfixes in XenCenter
Added the RPU hotfix for Dundee

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-10 14:59:39 +00:00
Gabor Apati-Nagy
7b6a296a68 CA-229185: XenCenter: Dundee and Creedence hosts should be disabled for Ely updates in 'Select Servers'
For ISO updates, when disabling hosts, use the filename matching logic for pre-Ely hosts as well.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 14:57:10 +00:00
Mihaela Stoica
a609e440f6 Merge pull request #1272 from mcintyre94/CA-228729
[CA-228729] Improve the message shown on finishing the update installation
2016-11-10 14:47:29 +00:00
Mihaela Stoica
30a5f36515 Merge pull request #1271 from mcintyre94/CA-228723
[CA-228723]  Cancelling update installation leaves the update in xapi db
2016-11-10 14:45:51 +00:00
Mihaela Stoica
19b0a86fa7 CA-192747: Default name for the performance graphs
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-10 14:42:45 +00:00
Callum McIntyre
f5fccc0ca5 [CA-228054] Performance graph datasources aren't sorted naturally
Replace the string comparison used when sorting columns of the datasources list table with a natural compare, which sorts these cases correctly.
2016-11-10 11:41:30 +00:00
Mihaela Stoica
d3a50d73fb CA-148427: XC logs get populated with wrong message even when the user does not change the master password when "save and restore" option
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-10 11:12:01 +00:00
mcintyre94
e7f4f3b8a0 Merge pull request #1267 from kc284/CA-227601
CA-227601: check SR supports db replication on a background thread.
2016-11-09 17:42:41 +00:00
Callum McIntyre
638d8fe9e6 [CA-228723] Use sync destroy method in the cleanup action 2016-11-09 16:32:16 +00:00
Callum McIntyre
4a2b27e8ab [CA-228729] Improve the message shown on finishing the update installation
Changed the message to Delete/Deleting/Deleted update installation files, as used in other messages.
2016-11-09 15:52:52 +00:00
Mihaela Stoica
4df0c65d26 Merge pull request #1264 from mcintyre94/CA-226897
[CA-226897] Resume on Server option won't automatically resume the VM
2016-11-09 14:44:03 +00:00
mcintyre94
c595a1a624 Merge pull request #1262 from MihaelaStoica/CA-226103
CA-226103: Hotkey conflict in the “Choose the type of new storage” UI…
2016-11-09 11:00:44 +00:00
Callum McIntyre
d71d9d10d8 [CA-228729] Improve the message shown on finishing the update installation
Previous message was Remove/Removing/Removed Updates, which is confusing. Changed to Clean/Cleaning/Cleaned Update Files.
2016-11-08 16:53:50 +00:00
Callum McIntyre
6a096ebf07 [CA-226897] Move the VMCrossPoolMigrateAction to be a variable outside the block, and added SuppressHistory to the MultipleAction. 2016-11-08 16:05:51 +00:00
Callum McIntyre
d7060cbdb1 [CA-228723] Cancelling update installation leaves the update in xapi db
Modify the cleanup pool update action to also call update destroy (removing the update from xapi db) when the update has not been applied to any hosts (ie we cancelled the wizard before completion).
2016-11-08 15:31:35 +00:00
Gabor Apati-Nagy
bb298cc213 Merge pull request #1270 from MihaelaStoica/CA-227034
CA-227034: Slipstream packaged Live patching hotfix is rebooting host
2016-11-08 14:44:07 +00:00
Mihaela Stoica
b0c4521340 Merge pull request #1266 from mcintyre94/CA-227845
[CA-227845] Fixing problems caused by tooltip container on hotfix wizard mode page
2016-11-08 14:31:20 +00:00
Mihaela Stoica
50d366b189 Merge pull request #1260 from mcintyre94/CA-225715
[CA-225715] Performance Graph reporting for CPU for a VM based on max VCPUs
2016-11-08 13:57:54 +00:00
Mihaela Stoica
6b374cb400 CA-227034: Slipstream packaged Live patching hotfix is rebooting host
This happened because the LivePatchCodesByHost was null when the prechecks were generated for an update, so the live patch codes returned by the precheck were ignored.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-08 11:43:54 +00:00
Usha Mandya
cb79c069f2 Adding content for Nutanix CVM Console 2016-11-07 15:20:06 +00:00
Konstantina Chremmou
b8eaa18f45 CA-227601 part 2: check whether the storage repositories support database replication
on a background thread and show a spinner while this process is going on. Also,
removed certain duplicate controls and made some minor layout changes (margins,
sizes, column widths).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-11-07 13:56:37 +00:00
Konstantina Chremmou
f17617b2ec CA-227601: check whether the storage repositories support database replication
on a background thread and show a spinner while this is going on. Also: run this
check only the first time the page is loaded; some refactoring, namely simplified
the code scanning for SRs by reducing the number of things each method does;
fixed column widths; removed unused property.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-11-07 13:54:03 +00:00
Callum McIntyre
15e04d1a6d [CA-227845] Fixing problems caused by tooltip container on hotfix wizard mode page
Due to the tooltip container introduced for the automatic radio button, winforms didn't treat these radio buttons properly - we needed code to make them mutually exclusive, tab didn't behave properly and keyboard arrow navigation between them didn't work. Therefore I have removed the tooltip container (so our radio buttons behave properly without any extra work) and we instead use a winforms tooltip shown when the mouse is over the automatic radio button. Note that since the control is disabled when we want a tooltip, neither hover events nor attaching a winforms tooltip in the usual way will work. Therefore I use a mousemove event on the table, which displays the tooltip if and only if we are over the disabled control. Also adjusted the tab indexes to make sure tab works correctly across the whole page.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-04 17:09:52 +00:00
Usha Mandya
ccd6c48eb6 Added new topics for PVS and Dom0 memory 2016-11-04 17:00:52 +00:00
Callum McIntyre
9b1a3315f0 [CA-226897] Resume on Server option won't automatically resume the VM
The resume on server uses the CrossPoolMigrateCommand to implement the migration of the VM to the desired host. Before this change that command had no support for resuming a VM after migrating it, so the VM was not resumed. With this change, the CrossPoolMigrateWizard can take an optional (default false) parameter to restart the VM after migration. When this is true, the migrate action becomes a MultipleAction, first migrating and then restarting the VM.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-03 15:35:25 +00:00
Mihaela Stoica
af8c178712 CA-147722: Truncation issue occurred on CPU & Memory window when VM memory more than physical memory.
Also aligning the warning icon with the label.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-03 15:30:56 +00:00
Mihaela Stoica
aca6c41aef CA-226103: Hotkey conflict in the “Choose the type of new storage” UI while creating new storage
Also changed the page to use different resource strings for the Storage type in the right hand panel (no hotkeys should be shown there)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-03 13:55:46 +00:00
Ravi Bharath Shanmugiah
9cb79877f8 xencenter help latest with vcpu and livepatching content 2016-11-03 13:17:05 +05:30
Callum McIntyre
a1e254e7a4 [CA-225715] Performance Graph reporting for CPU for a VM based on max VCPUs(not current vcpu)
Instead of using VCPUs_max, use VCPUs_at_startup, which is the value set when we change the VCPUs count on the VM. Note that despite its name we don't need to restart to see this value change.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-02 17:24:51 +00:00
Cheng Zhang
0b27b36d9b CA-227274: Fix CN and JP version process lable size
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-11-02 18:05:36 +08:00
Stephen Turner
74a911b68d Merge pull request #1256 from mcintyre94/CA-227608
[CA-227608] Change HA intro page wording
2016-11-01 17:49:29 +00:00
Callum McIntyre
8e88d9d36d [CA-227608] Change HA intro page wording
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-01 17:42:00 +00:00
Mihaela Stoica
adaa084d7a Merge pull request #1255 from GaborApatiNagy/master_packaging_fixes
Packaging-related bugfixes
2016-11-01 17:02:18 +00:00
Mihaela Stoica
30bf42c00e Merge pull request #1254 from mcintyre94/CA-227602
[CA-227602] Truncation on the Install Mode page in the Install Upgrade wizard
2016-11-01 16:44:39 +00:00
Gabor Apati-Nagy
75622ceece CA-226253 XenCenter: Handle new error code when a disk space precheck error occurs
Removed code that I used when dev testing

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-01 16:41:36 +00:00
Callum McIntyre
07f866e3a0 [CA-227602] Remove the unused bottom row from the table
This fixes the extra padding, we don't need that bottom row at all

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-01 16:32:45 +00:00
Gabor Apati-Nagy
bfdca9d7bf CA-226253 XenCenter: Handle new error code when a disk space precheck error occurs
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-01 15:46:40 +00:00
Callum McIntyre
722527f84e [CA-227602] Truncation on the Install Mode page in the Install Upgrade wizard
I've looked at how this was implemented in Dundee, and there we used an absolute height on the row containing the manual checkbox. I've done the same here, changing row 3 from autosize to absoliute 47px. I've also removed the empty row that was between the two radio buttons. This is a Winforms problem, without workarounds an autosize radio button in an autosize container (say the table row) will report its height as one row of text, no matter whether it needs more. This seems to be the only place we use a long radio label (as opposed to a separate label underneath the radio), so I doubt it's worth doing anything more complex than this. I've tested it with the CN string used in the ticket, and it uses less space than the English translation. The string also hasn't changed from Dundee.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-01 15:17:43 +00:00
Mihaela Stoica
b766e6e4b5 Merge pull request #1248 from mcintyre94/CA-203752
[CA-203752] New VM from Snapshot doesn't use default host
2016-11-01 11:14:07 +00:00
Mihaela Stoica
8f7c34c33f Merge pull request #1247 from mcintyre94/CA-207601
[CA-207601] License expiry time in general tab is incorrect
2016-10-31 15:29:26 +00:00
mcintyre94
a91280fc73 Merge pull request #1252 from MihaelaStoica/CA-227072
CA-227072: Improvements to the confirmation message on deleting a site
2016-10-28 17:21:32 +01:00
Mihaela Stoica
84f0a3a3ea CA-227072: Improvements to the confirmation message on deleting a site
- show a different message when deleting a Cache Configuration (a PVS_site object) that is actively in use by a PVS site
- some more text changes on the "Configure PVS Cache" dialog

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-28 16:58:15 +01:00
mcintyre94
5518efaa69 Merge pull request #1245 from kc284/master
CA-226817: Do not allow OVF/OVA import on a host incompatible with th…
2016-10-28 15:46:15 +01:00
Callum McIntyre
034a686947 [CA-226116] Add Windows update as a hidden feature
If windows_update is in the hidden features registry key, then we hide the virtualization state line about Windows update.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-28 12:58:23 +01:00
Callum McIntyre
e6cc09ae87 [CA-203752] New VM from Snapshot doesn't use default host
The reported bug was that the new VM would crash because when clicking through the wizard the pool master is selected by default, not the slave the VM snapshot is on. We already select a default host when a new VM is created from a selected host using HostAncestor, but this property is null for a template (which isn't in the server/VM tree). The fix is that if the selection is a template (which it is when we use new VM from Snapshot) then we instead use its host (using Home()) as the default host. Now the correct host is selected in the VM wizard and the VM creation succeeds.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-27 17:52:32 +01:00
Callum McIntyre
25c7accae5 [CA-207601] License expiry time in general tab is incorrect
The problem here was that TimeSpan.Minutes is always below 60, eg. for 67 minutes it is 7 (with TimeSpan.Hours being 1 then). So our TimeSpan was correct, but if it was between 1 and 2 hours then we would write the minutes in the second hour (which is below 60), ignoring the hour. The fix is to use s.TotalMinutes which for 67 minutes is 67. Hours also had a similar issue, except it would be off by 24 hours for spans between 1 and 2 days.
2016-10-27 16:07:07 +01:00
Konstantina Chremmou
3a2444ea49 CA-226817: Do not allow OVF/OVA import on a host incompatible with the VM's hardware
platform version. Also, preserve between export and import the VM's has_vendor_device settings.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-27 16:03:16 +01:00
Mihaela Stoica
8b9985f894 Merge pull request #1246 from GaborApatiNagy/CA-227067
CA-227067: General tab: XenCenter does not show Reboot required when Toolstack restart is required
2016-10-27 15:33:32 +01:00
Konstantina Chremmou
27f31431ca Merge pull request #1242 from mcintyre94/CA-223486
[CA-223486] Storage Link Status validation is wrongly included in Precheck During RPU
2016-10-27 15:26:40 +01:00
Mihaela Stoica
98133addc4 Merge pull request #1241 from mcintyre94/CA-220457
[CA-220457] Add friendly names for new graphs, and filter duplicates
2016-10-27 15:10:16 +01:00
Gabor Apati-Nagy
fa7dbc14ed CA-227067: General tab: XenCenter does not show Reboot required when Toolstack restart required
On the General tab XenCenter shows a list of updates that requires the host to be restarted. This is shown for applied updates for which the required guidance hasn't been done (eg. restartHost or restartAgent after-apply-guidances)

This commit fixes a regression that caused restartToolstack warnings to be not shown in the list of warnings.

The displayed messages are also improved, XenCenter will show Toolstack restart or host restart appropriately and not just restart only as it used to.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-27 14:27:20 +01:00
Callum McIntyre
c1e3346bd4 [CA-223486] Only add the licensing check if any hosts need to be checked
This will avoid having an empty group if no host needs checking.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-27 14:01:17 +01:00
Callum McIntyre
318faeedad [CA-223486] Refactoring and expanding fltering to all pre-Clearwater only checks
We now enumerate pre-Creedence and pre-Clearwater servers once, and check hosts only in those lists for the checks that only apply to those servers.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-27 11:39:01 +01:00
Callum McIntyre
fd46c9b24e [CA-220457] Move the match Regex objects to be static class objects
Moved from BuildList method to the GraphHelpers class. Since they're only used in this class for this search, and there's similar but broader Regex objects in the Helpers class that are used for parsing, I think it's better to keep them in this class to avoid confusion.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-27 10:41:44 +01:00
Callum McIntyre
299ed430cc [CA-223486] Only add the check for hosts that it applies to, instead of all selected ones.
This avoids unnecessary checks where we are upgrading multiple pools from different versions. Also made the same change for the unrelated pre-Clearwater only checks which had the same issue.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-27 10:18:26 +01:00
sri harsha tagore k
5b482aa43a L10N:TRanslations checkpin 2016-10-27 14:46:55 +05:30
Callum McIntyre
0ba1e5c6df [CA-223486] Storage Link Status validation is included in Precheck During RPU
We now only include the StorageLink check if we have any hosts earlier than Creedence in the RPU.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-26 17:28:11 +01:00
Callum McIntyre
173149b749 [CA-220457] Add friendly names for new graphs, and filter duplicates
We have some new RRDs - read, write, read_latency and write_latency. This adds support for them by adding a friendly name and using it to display them. It also adds some filtering (see GraphHelpers.cs) because for backward compatibility io_throughput_read and io_throughput_write (which differ from read and write only in scale) are still available, but shouldn't be displayed in XC. If the new read or write are available, we filter these old datasources out.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-26 16:03:12 +01:00
Mihaela Stoica
941fd6ce74 CA-220475: [PAR-173] XenCenter fails when updating network MTU with VLAN tag already in use error
- use the PIF of the master when trying to find out if an external network has changed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-26 13:07:47 +01:00
Gabor Apati-Nagy
325f2c2c6e Merge pull request #1238 from xenserver/CAR-2245
CAR-2245: XenCenter changes for CAR-2245 Standarize packaging formats
2016-10-24 17:56:16 +01:00
Gabor Apati-Nagy
3955704ec0 Merge pull request #1236 from mcintyre94/CA-226012
[CA-211267] Add a lightweight polling mechanism to the appliance tasks, to provide an accurate timer
2016-10-24 17:39:53 +01:00
Callum McIntyre
d39a1a7cd3 [CA-211267] Change MAX_ITERATIONS to use SLEEP_TIME, making it a bit clearer and ensuring it's always approx 24h
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-24 17:33:31 +01:00
Callum McIntyre
f11ed643b6 Add a timeout of approximately 24 hours to the TickUntilCompletion method. 2016-10-24 16:13:44 +01:00
Callum McIntyre
bb78309279 [CA-211267] Remove the passing this around and null action check, change TickUntilCompletion to be non-static 2016-10-24 14:22:35 +01:00
Callum McIntyre
7d7a040335 [CA-211267] Add a null check, use Run() to stop child classes directly calling InitialiseTicker()
TickUntilCompletion() is now a static method and again takes an ApplianceAction parameter. It does a null check on each while iteration to handle the case where another thread nulls the action. Also added Run() method to ApplianceAction which initialises the ticker (now a private method), and let child classes call Run() instead.
2016-10-24 11:59:28 +01:00
Konstantina Chremmou
56d7f52b16 Merge pull request #1235 from MihaelaStoica/master
CP-19257: Icon for Kylin Linux
2016-10-24 10:46:10 +01:00
Callum McIntyre
15b4705942 [CA-211267] Move the sleep time into a const int of the class. Also removed the ApplianceAction parameter from TickUntilCompletion (it behaved like a static method), to make it more similar to TaskPoller.PollToCompletion 2016-10-24 10:06:59 +01:00
Callum McIntyre
de43761039 [CA-211267] Add a lightweight polling mechanism to the appliance tasks, to provide an accurate timer
For other actions we get a ticking timer in the Events view because they use PollToCompletion, which calls their Changed event every 900ms. These actions don't use PollToCompletion, and didn't regularly call their Changed event - so their timer didn't tick regularly. This change adds a lightweight mechanism to call their changed event every 900ms until they complete. This allows the events page timer to tick every second in the same way as it does for other actions.
2016-10-24 09:56:09 +01:00
Konstantina Chremmou
1744ca0415 Merge pull request #1237 from MihaelaStoica/CA-226256
CA-226256: Trying to change boot order toggles boot flags
2016-10-24 08:47:09 +01:00
Mihaela Stoica
93149f75f8 CA-226256: Trying to change boot order toggles boot flags
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-21 18:53:17 +01:00
Mihaela Stoica
6eb2c80895 CP-19257: Icon for Kylin Linux
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-21 18:46:38 +01:00
Mihaela Stoica
4b67140b1d Merge pull request #1224 from kc284/master
Some enhancements on the New Graph Dialog:
2016-10-21 13:16:20 +01:00
Konstantina Chremmou
ac01c0e120 Fixed size changes done by the VS designer.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-21 13:11:46 +01:00
Mihaela Stoica
1992e2bc58 Merge pull request #1231 from sriharshak/master
L10N:Bug fixes for "CA-226245" and "CA-226244"
2016-10-21 12:18:01 +01:00
Gabor Apati-Nagy
55a4957056 Removed unused field (Release build failed on this)
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-21 11:29:32 +01:00
sri harsha tagore k
4d65c1cf1e L10N:Bug fixes for "CA-226245" and "CA-226244" 2016-10-21 15:17:21 +05:30
Gabor Apati-Nagy
92b59a9e44 CA-226261: Install HFX Wizard: Mode page: both radio buttons selected
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-21 10:20:25 +01:00
Mihaela Stoica
6bffb803a1 CA-226112: Disable PVS read caching causes System.NullReferenceException
- code simplification

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-21 07:10:23 +01:00
Gabor Apati-Nagy
668979c29f Merge remote-tracking branch 'github_xenadmin/master' into CAR-2245_temp
Conflicts:
	XenAdmin/TabPages/GeneralTabPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizardModeGuidanceBuilder.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_ModePage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
	XenAdminTests/WizardTests/PatchingWizard/PatchingWizardModeGuidanceBuilderTests.cs
	XenModel/Network/Cache.cs
	XenModel/XenModel.csproj
2016-10-20 19:12:57 +01:00
Gabor Apati-Nagy
735feec3e4 CP-19218: Using livepatch_status (for newer bindings)
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-20 18:12:13 +01:00
Gabor Apati-Nagy
1c7f6ac643 Merge remote-tracking branch 'github_xenadmin/CAR-2245' into CAR-2245_temp 2016-10-20 17:58:20 +01:00
Gabor Apati-Nagy
6c26359dd6 Merge pull request #1222 from MihaelaStoica/CAR-2245
CP-19218: Add restart warnings to the Precheck Page when installing h…
2016-10-20 17:41:32 +01:00
Gabor Apati-Nagy
f4a0f3ae40 CP-19303: XenCenter: Use new livepatching codes
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-20 17:19:42 +01:00
Mihaela Stoica
2a66b68c7b Merge pull request #1220 from GaborApatiNagy/CAR-2245_temp
CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
2016-10-20 16:02:05 +01:00
Mihaela Stoica
994ced8388 CA-226112: Disable PVS read caching causes System.NullReferenceException
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-20 14:52:51 +01:00
Mihaela Stoica
8c93206ce5 CP-19218: Add restart warnings to the Precheck Page when installing hotfixes
-  If reboot is needed, display this as an info, not a warning

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-20 13:09:48 +01:00
Mihaela Stoica
2546731edc CA-226102: HFX wizard host selection not grayed out when hotfix not applicable for current version
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-20 11:33:55 +01:00
Konstantina Chremmou
e6ec0d430b Some enhancements on the New Graph Dialog:
- on certain occasions retrieving datasources can be slow; show a spinner while in progress.
- on certain systems the list of datasources may be long; added search box to aid the user filter them by name.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-20 00:03:47 +01:00
Gabor Apati-Nagy
da0ebc467c CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Fixed refactoring mistake

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 14:02:29 +01:00
Gabor Apati-Nagy
64d7938f55 CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Removed dead code

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 13:42:34 +01:00
Gabor Apati-Nagy
27581fa7a1 CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Moved ISO to InvisibleMessages and Branding

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 13:42:16 +01:00
Gabor Apati-Nagy
225885ac45 CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Always define the extension to search for

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 13:39:14 +01:00
Mihaela Stoica
49ba853958 Merge pull request #1218 from mcintyre94/CA-225062
[CA-225062] For Ely and greater hosts, don't check for IO tools when activating/deactivating (this covers detatch + delete too in UI) a VBD
2016-10-19 13:19:22 +01:00
Mihaela Stoica
07faabe1f0 CP-19218: Add restart warnings to the Precheck Page when installing hotfixes
- added a new precheck, called "Live patching status" which checks is a reboot is needed for each host. If reboot is needed, the check will display a warning, otherwise it will show a green tickbox, saying that the server does not need to be rebooted, and if live patching is used, this information will be included as well.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-19 13:10:24 +01:00
sri harsha tagore k
1e8791fb38 L10N:TRanslations check-ins 2016-10-19 16:37:43 +05:30
Gabor Apati-Nagy
8ac6774e80 CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 11:29:57 +01:00
Sharath Babu
9bade951b9 CA-213509: [VMSS] XC Unable to add policy to a Folder/ Tags
Disable Folder/Tags for VMSS feature

Signed-off-by: Sharath Babu <sharath.babu@citrix.com>
2016-10-19 05:04:26 +05:30
Mihaela Stoica
9de2dae4a1 Merge pull request #1219 from sriharshak/master
L10N:TRanslations check-ins
2016-10-18 17:57:42 +01:00
sri harsha tagore k
529cddb035 L10N:TRanslations check-ins 2016-10-18 22:16:57 +05:30
mcintyre94
284afe255e Merge pull request #1210 from kc284/CA-150412
CA-150412: OtherConfigAndTagsWatcher deliberately throws exceptions
2016-10-18 17:11:28 +01:00
Mihaela Stoica
045db14381 Merge pull request #1191 from mcintyre94/master_dotnetupgrade
[Dotnet upgrade] Upgrade XenCenter to .net 4.6
2016-10-18 16:57:18 +01:00
Callum McIntyre
2ad99b06d4 [CA-225062] For Ely and greater hosts, don't check for IO tools when activating/deactivating (this covers detatch + delete too in UI) a VBD
Instead we use the vbd.allowed_operations list, and check for the plug/unplug operation respectively.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-18 16:48:05 +01:00
sri harsha tagore k
63387232b9 L10N:TRanslations check-ins 2016-10-18 20:45:24 +05:30
Mihaela Stoica
329f084a7e Merge branch 'CAR-2184' to master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/XenAPI-Extensions/SR.cs
2016-10-18 10:18:47 +01:00
Mihaela Stoica
7ec3881e05 Merge pull request #1212 from kc284/CA-157786
CA-157786: General tab for VDIs.
2016-10-18 08:01:57 +01:00
Konstantina Chremmou
c7ea650cf6 CA-157786: Use NameWithLocation to display the name of the VDI's SR. Also, removed
unconventionally named method which did not offer much to code legibility.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-17 23:26:13 +01:00
Konstantina Chremmou
38bf5b86d3 Merge pull request #1208 from MihaelaStoica/CA-224567
CA-224567: PVS Site renaming plus some other improvements
2016-10-17 22:06:48 +01:00
Mihaela Stoica
15344401c0 CA-224567: Correction in the text on the PVS Cache configuration page
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-17 16:00:28 +01:00
Mihaela Stoica
18243b229f CA-225708: Can not increase dom0 Memory multiple times
- take the already assigned dom0 memory into account when calculating maximum memory available

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-17 14:23:50 +01:00
Mihaela Stoica
e6fbcfdb5d CA-224567: PVS Site renaming plus some other improvements
- Correction in the text on the PVS Cache configuration page
- Added help IDs for all new dialogs and the PVS tab
- Help button on the Enable PVS read caching dialog, plus some adjustments in the controls sizes on this dialog
- Removed minimize and maximize buttons from the PVS servers dialog, and added the help button

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-17 13:02:59 +01:00
Konstantina Chremmou
08e1b2c1b7 CP-18417: Removed flag forbidding update; was added for CP-17750, but is no longer applicable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-17 11:16:16 +01:00
Konstantina Chremmou
cff98908b3 Merge remote-tracking branch 'upstream/CAR-2226' 2016-10-17 11:07:15 +01:00
Konstantina Chremmou
7a74096d3b CA-157786: Added general tab for VDIs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-14 13:51:51 +01:00
Konstantina Chremmou
0b3d3abfcc Code repetition.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-14 12:21:59 +01:00
Konstantina Chremmou
bf08f9d875 Refactored old events which did not need to pass parameters when fired, but were
defined a long time ago, before C# obtained the Action delegates.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-13 22:59:06 +01:00
Mihaela Stoica
9ec9cf1aee CA-225057: Add a helper method for setting the Clipboard text and use in all places where Clipboard.SetText was used.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-13 16:16:16 +01:00
Frezzle
c96911aac5 [CP-19111] Removed duplicated code for functions registered to UI controls
Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-10-13 15:28:17 +01:00
Mihaela Stoica
9398837c38 Merge pull request #1205 from GaborApatiNagy/CAR-2245_CP-19266_2
CP-19266 & other changes
2016-10-13 15:08:38 +01:00
Gabor Apati-Nagy
f5545c83f5 CP-19265: Some improvements to comments
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-13 14:59:20 +01:00
Gabor Apati-Nagy
7e20b11300 CAR-2245: Passing Pool_update to the precheck page
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-13 14:53:46 +01:00
Mihaela Stoica
387c28dadc CA-225057: XenCenter throws an Exception when trying to copy something to the clipboard on the Network page
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-13 13:14:37 +01:00
Mihaela Stoica
abde6e9641 CA-224567: PVS Site renaming plus some other improvements
- Renamed Add/Remove PVS Site buttons
- Added a note on the PVS Cache configuration page, regarding the recommended cache size and the allowed size for "memory only"
- Added a warning about the Site configuration not being complete until the PVS part is done as well (only visible if PVS_uuid is not set for a PVS_site)
-  Added PVS Read Caching status on the VM's general tab
- The absolute maximum allowed for a cache size is 2TB
- Changed the rubric on the Enable PVS read caching dialog

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-13 12:47:32 +01:00
Konstantina Chremmou
dc5318010c Merge pull request #1196 from mcintyre94/CA-114492
[CA-114492] Stop GroupBy buttons remaining overlapped…
2016-10-12 20:24:36 +01:00
Frezzle
3522e2980d [CP-19111] Added ability to choose Basic or Digest authentication for proxy server
2 new radio buttons in Connection Options page, for Basic and Digest; Digest is the default as it's the most secure.
New proxy authentication method setting, which is used to configure XenAPI's HTTP class and the .NET AuthenticationManager (which handles which authentication schemes can be used by the .NET web classes).
The new setting is also transferred and used by the Health Check service.

The bug noted in CA-214653 also occurs here, but the work-around on PR#1201 for that bug will also work for this.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-10-12 19:09:35 +01:00
Mihaela Stoica
be668850a4 CP-19086: In the PVS Cache configuration dialog, we shouldn't try to save a "not configured" site if it was "not configured" before
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-12 17:10:39 +01:00
Mihaela Stoica
af680eb6eb CA-224666: Things in PVS tab constantly refreshing
- instead of repopulating the whole grid when a proxy or a site changes, we now refresh just the row that needs refreshing, and when the refresh is indeed needed.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-12 16:59:46 +01:00
Gabor Apati-Nagy
a9c2662715 CAR-2245: Passing Pool_update to the precheck page
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-12 16:55:21 +01:00
Gabor Apati-Nagy
a722c8b853 CAR-2245: Remove unused method
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-12 16:54:53 +01:00
Gabor Apati-Nagy
33adf91a68 CP-19266: [CAR 2245] Make sure XenCenter does not use Pool_patch at all (from Ely)
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-12 16:49:43 +01:00
Gabor Apati-Nagy
5fa7f5a797 CP-19265: Use Pool_update.async_apply
Changed XenCenter following the XAPI fix

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-12 16:27:34 +01:00
Mihaela Stoica
47665f5323 CA-225015: XenCenter Allows VM migration to MemorySR
- We shouldn't include the hidden SRs in the list of available SRs in the Migration wizard
- Updated the SR.SupportsVdiCreate function to return false for the Memory SR; this fixes other places where the Memory SR might be visible (e.g. all places where SrPicker is used)
- Also fixed the same issue in the  Attach disk dialog

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-12 15:47:24 +01:00
Gabor Apati-Nagy
5df1593989 CP-19264: Live Patching in XC: Use Pool_update version of Host.patches_requiring_reboot in XenCenter
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-12 14:48:17 +01:00
Mihaela Stoica
a8c7aba673 CP-17932: Ensure that the correct units are displayed for the PVS cache stats
- For the PVS cache space utilization the multiplying factor should be 1 (the default value) because its values range from 0 to 100

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-12 14:19:32 +01:00
Mihaela Stoica
80df4a2681 CP-17932: Ensure that the correct units are displayed for the PVS cache stats
- plus resorting Messages.resx

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-11 13:13:50 +01:00
Konstantina Chremmou
6df0508c92 Enforce filetrs to be run with a target that is Pool or Host and a non-null VM selection.
Small refactoring for performance gain on Host extension method.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-11 09:45:37 +01:00
Mihaela Stoica
82c0f6d7a3 CA-224619: XenCenter cannot use Switch to Remote Desktop option for VMs connected to internal network
- correction to the previous commit: only collect the IP addreses if the PIF is connected or is null

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-10 15:28:00 +01:00
Mihaela Stoica
c0d5dd2d94 CA-224619: XenCenter cannot use Switch to Remote Desktop option for VMs connected to internal network
- include networks without PIFs in the list of networks to test for RDP (at the end of the list)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-10 15:28:00 +01:00
Callum McIntyre
baccb87d00 [CA-114492] Only do SetUp if the user was actually dragging a button (not for every click on the button)
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-10 10:11:30 +01:00
Gabor Apati-Nagy
6296277317 Merge pull request #1188 from kc284/vm_migration
CA-220218, CA-205799, CA-205791 plus one or two other issues and refactoring
2016-10-07 16:18:49 +01:00
Callum McIntyre
9f39bdfb23 [CA-114492] Stop GroupBy buttons remaining overlapped after a drag operation by ensuring they snap back to a correct setup on mouseup
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-07 14:16:06 +01:00
Mihaela Stoica
d6c735bd18 Merge pull request #1173 from kc284/migration
CA-220511, CA-187659, CA-220216 plus some refactoring and minor enhancements.
2016-10-07 10:11:07 +01:00
Konstantina Chremmou
f36fa9ea2f Fixed regressed button height. Also, it seems VS designer has the bad habit of
removing event registration unless it's written out fully like the rest of the
autogenerated code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-06 09:13:52 +01:00
Mihaela Stoica
c8d86baeee CP-19086: More improvements to the PVS cache UI
- in the ConfigurePvsSiteAction, we now check if a site still exists, before trying to configure it
- added a CollectionChanged event handler in the Cache configuration dialog, and if we observe that a site has been added, we add it to the dialog as a new page

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-05 14:12:24 +01:00
Gabor Apati-Nagy
c3f376ed7d CP-18422: Remove supp pack handling code for Ely hosts
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-05 13:22:29 +01:00
Gabor Apati-Nagy
37735febd1 CP-18421: Use host.updates instead of host.patches
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-05 12:55:34 +01:00
Mihaela Stoica
d827361acc CP-19086: Improvements to the PVS cache UI
- Removed the cache configuration gridview from the PVS tab. This tab now contains the button to configure PVS cache and the VMs grid
- Show the confirmation dialog even when deleting a new site
- Enabled the "View PVS servers" button only if the site has servers

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-05 09:51:23 +01:00
sri harsha tagore k
77631ffb3e L10N:TRanslations check-ins 2016-10-05 10:58:50 +05:30
Gabor Apati-Nagy
5cfce00e01 CP-17848: Apply hotfixes using new API calls
Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-04 23:26:35 +01:00
Gabor Apati-Nagy
5966c5399a Merge remote-tracking branch 'github_xenadmin/master' into CAR-2245_temp
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PatchingPage.cs
2016-10-04 15:10:47 +01:00
Gabor Apati-Nagy
7d62621dd3 CP-17848: Apply hotfixes using new API calls
Using new XAPI functionality in Install Update Wizard required by the new packaging format (ISO updates)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-04 14:58:54 +01:00
Stephen Turner
82de583e3d Merge pull request #1193 from ushamandya/master
CP-18445: Updated XC Help for WinServer 2016 support
2016-10-03 16:26:33 +01:00
Usha Mandya
596863c28b CP-18445: Updated XC Help for WinServer 2016 support 2016-10-03 16:17:19 +01:00
Gabor Apati-Nagy
1750c47de9 CP-18421: Use host.updates instead of host.patches
Showing relevant Pool_updates instead of Pool_patches on General tab

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-03 14:19:32 +01:00
Mihaela Stoica
be66919627 CP-19086: Improvements to the PVS cache UI
- If the PVS site cannot be removed (it has running proxies) then popup a dialog stating the reason, instead of starting the action and failing there. We still have the same check in the action, just in case the situation changed in the meantime.
- Removed unused controls

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-03 10:51:56 +01:00
Konstantina Chremmou
b78f823b17 CA-220218: For halted VMs moving intra-pool, XenCenter does not need to assert migration
is possible, because what it actually does is move. When asserting migration use
an SR other than the VDI's current SR for the check to ensure that both source and
target SRs are checked to see whether they support migration. Also, use the VM's
Home() instead of resident_on to ensure the current server cannot be selected as
target server. Some refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-03 10:30:40 +01:00
Konstantina Chremmou
e6b2f9b293 Refactoring: removed three out of the classes deriving from the DelayLoadingOptionComboBoxItem
because the differentiation was in the filters, which can be passed in as parameters
to the base class, and other than this they were only adding complexity.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-02 22:04:58 +01:00
Mihaela Stoica
aebffe9b13 CP-19086: Improvements to the PVS cache UI
PVS Tab:
- Move the "View PVS sites" button inside the "Configure PVS Cache" dialog (next to Remove button) and make it per-site (showing only the PVS servers from that site)
- Remove "Currently attached" column from the VMs section
- Rename "Status" column to "Read caching status"

Configure PVS Cache" dialog:
- Make sure there is a scrollbar to accommodate all hosts in a pool
- Add a confirmation dialog when a site is removed. The action is executed when the Remove button is pressed.
- When Memory SR is selected, set the maximum value to the dom0-extra-memory..
- Allow empty configuration (but see next point): The OK button should only be disabled if the PVS site name is empty
- Add an extra option in the "Cache storage" combobox, with text "Not configured", selected by default on a new site. When this is selected, we will remove the existing entry in pvs_cache_storage and will not create a new one.
- When a PVS site is deleted (forgotten), we first delete all the associated PVS_servers, otherwise the site cannot be deleted.
2016-10-01 00:23:28 +01:00
Stephen Turner
3e8f052117 Merge pull request #1187 from MihaelaStoica/CP-19060
CP-19060: Port vCPU hotplug code to master and add license key
2016-09-30 16:33:56 +01:00
Mihaela Stoica
cdfec90fa8 Merge branch 'master' into CAR-2184 2016-09-30 14:46:26 +01:00
Stephen Turner
9d2024c132 Update credits 2016-09-30 13:49:47 +01:00
Konstantina Chremmou
61a2c12c45 CA-205799: Fixed issue where the user was allowed to select the VM's home server
as move (halted) or migrate (suspended) destination; this was caused by using the
VM's resident_on instead of Home() host. Also, changed the disabled reason to be
a bit more generic and cover cases other than migration.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:59 +01:00
Konstantina Chremmou
f1a43abbf0 Refactoring: it's not a good idea to set virtual members in constructors; thus
the MenuText can stay a getter.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:44 +01:00
Konstantina Chremmou
4bf04e6279 In Move mode the text on the destination page should read "move the VMs" and not migrate.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:37 +01:00
Konstantina Chremmou
55f1a03224 Fixed wrong images in the following cases:
- the image for resume suspended VM on non-home server should be connected-server,
not vm-being-migrated.
- the image for a server where a running VM cannot be migrated to should be connected-server,
not disconnected-server (it is disabled anyway). Also, simplified the logic to obtain
the cannot-execute-reasons.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:30 +01:00
Konstantina Chremmou
6833722992 Renamed command so it's more obvious what it does and made some corrections to its checks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:23 +01:00
Konstantina Chremmou
97278e88ad Refactoring: normally we create the actions in the wizard class obtaining the parameters
from the page properties; removed unnecessary field.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:04 +01:00
Mihaela Stoica
2a6a237a7f CP-18889: Fix the layout in the CN version of the CPU page (#1166)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-29 12:17:00 +01:00
Mihaela Stoica
18fb723f6a CP-18889: Implement UI changes for vCPU hotplug (#1159)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-29 12:11:37 +01:00
Callum McIntyre
1b1c7ae581 [Dotnet Upgrade] Convert all projects to use .net 4.6. All changes autogenerated by VS.
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-29 10:50:24 +01:00
Mihaela Stoica
4aaaea43d9 CA-223407: Hosts don't get rebooted after a supplemental pack installation and the wizard is stuck in "rebooting" phase
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-29 10:07:00 +01:00
Konstantina Chremmou
13bc93a5ad UI workaround for CA-220216: swapped the order of checks and put VDI migration
before move; thus, if the SR does not support migration, the user can at least
detach the disk and try a move.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-28 23:50:46 +01:00
Konstantina Chremmou
775ee87bab CA-220511: Fixed issue where it was not possible to migrate the VDI of a VM without
home host from a shared to a local storage (while it was possible from the CLI).
Minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-28 23:14:25 +01:00
Mihaela Stoica
b0f748ceb5 CP-17920: New icons for Add and Remove PVS site
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-28 17:56:39 +01:00
Konstantina Chremmou
eb3fbe2ac8 Corrections and refactoring on VDI move/migrate:
- Allow move of multiple VDIs
- CA-187659: show better messages when batching move/migration of multiple VDIs.
- Show different tooltips for single vs. multiple VDI move/migration/deletion.
- Refactored the MoveDiskDdialog. Removed the inherited class VDIMigrateDialog and
the batching manager as it was not very different from its parent, it was registering
the events twice, and was batching migration of even single VDIs.
- Tidied up the Move- and MigrateVirtualDisk commands so they're easier to compare.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-28 09:50:43 +01:00
Konstantina Chremmou
2ff6f74488 Fixed the following issues:
- Was only able to move and not migrate vdi if selected from the objects view.
- The text on the ToolStripMenuItems on the SrStoragePage was different from the
corresponding buttons.
- Added item move/migrate to the multiple VDI context menu. The Properties item
should not be shown in this case.
2016-09-28 09:50:23 +01:00
Mihaela Stoica
277914a202 CP-17920: Add dialog for PVS cache configuration
-rename local variable

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-27 18:39:49 +01:00
Mihaela Stoica
82dea74899 CP-17920: Add dialog for PVS cache configuration
- new image for PVS_site
- added cache size restrictions based on the SR selected
- added button to remove the PVS site on the page
- fixed the error where the subtext for a new PVS sites showed as "Not configured" even after it has been configured

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-27 16:34:26 +01:00
Mihaela Stoica
fe6144ba70 CP-17920: Add dialog for PVS cache configuration
- this commit contains a temporary image for PVS_site

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-26 17:44:17 +01:00
Mihaela Stoica
f2b1443064 Merge branch 'master' into CAR-2184
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2016-09-26 13:26:31 +01:00
Mihaela Stoica
151e6f42fb CP-17920: Show the PVS tab only when the supplemental pack is installed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-23 14:51:19 +01:00
Gabor Apati-Nagy
ccaeed67cb CA-223082: Replace PATCH_PRECHECK_LIVEPATCH_MISSING
Replace PATCH_PRECHECK_LIVEPATCH_MISSING to PATCH_PRECHECK_LIVEPATCH_NOT_APPLICABLE due to changes in XAPI
Note: if XAPI change gets active before this change we will see UNKNOWN instead of PATCH_PRECHECK_LIVEPATCH_NOT_APPLICABLE in XenCenter what will make no difference
2016-09-23 13:35:02 +01:00
Mihaela Stoica
c6eab65fdf Merge pull request #1154 from kc284/master
Some corrections on VMStorage page and disk move/migrate/detach
2016-09-22 15:21:48 +01:00
mcintyre94
dd42394a25 CP-16922: Implement GUI for enabling PVS read caching (#1179)
* CP-16922: UI changes to PvsPage to replace the single configure button with a separate enable and disable one, per the design doc

* CP-16922: Intermediate checkin - command + dialog implemented, but PVS page has some layout problems.

* CP-16922:  Implement GUI for enabling PVS read caching and marking/unmarking VMs for prepopulation

Fix the broken layout by reverting MainWindow.resx (which shouldn't have changed) back to the previous commit. Also removed duplicate properties button code.

*  CP-16922: PVS Page changes, to properly display all VMs (not just ones with proxy), only populating proxy columns if there is a proxy set.

* CP-16922: Use a CommandButton for the enable button, connected to the same command as the VM main menu button, and using the table selection as its selection manager.

* CP-16922: Delete the old enable button click behaviour (because it now has a proper command), was causing the dialog to show up twice

* CP-16922: Properly list VMs by hiding those that should be hidden (in addition to non-VMs, also hide the __gui__ prefix and others covered by Show function). Also fixes a bug in NewVMGroupVMsPage discovered when fixing this - it would show VMs that should be hidden if you used the search bar.


* CP-16922: Use ButtonText on the Command to set the text on the PVS enable button

* CP-16922: Add the disable PVS read-caching command, and its associated proxy destroy action. Both based off enable equivalents (main difference is no dialog for now). Not used yet but will be in main window menu + disable button

* CP-16922: Add disable PVS read-caching to the main window menu (under enable), with the disable command attached to it


* CP-16922: Add support for disabling PVS read-caching for selected hosts via the PVS tab page by converting the disable button into a CommandButton in the same way as the enable button, using its own command + selection manager (because Selection Managers only bind to one control)

* CP-16922: Design - adding the "read caching enabled" column from the design, so that we display both whether caching is enabled and whether the VM is currently cached. If it's disabled all other values are missing.


* CP-16922: Add the PVS site column per the design to show the site a VM's PVS Proxy is on if it has a proxy


* CP-16922: Add an event handler for VMs changing so that newly provisioned VMs immediately show up in the PVS tab page


* CP-16922: Support for properly remembering the selection when the VM list is refreshed. A new method returns the list of VMs for the selected rows, and we can then check if the VM for the row being added is in this list. If there was no previous selection then we still select the first row by default.


* CP-16922: Remove prepopulate, which is being removed from the design. The next XAPI version will remove it, so just pass False as prepopulate for now, and remove the option from the dialog and PVS tab page.


* CP-16922: Improve UI appearance for a missing Storage Repository. Per the design, if there is no SR show the message None (memory only) instead of an empty cell

* CP-16922: Improved sorting behaviour. All columns (except VM name, which always uses it) use the VM tag as a sorting fallback (since they all have duplicates). New default sort which sorts by caching enabled first (yes before no), and then VM tag as a tiebreaker. Support for remembering the current sort on refresh, ie when a value changes.

* CP-16922: Refactoring to use a VM extension method to get the PVSProxy (or null if none exists) for a VM. This was used in the PVS Page + commands which are now much simpler.


* CP-16922: Move where the SelectionChanged event handler is set when refreshing the PVS table, so that the command buttons are updated correctly.

* CP-16922: Improvements to PVS read-caching dialog. Set accept/cancel buttons properly + adjust tab values, so focus acts as expected


* CP-16922: Remove the images from the menu for Enable/Disable PVS read-caching, most commands in the menu don't have one

* CP-16922: Sorting out the strings for the actions + ParallelAction calls, and moving them into the resx. Also reverting wrong MainWindow.resx changes.

* CAR-2184: XAPI changes. I've made the minimal possible changes to PvsPage to ensure it compiles, but it's had a lot of feature work (CP-16922) that supersedes this, these small changes should keep that merge painless.


* CAR-2184 XAPI: Reverse the unrelated changes, only keep the PVS ones.

* CP-16922: Merge latest XAPI changes, notably changes to Pvs_site.create

* CP-16922: Change tab show/hide logic for PVS tab, show it even if there are no PVS sites.

* CP-16922: Implement GUI for enabling PVS read caching

Design changes - remove the storage repo column and replace it with status, which is populated with a friendly version of the pvs_proxy_status enum. Also populate site list using site.name_label

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

*  CP-16922: Implement GUI for enabling PVS read caching

Adjusting the CanExecute of Enable PVS read-caching command to require at least one PVS site to be created. Since the PVS tab can show up without any sites, we need this because we can't create a proxy without a site.

* CP-16922: Code review changes.

Tidied up messages, and ensured actions run async properly, and without exiting before their task.

* CP-16922: Code review changes.

Update dialog resx, wider combobox on dialog, update action descriptions before setting RelatedTask, add friendly message body for PVS error notifications.
2016-09-22 15:08:15 +01:00
Mihaela Stoica
8ea8c71f74 Merge pull request #1164 from kc284/master2
Did some work on the SrStoragePage:
2016-09-22 14:12:59 +01:00
Konstantina Chremmou
03639d35b5 Added missing hotkey to the delete toolstripmenuitem; changed the hotkey on the move
toolstripmenuitem so it's the same as the button.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-20 23:12:54 +01:00
Gabor Apati-Nagy
b09de72f83 Revert "CP-18925: Hide batch hotfixing option in XenCenter" 2016-09-20 15:00:06 +01:00
Mihaela Stoica
e5eeb29e55 Merge pull request #1170 from kc284/master3
CA-100083 (part of): Set minimum width of the main window's tab contr…
2016-09-20 13:57:39 +01:00
Konstantina Chremmou
6bb71ffd23 Merge pull request #1124 from GaborApatiNagy/CA-174979
CA-174979: Confusing right-click add to pool menu (if you accept the defaults)
2016-09-20 13:15:36 +01:00
Konstantina Chremmou
2aa8d956c0 Fixed tab order.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-20 13:10:02 +01:00
mcintyre94
6707139e6e CAR-2184: XAPI changes. (#1177)
* CAR-2184: XAPI changes. I've made the minimal possible changes to PvsPage to ensure it compiles, but it's had a lot of feature work (CP-16922) that supersedes this, these small changes should keep that merge painless.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

* CAR-2184 XAPI: Reverse the unrelated changes, only keep the PVS ones.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-20 12:33:00 +01:00
Mihaela Stoica
963d5211d6 Merge pull request #1174 from mcintyre94/CA-217821
CA-217821: Renaming home server to target server in VM migration wizard
2016-09-20 11:43:24 +01:00
Mihaela Stoica
a4ffaf239f CA-218242: Don't assign values outside the range in the memory spinner control
- The value of the spinner control is rounded to the nearest, while the minimum is rounded up and the maximum down (or, in some cases, min and max are not rounded at all).
In most cases this is fine, but if the current value (in bytes) is equal to one of these ranges, by rounding this way we might end up with a value that is outside of the control's ranges (causing ArgumentOutOfRange exception).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-19 23:14:26 +01:00
Gabor Apati-Nagy
d12481fa0f CA-174979: Confusing right-click add to pool menu (if you accept the defaults)
Leaving the new pool's name field empty, forcing user to enter a name before the Next button is enabled.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-19 18:15:44 +01:00
Callum McIntyre
0c5eaef042 CA-217821: Renaming home server to target server in VM migration wizard
We already renamed the column to target server, this changes the message in the case where the user doesn't choose a server on this page to also use target server.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-19 17:00:02 +01:00
Mihaela Stoica
c86a69e3b9 CA-218242: Fix crash in Dom0 memory dialog
- reset the spinner limits before changing the value

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-19 16:11:13 +01:00
Konstantina Chremmou
2fdf033b25 Merge pull request #1150 from mcintyre94/CA-149965
CA-149965: Snapshot name is truncated on “Revert To Snapback” dialog.
2016-09-19 12:22:48 +01:00
Mihaela Stoica
65db5e3320 Merge pull request #1171 from mcintyre94/CA-219777
CA-219777: Bad progress dialog message
2016-09-19 12:03:57 +01:00
Callum McIntyre
6136f70d13 CA-219777: Bad progress dialog message
The bad message was in the dialog created in the BugToolWizard after selecting servers. Since this method is the only one using the ActionProgressDialog(String) constructor, I've modified that ctor to hide the subaction label - which makes sense because there is no action in that ctor (to set a subaction) and no other appropriate label.
2016-09-19 11:31:48 +01:00
Callum McIntyre
c9dc5af32d CA-149965: Snapshot name is truncated on “Revert To Snapback” dialog
Shorten the ellipsise to the first 40 characters instead of 45, which allows the ellipsis, quotation and question marks to fit correctly onto the line.
2016-09-19 10:37:48 +01:00
Mihaela Stoica
db9eea0cf6 Merge pull request #1168 from sriharshak/master
L10N: Ely:Translation check-ins
2016-09-18 07:12:27 +01:00
Konstantina Chremmou
565f95291d CA-100083 (part of): Set minimum width of the main window's tab control to 40% to
avoid buttons on the console tab overlapping. Removed some panels from the console
tab to reduce control nesting.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-17 01:23:55 +01:00
Gabor Apati-Nagy
bd7d6bcc9c CP-18925: Hide batch hotfixing option in XenCenter
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-16 14:04:10 +01:00
Callum McIntyre
d83a9cefb5 CP-18417 review changes: Improved PatchRequiresReboot logic. Introduced a new bool someHostMayRequireRestart, passed as an out parameter into both the guidance string builder methods, and the Build method they both use. In that Build method the parameter is set to true if any restartHost guidance is seen - this check is done before live checks exit for consistency.
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-15 17:19:47 +01:00
Callum McIntyre
5d53ab3db3 CP-18417 review changes: Simpler other_config key, added a pool extension method to check for it, moved the check on the Select Servers page to be the first check, simpler logic toggling the automatic/manual buttons. Still need to rework the PatchRequiresReboot part
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-15 16:37:37 +01:00
sri harsha tagore k
49ef8a3aad L10N: Ely:Translation check-ins 2016-09-15 16:47:31 +05:30
Stephen Turner
3154a0bd92 CA-220440: Remove CLM link from XenCenter home page 2016-09-14 15:31:21 +01:00
Callum McIntyre
31941eb71e Remove unwanted files from first commit
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-14 10:41:57 +01:00
Callum McIntyre
b22618ef5c Merge remote-tracking branch 'upstream/master' into CP-18417 2016-09-14 10:30:52 +01:00
Konstantina Chremmou
9a26b3cb2e Did some work on the SrStoragePage:
- show/hide the context menu items instead of creating and adding new ones each time the context menu opens
- right click menu with rescan/add was not available for empty list or when empty space was clicked
- the condition for the edit button was slightly different from the edit toolstripmenuitem
- improved button layout (part of CA-100083)
- tidied up button event handlers and renamed one or two class members
- removed unused parameter in constructor and method of VDIRow

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-14 09:06:19 +01:00
Konstantina Chremmou
0f9c6fbc2f Did some work on the VM storage page:
- fixed issue where the context menu with add/attach items was not available
for empty list or when empty space was clicked; in the latter case I also clear
the selections
- added ability to launch the context menu by using the windows properties button
- moved context menu to the designer; changed code to show/hide the relevant menu
items instead of adding new ones each time the context menu opens
- added icon to the context menu item Properties
- fixed button layout (part of CA-100083), then removed separators between buttons
because when they wrap it looks a bit strange
- fixed some weird cross-threading exception (could not reproduce reliably)
- renamed one or two class members and tidied up the button event handlers

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-13 01:29:47 +01:00
Gabor Apati-Nagy
fdb32cf579 CA-220599: Supplemental Pack installed via XenCenter does not get listed in updates box
Fixed regression caused by 5555709337.
Supplemental packs can now be installed again in automatic mode.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-12 17:07:59 +01:00
Konstantina Chremmou
f4dfbe83b4 Merge pull request #1155 from MihaelaStoica/CA-220613
CA-220613: Truncation on the Migration Network page of the Cross Pool…
2016-09-12 09:02:28 +01:00
Konstantina Chremmou
6298a7e885 Do not calculate twice the VMs to move or migrate. Text improvement.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-09 18:52:38 +01:00
Callum McIntyre
129330c326 CP-18417: Modify the hotfix wizard to make it work for hosts that can't auto-update/restart from XC
Adjusted messages, and added a tooltip to the Automatic restart radio when it's disabled. Also now support standalone hosts in addition to pooled.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-09 15:45:38 +01:00
Callum McIntyre
2b215ffd78 Merge branch 'master' of https://github.com/xenserver/xenadmin into CP-17848
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/PatchingWizard/PatchingWizardModeGuidanceBuilder.cs (resolved using master)
2016-09-09 12:59:29 +01:00
Callum McIntyre
9a8cb87e29 Pull down + merge master (which has changes to update wizard in live patching etc). Automerged. 2016-09-09 12:40:07 +01:00
Callum McIntyre
d302815b66 CP-17848: Commit to hand over. PatchingWizard_UploadPage.cs contains new code to introduce a Pool_update, PatchingWizard_PatchingPage.cs to apply and clean it. 2016-09-09 12:02:59 +01:00
Mihaela Stoica
1bb49758ff Merge pull request #1151 from huazhihao/CA-218956
CA-218956: Expose HIMN when showing hidden objects
2016-09-08 13:10:38 +01:00
Mihaela Stoica
8bf507e634 CA-220613: Truncation on the Migration Network page of the Cross Pool Migration wizard
Fixing regression introduced in commit 3a5444ceb2

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-08 12:01:56 +01:00
John Hua
b0638bb4f5 CA-218956: Expose HIMN when showing hidden objects
Expose both the HIMN network and any VIFs associated with the HIMN
network using XenCenter when the "View->Show Hidden Objects" option
is displayed. However the shown HIMN should not be able to autoplug,
edit or delete.
2016-09-08 17:48:25 +08:00
Konstantina Chremmou
d2a3a17369 Fixed typos.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-06 14:53:46 +01:00
Mihaela Stoica
4623d65a4d Merge pull request #1138 from kc284/master
CA-215575: Top connection bar on full screen console was not listening to server events
2016-09-06 10:53:35 +01:00
Konstantina Chremmou
4cdb24dd29 CA-215575: Corrected regression as requested per code review: the full screen
console should appear on the same monitor as the main form.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-06 10:32:49 +01:00
Callum McIntyre
7b78038a2b Revert "CA-149965: Snapshot name is truncated on “Revert To Snapback” dialog."
This reverts commit 79f734f0ff.
2016-09-06 09:48:34 +01:00
Gabor Apati-Nagy
b12f488ffd Merge pull request #1147 from MihaelaStoica/CA-220040
CA-220040: Patching wizard shows reboot required where it is not expected
2016-09-05 12:05:12 +01:00
Gabor Apati-Nagy
6065465a52 Merge pull request #1148 from MihaelaStoica/CA-220049
CA-220049: Non-livepatch hotfix installation is failing
2016-09-05 12:05:06 +01:00
Gabor Apati-Nagy
531613b037 Merge pull request #1149 from MihaelaStoica/CA-220171
CA-220171: Configure HA dialog incorrectly states failover tolerance …
2016-09-05 12:02:06 +01:00
Callum McIntyre
79f734f0ff CA-149965: Snapshot name is truncated on “Revert To Snapback” dialog.
Changed the ellipsise length from 45 to 90 characters. This means that the first row of text becomes variable length, so I've reworked the dialog to support this and work like others: icon/rows of text in table cells, right aligned flow panel for buttons.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-02 17:47:23 +01:00
Mihaela Stoica
7764a6bf9f Merge pull request #1145 from mcintyre94/CA-140338
CA-140338: Truncation on New Search Page with long Custom Field Filters name
2016-09-02 11:25:59 +01:00
Mihaela Stoica
8755126e8d Merge pull request #1144 from mcintyre94/CA-112317
CA-112317: Sorting on SR storage tab is incorrect
2016-09-02 11:17:55 +01:00
Mihaela Stoica
8e077e1e78 CA-220171: Configure HA dialog incorrectly states failover tolerance would be 0
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-02 10:46:33 +01:00
Mihaela Stoica
12a025a253 CA-220040: Patching wizard shows reboot required where it is not expected
- When building the list of servers that require post-install actions, ignore the ones where the patch has already been installed.
- Also fixing the infinite recursion in Build() method (causing StackOverflowException when installing a supplemental pack).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-01 17:36:11 +01:00
Mihaela Stoica
b1728ee125 CA-220049: Non-livepatch hotfix installation is failing
This fixes the NullReferenceException that occurs when trying to evacuate a host after a non-livepatch update (that requires reboot) has been installed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-01 17:14:21 +01:00
Callum McIntyre
c36f160327 CA-140338: Truncation on New Search Page with long Custom Field Filters name
Accidentally left an extra piece of ellpising in the wrong place, now removed.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-01 15:03:43 +01:00
Callum McIntyre
3295dc845d CA-140338: Truncation on New Search Page with long Custom Field Filters name.
The truncating of the custom field name by space (instead of ellipsising) seems to be a Windows default, but it's not ideal. This change edits the text displayed in the dropdown when an item is selected so that if a custom field is selected it is ellipsised to an appropriate length. It doesn't affect the dropdown itself, which continues to display the full custom field name.
2016-09-01 15:00:06 +01:00
Mihaela Stoica
b758e0660a Resurrect CP-18011: [XenCenter] Add live patching checkbox
(reverting  8a10351c5d: Revert "Cp 18011: [XenCenter] Add live patching checkbox")

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-01 14:59:37 +01:00
Callum McIntyre
df9410ac6a CA-112317: Sorting on SR storage tab is incorrect
Making the requested changes: Name is now sorted by the generic CompareTo method (which uses name with opaque ref as tiebreaker), and Description also uses opaque ref as tiebreaker for consistency.
2016-08-31 16:42:01 +01:00
Callum McIntyre
49a586430e CP-17848: Rename UpdateType enum NewSuppPack to ISO, since for this ticket we will handle all updates as ISOs 2016-08-31 10:42:09 +01:00
Gabor Apati-Nagy
d5bb5d96bc Merge pull request #1139 from mcintyre94/CA-107341
CA-107341:  Truncation issue occurred on rolling pool upgrade window.
2016-08-30 16:01:01 +01:00
Gabor Apati-Nagy
b510dbe8c7 Merge pull request #1140 from mcintyre94/CA-112317
CA-112317: Sorting on SR storage tab is incorrect
2016-08-30 15:57:47 +01:00
Gabor Apati-Nagy
d7a94c1684 CP-18014: Alter batch hotfixing to use host.patches_requiring_reboot
Fixed flickering

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 16:41:12 +01:00
Gabor Apati-Nagy
15f69ef584 CP-18014: Alter batch hotfixing to use host.patches_requiring_reboot
Improving AvoidRestartHost usage/interface

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 16:04:28 +01:00
Gabor Apati-Nagy
f55cf77c00 CP-18014: Alter batch hotfixing to use host.patches_requiring_reboot
XenCenter will check host.patches_requiring_reboot when a host restart is due while a batch update is in progress. If the restart is not required, XenCenter will skip relevant PlanActions.
The intention here is to check this whenever a restart is due according to the original schedule - this way a completely livepatchable update can prevent the restart while the key batch hotfixing logic is not changed.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 15:37:57 +01:00
Gabor Apati-Nagy
0174974c93 Merge branch 'master' of https://github.com/xenserver/xenadmin into CP-18014
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Messages.Designer.cs
	XenModel/Messages.ja.resx
	XenModel/Messages.resx
	XenModel/Messages.zh-CN.resx
2016-08-26 15:22:03 +01:00
Callum McIntyre
b7de03cd98 CP-18417:Move the pool forbidden message into the Messages class (though text isn't finalised yet) 2016-08-26 14:51:05 +01:00
Callum McIntyre
a548c21120 CP-18417: Simplifying the automatic enabled/disabled logic.
Automatic is disabled if any pool forbids auto restart (per Neptune), and reboot is required. It's also disabled if the update type isn't one of the three in the switch statement. If it's enabled it is checked by default.
2016-08-26 14:45:24 +01:00
Callum McIntyre
8639660562 Move the check to stop Neptune servers being selected into the IsInAutomaticMode checks 2016-08-26 14:24:24 +01:00
Callum McIntyre
1cc960860b CA-112317: Sorting on SR storage tab is incorrect
Change the sorting on the Name and Description columns to use StringUtility.NaturalCompare, which correctly sorts strings with numbers at the end (eg name, name0, name1, name2, name10 will now sort correctly while alphabetic sorting is incorrect). Also added a tie break on uuid to make sorting behave predictably with duplicates in these columns.
2016-08-26 10:06:30 +01:00
Callum McIntyre
c41602085d CA-107341: Truncation issue occurred on rolling pool upgrade window.
Truncated pool and host names on the Ready to Upgrade page to 64 characters, which resolves the layout problem from extremely long names.
2016-08-25 16:48:39 +01:00
Konstantina Chremmou
9b7f90ccb4 CA-215575 plus refactoring: The connection bar does not need to manipulate anything
other than strings. Moved settings of the FullScreenForm from the VNCTabView to
the former class. The FullScreenFormof the VNCTabView is only initialised as
FullSCreenFrom so no casts are necessary. The FullScreenForm is responsible for
updating the connection bar text with the value obtained from the vncScreen everytime
the name of the connection changes. Also reduced visibility of certain members.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-24 13:51:50 +01:00
Konstantina Chremmou
a9a1cd6b9c Tidied up: the vncScreen should notify the parent vncTab when the rdp warning needs
to be shown. It is complicated to have the one control call a method in the other
which checks the state on the first control.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-24 11:48:42 +01:00
Callum McIntyre
7f5390e9c4 CP-18618: If live patching fails, warn the user
If we are expecting to live patch, but at the end
hosts.patches_requring_reboot contains the patch, then warn the user that
live patching has failed for the host - and it needs to be rebooted.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-24 11:13:58 +01:00
Konstantina Chremmou
38ca217bc3 Tidied up: moved the full screen message from the VNCTabView class to the more relevant
FullScreenHint class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-24 01:38:51 +01:00
Gabor Apati-Nagy
7ee2e605ee CP-18012: Use extended precheck information in Update Wizard
This commit implements the check for LiveUpdate capability of a patch. If
the patch is completely live-updatable, XenCenter will not restart the
host (but will do further checks once it has finished installing the
update - separate ticket)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-23 18:31:23 +01:00
Konstantina Chremmou
629c2b48d1 Merge pull request #1134 from mcintyre94/CA-140181
CA-140181: Inconsistent name displaying when it contains symbol '&’
2016-08-23 12:14:01 +01:00
Konstantina Chremmou
ba4ecd5fa4 Merge pull request #1135 from mcintyre94/CA-152163
CA-152163: Duplicate hotkey "S" on "Location Mirrored SRs" wizard.
2016-08-23 12:06:20 +01:00
Callum McIntyre
cf4ed293ba CA-140181: Inconsistent name displaying when it contains symbol '&’ and becomes hotkey.
Now using the EscapeAmpersands string extension method. Also resolved the custom fields display issue in the same way.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-23 11:33:24 +01:00
Callum McIntyre
af9327d30a CA-152163: Duplicate hotkey "S" on "Location Mirrored SRs" wizard.
Redone the commit without any size changes.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-23 10:52:00 +01:00
Callum McIntyre
493b86a5c3 Revert "CA-152163: Duplicate hotkey "S" on "Location Mirrored SRs" wizard."
This reverts commit d928a406bc.
2016-08-23 10:37:29 +01:00
Konstantina Chremmou
bb327ac245 Merge pull request #1132 from stephen-turner/CA-150364
CA-150364: Shrunken item on status bar
2016-08-23 10:01:46 +01:00
Callum McIntyre
d928a406bc CA-152163: Duplicate hotkey "S" on "Location Mirrored SRs" wizard.
Moved the hotkey for "Find Storage Repositories" from S to R.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-22 17:44:56 +01:00
Callum McIntyre
14288ede3a CA-140181: Inconsistent name displaying when it contains symbol '&’
The ticket said the character after the & became a hotkey (like labels etc do with UseMnemonic enabled) but I couldn't reproduce that - & symbols were simply removed from the string. The fix is to replace them with &&, so the string.format prints a single & as it should.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-22 16:07:53 +01:00
Konstantina Chremmou
e99f86c29c Merge branch 'master' into REQ-156 2016-08-19 17:54:37 +01:00
Callum McIntyre
615b55321d Intermediate checkin, branched from REQ156 and applied my changes, needs checking. 2016-08-19 17:27:24 +01:00
Stephen Turner
e99a97f748 CA-150364: Shrunken item on status bar 2016-08-19 16:50:08 +01:00
Konstantina Chremmou
d07a34ad19 Set checkbox state in the designer and not in the constructor to avoid starting
the checks before the page is loaded. Corrected the conditions for enabling the
Previous and Next buttons on this page. This commit fixes broken RPU wizard test.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-19 15:45:16 +01:00
Konstantina Chremmou
73b0c36fb6 CA-217232: Added some null ref checks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-19 10:55:18 +01:00
Konstantina Chremmou
0cd8391feb Merge pull request #1128 from GaborApatiNagy/REQ-156_github
CA-217232: Fixed regression caused by the fix for CA-216935
2016-08-19 10:42:41 +01:00
Gabor Apati-Nagy
54f67be47c CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-18 17:55:44 +01:00
Gabor Apati-Nagy
d054c80f62 CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review
2016-08-18 16:02:24 +01:00
Gabor Apati-Nagy
1c5ba794b4 CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review
2016-08-18 16:00:50 +01:00
Gabor Apati-Nagy
53619c775d Merge remote-tracking branch 'github_xenadmin/master' into REQ-156_github_master
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
	XenModel/Actions/ParallelAction.cs
	XenModel/FriendlyNames.resx
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2016-08-18 12:22:40 +01:00
Gabor Apati-Nagy
37c120ee57 CA-217232: Fixed regression caused by the fix for CA-216935
Creation of PoolPatchMapping objects made safer.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-18 11:30:50 +01:00
Gabor Apati-Nagy
feafb7ac62 CA-217232: Fixed regression caused by the fix for CA-216935
Comparing uuids instead of references that likely will be changed after the Cache has been repopulated.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-18 11:25:39 +01:00
Konstantina Chremmou
73a549a4d0 Improvements made while investigating CA-218953:
- when the cd drive or the tools iso cannot be found, the action should fail.
- if the tools SR is broken, do not show the error on a pop-up because the UX is
bad when installation is attempted on multiple VMS.
- added one more entry to the list of possible tools iso names.
- small performance improvement.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-17 22:35:01 +01:00
sharath babu
d89dbe3b2d CA-213496: Snapshots taken part of VMSS have same symbol
as manually taken snapshots in saved snapshot search

Signed-off-by: Sharath Babu <Sharath.Babu@citrix.com>
2016-08-17 15:22:45 +05:30
Callum McIntyre
2d089fa9e9 CP-18013: [XenCenter] Update host/pool updates pane
Generalising to also support pools. New CheckHostPatchesRequiringReboot method with the same behaviour as old method (return list of KeyValue warning messages). Pool updates on Ely use the union of messages from this method instead of the old one. Also localised the "{hotfix} on {server}" string per todo (hence resx changes).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-17 10:45:11 +01:00
Callum McIntyre
dffd7507cc CP-18013: [XenCenter] Update host updates pane
For servers running Ely or greater we now produce messages for patching requiring reboot using the host.patches_requiring_reboot field. The Pool_patch objects resolved are sufficient to produce the same messages. Note that some patches produce a message in the old API but not the new, this is intentional. Still to do: update pool updates in the same way,

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-17 09:29:39 +01:00
Gabor Apati-Nagy
684b03317d Merge pull request #1120 from MihaelaStoica/CA-180127
CA-180127: Unable to unset VM home server if all shared SRs are full
2016-08-16 16:22:16 +01:00
Gabor Apati-Nagy
3fc9c3edb6 Merge pull request #1111 from MihaelaStoica/CA-210549
CA-210551: Non-modal action progress bar on the Pre-Checks page of th…
2016-08-16 16:08:54 +01:00
Mihaela Stoica
a3ad025bc6 Merge pull request #1117 from mcintyre94/CA-218304
CA-218304: Text cut off in Properties dialog, Alerts tab
2016-08-16 11:03:48 +01:00
Callum McIntyre
e2215c71f5 CA-218304: Modify tab stops in alert properties tab
Now behaves as expected - alert interval (top control) has lowest tab stop, all other groups incremented by 1.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-16 10:44:37 +01:00
Mihaela Stoica
4bc3cca91c Merge pull request #1122 from GaborApatiNagy/master_CA-150198
CA-150198: EN: Missing hotkey for “Properties” after right clicking virtual disk
2016-08-16 10:40:55 +01:00
Mihaela Stoica
7c4a4fa219 Merge pull request #1121 from mcintyre94/CA-218241
CA-218241: Cancel connect right click menu item does not seem to be doing anything
2016-08-16 09:44:51 +01:00
Callum McIntyre
4559e162b7 CA-218304: Text cut off in Properties dialog, Alerts tab
Instead of adding a second table layout panel for the rubric label, I have extended the original table to include two new rows at the top - one for the label rubric, and one for the repeat interval controls (previously not in the table).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-16 08:49:56 +01:00
Gabor Apati-Nagy
0cb878d577 CA-150198: EN: Missing hotkey for “Properties” after right clicking virtual disk.
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-15 17:32:53 +01:00
Callum McIntyre
05efba8b9f CA-217821: Rename command back to CrossPoolMigrateToHomeCommand 2016-08-15 16:13:35 +01:00
Callum McIntyre
8b035b3af5 CA-218241: Cancel connect right click menu item does not seem to be doing anything
The CancelHostConnectionCommand executes by using a DisconnectCommand, so the fix here is to allow that command to execute on connections in progress as well as those that are connected.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 15:25:14 +01:00
Mihaela Stoica
67be366858 CA-180127: Unable to unset VM home server if all shared SRs are full
By passing null as the srHost parameter to the affinity picker, the "no home server" radio button remains enabled, even when no shared SRs are available, allowing users to unset the home server of a VM

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-15 15:15:00 +01:00
Callum McIntyre
3a5444ceb2 CA-217821: Specified home server in cross pool migration should behave as home server
Mostly just terminology changes from home server to target server in the CPM wizard. Changes in shared component SelectMultipleVMDestinationPage (shared with ImportWizard) to allow CPM wizard to rename the Home Server column (as it can the VM/template one - using the same pattern).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 14:22:18 +01:00
Callum McIntyre
0cb567128b CA-218304: Text cut off in Properties dialog, Alerts tab
This is resolved by moving the label into a TableLayoutPanel, docked to the top and with auto-grow on.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 10:45:53 +01:00
Gabor Apati-Nagy
9dd3a41857 Revert "Cp 18011: [XenCenter] Add live patching checkbox" 2016-08-12 17:19:34 +01:00
Mihaela Stoica
aeeb1260e7 Merge pull request #1110 from mcintyre94/CP-18011
Cp 18011: [XenCenter] Add live patching checkbox
2016-08-12 17:17:37 +01:00
Callum McIntyre
177ae6acee Merge commit 'e5ab6fe06d581e5f00c0b94e3f3023cc049e7c6f' into CP-18013 2016-08-12 17:12:39 +01:00
Callum McIntyre
cc25e3ec45 CP-18011: [XenCenter] Add live patching checkbox
UI changes to add rubric label and radio buttons instead of a checkbox.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-12 15:58:49 +01:00
Mihaela Stoica
549bcd8480 CA-210551: Non-modal action progress bar on the Pre-Checks page of the Hotfix and RPU wizards
- Moved progress bar at the bottom of the page and made it the same height as on Upload page; This progress bar is now used when the prechecks are performed (existing functionality) and also for the "resolve" actions (new functionality).
- Added a label for displaying action progress.
- The icon and label saying that you need to resolve problems is hidden when there are no issues found and when an action is in progress (when the progress label is shown instead).
- When a resolve action is in progress, all controls on the page are disabled, apart from Cancel; pressing Cancel will cancel the "resolve" action and the wizard.
- Also put everything in a TableLayoutPanel (hence all the designer changes)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-12 13:27:47 +01:00
Callum McIntyre
82092adee4 CP-18011: Add licensing check for live patching before showing the new page
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-12 11:55:12 +01:00
Callum McIntyre
d3f4a4aa99 CP-18011: [XenCenter] Add live patching checkbox
Add the Live Patching tab as a new part of PropertiesDialog, shown for pools and standalone hosts. Tab contains one checkbox which toggles the live_patching_disabled XenServer API property. Not yet implemented: license check ("The option should only be shown if the pool is licensed")

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-12 09:51:20 +01:00
Gabor Apati-Nagy
50e9504da7 CA-217862: Batch Updates: Fixed order of checks when setting the tooltip for disabled hosts
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-11 11:14:32 +01:00
Konstantina Chremmou
68ac5a50e4 CA-33357: FIxed tab order.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-10 15:24:47 +01:00
Mihaela Stoica
5f8cb2ce0b CP-16935: Configure Control domain memory for a host
- Removed unnecessary calls to Close()

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-10 14:04:01 +01:00
Gabor Apati-Nagy
9f7a635da1 Merge remote-tracking branch 'github_xenadmin/REQ-156' into REQ-156
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Core/Updates.cs
2016-08-10 12:50:45 +01:00
Gabor Apati-Nagy
f9d8b4dea9 CA-217862: Batch updates: Install dundee released hotfixes in Batch fails when pool slave is not reachable and pool partially upgraded
Partially upgraded pools are not supported. If the versions of servers mismatch in a pool, Automatic updating will be disabled with the appropriate info message.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-10 10:48:22 +01:00
Konstantina Chremmou
12b44cfece Merge pull request #1093 from MihaelaStoica/CA-217388
CA-217388: Hotfix Install wizard shows update as already uploaded whe…
2016-08-10 09:11:37 +01:00
Sharath Babu
795b12cdcd CA-213500: Revert To, Actions and Delete buttons
are enabled even if there is no manual snapshot.

Signed-off-by: Sharath Babu <Sharath.Babu@citrix.com>
2016-08-10 12:04:11 +05:30
Konstantina Chremmou
5f75c0dd74 CA-217847: Fixed issue where servers were marked as unable to be updated automatically
even when automatic mode was supported for them. The problem was that the xenserver
versions were not retrieved from the DownloadUpdatesXmlAction once the latter had run.
Also, minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-09 16:53:02 +01:00
Mihaela Stoica
72be4e1141 CP-16935: Configure Control domain memory for a host
- Added Control Domain memory entry in the host memory control on Memory tab.
- Control domain memory is editable for Ely and greater hosts.
- Can be changed from a dialog that requires host to be in maintenance mode and triggers a host reboot after the memory is changed.
- This dialog is available from Server main menu and from the host memory tab.
- Also removed unused unit controls on host and VM memory bars.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-09 14:50:04 +01:00
Mihaela Stoica
4046ce0f95 Merge pull request #1096 from GaborApatiNagy/master_batch_new2
CA-217382: Batch updates: Install batch updates is not showing low di…
2016-08-09 14:17:48 +01:00
Konstantina Chremmou
208d4aa1f9 Merge pull request #1099 from GaborApatiNagy/CA-217844
CA-217844: Handling Automatic update not supported
2016-08-09 14:05:12 +01:00
Konstantina Chremmou
016c39bdaa CA-217843: AS requested per code review, hide originally the controls related to
automatic mode to avoid flickering during page load.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-09 12:45:35 +01:00
Mihaela Stoica
9df8b0494c CP-18407: Rename PVS farm to PVS site
- Rename everything to PVS site

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-09 12:01:59 +01:00
Mihaela Stoica
dea2749afa CP-18407: Rename PVS farm to PVS site
- New API bindings
- Fixed usages of PVS_farm class

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-09 11:12:34 +01:00
Mihaela Stoica
ea52f34d65 Merge pull request #1100 from mcintyre94/CA-150200
CA-150200: EN: Duplicate hotkeys for “Storage” and “Show Columns” under Citrix XenCenter
2016-08-09 10:37:41 +01:00
Callum McIntyre
93518392a8 CA-150200: EN: Duplicate hotkeys for “Storage” and “Show Columns” under Citrix XenCenter.
Remove the old value, leaving only the new one

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-09 10:31:55 +01:00
Gabor Apati-Nagy
e28ca1ded1 CA-217844: Handling Automatic update not supported
If there is no <minimalpatches /> tag, the version is not supported. This check has priority over licensed state when displaying the reason why a server is not supported.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-08 18:30:54 +01:00
Gabor Apati-Nagy
16afbd3bed CA-217382: Batch updates: Install batch updates is not showing low disk space error in pre-checks when host dom0 is full
Fixes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-08 18:05:42 +01:00
Mihaela Stoica
77336bdd44 Merge pull request #1095 from kc284/CA-33357
CA-33357: Improvements: show the disk name on the New VM storage page…
2016-08-08 17:04:01 +01:00
Callum McIntyre
0b67303f77 CA-150200: EN: Duplicate hotkeys for “Storage” and “Show Columns” under Citrix XenCenter.
New hotkey for "Show columns" is alt+C

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-08 15:10:51 +01:00
Konstantina Chremmou
e9ca8b529a CA-217843 best effort: Run RestoreDismissedUpdates action asynchronously to prevent UI hiccups.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-08 14:37:47 +01:00
Mihaela Stoica
529e921e24 Merge pull request #1078 from kc284/CA-147657
CA-147657 plus some refactoring
2016-08-08 13:47:59 +01:00
Konstantina Chremmou
c30938ff12 CA-217843: Fixed various issues on the select patch page: control tab order; some
hotkeys; button enabled state; some memory leaks; added spinner while check for
updates is in progress; added alternative text for when automatic mode is not available.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-08 11:41:42 +01:00
Gabor Apati-Nagy
f93a977ddf CA-217382: Batch updates: Install batch updates is not showing low disk space error in pre-checks when host dom0 is full
Implemented pre-check to check whether there is enough free disk space
before starting updating a pool.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-05 18:05:09 +01:00
Konstantina Chremmou
9d05bcdce5 CA-33357: Improvements: show the disk name on the New VM storage page so it is
more obvious to the user that they can edit it. To this purpose change the button
Properties to Edit (and do the same on the Networking page for consistence). Also
show the name of the disk (ellipsized if too long) on the wizard's finish page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-05 16:02:03 +01:00
Konstantina Chremmou
1065ca14eb Merge pull request #1088 from MihaelaStoica/CA-217449
CA-217449 &  CA-173661 - Control domain memory alert fixes
2016-08-05 12:27:31 +01:00
Mihaela Stoica
7186860cc2 CA-217390: Hotfix wizard: Add null reference check in the function that builds the list of post-update tasks.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-04 15:31:34 +01:00
Mihaela Stoica
dc24aa7fcc CA-217388: Hotfix Install wizard shows update as already uploaded when it is not actually uploaded because there wasn't enough space
- Add a new update to the list of uploaded updates only when the upload action has completed successfully.
- Do not perform the disk space check if there is nothing to upload (update has already been uploaded).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-04 15:10:36 +01:00
Konstantina Chremmou
dbef554ac0 CA-104472: Refactoring and removal of duplicate code. This also fixes descrepancies
in the calculation of the never-expiring licence ("greater than 3653 days" in
LicenceAlert and LicenceStatus vs "greater than or equal to 3653 days" elsewhere).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-03 21:07:04 +01:00
Gabor Apati-Nagy
0ae6568a60 CA-216854: Fixed error messages shown
Now the wizard shows localized and friendly error messages instead of error codes

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-03 17:15:57 +01:00
Gabor Apati-Nagy
90653493c5 CA-217232: Batch updates: Install Dundee released hotfixes in Batch fails with wrong message in hotfix wizard
Despite the update sequences are correct by host, when they are flattened, the original order (order in minimal patches) was not considered properly, so a missing patch was scheduled for later in the sequence than it should have been, thus the upgrade failed with a precheck-error.

This bug occurs when we are given
* a pool of more than one host,
* with (at least) patchA not installed on 2 or more hosts
* patchA requires patchR that is not installed on at least one of the above hosts (but not not on all)
* the host that is missing patchR is ahead of other hosts in pool.Hosts.Cache

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-02 16:58:24 +01:00
Gabor Apati-Nagy
48ef276c06 CA-216935: Fixed a bug that can occur when multiple pools are being updated with the same update and one of the prechecks happen before the other pool is finished applying the update
The PatchPrechecksOnMultipleHostsInAPoolPlanAction did not filter the patchmappings by masterhost, so with some probability, it could choose the wrong mapping (pool_patch object for the same update, but in different pool). This bug is being fixed in this commit, other changes only renamed (for more consistent naming) a class and removed an unused field.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-02 14:30:20 +01:00
Mihaela Stoica
35fb115358 CA-173661: Control domain memory alert setting not showing up in the tab subtitle on Host Properties dialog
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-01 12:24:25 +01:00
Mihaela Stoica
bd497356f6 CA-217449: Dom0 VM properties should not be visible in XenCenter
- The "Alarm Settings" action on Alerts page should open host's properties dialog for Dom0 alerts
- Also added help id for the Control Domain Memory Usage alert
2016-08-01 12:21:19 +01:00
Sharath Babu
815822e003 CA-213499: List view of snapshots not working as expected with VMSS
vmss snapshots are shown even when Scheduled snapshots is
unchecked in same menu.

Signed-off-by: Sharath Babu <Sharath.Babu@citrix.com>
2016-07-29 09:28:21 +05:30
Konstantina Chremmou
e8a009678f Fixed issue on the New SR wizard where the SR type details panel was not populated
when the default checked button was invisible.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-28 13:16:49 +01:00
Frezzle
4a20405ef5 [CP-16936] Implement GUI for viewing the PVS farms and PVS servers (read-only)
Actually use new string resource to set the pvs farm dialog's title!

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-26 17:21:29 +01:00
Frezzle
d0a4f9cb81 [CP-16936] Implement GUI for viewing the PVS farms and PVS servers (read-only)
Removed unused properties.
Added new string resource to set the pvs farm dialog's title.
Extended XenAPI's PVS_farm class to override Name property to allow for simpler sorting code.
Removed embedded icon in resource file; dialog now inherits the application's icon.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-26 15:19:18 +01:00
Mihaela Stoica
aa78621897 Merge pull request #1069 from kc284/master
CA-136768: Fixed bad layout of buttons at the top of the snapshots ta…
2016-07-26 14:43:33 +01:00
Frezzle
e6dfddb98c [CP-16936] Implement GUI for viewing the PVS farms and PVS servers (read-only)
Added event handlers for changes made to PVS server; it may end up calling Rebuild() twice but that's not a problem.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-26 11:31:00 +01:00
Mihaela Stoica
54849d4f5e Merge pull request #1084 from GaborApatiNagy/master_CA-213728
CA-213728: Going to Home Server tab can change home server
2016-07-25 16:45:45 +01:00
Frezzle
6c7df810f3 [CP-16936] Implement GUI for viewing the PVS farms and PVS servers (read-only)
Added new dialog for viewing PVS farms and servers.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-25 15:26:08 +01:00
Gabor Apati-Nagy
3ca0db4b98 Merge pull request #1072 from Frezzle/CA-209198
CA-209198: Allowed to attempt to install hotfix when it is already applied
2016-07-25 15:04:21 +01:00
Gabor Apati-Nagy
f6139c713a CA-213728: Going to Home Server tab can change home server
Even though the correct row have been selected by the time the grid becomes visible, it is not displayed properly. This change set fixes the problem by selecting the row again.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-25 14:31:55 +01:00
Gabor Apati-Nagy
a1bb0846e8 CA-213281, CA-213278: OK fixed
Bugs fixed:
* OK button not re-enabling when switching back to using existing credentials in Health Check Enrollment dialog
* Using empty credentials to authenticate with Citrix Insight Services does not disable OK button in Health Check Enrollment dialog

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-25 13:54:47 +01:00
Mihaela Stoica
9b9e9f87a8 Merge pull request #1076 from kc284/bugfix
Fixed bugs CA-207901 and CA-149814
2016-07-25 09:14:39 +01:00
Sharath Babu
5aaeeb3318 CA-213498: [VMSS] XC create new VMSS Policy wizard
disables "quiesce" option when no VMs are selected in policy

Signed-off-by: Sharath Babu <Sharath.Babu@citrix.com>
2016-07-25 11:36:28 +05:30
Konstantina Chremmou
cce9d5b1ce Refactoring: (1) Simplified the logic for gathering the can't-execute-reasons for
a selected item collection - there was no need to make temporarily each one of them
the command selection just to call CanExecute on them. (2) Do not mix the methods
returning the can't-execute-reasons (which can be unknown) with the tooltip property
(which can be null).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-25 01:01:05 +01:00
Konstantina Chremmou
1bbec00d57 CA-147657: Allow setting the ToolTipText for the command ToolStripButtons and ToolStripMenuSubitems
to null, otherwise the wrond text is shown for items with null can't-execute-reason
that are selected after items with non-null can't execute reason.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-25 01:00:53 +01:00
Konstantina Chremmou
d32b7a967b Added overload for the SelectedItemCollection constructor taking one item - it seems to be needed as often as the other constructors.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-25 01:00:44 +01:00
Konstantina Chremmou
13e6a73fa5 Merge pull request #1074 from MihaelaStoica/CA-216697
CA-216697: MTU message present on the Network Settings page when crea…
2016-07-22 20:38:44 +01:00
Konstantina Chremmou
b9b00ca4cd CA-149814: Added short description to fill in the redundant space on the top of the
FolderBrowser dialogs. Fixed text which caused label to look unaligned. Prevent
crash when attempting to launch the DownloadAppliance dialog with "http://" as URI.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-22 08:31:58 +01:00
Mihaela Stoica
5d6867dab0 CP-16921: Add new PVS tab
- Changes following code review
- Made PVS tab localizable and added Chinese and Japanese resources

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-07-21 11:47:42 +01:00
Sharath Babu
4d4fab03cb CA-213493: [VMSS] Quiesce info icon and alert icon
in VMSS wizard are not aligned properly

Signed-off-by: Sharath Babu <Sharath.Babu@citrix.com>
2016-07-21 12:43:55 +05:30
Mihaela Stoica
2e62dc8476 CA-216697: MTU message present on the Network Settings page when creating an internal network
In the New Network wizard, when the "Single-Server Private Network" type is selected, the Network settings page should not display the MTU hint message, because it is not relevant to any controls on the page

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-07-20 10:26:12 +01:00
Konstantina Chremmou
2fd3a91ee6 CA-136768: Fixed bad layout of buttons at the top of the snapshots tab page. Also fixed text alignment on the chevron button.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-20 00:04:06 +01:00
Konstantina Chremmou
917754c937 CA-192541: Added detail to the Import/Export OVF/OVA and Import Disk Image actions
title so we can tell the one from the other. For consistency I used a format similar
to Import/export XVA. I also removed the gerund from the latter as it cannot be
used when the action is completed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-19 23:53:17 +01:00
Frezzle
5555709337 [CA-209198] Allowed to attempt to install hotfix when it is already applied
XenCenter no longer ignores checking if the master host already has the specified patch applied; it now checks before trying to apply it, which means we get no error in the Patching Wizard's Patching Page.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-19 17:49:40 +01:00
Gabor Apati-Nagy
893275fb2f CA-215573: Batch updates: Install update wizard "Finish" button activated even when batch install still in progress
Trivial changeset

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-19 09:25:17 +01:00
Gabor Apati-Nagy
a007eec882 CA-216162: Batch updates: Wrong hover message on install update wizard when installing batch updates
Better messages on Select Server Page

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-19 09:12:30 +01:00
Frezzle
25d54119f3 Merge pull request #1062 from MihaelaStoica/CA-107240
CA-107240: VDI move window shows incorrect message for broken storage…
2016-07-14 11:21:07 +01:00
Mihaela Stoica
f96b36f06e CA-107240: VDI move window shows incorrect message for broken storage as ‘Local storage must belong to resident host’
Added null check for SR.Connection, displaying a different message if its null.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-07-14 11:16:19 +01:00
Mihaela Stoica
f2b21975aa CP-16921: Add new PVS tab
- tab visible on pool or standalone server if the feature is not restricted and the pools has at least one farm

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-07-13 13:36:49 +01:00
Mihaela Stoica
b9ec82849b Merge pull request #1050 from fillzero/CA-144951
CA-144951: [WLB Settings] Multiple pop-ups when navigating to Automation tab.
2016-07-12 10:04:27 +01:00
Konstantina Chremmou
ea60eaa24e Merge pull request #1065 from xenserver/CAR-2217
Request to merge CAR-2217 into master
2016-07-11 14:11:00 +01:00
Frezzle
84b587235e Merge pull request #1053 from kc284/master
Some refactoring and small issues fixed.
2016-07-11 11:43:57 +01:00
Frezzle
35f8c3ec2f CA-214953: Multiple connection dialogs while attempting to connect (#1060)
* [CA-214953] Multiple connection dialogs while attempting to connect

ConnectingToServerDialog now keeps track of the dialogs for each connection and focuses on them if they already exist, instead of creating new ones.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>

* [CA-214953] Multiple connection dialogs while attempting to connect

Moved code to handle open connection dialogs to XenConnectionUI, instead of being done inside ConnectingToServerDialog.
Only one error message appears now upon connection failure.
If connection dialog was minimized, and user double-clicks again to connect, it now returns to normal state on the screen as well as taking focus.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-08 16:24:19 +01:00
Mihaela Stoica
21fe02922f Merge pull request #1048 from cheng-z/CA-213045
CA-213045: Make server backup file name rebrandable
2016-07-08 16:16:46 +01:00
Konstantina Chremmou
f63ca812f3 When the host name changes, the teal label of the docked CVM console should change too.
Also, fixed bug where the title of the server's undocked console was truncated to
the server's name when the latter changed.
2016-07-08 13:15:15 +01:00
Mihaela Stoica
ae4670c3b1 CA-107240: VDI move window shows incorrect message for broken storage as ‘Local storage must belong to resident host’
Also fixed a similar issue, where the broken SR was selectable (Create new virtual disk from the SR Storage tab)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-07-08 11:48:29 +01:00
Konstantina Chremmou
7528cefce4 Do not show the CVM's own name on its console, but rather a description including the host's name. 2016-07-08 09:19:39 +01:00
Frezzle
54a2ba7ac4 [CA-107357] Migrate VM Wizard allows selection of broken SRs
Detached SRs are no longer selectable.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-07 14:57:20 +01:00
Konstantina Chremmou
336681fc6a Fixed regression introduced in previous commit. Also, the MultipleDvdIsoList on the
VMstorage page uses the default colours of the controls, hence we only need to set
them on the VNCTabView and the linklabel does not need to be public.
2016-07-06 08:55:28 +01:00
Gabor Apati-Nagy
bd26c7ac0e CA-215093: Batch updates: Update progress failed in a pool of mixed state hosts
Utilising default comparer on Host (This will makemaster first.)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 15:37:52 +01:00
Gabor Apati-Nagy
f8a7d97890 CA-215093: Batch updates: Update progress failed in a pool of mixed state hosts
Where (in code removed by this commit) we iterated through the planActionsByHost dictionary, the hosts were iterated through in the order how the dictionary was initialized. Despite the actions were added in the right order, they then were screwed up, because the Cache.Hosts can have the hosts randomly while we want the master to be first.

To fix the bug, I changed the data structure from a dictionary to a list that has the actions exactly in the (good) order, the order they were added, eliminating the risk of the actions being retrieved in the wrong order.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 14:35:31 +01:00
Gabor Apati-Nagy
1fe300c16d CA-214063: Batch Updates: Name of the master is shown
Removed unused field

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 11:00:40 +01:00
Gabor Apati-Nagy
504f73778f CA-214063: Batch Updates: Name of the master is shown instead of the pool's name on Select Servers Page
Code review changes: Showing server icon for standalone hosts instead the pool icon

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 10:42:49 +01:00
Frezzle
5f412549b2 [CP-17933] Add feature flag for proxy authentication
Made event handler logic clearer and more readable.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-05 10:40:21 +01:00
Konstantina Chremmou
094e4c4c4f CP-18028: For hosts with more than one control domain (dom0 and cvm at the moment) add an extra tab to display the console of the cvm. 2016-07-05 08:14:13 +01:00
Konstantina Chremmou
8991a257d2 Removed some unnecessary methods; changed visibility for controls that don't need to be public. 2016-07-04 23:05:51 +01:00
Frezzle
10261a85e9 [CP-17933] Add feature flag for proxy authentication
Added Registry.ProxyAuthenticationEnabled boolean property to enable/disable proxy authentication UI controls in Connection Options page.
Cleaned up event handler logic in Connection Options page to return from multiple/unnecessary calls to event handlers when manually changing controls through code.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-04 13:47:24 +01:00
Konstantina Chremmou
8de55cb90c Merge pull request #1051 from kallisti5/master
Case sensitivity fixes
2016-07-04 13:30:30 +01:00
Konstantina Chremmou
04ffdbadc5 CP-17756: Do not use the field VM.is_control_domain to find the console for the
host as it applies to other control domains too. Use the new Host.control_domain
field instead. Minor refactoring.
2016-07-04 13:22:08 +01:00
Konstantina Chremmou
56265bbfd6 CP-17756: The dom0 VM is found now using the new field Host.control_domain as
there can be more than one control domains. For older hosts return the control
domain with domid 0. Renamed property.
2016-07-04 13:21:52 +01:00
Konstantina Chremmou
94df31b878 Removed call of virtual member in the constructors. 2016-07-04 08:22:35 +01:00
Cheng Zhang
a682811ed5 CA-213045: Rework on comments to change string format
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-07-04 09:11:10 +08:00
Konstantina Chremmou
f320dd7881 Renamed control because Resharper was complaining about ambiguous references in
the resx files between this and homonymous control in two derived classes. Removed
reference of non-existent file from XenAdmin.csproj.
2016-07-03 19:45:40 +01:00
Konstantina Chremmou
f1b7aadc88 Fixed issue where the error message was not displayed if connection to the host console was not possible.
Refactored to hide/show error controls instead of adding/removing them. Removed duplicate null check.
Do not use a second list to track active VM consoles.
2016-07-03 17:45:49 +01:00
Konstantina Chremmou
8a8bdc21e6 Tidied up the ConsolePanel; moved designer code to the corresponding file and removed setting of virtual field from the constructor. 2016-07-01 17:47:41 +01:00
Gabor Apati-Nagy
55ff3794cf CA-214063: Batch Updates: Name of the master is shown instead of the pool's name on Select Servers Page
Fixed display issue, now showing pools (and standalone hosts at the same level), not masters.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-01 17:41:49 +01:00
Konstantina Chremmou
7d618d9e79 Merge pull request #1049 from MihaelaStoica/CA-116547
CA-116547: During Installation of Hotfix requiring restart of PV gues…
2016-07-01 09:16:29 +01:00
Konstantina Chremmou
051afb48c2 Merge pull request #1012 from MihaelaStoica/CA-209502
CA-209502: Exception while deleting multiple folders
2016-07-01 09:04:48 +01:00
Liang Dai
42f69a7ea1 CA-144951: [WLB Settings] Multiple pop-ups when navigating to Automation tab.
Signed-off-by: Liang Dai <liang.dai1@citrix.com>
2016-07-01 13:37:38 +08:00
Alexander von Gluck IV
47c65d4bcc XenAdmin/Resources: More image path case fixes 2016-06-30 23:01:52 -05:00
Alexander von Gluck IV
4d0097ce9c XenAdmin/TabPages: Case fix on WlbPage files 2016-06-30 22:51:27 -05:00
Alexander von Gluck IV
4cf4c4c33f XenAdmin/Resources: Fix case of images paths 2016-06-30 22:42:58 -05:00
Mihaela Stoica
bcc120f0b2 CA-209502: FolderAction refactoring
- created subclasses for each folder action type (create, rename, delete, move)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-30 15:41:46 +01:00
Mihaela Stoica
60c298d9e3 CA-116547: During Installation of Hotfix requiring restart of PV guests displays Dom0 in the list of VMs to be rebooted in XenCenter.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-30 12:32:41 +01:00
Konstantina Chremmou
975fe4f303 While researching the places where we use is_control_domain, I refactored some issues I noticed and were quick to fix:
- removed unnecessary casts
- no need to catch exception only to rethrow it; do not interrupt the call stack by using "throw ex"
- redundant check and value setting
2016-06-30 12:23:49 +01:00
Cheng Zhang
76f7946ec4 CA-213045: Make server backup file name rebrandable
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-06-30 10:31:10 +08:00
Gabor Apati-Nagy
66be637878 Merging (upstream) master into REQ-156 branch caused a build error:
Fixed build error that was caused by changed visibility of a method.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-29 17:56:51 +01:00
Gabor Apati-Nagy
994f5b4811 Merge remote-tracking branch 'github_xenadmin/master' into master_batch_new2 2016-06-29 16:52:13 +01:00
Konstantina Chremmou
d35c162e76 CP-17689: Restrict maximum host failures to tolerate to the number specified by the other-config:hci-limit-fault-tolerance field. 2016-06-29 12:57:29 +01:00
Gabor Apati-Nagy
9337663adb CP-17282: Unit tests to validate the Update Sequence logic
Unit tests to test GetUpdateSequence

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-29 12:49:53 +01:00
Mihaela Stoica
b42a9e6556 Merge pull request #1043 from Frezzle/CA-213410
[CA-213410] XenCenter ignores proxy settings in some places
2016-06-28 18:02:03 +01:00
Frezzle
e677bc7e52 [CA-213410] XenCenter ignores proxy settings in some places
Changed incorrect web-related call to a correct xenserver-related call.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-06-28 13:40:04 +01:00
Mihaela Stoica
97feb30fbf Merge pull request #1041 from kc284/CAR-2217-other
CP-17866: Grey out the "Move" button on the VM storage tab if the storage does not allow mirroring.
2016-06-28 13:22:30 +01:00
Mihaela Stoica
20cb3b4df1 Merge pull request #1042 from kc284/master
Latest API bindings, including definition of dundee-plus release...
2016-06-28 13:09:36 +01:00
Gabor Apati-Nagy
ee08e06f52 CA-214566: Upload succeeded, but Pool_patch hasn't been found
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-27 19:43:41 +01:00
Frezzle
be94dc2f45 [CA-213410] XenCenter ignores proxy settings in some places
Assigned Proxy property in all WebClient, WebRequest and HttpWebRequest instances.
Removed "proxy not supported" message from Download Appliance dialog, since the download does work with a proxy.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-06-27 17:59:02 +01:00
Konstantina Chremmou
877081d3e8 Merge pull request #1031 from Frezzle/proxy-auth
CP-17231: Implement proxy authentication setting in XenCenter
2016-06-27 11:38:09 +01:00
Konstantina Chremmou
db79326ab1 Merge pull request #1025 from MihaelaStoica/CA-212147
CA-212147: RPU failing with insufficient license error when host lice…
2016-06-27 11:37:46 +01:00
Konstantina Chremmou
3d8ae9daf8 CP-17470: Added missing hotkey. Performance improvement by using Exists instead of FindAll in check. 2016-06-27 10:43:29 +01:00
Konstantina Chremmou
fd3393049c Code simplification: use Action delegate instead of EventHandler since the event is not sending any objects when triggered. 2016-06-27 10:20:23 +01:00
Konstantina Chremmou
5dd2873b72 CP-17866: Grey out the "Move" button on the VM storage tab if the storage does not allow mirroring. 2016-06-24 18:10:22 +01:00
Mihaela Stoica
05059c6f52 CA-213414: Check feature-flag for ssl-legacy control switch
- For Dundee and newer hosts: the feature is restricted only if the "restrict_ssl_legacy_switch" flag exists and it is set to true
- For pre-Dundee hosts: the feature is restricted if the "restrict_ssl_legacy_switch" is absent or it is present and set to true

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-24 13:16:40 +01:00
Frezzle
bf4cf16b81 [CP-17231] Implement proxy authentication setting in XenCenter
Moved MD5Hash function from EncryptionUtils to HTTP class.
Replaced unnecessary new string/List-related functions with existing methods.
Removed redundant string.IsNullOrEmpty() call.
Changed duplicate hotkey in Connection Options page.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-06-24 11:49:55 +01:00
Konstantina Chremmou
7e926f64a3 Rebooted myself. 2016-06-23 21:27:41 +01:00
Frezzle
7faf4fad1d Merge pull request #1032 from MihaelaStoica/CP-17161
CP-17161: Add 'using' statement around dialogs to ensure garbage collection
2016-06-23 15:52:32 +01:00
Mihaela Stoica
e87505e13d CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix a dialog return check changed by accident

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-23 15:47:15 +01:00
Konstantina Chremmou
8e2c381f85 CP-17470: Warn users if they attempt rebooting or shutting down a host running a
VM with the hci-warn-before-shutdown flag. Minor changes to make the warnings for
rebooting and shutting down more consistent (preselect the No button for rebooting;
extended the Yes button text; modified warning text)
2016-06-23 15:26:32 +01:00
Gabor Apati-Nagy
a8445d5ed8 Fixed warning as an error in build
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-23 10:27:16 +01:00
Konstantina Chremmou
3fc701ecb8 CP-17502: Hide SR types from the NewSrWizard if the corresponding sm plugin is not available.
Further, disable the Reattach SR if there is no sm plugin for its type.
2016-06-22 18:34:21 +01:00
Frederico Mazzone
7ec3442f40 [CP-17401] Use Proxy authentication in Health Check Service
Now transfers proxy credentials in encrypted format and checks for default empty credentials when loading them for first time.
Fixed a break in unit test in HTTP.ReadHttpHeaders().

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-06-22 17:10:25 +01:00
Gabor Apati-Nagy
587c2b5f5d CA-214077: Typo in Messages.resx
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-22 14:43:22 +01:00
Frederico Mazzone
9fa8740cb9 [CP-17401] Use Proxy authentication in Health Check Service
Removed last bits of code relating to "Bypass proxy server for local addresses" option.
New proxy settings are sent from XenCenter to health check service and used to configure the proxy using GetProxyFromSettings().
Health check service now correctly saves its proxy settings and updates the static Proxy property for the Session class; done in new ReconfigureConnectionSettings().

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-06-22 13:05:21 +01:00
Gabor Apati-Nagy
39109d30a4 CA-214062: REQ-156 Batch Updates: In progress actions shown as done
Fixed trivial bug where in progress actions had done shown as their statuses

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-22 11:07:12 +01:00
Konstantina Chremmou
bdbd9e1f55 CP-17502: No directly related to this ticket, but I found myself in the ISO SR neighbourhood and did some minor refactoring. 2016-06-21 10:29:37 +01:00
Frederico Mazzone
46c15efe57 [CP-17231] Implement proxy authentication setting in XenCenter
Added 2 textboxes for proxy username and password; encrypted when saved and decrypted when loaded.
Added 2 checkboxes; one for bypassing proxy for xenserver connections, one for providing proxy credentials.
Removed checkbox for bypassing proxy for local addresses.
Controls are no longer enabled/disabled when the related proxy option is selected/deselected.
Making changes to a control (e.g. username, bypass checkbox, etc) selects the 'Use this proxy server' option automatically.
Removed "Bypass proxy server for local addresses" option.
Basic and Digest authentication implemented. Tested with FreeProxy (Basic+Digest), CCProxy (Basic) and AnalogX Proxy (no authentication); each were tested with correct credentials, incorrect credentials and missing credentials; all gave expected results.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-06-20 17:15:00 +01:00
Konstantina Chremmou
0f908a674e CP-17750: Block the patching wizard for clusters with the hci-forbid-update flag (disable the relevant pools/hosts on the select servers page; do not launch the patching wizard at all if there are no clusters that can be patched). 2016-06-20 14:10:00 +01:00
Mihaela Stoica
62870544c6 CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix UpsellDialog usages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 13:26:52 +01:00
Mihaela Stoica
da9e99b1cb CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix ActionProgressDialog usages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 13:17:42 +01:00
Konstantina Chremmou
b575fd3d44 CP-17690: Block RPU for clusters with the hci-forbid-rpu flag (disable the relevant pools/hosts on the select pool page; do not launch the RPU wizard at all if there are no upgradable clusters). 2016-06-20 13:11:21 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
Gabor Apati-Nagy
7a84b305ef CP-17699: Developer testing and improvements
for Batch Updating

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-17 14:15:59 +01:00
Sharath Babu
93e3c05216 Incoporating review comments by Mihaela.
Signed-off-by: Sharath Babu <Sharath.Babu@citrix.com>
2016-06-14 15:22:15 +00:00
Sharath Babu
2ad62fd48e CP-17752: make unit tests use a generic class of policy wizard and
added support for New Policy Wizard help document.

Signed-off-by: Sharath Babu <Sharath.Babu@citrix.com>
2016-06-14 13:20:04 +00:00
Mihaela Stoica
72cffa03e3 CA-212147: RPU failing with insufficient license error when host license removed
If the license does not allow VM migration, then cause the VMs to be shut down / suspended on the pre-checks page

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-14 13:38:12 +01:00
Frederico Mazzone
acf39533fe [CA-207306] Select box is not in line with pGPU bar on GPU tab of host
The last pGPU's row was stretching to the bottom, causing the lowest select box to fill its space and go down too much.
Changed the select boxs' dock style and margin.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-06-13 15:16:31 +01:00
Gabor Apati-Nagy
d04cccea85 Merge pull request #1017 from MihaelaStoica/CA-212905
CA-212905: Fix dialog size
2016-06-13 11:14:26 +01:00
Sharath Babu
32d5c15329 CP-17704: Adding support for help document
Signed-off-by: Sharath Babu <Sharath.Babu@citrix.com>
2016-06-13 09:11:05 +00:00
Mihaela Stoica
996f84c97f CA-212905: Fix dialog size
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-10 11:25:38 +01:00
Gabor Apati-Nagy
546dbca6e1 CP-17444: Show minimal hotfixes on General tab
Changed heading from Recommended Updates to Required Updates following further discussions around wording

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-08 16:16:01 +01:00
Gabor Apati-Nagy
3e092f6d50 CP-17444: Show minimal hotfixes on General tab
Showing recommended* hotfixes for servers when the data is available (Check For Updates xml has been downloaded and has minimalPatches node in it for the given server version). *:Not applied ones from the minimal set.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-08 13:34:59 +01:00
Mihaela Stoica
a89ba4a91e Merge pull request #1013 from kc284/master
CA-212078: Do not check for CPU compatibility feature when the VM's r…
2016-06-08 12:59:26 +01:00
Mihaela Stoica
fcee4d8876 CA-77990: Report required actions for all VMs at once in the hotfix wizard / RPUW (#951)
* CA-77990: Report required actions for all VMs at once in the hotfix wizard / RPUW

* CA-77990: Resolve precheck problems in parallel in the Patching wizard

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-77990: Resolve precheck problems in parallel in the Patching wizard

Changes following code review: Made the ParallelAction work across connections and removed CrossConnectionParallelAction

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-77990: Modified ParallelAction to create queue on RunSubActions only, with the correct queue size

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-07 17:40:59 +01:00
Gabor Apati-Nagy
9ec512921b CP-15790: Prepare XenCenter for unit testing of Automatic Updates
Added support for defining custom update.xml location in Registry. This
can be either a local file or an URL. This will be beneficial when testing XenCenter.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-07 16:02:57 +01:00