Commit Graph

2813 Commits

Author SHA1 Message Date
Mihaela Stoica
8fbfe4c060 Merge branch 'REQ-528' into master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenAdmin/MainWindow.Designer.cs
2017-10-12 11:39:19 +01:00
Mihaela Stoica
7ba7b70a2c Merge pull request #1804 from vetrivelc/master
L10N: CA-259356 Fixed button truncation in JA
2017-10-12 10:47:12 +01:00
Ji Jiang
225474f913 CA-268683: Turn on disable HA on unlicensed pool
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-10-11 14:58:10 +01:00
Gabor Apati-Nagy
010a5189ac Merge pull request #1803 from jijiang/CA-266843
CP-266755 & CA-266843: Fix XC brand string
2017-10-11 12:00:52 +01:00
Kun Ma
1e2bc9a0c3 CP-25081: Add missing resource files for USB controls
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-10-10 18:08:06 +08:00
Michael
e8cb4ad7d6 CP-24412 & CP-24333: USB device list filter in Attach dialog. (#1789)
* CP-24412: Apply a filter before adding USBs to candidate list in Attach Dialog.

* CP-24333: Apply HA restraint.

* CP-24412: Fix a merge error.

* CP-24412: implement actions to attach/detach/passthrough.

* CP-24412: Add license check before making UI components visible.

* CP-24412: Change layout of new components to Dpi.

* Fixed all comments.

* Fix comments.

* fixed comments
2017-10-10 09:05:22 +01:00
Mihaela Stoica
91de7501c4 CA-266814: Fix the precheck that requires shared CDs to be ejected prior to update installation 2017-10-09 16:34:59 +01:00
vetrivelc
795612720e L10N: CA-259356 Fixed button truncation in JA 2017-10-09 12:53:23 +05:30
Callum McIntyre
e77b8f9445 [CP-24974] Avoid calculatingVM agility/failure tolerance twice
This is caused by the `waitingNtolUpdate.waitOne()` call being at the end of the loop, not the beginning. The reason is that the `waitingNtolUpdate` is set during the first iteration (before the thread even gets loaded) - because the setter for Settings in this file sets it (and that's set by the setter for AssignPriorites.Connection, which is set in the HAWizard constructor). So when the thread first spawns we do the calculations, then get to the `waitOne` lock, which is set so we go back around the loop and calculate everything again before returning to the lock and waiting to be triggered. The correct behaviour is to trigger only once on the page load, and then only when re-triggered. To achieve that I've moved the `waitOne` call to the beginning of the loop, so that (assuming the `waitingNtolUpdate` lock is set before the thread is first started) we immediately run the calculations and then stop at the beginning of the loop waiting to be triggered again. This means that on page load (and after each re-trigger) we only calculate once.

The assumption that the lock is set before the thread is triggered is currently valid, because as mentioned above it's currently set by the setter for Settings which is indirectly called by the wizard constructor. I don't want to rely on that behaviour though because it's very indirect, so just to be safe I've added an explicit set just before the thread is triggered so that it's guaranteed to run the calculations the first time. This isn't strictly necessary but seems better than relying on the existing implicit setting. Since we use the same mechanism just in a different place, all the existing code that sets `waitingNtolUpdate` continues to trigger this thread as expected.
2017-10-06 14:07:31 +01:00
Ji Jiang
89bc74583f CP-266755 & CA-266843: Fix XC brand string
Following pattern would be caught when using "XenCenter" "XenServer" and
"Citrix":
1) not "[" or "/" or """ on left of the brand string
2) brand string followed by space followed by not "p", and optional letter
3) optional letter followed by space followed by the brand string
4) brand string followed by "," and optional letter
5) begin with the brand string
6) end with the brand string

tested with all .resx files

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-10-06 13:30:31 +01:00
Mihaela Stoica
b79d7923cc CA-268105: fix the bug where the pool item is disabled when an update is already installed on one host in the pool
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-10-04 16:48:58 +01:00
Mihaela Stoica
20d79ad6f4 Merge remote-tracking branch 'upstream/REQ-67'
Conflicts:
	XenModel/Messages.Designer.cs
2017-10-04 14:40:01 +01:00
Ji Jiang
2f41bbfde1 CA-267553: Fix offline XC showing up to date bug
Refactor the code.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-10-03 18:00:48 +01:00
Mihaela Stoica
a62c04a3a9 Merge pull request #1798 from GaborApatiNagy/master_CA-266911
CA-266911: Exported data from Notification->updates page having incorrect values for "Web page"column
2017-10-03 17:57:26 +01:00
Mihaela Stoica
e6a6a9cc83 Merge pull request #1790 from jijiang/master
CA-267553: Fix offline XC showing up to date bug
2017-10-03 17:52:35 +01:00
Gabor Apati-Nagy
b49c14fd92 CA-266911: Exported data from Notification->updates page having incorrect values for "Web page"column
Displaying the full "Go to web page" URLs in the exported csv file

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-10-03 16:42:48 +01:00
Ji Jiang
7fa784ba96 CA-267553: Fix offline XC showing up to date bug
Fix comments about considering whether XS version is found in updates XML file.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-10-03 15:32:57 +01:00
Gabor Apati-Nagy
c00439bef4 CP-24818: [Update Wizard Improvements] Show the progress of the download in Automated mode
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-10-02 16:35:10 +01:00
Gabor Apati-Nagy
a8db7bfae9 Merge remote-tracking branch 'github_xenadmin/REQ-411' into master_REQ-411_merge
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Core/Updates.cs
	XenAdmin/TabPages/ManageUpdatesPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Messages.Designer.cs
2017-09-29 11:56:46 +01:00
Gabor Apati-Nagy
0cc907bb14 CP-24709: Add a warning in the New VM wizard and Import wizard if the pool is licensed using XD/XA entitlement (#1791)
* CP-24709: Add a warning in the New VM wizard and Import wizard if the pool is licensed using XD/XA entitlement

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CP-24709: Add a warning in the New VM wizard and Import wizard if the pool is licensed using XD/XA entitlement

Fixed unintended designer code additions/changes

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-09-29 11:05:57 +01:00
Ji Jiang
a70307a3a6 CA-267553: Fix offline XC showing up to date bug
The bug is that when XC does not connect to Internet, By Server Update
page shows all the hosts up to date.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-29 10:44:50 +01:00
Gabor Apati-Nagy
39026f300e CP-24707: Add license status information to the title bar for pool and hosts (#1783)
* CP-24707: Add license status information to the title bar for pool and hosts

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CP-24707: Add license status information to the title bar for pool and hosts

Show expired licenses as Unlicensed in the Header

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CP-24707: Add license status information to the title bar for pool and hosts

Improvements, fixes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CP-24707: Add license status information to the title bar for pool and hosts

More code to make it nicer

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CP-24707: Add license status information to the title bar for pool and hosts

More code to make it even more nicer

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-09-28 16:10:41 +01:00
Ji Jiang
268b19421f REQ-534: Fix some UI text display
Based on comments from doc team:
1) Column title "Patching Status" should be replaced by "Status" in csv file
2) In View dropdown, "By Host" should be replaced by "By Server"

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-27 15:14:15 +01:00
kunm
912475a4eb CP-24331 & CP-24135: Add UI support for usb-passthrough on both Host & VM (#1766)
* CP-24331: Add UI for UsbTab and VM Usb Property

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Update XenAPI reference

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Add AttachUsbDialog

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Refine UI changes

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Discard UsbList and little refining to code

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Refine UI code

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Refine USBEditPage

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Refine USBEditPage

Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-09-27 13:37:17 +01:00
Ji Jiang
d0687e5ae3 CP-24708: Show different unlicensed pool/host icon
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-27 11:30:12 +01:00
Ji Jiang
37499d81b6 CP-24477: Add licence check for CBT feature
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-25 18:19:15 +01:00
Ji Jiang
cb97e3788e CP-24405: Add message alert for CBT error msg
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-25 15:14:53 +01:00
Ji Jiang
a63ca0a030 CP-24344: Add HelpID and warning when disable CBT
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-25 15:14:09 +01:00
Mihaela Stoica
0e5f1335d4 CP-24498: RPU wizard to block the selection of unlicensed hosts
Also includes some improvements to the Select Pools page of the RPU wizard
- do not show the checkbox if the item is disabled
- show the icon for the pool items, not only for hosts (making this consistent with the similar page in the Update Wizard)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-09-25 13:27:06 +01:00
Gabor Apati-Nagy
9fec33d892 Merge pull request #1777 from MihaelaStoica/master
CP-24806: Update the RPU hotfix to version 4
2017-09-22 13:58:34 +01:00
Mihaela Stoica
50623be97c CP-24806: Update the RPU hotfix to version 4
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-09-22 13:55:28 +01:00
Ji Jiang
152c25d2f2 Fix compilation error after merging
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-22 11:07:56 +01:00
Ji Jiang
fce3a725cd Merge 'upstream/master' into REQ-67-us
Conflicts:
	XenAdmin/Commands/MigrateVirtualDiskCommand.cs
	XenAdmin/Commands/MoveVirtualDiskCommand.cs
	XenAdmin/TabPages/SrStoragePage.cs
	XenModel/Messages.resx

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-22 11:02:51 +01:00
Ji Jiang
8f03795797 Fix compilation error after rebase REQ-534 on master
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 17:11:43 +01:00
Ji Jiang
f6f17746db CA-265684: Fix bug of disabled "Export All" button
The bug is that "Export All" button is disabled when all hosts are up to
date.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:49 +01:00
Ji Jiang
026c2b8d47 CA-265410: Fix missing required updates
The bug is that required updates for slaves of pre-dundee pool don't show.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
7fd18e99cf CP-24032: Updates page collapsing enhancement
Store the pool collapsing state and rebuild it after refresh.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
41cec6e42b CP-23967: change two superclass to abstract class
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
30400790c1 CP-24032: Updates page: collapsing funtionality
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
17f76870b3 CP-23967: Fix and unify sorting in different views
The commit fixes bug and unify sorting rules in ManageUpdatesPage,
PatchingWizard_SelectServers and RollingUpgradeWizardSelectPool data
grid views.

The rules are:
1) Name column sorted purely by name.
2) Other columns sorted by string value, if the same, sorted by default,
which is still in order even in reverse direction.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
880bde38f6 CP-23455: Add Update btn in Updates page "By Host"
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
d8ca87cd15 CP-24210: fix the patch sorting in newer version
Keep order consistency with general tab for newer version servers.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
1e335de316 CP-24210: Populate "By Host" view correctly
1) Show required updates in case of versions without minimal patches
2) Hide version text in installed updates when version is Ely or above

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
0a33bf1448 Fix PatchingWizard_SelectServers version sorting
The problem is that pool and host rows are mixed when sorting by
version.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
dfe7a2ea70 Refactoring RollingUpgradeWizardSelectPool sorting
Combine sorting by Description and by Version to a single class

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
af9143d199 CP-23967: sort "By Host" view rows in Updates page
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
b5a8282089 CP-23454: Export function in "By Host" view
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:47 +01:00
Ji Jiang
8b2bc83a12 CP-23453: Populate "By Host" view in Updates page
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:47 +01:00
Ji Jiang
66b1b52ad1 CP-23450: Add "View" btn in Updates page toolbar
1) View button has "By Update" and "By Host" options.
2) "By Host" view hides "Filter by Date", "Dismiss All" and "Restore
Dismissed Updates" buttons.
3) "By Host" view turns date filter OFF.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 14:58:04 +01:00
Mihaela Stoica
d4c980dbfd Merge branch 'master' into REQ-230 2017-09-18 13:12:06 +01:00
Hui Zhang
7298b085be CP-23604: Fix the comments to merge to XenAdmin master.
Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
2017-09-18 11:42:13 +01:00
Konstantina Chremmou
673846924b Do not set API object properties that have a default value of "OpaqueRef:NULL" to null.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-14 12:48:05 +01:00
Konstantina Chremmou
915059d099 The Proxy_xxx classes should not be used outside the API bindings (in reality
these classes should have been internal).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-14 11:52:15 +01:00
Ji Jiang
23c903af09 CA-265029: Disable "Move VM" on CBT enabled VM
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-13 14:32:16 +01:00
Mihaela Stoica
92b3dc8395 Merge pull request #1757 from xenserver/REQ-420
Merging REQ-420 into master
2017-09-13 12:35:50 +01:00
Ji Jiang
48afa741b1 CP-24344: Fix and refactor CBT implementation
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-11 14:41:36 +01:00
Konstantina Chremmou
37e3810d73 Removed the background worker and added an async action to retrieve the local
server time (previously on the UI  thread) and also update the message list
for each snapshot schedule. Preserve column sorting and multiple selection
when the list is rebuilt. Do not enforce minimum size on the form since it
is not resizable.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-11 13:22:12 +01:00
Gabor Apati-Nagy
e92d3df839 Merge pull request #1752 from kc284/master
CA-265044: Text corrections on the New VMSS Schedule wizard; image co…
2017-09-08 18:00:03 +01:00
Ji Jiang
0286840728 CP-24343: Display CBT status per VDI in SR storage
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-08 16:44:38 +01:00
Ji Jiang
b19b60f442 CP-24344: Add "Disable CBT" menu item under VM
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-08 14:03:54 +01:00
Mihaela Stoica
4274bf28fb CA-265172: Ensure that the "disk space requirement" precheck is performed for a standalone host in automated updates mode
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-09-07 14:29:39 +01:00
Konstantina Chremmou
4fba904d06 CA-265044: Moved the chevron button immediately below the info icon, so it
does not jump to the bottom of the page when the run history panel is expanded.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-07 13:10:37 +01:00
Konstantina Chremmou
dd76b9f0d5 CA-265044: Text corrections on the New VMSS Schedule wizard; image correction
on the VM Snapshots page; update VM's status on the Snapshots page when the
VM's membership in a policy changes.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-07 12:56:41 +01:00
Konstantina Chremmou
d9aeeb15e5 Rewriting of the Snapshot Schedule dialog for performance optimisation.
Merged the PolicyHistory control into the dialog; removed legacy column from
the policies datagridview; put retrieval of messages on a background thread
to avoid UI freezing if there is a huge number of messages; retrieve messages
only when the VMSS collection changes and not every time the run history grid
is repopulated; sorted out button enabled state.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-07 11:02:07 +01:00
Konstantina Chremmou
1f2b550f4d Renamed controls and moved about methods in view of merging the run history controls into this dialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-06 13:22:29 +01:00
Konstantina Chremmou
9ce11ddf55 Renamed controls and placed them on a panel in view of merging them into the ScheduledSnapshotsDialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-06 13:15:47 +01:00
Gabor Apati-Nagy
5ef13705a5 CA-263044: [XSO-765] Install Update fails because it tries to install the hotfix to one pool twice
Fixed a bug that caused XenCenter to try to apply an update (that the user manually selected) multiple times and therefore failed. This was only present when the Select All button was used.
2017-09-05 18:38:20 +01:00
Konstantina Chremmou
514c33140b Converted remaining extension get and set properties of the API classes to methods
in order to prevent them from being serialised alongside the API properties.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-05 02:15:38 +01:00
Konstantina Chremmou
71301eb332 Removed the extension Properties from the VMSS class. Removed the GetVMSSAlertsAction;
it's not needed as it does not make server calls. Some more refactoring and corrections
here and there.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-04 23:07:22 +01:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Konstantina Chremmou
da3cd070ee Removed VIF.RateLimited property because usage on the VIFDialog shows it is
occasionally preferable to access the qos_algorithm_type directly.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:23 +01:00
Konstantina Chremmou
4825b60a60 Moved UI logic from the VM extensions to the SnapshotsPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:23 +01:00
Konstantina Chremmou
85d398d067 Moved the SR.GetIcon() method to XenAdmin where it belongs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:23 +01:00
Konstantina Chremmou
880d56b30f Renamed method so it's more obvious what it does.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:23 +01:00
Mihaela Stoica
dc2968b3d4 CP-24215: Add null checks when we log the minimal patches
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-09-01 15:34:58 +01:00
Mihaela Stoica
6a2f77c9f6 CA-264439: Change the XenCenter version check to return just a warning in the RPU wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-08-31 09:51:20 +01:00
Ji Jiang
d478115ec6 CA-248292: Fix btn truncation in VM storage page
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-08-30 13:38:53 +01:00
Mihaela Stoica
69007dbaec CP-24213: Some fixes in the Patching wizard
- Change the "Web page" column alignment to TopLeft, to match the other columns
- When trying to find an alert from a filename, use the patch name instead of the alert name, because now the alert name can also be a version name

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-08-30 09:31:05 +01:00
Mihaela Stoica
85d57f558f CP-24215: If the Automated Updates mode goes to a new version, also apply this version's minimum patches
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-08-29 17:00:58 +01:00
Mihaela Stoica
c59a3d14c4 CP-24213: Show CUs as updates
CUs are available as both updates and upgrades, but they should be presented as updates where possible.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-08-25 10:56:04 +01:00
Mihaela Stoica
86d2acee7f Merge branch 'master' into REQ-411
Conflicts:
	CFUValidator/CFUValidator.cs
	CFUValidator/OutputDecorators/XenCenterUpdateDecorator.cs
	CFUValidator/OutputDecorators/XenServerUpdateDecorator.cs
	XenAdmin/TabPages/ManageUpdatesPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Actions/Updates/XenCenterVersion.cs
	XenModel/Actions/Updates/XenServerVersion.cs
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2017-08-23 16:32:39 +01:00
Stephen Turner
89f51e90a1 CA-258782 Remove thin provisioning code (#1728)
* CA-258782 Remove thin provisioning code

* Revert file that shouldn't have been touched

* Remove line that was only present for debugging
2017-08-22 16:40:08 +01:00
Mihaela Stoica
8089617eaf CP-24087: Parse the error parameters of the UPDATE_PRECHECK_FAILED_UNKNOWN_ERROR precheck failure (#1740)
When the update precheck fails with UPDATE_PRECHECK_FAILED_UNKNOWN_ERROR, we try to find the actual error in the failure's parameters (in the form of an xml string containing the error code) and display that error instead of the "unknown error".

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-08-22 16:09:47 +01:00
Mihaela Stoica
67b18665f5 Merge pull request #1737 from vetrivelc/master
L10N:CA-261954,CA-261973 & CA-261977
2017-08-21 12:16:16 +01:00
Vetrivel Chinnasamy
21eff4d819 L10N:CA-261954,CA-261973 & CA-261977 2017-08-21 16:19:39 +05:30
Gabor Apati-Nagy
8514ddf21e CA-261107: Metadata file osVersion is showing same value for XenCenter on different windows versions
Added app manifest to explicitly target XC to all windows versions from Vista to Windows 10 so that the Environment variables will reflect the correct Windows versions. Note that "Manifesting the .exe for Windows 8.1 or Windows 10 will not have any impact when run on previous operating systems." [1]

[1] https://msdn.microsoft.com/en-gb/library/windows/desktop/dn481241.aspx

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-08-18 13:40:36 +01:00
Hui Zhang
d8c248fa76 CP-23604: Add IGMP snooping toggle.
Add the toggle to enable/disable IGMP snooping.
Display the property if the pool is licensed
and the network backend is OVS.

Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
2017-08-16 12:32:18 +08:00
Gabor Apati-Nagy
5a7e6651cd CA-260304: WLB Configuration parameters can not be reset in XenCenter 7.2
Fixed the regression

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-08-15 12:20:25 +01:00
Gabor Apati-Nagy
48134dfd14 Merge pull request #1723 from xenserver/REQ-473
Merge from REQ-473
2017-08-09 10:47:01 +01:00
Ji Jiang
6bfbbc7aa8 CA-141166: Fix truncation issue on HA wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-07-31 09:09:54 +01:00
Mihaela Stoica
5b75b5f25d CA-260365: Hide the build number from the General Tab for Ely and newer hosts (to cover the Honolulu case)
Also restrict the use of build number as an integer to pre-Ely hosts (because a Honolulu host has a non-numeric build number and XenCenter doesn't know the difference between Ely and Honolulu)
And a small update to the pool join rule to match what we have in Honolulu XenCenter (check the database schema regardless of the version)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-27 14:47:12 +01:00
Konstantina Chremmou
ad7e2fa6a6 CA-257927: Changed ChangeableList.RemoveAll method to fire the CollectionChangedEvent
once for all the items to be removed, passing in their list as argument. This method,
and the method Clear calling it, are used for alerts, updates, events and connections,
hence changed the handling of the CollectionChanged event in these cases to expect
either a single item or a collection. In the case of alerts, updates and events
this means that we can rebuild the whole list instead of removing single rows which
causes the application to hang for big numbers of items.
2017-07-24 14:48:02 +01:00
Konstantina Chremmou
bfcdfd982f The event registered on the HistoryPage is ConnectionsManager.History.CollectionChanged,
not ConnectionsManager.XenConnections.CollectionChanged.
2017-07-24 14:48:02 +01:00
Letsibogo Ramadi
2fb35c8faa CA-235459 - G11n:SC: The numeric tag for “Disks” and “Network” is ove… (#1693)
* CA-235459 - G11n:SC: The numeric tag for “Disks” and “Network” is overlap on the search window.

* CA-235459 - G11n:SC: The numeric tag for “Disks” and “Network” is overlap on the search window.

- use col widths from resource file instead of hardcoded values

* CA-235459 - G11n:SC: The numeric tag for “Disks” and “Network” is overlap on the search window.

- safer implementation

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-07-21 16:15:29 +01:00
Letsibogo Ramadi
c44f89bf05 CA-249823 - Accept zip files in Updates Wizard (#1667)
* CA-249823 - Accept zip files in Updates Wizard
* CA-258326 - Improve implementation of CA-248823(Accept zip files in Updates Wizard)
* Small unrelated bugfix: Stop selectFromDiskRadioButton being checked when
restoring dismissed updates.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-07-21 15:56:27 +01:00
Mihaela Stoica
5e2fe55771 CA-260214: Update the uuid of the RPU hotfix (#1704)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-20 12:32:03 +01:00
vetrivelc
a9e5198c7e L10N : Translation updates and bug fixes 2017-07-19 15:09:10 +05:30
vetrivelc
d829654203 Merge branch 'master' of https://github.com/xenserver/xenadmin 2017-07-19 14:22:53 +05:30
Mihaela Stoica
8bdbb122c8 CA-259276: Error when trying to install an update via JA XenCenter
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-06 14:16:06 +01:00
vetrivelc
5abd456a28 L10N: Translation Product tag Correction Checkins 2017-07-06 11:29:02 +05:30
vetrivelc
78fc06d0af L10N : Issue Fixing 2017-07-05 17:10:43 +05:30
Letsibogo Ramadi
7f9b6e65a3 CP-22472 - Add new XenCenter metadata file to the server status report
Change OSCulture to show language currently installed on UI instead of
default language selected at OS installation stage
2017-07-05 11:19:07 +01:00
Gabor Apati-Nagy
51c08c7433 Merge pull request #1666 from MihaelaStoica/CP-21161
CP-21161: Do not call the disk-space plugin cleanup functions on Ely …
2017-07-04 15:37:34 +01:00
Mihaela Stoica
ad0cd9ef00 CP-22472: Add copyright notice
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-04 13:18:59 +01:00
vetrivelc
d624d93865 L10N:CP-23040,CP-23012 Traanslation Checkin 2017-07-04 10:39:46 +05:30
Ji Jiang
5654b4eb89 CA-258321: Incorrect CFU user agent
Fixed user agent string for CFU.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-07-03 17:54:57 +01:00
Mihaela Stoica
dd92f0e6a6 CP-22472: Add more metadata
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Mihaela Stoica
0fbe225fa4 CP-22472: Add new XenCenter metadata file to the server status report: changes following code review
- Add an empty string (instead of 'null') if the IP address is null
- Only include the XC uptime in the SSR produced in XenCenter
- Also changed the name of the metadata file that is included in the SSR

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Mihaela Stoica
713f84cf54 CP-22472: Add new XenCenter metadata file to the server status report: changes following code review
- Added more items to the metadata; the content is now slightly different between the SSR produced in XenCenter and the one from the HealthCheck;
- Encode the metadata string before sending it to the Health Check;
- Always suppress history for the action that sends the proxy settings;
- Renamed some of the new classes;
- Also refactored the actions that send data to the HealthCheck service.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Mihaela Stoica
54ab9307d2 CP-22472: Add new XenCenter metadata file to the server status report
- XenCenter sends its telemetry info to the HealthCheck service
- The HealthCheck service saves this metadata in its settings file and includes it in the health check upload

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Mihaela Stoica
2c37367155 CP-22472: Add new XenCenter metadata file to the server status report
- this adds the telemetry file to the server status report produced in XenCenter

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Letsibogo Ramadi
a5c895da0c Merge pull request #1672 from MihaelaStoica/CA-257760
CA-257760: Strip leading and trailing spaces from the filename in the…
2017-07-03 10:32:24 +01:00
Letsibogo Ramadi
24454ad6a7 Merge pull request #1674 from MihaelaStoica/CA-39992
CA-39992: Add "Repair Storage" action to the PBD_PLUG_FAILED_ON_SERVE…
2017-07-03 10:25:39 +01:00
Mihaela Stoica
743e9938da Merge pull request #1665 from minglumlu/private/mingl/CA-254479
CA-254479,CA-223802,XSO-672: distinct the VM IP addresses which are r…
2017-07-03 09:59:18 +01:00
Mihaela Stoica
813228eed6 CA-39992: Add "Repair Storage" action to the PBD_PLUG_FAILED_ON_SERVER_START alert
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-30 16:24:29 +01:00
Mihaela Stoica
bdbe40187a CA-257760: Strip leading and trailing spaces from the filename in the Import wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-29 16:19:39 +01:00
Gabor Apati-Nagy
c0edd4c587 CA-224724: VBD edit page: show 'position in use' message on the dropdown items
requested changed by code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-29 12:04:16 +01:00
Gabor Apati-Nagy
33c95f5e6f CA-224724: VBD edit page: show 'position in use' message on the dropdown items
requested changed by code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-29 12:04:16 +01:00
Gabor Apati-Nagy
5df4d174c0 CA-224724: VBD edit page: show 'position in use' message on the dropdown items
This commit changes the dropdown control to not only show the available
positions, but also mark the ones that are already being used.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-29 12:04:16 +01:00
minglumlu
3a7d1c1cd9 CA-254479,CA-223802,XSO-672: distinct the VM IP addresses which are retrieved from XAPI. 2017-06-28 10:08:16 +08:00
Mihaela Stoica
c061b0f57d CA-257574: Manage vApps dialog is unusable with a vApp containing a l… (#1664)
* CA-257574: Manage vApps dialog is unusable with a vApp containing a large number of VMs

- In the VMAppliancesDialog, change event handlers to reduce the number of refreshes when something changes: only reload the appliances when the VM_appliance collection change; if a relevant property is changed (in VM_appliance or VM), then update only the affected rows.
- Improve the way we assign VMs to a group (AssignVMsToVMApplianceAction and AssignVMsToPolicyAction): only update the VMs that really changed.
- Also improve the way we update the VM startup options and HA restart priorities on a set of VMs

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-257574: Manage vApps dialog is unusable with a vApp containing a large number of VMs: changes following code review

- reverted the changes to the AssignVMsToGroup actions that added the additional constructor
- changed the AssignVMsToGroup actions to calculate the set difference between two lists more efficiently
- added code to deregister PropertyChanged events on VM_appliances
- removed getCurrentSettings() method as it is not needed, GetChangedSettings can be used in all cases

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-27 17:32:46 +01:00
Mihaela Stoica
537e569a62 CP-21161: Do not call the disk-space plugin cleanup functions on Ely and above hosts
- Ensure that the disk-space plugin functions are not called on Ely or greater hosts, except for the 'get_avail_host_disk_space' function, which is still needed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-27 13:48:54 +01:00
Gabor Apati-Nagy
10e2aff2e4 CA-257553: Unexpected error on the Memory tab while running an "Instant VM create" action
Calling Rebuild() from the event thread now

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-22 15:49:15 +01:00
Vetrivel Chinnasamy
1fce4298e5 L10N: Fix CA-255548 & translation updates (#1660) 2017-06-22 09:19:58 +01:00
Mihaela Stoica
15d748925a Merge pull request #1641 from letsboogey/CA-220169
CA-220169 - Network heartbeat status initially shows 'Error' after en…
2017-06-21 17:02:36 +01:00
Mihaela Stoica
bfab94f923 Merge pull request #1653 from letsboogey/CA-177402
CA-177402 - XenCenter doesnt show migrate option on selecting multipl…
2017-06-21 10:11:45 +01:00
Letsibogo Ramadi
a579ac9196 CA-177402 - XenCenter doesnt show migrate option on selecting multiple Suspended VMs
Enable CrossPoolMove for a single VM too

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-20 15:00:49 +01:00
Letsibogo Ramadi
c1635fba58 CA-220169 - Network heartbeat status initially shows 'Error' after enabling HA
Renaming and minor refactoring

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-20 14:56:26 +01:00
Stephen Turner
eda73f1dff Fix several usage errors identified by Lexica 2017-06-20 14:29:22 +01:00
Gabor Apati-Nagy
46edc78e50 Merge pull request #1654 from MihaelaStoica/CA-241298
CA-241298: Do not offer to install tools if the VM runs on a slave in…
2017-06-20 13:27:04 +01:00
Konstantina Chremmou
d88fc10e3f Merge pull request #1649 from letsboogey/CA-247333
CA-247333 - Remove rdpclient6 code after April 2017
2017-06-20 13:19:52 +01:00
Letsibogo Ramadi
a17063ec7d CA-177402 - XenCenter doesnt show migrate option on selecting multiple Suspended VMs
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-20 12:29:03 +01:00
Gabor Apati-Nagy
ee2f1ef920 Merge branch 'master' of https://github.com/xenserver/xenadmin into CA-243675
Conflicts:
	XenModel/Messages.resx
2017-06-20 11:40:03 +01:00
Letsibogo Ramadi
cca0ab5d89 CA-247333 - Remove rdpclient6 code after April 2017 when it will become redundant
-Removed rdpControl because it is always identical to rdpClient9
-Renamed rdpClient9 to just rdpClient because we use only one
client so there is no need to distinguish, and it can easily be updated
to future versions.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-20 11:33:52 +01:00
Mihaela Stoica
410e77d94e CA-241298: Do not offer to install tools if the VM runs on a slave in a partial upgraded pool
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-16 16:49:06 +01:00
Letsibogo Ramadi
ddd481fff0 CA-177402 - XenCenter doesnt show migrate option on selecting multiple Suspended VMs
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-16 14:38:22 +01:00
Gabor Apati-Nagy
71ed9d8955 Merge pull request #1651 from kc284/master
CA-257209: The VNCControl has been deprecated.
2017-06-16 14:12:41 +01:00
Mihaela Stoica
7cd7be6d03 Merge pull request #1648 from GaborApatiNagy/master_fixbuild
CA-255547: WLB code in XenCenter: Remove all code targetting <= 6.1 XenServers
2017-06-16 09:43:53 +01:00
Konstantina Chremmou
39f3e9ea1e CA-257209: The VNCControl has been deprecated. 2017-06-16 08:55:38 +01:00
Gabor Apati-Nagy
9806491863 CA-243675: No Clear error message when proxy server which is configured is not running
Mention proxy in the suggestion that is shown when a connection fails

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-15 17:54:27 +01:00
Gabor Apati-Nagy
c19ee0bf13 CA-255547: WLB code in XenCenter: Remove all code targetting <= 6.1 XenServers
Fixed build by removing unused fields that caused the Release build to fail. Removed more dead code.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-15 16:11:05 +01:00
Gabor Apati-Nagy
9b336ec3c6 CA-255547: WLB code in XenCenter: Remove all code targetting <= 6.1 XenServers
Put back code that shouldn't have been removed

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-15 16:09:32 +01:00
Mihaela Stoica
cd71c4fe1c CA-249858: Fix build warning as error
(The member 'CanExecute()' does not hide an inherited member. The new keyword is not required)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-15 08:31:47 +01:00
Konstantina Chremmou
062938878d Merge pull request #1602 from GaborApatiNagy/master_CA-220047
CA-220047: Show proper precheck error when a VM cannot be migrated
2017-06-15 08:24:06 +01:00
Letsibogo Ramadi
5e458ac234 CA-247333 - Remove rdpclient6 code after April 2017 when it will become redundant 2017-06-14 17:22:42 +01:00
Letsibogo Ramadi
be6b2ebcb3 Merge pull request #1630 from kc284/master
One more take to CA-231518
2017-06-14 13:37:13 +01:00
Gabor Apati-Nagy
5fe4b8ba09 Merge pull request #1639 from GaborApatiNagy/CA-255547
CA-255547: WLB code in XenCenter: Remove all code targetting <= 6.1 XenServers
2017-06-14 10:02:36 +01:00
Gabor Apati-Nagy
4e8541fb91 Merge pull request #1642 from MihaelaStoica/CA-249858
CA-249858: XenCenter gives different messages for migrate VM at diffe…
2017-06-13 16:53:19 +01:00
Mihaela Stoica
a79e156cf5 CA-249858: Moved the Trim call
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-13 16:47:43 +01:00
Mihaela Stoica
77b73c8d16 CP-22471: Add information on XenCenter help usage to the user settings
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-13 13:42:26 +01:00