Commit Graph

296 Commits

Author SHA1 Message Date
Letsibogo Ramadi
045c405f92 CA-239951 - Patching wizard allows selection of unreachable hosts
Disabled the ability to select unreachable hosts and in addition
added a try/catch block to hide error message resulting from trying
to clean up an unreachable host.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-25 10:28:11 +00:00
Mihaela Stoica
b14cc05968 Merge pull request #1397 from letsboogey/master
CA-236114 - Wrong update is installed when two different updates are …
2017-01-23 12:51:03 +00:00
Letsibogo Ramadi
cdfdacd88f CA-236114 - Wrong update is installed when two different updates are uploaded in the same instance of the wizard
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-23 12:36:47 +00:00
Gabor Apati-Nagy
d85cc824b5 Merge pull request #1392 from letsboogey/master
Ca-238273 - Install Update Wizard: Update still shows up in the grid …
2017-01-20 17:01:26 +00:00
Letsibogo Ramadi
8f48c99b2d Ca-238273 - Install Update Wizard: Update still shows up in the grid after it's been installed
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-20 11:35:25 +00:00
Konstantina Chremmou
a59e4f4ad3 Merge pull request #1382 from GaborApatiNagy/master_CA-176169
CA-176169: Copyright statement checking
2017-01-19 15:14:25 +00:00
Mihaela Stoica
3abce40f74 CA-226900: Do not allow selection of individual pool members when installing a hotfix
Changed the rubric on the Select Servers page.
2017-01-18 10:59:35 +00:00
Gabor Apati-Nagy
978f85233c CA-176169: Added copyright statement to files which it was missing from
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-16 20:14:56 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Mihaela Stoica
84df0d5f80 CA-239210: Fixed the tab order on the Select Servers page
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-11 11:48:58 +00:00
Mihaela Stoica
b418a8a170 CA-226900: Do not allow selection of individual pool members when installing a hotfix
This change does not apply to supplemental packs, as we should be able to install supp packs to individual hosts in a pool.
Also, if the wizard is installing an update from disk and we cannot match it in updates.xml, then we will continue to allow host selection, because we can't tell whether it is a supp pack or a hotfix.

Plus fixing the bug where the "Select All" button is enabled even when all the selectable servers/pools are selected

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-11 11:32:57 +00:00
Konstantina Chremmou
cbdf7d3742 Merge pull request #1334 from MihaelaStoica/CA-216752
CA-216752: Not all wizards progress through to the next page by press…
2016-12-22 09:14:29 +00:00
sri harsha tagore k
fcda47d3a0 L10N:Translations check-ins
Cherry-picked: ff6a3984d5a97313903a4d230bca15e54674976e [ff6a398]
Author: sri harsha tagore k <sriharshatagore.karpurapu@citrix.com>
2016-12-21 16:20:30 +00:00
Gabor Apati-Nagy
7ce6d50ed0 CA-236547: Unexpected error while applying hotfix on multiple Xenservers of different version
Reset both before any upload as the upload is going to set the correct one anyway

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-21 10:37:06 +00:00
Gabor Apati-Nagy
9bd776c83d CA-236547: Unexpected error while applying hotfix on multiple Xenservers of different version
Fixing the error, so the hotfix installation will fail as and where it is expected

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-19 18:00:42 +00:00
Gabor Apati-Nagy
9d5e71326c CP-20065: Change "Automatic Update" to "Automated Updates"
changed more messages following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-12 18:12:01 +00:00
Gabor Apati-Nagy
5ed6a7c8ff CP-20065: Change "Automatic Update" to "Automated Updates"
more renaming

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-10 15:01:25 +00:00
Gabor Apati-Nagy
b0ca08ae6d CP-20065: Change "Automatic Update" to "Automated Updates"
made naming more consistent

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-10 14:44:15 +00:00
Gabor Apati-Nagy
5b6bedea48 CP-20065: Change "Automatic Update" to "Automated Updates"
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-10 14:19:37 +00:00
Mihaela Stoica
508f638b3a CA-216752: Not all wizards progress through to the next page by pressing the Enter key
- Added a new method in XenTabPage which the derived classes can implement to select a default control after the page is loaded.
- Added a new wizard test that runs through the wizard by pressing the Enter key and checks if it has landed on the right page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-08 14:52:21 +00:00
sri harsha tagore k
821f42e1f2 L10N:Translations check-ins 2016-12-02 20:13:49 +05:30
Gabor Apati-Nagy
9c4628f216 CA-229365: Install Update Wizard: Fixed commas in the blurb
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-25 17:40:15 +00:00
Gabor Apati-Nagy
5cd032525c CA-229009: VDI is not deleted for the updates
If batch updating fails in a pool, this code will do the clean up by
running the appropriate (next in the queue) RemoveUpdateFilesFromMaster action. In addition to Pool_update.clean(), Pool_update.destroy() will be called when needed.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-24 10:40:06 +00:00
Gabor Apati-Nagy
838303b3b3 CA-230461: NullReferenceException during batch update when no check-for-updates has been performed
Removed unneeded overload and it's usage

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-16 13:53:29 +00:00
Gabor Apati-Nagy
34169dd256 CA-230461: NullReferenceException during batch update when no check-for-updates has been performed
Much better way to update/download the CFU

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-16 12:26:26 +00:00
Mihaela Stoica
ceaa7460e4 Merge pull request #1281 from GaborApatiNagy/CA-229009&CA-229019
CA-229019 and CA-229009
2016-11-10 17:52:24 +00:00
Gabor Apati-Nagy
7790c8e51d CA-229019: XenCenter behavior on installing already uploaded update
Code review follow up commit

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 17:46:07 +00:00
Mihaela Stoica
bef415cc98 Merge pull request #1277 from GaborApatiNagy/CA-227719
CA-229185: XenCenter: Dundee and Creedence hosts should be disabled for Ely updates in 'Select Servers'
2016-11-10 17:20:03 +00:00
Gabor Apati-Nagy
b0588d980a CA-229009: VDI is not deleted for the updates
XenCenter will now remove VDIs that couldn't been introduced.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 17:18:51 +00:00
Gabor Apati-Nagy
4fad0d309a CA-229019: XenCenter behavior on installing already uploaded update
The Pool_update does not always covers all the VDIs XenCenter creates. These orphaned ones have to be deleted as well.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 17:15:40 +00:00
Gabor Apati-Nagy
7b6a296a68 CA-229185: XenCenter: Dundee and Creedence hosts should be disabled for Ely updates in 'Select Servers'
For ISO updates, when disabling hosts, use the filename matching logic for pre-Ely hosts as well.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 14:57:10 +00:00
Mihaela Stoica
a609e440f6 Merge pull request #1272 from mcintyre94/CA-228729
[CA-228729] Improve the message shown on finishing the update installation
2016-11-10 14:47:29 +00:00
Mihaela Stoica
30a5f36515 Merge pull request #1271 from mcintyre94/CA-228723
[CA-228723]  Cancelling update installation leaves the update in xapi db
2016-11-10 14:45:51 +00:00
Callum McIntyre
638d8fe9e6 [CA-228723] Use sync destroy method in the cleanup action 2016-11-09 16:32:16 +00:00
Callum McIntyre
4a2b27e8ab [CA-228729] Improve the message shown on finishing the update installation
Changed the message to Delete/Deleting/Deleted update installation files, as used in other messages.
2016-11-09 15:52:52 +00:00
Callum McIntyre
d71d9d10d8 [CA-228729] Improve the message shown on finishing the update installation
Previous message was Remove/Removing/Removed Updates, which is confusing. Changed to Clean/Cleaning/Cleaned Update Files.
2016-11-08 16:53:50 +00:00
Callum McIntyre
d7060cbdb1 [CA-228723] Cancelling update installation leaves the update in xapi db
Modify the cleanup pool update action to also call update destroy (removing the update from xapi db) when the update has not been applied to any hosts (ie we cancelled the wizard before completion).
2016-11-08 15:31:35 +00:00
Gabor Apati-Nagy
bb298cc213 Merge pull request #1270 from MihaelaStoica/CA-227034
CA-227034: Slipstream packaged Live patching hotfix is rebooting host
2016-11-08 14:44:07 +00:00
Mihaela Stoica
6b374cb400 CA-227034: Slipstream packaged Live patching hotfix is rebooting host
This happened because the LivePatchCodesByHost was null when the prechecks were generated for an update, so the live patch codes returned by the precheck were ignored.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-08 11:43:54 +00:00
Callum McIntyre
15e04d1a6d [CA-227845] Fixing problems caused by tooltip container on hotfix wizard mode page
Due to the tooltip container introduced for the automatic radio button, winforms didn't treat these radio buttons properly - we needed code to make them mutually exclusive, tab didn't behave properly and keyboard arrow navigation between them didn't work. Therefore I have removed the tooltip container (so our radio buttons behave properly without any extra work) and we instead use a winforms tooltip shown when the mouse is over the automatic radio button. Note that since the control is disabled when we want a tooltip, neither hover events nor attaching a winforms tooltip in the usual way will work. Therefore I use a mousemove event on the table, which displays the tooltip if and only if we are over the disabled control. Also adjusted the tab indexes to make sure tab works correctly across the whole page.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-04 17:09:52 +00:00
Cheng Zhang
0b27b36d9b CA-227274: Fix CN and JP version process lable size
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-11-02 18:05:36 +08:00
Callum McIntyre
07f866e3a0 [CA-227602] Remove the unused bottom row from the table
This fixes the extra padding, we don't need that bottom row at all

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-01 16:32:45 +00:00
Callum McIntyre
722527f84e [CA-227602] Truncation on the Install Mode page in the Install Upgrade wizard
I've looked at how this was implemented in Dundee, and there we used an absolute height on the row containing the manual checkbox. I've done the same here, changing row 3 from autosize to absoliute 47px. I've also removed the empty row that was between the two radio buttons. This is a Winforms problem, without workarounds an autosize radio button in an autosize container (say the table row) will report its height as one row of text, no matter whether it needs more. This seems to be the only place we use a long radio label (as opposed to a separate label underneath the radio), so I doubt it's worth doing anything more complex than this. I've tested it with the CN string used in the ticket, and it uses less space than the English translation. The string also hasn't changed from Dundee.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-01 15:17:43 +00:00
Gabor Apati-Nagy
55a4957056 Removed unused field (Release build failed on this)
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-21 11:29:32 +01:00
Gabor Apati-Nagy
92b59a9e44 CA-226261: Install HFX Wizard: Mode page: both radio buttons selected
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-21 10:20:25 +01:00
Gabor Apati-Nagy
668979c29f Merge remote-tracking branch 'github_xenadmin/master' into CAR-2245_temp
Conflicts:
	XenAdmin/TabPages/GeneralTabPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizardModeGuidanceBuilder.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_ModePage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
	XenAdminTests/WizardTests/PatchingWizard/PatchingWizardModeGuidanceBuilderTests.cs
	XenModel/Network/Cache.cs
	XenModel/XenModel.csproj
2016-10-20 19:12:57 +01:00
Gabor Apati-Nagy
1c7f6ac643 Merge remote-tracking branch 'github_xenadmin/CAR-2245' into CAR-2245_temp 2016-10-20 17:58:20 +01:00
Gabor Apati-Nagy
6c26359dd6 Merge pull request #1222 from MihaelaStoica/CAR-2245
CP-19218: Add restart warnings to the Precheck Page when installing h…
2016-10-20 17:41:32 +01:00
Gabor Apati-Nagy
f4a0f3ae40 CP-19303: XenCenter: Use new livepatching codes
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-20 17:19:42 +01:00
Mihaela Stoica
2a66b68c7b Merge pull request #1220 from GaborApatiNagy/CAR-2245_temp
CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
2016-10-20 16:02:05 +01:00