Commit Graph

6754 Commits

Author SHA1 Message Date
Konstantina Chremmou
e582ae1e24 Use the server combobox's item list for autocompletion suggestions.
This fixes occasional crash when typing in the combobox.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-21 15:51:59 +00:00
Konstantina Chremmou
e4cecfb1bd Removed unused button and made minor layout tweaks.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-21 15:51:59 +00:00
Konstantina Chremmou
8ede70ff99 CA-375942: Corrected RBAC check for create/destroy vTPM (rely on the actions' RBAC check instead of replicating it on the dialog).
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-20 08:55:30 +00:00
Konstantina Chremmou
ef4ceaac3c
Merge pull request #3113 from danilo-delbusso/localised-install-CA-375703
CA-375703: Remove leftover language mentions in `XenCenter.wxs`
2023-03-08 09:57:28 +00:00
Danilo Del Busso
d4f232cd87
Remove unused lines from xenadmin-build.sh
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-08 09:53:25 +00:00
Konstantina Chremmou
1b8fd8eb48 CA-375668: Report bytes uncompressed instead of percentage when uncompressing a gzip.
GZipStream does not support Position.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-08 09:51:06 +00:00
Danilo Del Busso
2585da8bb3
CA-375703: Remove leftover language mentions in XenCenter.wxs
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-08 09:35:27 +00:00
Ross Lagerwall
91b224d0c4 CP-41775: Fix using Hanja/Hangeul keys over VNC
Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
2023-03-06 15:59:48 +00:00
Konstantina Chremmou
8cf8e6289a
Merge pull request #3086 from danilo-delbusso/FCoE-CP-41737
CP-41737: Add FCoE deprecation warnings
2023-03-06 15:25:25 +00:00
Konstantina Chremmou
4034a48ee3 Reordered templates on the NewVM wizard:
- Moved Windows Server templates to a different category.
- Show templates in reverse alphabetical (typically release) order.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-06 15:24:41 +00:00
Danilo Del Busso
e5664bab7e Update CODEOWNERS and MAINTAINERS
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-06 14:44:17 +00:00
Danilo Del Busso
8f6ebb63fd CP-42354: Bump branding version
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-02 15:41:21 +00:00
Konstantina Chremmou
5bf8559b60 Show more analytical warning.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-02 09:04:43 +00:00
Konstantina Chremmou
fddca73f08
Merge pull request #3090 from kc284/custom_fields
Fixed some issues around custom fields
2023-03-01 14:31:18 +00:00
Konstantina Chremmou
488f27e2ae Revised Rbac checks for addition/removal of custom fields.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:25:02 +00:00
Konstantina Chremmou
5c70cbfd3d CA-84612: Rewrote the CustomFields Property page to fix some issues:
- The CustomFieldsDialog was an unnecessary intermediate step deteriorating the user experience.
- Fixed layout issues when we have a long list of custom fields.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:03:16 +00:00
Konstantina Chremmou
0d1e4993ec Added blurb to the NewCustomFieldDialog; improved error message and control state checks.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:03:16 +00:00
Konstantina Chremmou
bc40d47ba6 Corrections to removal of custom fields:
- Custom fields were not removed from all types of objects the UI allows
  setting them for, which meant they were left behind in the other_config.
- Only remove a custom field if it is set on an object, otherwise we hammer
  the server with unnecessary requests.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:03:16 +00:00
Konstantina Chremmou
423ee7bd81 Added RBAC checks to the actions adding/removing custom fields. Also:
- Converted them to proper AsyncActions to facilitate further refactoring.
- Moved SaveCustomFieldsAction to the same folder as the above.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:03:15 +00:00
Konstantina Chremmou
87ff42086f Missing RBAC permission checks for CreateDiskAction.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 15:36:13 +00:00
Konstantina Chremmou
d3a2805af8 Renamed private fields to match conventions.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 15:36:13 +00:00
Konstantina Chremmou
8c42b0428e Refactored the actions creating disks.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 15:36:13 +00:00
Konstantina Chremmou
5828c03e8d CA-375173: Create the VDI and VBD records before closing the new disk dialog. Also:
Fixed issue where the SR was not preselected when editing an existing disk and no scans were taking place.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 15:36:13 +00:00
Danilo Del Busso
43e2cecf32
CP-41737: Update copyright notices
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-28 08:07:30 +00:00
Danilo Del Busso
c13ba4082d
CP-41737: Consider upgrade version in PoolHasFCoESrWarning
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-28 08:07:29 +00:00
Danilo Del Busso
fa12c5d10c
CP-41737: Update warning UI elements
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@cloud.com>
2023-02-28 08:07:29 +00:00
Danilo Del Busso
7fa8731c59
CP-41737: Update CanRun override logic in PoolHasDeprecatedSrsCheck
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-28 08:07:29 +00:00
Danilo Del Busso
727612b68b
Apply code review suggestions
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-28 08:07:28 +00:00
Danilo Del Busso
04e209bd37
CP-41737: Add FCoE SR deprecation warning to New SR wizard
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-28 08:07:28 +00:00
Danilo Del Busso
7da325899b
CP-41737: Add FCoE SR deprecation warning to SR general tab
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-28 08:07:28 +00:00
Danilo Del Busso
11328e86b9
CP-41737: Add FCoE SR deprecation warning in RPU wizard
Support for Software FCoE deprecation has been announced in 8.2 CU1

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-28 08:07:27 +00:00
Danilo Del Busso
6cdf37a22c
Tidy up minor code smells in RollingUpgradeWizardPrecheckPage
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-28 08:07:27 +00:00
Danilo Del Busso
1607f67a59
Remove redundant qualifiers in Helpers.Versions.cs
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-28 08:07:27 +00:00
Danilo Del Busso
af23635a20 CA-375366: Delete ZIP file generated while checking write permissions in BugToolPageDestination.cs
Also contains minor whitespace tidy up

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-24 18:09:52 +00:00
Konstantina Chremmou
f139334ac3 CP-40842: Changed icons for status report rows.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-24 18:09:42 +00:00
Danilo Del Busso
3edf31b7a2 CA-375346: Point to Wix Shell instead of executable when launching XenCenter
XenCenter executable was started with elevated privileges even with use of `Impersonate = "yes"`, and `WixShellExecTarget` was actually ignored.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-24 18:09:28 +00:00
Konstantina Chremmou
4089e821bd
Merge pull request #3099 from danilo-delbusso/remove-localisation-CP-41748
CP-41748: Remove non-English locals from installer
2023-02-22 14:41:34 +00:00
Danilo Del Busso
88a60312df
CP-41748: Update branding tag in Jenkinsfile
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-22 14:30:11 +00:00
Danilo Del Busso
c74f6169bf
CP-41748: Remove non-English locals from installer
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-22 14:29:50 +00:00
Danilo Del Busso
92b9f59e55
Merge pull request #3098 from danilo-delbusso/chc-rename-CP-42186
CP-42186: Rename CHCUpdates mentions and schema into XC based ones
2023-02-22 11:40:59 +00:00
Danilo Del Busso
ea9669ce1b
CP-42186: Update XML tag name in DownloadUpdatesXmlAction
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-22 10:30:05 +00:00
Danilo Del Busso
375b7485a6
CP-42186: Update tags in Jenkinsfile
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-22 10:30:04 +00:00
Danilo Del Busso
044ca44f3f
CP-42186: Rename CHCUpdates mentions and schema into XC based ones
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-22 10:29:38 +00:00
Konstantina Chremmou
91055c6e2c
Merge pull request #3096 from kc284/master
(master) CP-42155: Removal of HealthCheck service leftovers
2023-02-21 16:13:00 +00:00
Konstantina Chremmou
c70116691a Corrections as per code review:
- Bumped branding to v4.11.
- Reverted VS version in the solution file.
- Removed brand override registry entry.
- Converted HealthCheck warning pop-up to info pop-up.
- Moved status report actions to a separate folder.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-21 16:05:10 +00:00
Konstantina Chremmou
7063b3e130 CP-42155: Removed HealthCheck service and related dialogs.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-21 16:05:09 +00:00
Konstantina Chremmou
b49481b83b CP-42155: Removed HealthCheck tests.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-21 16:05:09 +00:00
Konstantina Chremmou
3a71ff29eb CP-42155: Removed HealthCheck service leftovers from the build and the installer.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-21 16:05:09 +00:00
Danilo Del Busso
39b84bbcc5 CA-375282: Insert sanitised TARs into Temp folder
Avoids permission related exceptions

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-17 11:50:33 +00:00
Danilo Del Busso
653d66cb10 CP-40842: Report host action as failed when connection isn't possible
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-14 11:26:17 +00:00