Commit Graph

841 Commits

Author SHA1 Message Date
Konstantina Chremmou
393e041c4f Removed commented out and dead code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-27 11:30:58 +01:00
Konstantina Chremmou
3082745c85 Tidied up WLB report files:
- Moved the business logic classes to XenModel close to their base class.
- Moved WorkloadReports dialog close to the other WLB dialogs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-26 17:54:53 +01:00
Konstantina Chremmou
2dff51f4cc CA-353426: Button text was truncated in Japanese.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-04 13:05:44 +01:00
Konstantina Chremmou
b116c4713d CA-353524: Full copy of VM on the same SR is allowed.
Moving and copying a VM should be treated differently, hence we need a different
SrPickerItem subclass for each operation. Minor logic simplifications.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-04 13:05:27 +01:00
Konstantina Chremmou
6d8ad062f8 CA-353070: Corrected wizard title. Fixed navigation with the Tab key.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-08 17:28:48 +01:00
Konstantina Chremmou
abf4ae3f35 CP-36392 pt.1: Removed unused using directives.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-07 10:04:47 +01:00
Konstantina Chremmou
e5bee7be6a Added Events in progress to the outlook-style status labels of the main window.
- Reordered the labels to reduce flickering for short actions.
- No need to fire action events in a try-catch block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-07 10:04:30 +01:00
Konstantina Chremmou
35e1d68afa CA-352901: Fixed window title and translations for window title and menu item.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-01 11:30:54 +01:00
Mihaela Stoica
a5d7bdc0ec CA-352678: Diagnostic token is not needed for uploads to CIS from the SSR wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2021-03-17 15:30:59 +00:00
Mihaela Stoica
96956dbc81 CA-352663: Fix button action on Custom Field deletion confirmation dialog
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2021-03-16 00:13:06 +00:00
Konstantina Chremmou
a109f5f22d Pascal-cased method name.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-02 11:57:50 +00:00
Darren Matthews
a8988276be L10n : Resx resync and translation update
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2021-03-02 09:44:29 +00:00
Vetrivel Chinnasamy
78033c8186 CA-350227: L10N- Translation Updates 2021-01-15 11:54:48 +00:00
Konstantina Chremmou
f73ea42cb2 CA-343280: Reworked saving user settings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-07 15:57:26 +00:00
Konstantina Chremmou
60fb141e57 CA-339384: Take account of thin provisioning when placing a disk on a target SR.
Also, set the required disk size to zero when the disk spinner value is invalid.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-11-18 09:24:45 +00:00
Konstantina Chremmou
c9a70d282e Do not disable the OK button on validation, but rather point out the problematic entry using validation tooltips.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-11-03 11:34:06 +00:00
Konstantina Chremmou
c1375c51ed CA-347407: Handle exceptions when failing to unprotect saved proxy credentials.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-11-03 11:34:06 +00:00
Konstantina Chremmou
248b99abd7 Fixed layout issue whereby the rightmost textboxes were spilling out of the containing groupbox when the control was resized.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-11-03 11:34:06 +00:00
Konstantina Chremmou
61d77cada4 CA-343956: Corrected action performed by the Attach Disk context menu item. Show grip on the Attach Disk dialog.
The dialog is launched non-modally, hence showing the grip automatically has no effect.
Also, made the dialog slightly bigger.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-11-03 11:33:16 +00:00
Darren Matthews
a9016bc14e L10N : Translation Update and RESX resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-10-13 13:56:55 +01:00
Konstantina Chremmou
1e6197022e
CA-339233: Do not allow selection of networks while they're locked. (#2733)
* Hid properties from the designer and renamed them because they give the wrong impression.
* Fixed some inefficiencies around the NetworkComboboxItem.
- Move NetworkComboBoxItem into the NetworkComboBox class.
- Moved XenAdmin.Dialogs.NetworkComboBoxItem into the VIFDialog class and made it
  private to avoid ambiguousness with the public XenAdmin.Controls.NetworkComboBox.NetworkComboboxItem.
- Create a NetworkComboBoxItem only if needed and assign its name at construction time.
- Add method to select a NetworkComboBoxItem and property to return the SelectedNetwork.
* CA-339233: Do not allow selection of networks while they're locked.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:34:03 +01:00
Konstantina Chremmou
25b61ea129
CA-343763: Corrected the handling of VMSS alert priority/severity according to CA-342874. (#2730)
* CA-343763: Corrected the handling of VMSS alert priority/severity according to CA-342874.

- Distinguish between warnings and errors.
- Made PolicyAlert derive from MessageAlert to conform with other alert types.
- Replaced EventType column by a simple image column because it adds to clatter
  without really offering useful information.

* Correction as per code review.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-06 14:51:14 +01:00
Konstantina Chremmou
7352ae1d38 Fixed broken help button on the ThreeButtonDialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-06 11:27:32 +01:00
Konstantina Chremmou
d93e40065a Various fixes on the EvacuateHostDialog (includes CA-292642, CA-284126, CP-34862).
- CP-34862: Do not allow nomination of new master if a pool secret rotation or
  other pool operations are in progress.
- CA-292642: Fixed button enablement after resolving VM problem.
- CA-284126: Added button to rescan running VMs on the server.
- Removed annoying, focus stealing, modal action progress dialog. When scanning
  for VMs show a spinner on the control instead.
- Fixed crash when the host combobox was updated due to cache changes.
- Logging in an elevated session was happening on the UI thread.
- Show the role elevation dialog before launching the host evacuation dialog or
  we end up with showing the user an unpopulated control.
- Stop deriving from animated progress dialog because it makes it difficult to
  get the resizing right when adding more controls.
- Stop using the progress bar for the VM solution actions; rely simply on the
  action's description and the VM's icon in the gridView.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-06 11:27:32 +01:00
Darren Matthews
c75ab40ef8 L10N : Translation Updates and Resx Resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-09-01 14:26:40 +01:00
Konstantina Chremmou
2e66ec9133 Merge remote-tracking branch 'upstream/master' into feature/REQ-819
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/OptionsPages/SecurityOptionsPage.cs
2020-08-11 13:35:39 +01:00
Konstantina Chremmou
a076cc59a2
Dialog deletion (#2701)
* Replaced LicenseWarningDialog with a simple WarningDialog.
* Replaced VcpuWarningDialog with a simple WarningDialog.
* Replaced RemoveCrashdumpsWarningDialog with a simple WarningDialog.
* Replaced UsbUsageDialog with a simple WarningDialog.
* Replaced WlbDeleteReportSubscriptionDialog with a simple WarningDialog. Added null checks to event invocation.
* Replaced DisableWlbDialog with a simple Warning dialog.
* Replaced ConnectionRefusedDialog with a simple Error dialog.
* Replaced UserDeviceDialog with a simple Warning dialog.
* Replaced RevertDialog with a simple Warning dialog.
* Removed unused dialogs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 11:29:01 +01:00
Konstantina Chremmou
a66a82878e The ConnectionOptionsPage should not access private controls of its parent but rather communicate its valid state via an event.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 11:27:29 +01:00
Konstantina Chremmou
ca3e9c0219 Removed unused SaveSessionCommand and consequently refactored SaveAndRestoreDialog constructor.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 11:27:29 +01:00
Konstantina Chremmou
65ea154b9d Moved the code that logs settings to the Settings static class.
Although it may look tidy to log the settings in the OptionsDialogPages that
expose them to the user, in reality it makes for unnecessarily complicated code
design as it places business logic in UI code and mixes the class dependencies.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 11:27:29 +01:00
Konstantina Chremmou
5f7d3e1518 Homogeneous icon usage across the application.
- Replaced remaining instances of SystemIcons. SystemIcons.Information of size
  32x32 were excepted as we don't have the right size icon yet.
- The question mark icon is used for help, not for asking questions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-18 07:49:27 +01:00
Konstantina Chremmou
8a6a579402 CP-20425: Use static images everywhere an image is assigned programmatically.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-18 07:49:27 +01:00
Konstantina Chremmou
d08f02cce2 CP-20425: Added test to ensure all Resource images have a static counterpart.
Also, stop boxing Bitmap into Image so as to avoid casting wherever it is called.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-18 07:49:27 +01:00
Konstantina Chremmou
e27a0a7333 Minor refactoring on UpsellPage:
- Modernised properties.
- Removed unnecessary public method; it was rather obfuscating setting properties.
- Made Image property non-browsable.
- Missing null check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-18 07:49:27 +01:00
Konstantina Chremmou
9d7cf72c78 CP-33781: Added admin exit procedure warnings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-17 16:04:10 +01:00
Konstantina Chremmou
f3c5e74dae CP-33892: Audited the use of First() and replaced with FirstOrDefault() where appropriate.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-25 11:17:11 +01:00
Darren Matthews
cef05ab005 L10N : Resx Resync and translation update. Fixed Confirmation Options page with the Resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-06-11 13:57:12 +01:00
Darren Matthews
00b6fdc8e3 L10N: Translation and Resx Resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-06-11 13:57:12 +01:00
Konstantina Chremmou
89487fcf60 CA-337270: Perform authentication on a background thread.
- Added controls to display the error in case authentication fails.
- Use the same control(LinkLabel) to show the rubric either when new
  authentication is needed or an existing one can be used.
- Moved privacy policy statement next to the checkbox because it looked crammed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-05 11:48:54 +01:00
Konstantina Chremmou
ec7fc14c18 Typo.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-05 11:48:54 +01:00
Konstantina Chremmou
ec1aff6c82 Control alignment corrections on the Role Elevation dialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-19 23:03:45 +01:00
Konstantina Chremmou
8a478011d9 CA-339370: Assign the new VM's name at a late stage to reduce duplicate names. Some simplifications.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-19 07:49:23 +01:00
Darren Matthews
1d74094e5a L10N : Translation and Resx Resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-05-18 15:15:07 +01:00
Konstantina Chremmou
f05b502399 CA-339331: Skip uses deferred execution and needs enumeration.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-15 11:38:23 +01:00
Konstantina Chremmou
a84053cf8d CA-337323 : SR.scan on the SrPicker was happening silently without any indication on the UI (enhanced fix for CA-280299).
The result was that numbers were changing suddenly; in cases of slow connections,
a user could make a selection before the scan was over.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-04 14:30:24 +01:00
Konstantina Chremmou
d1c9e7ddd1 CA-337323: Attempt finding the right owning form for the RoleElevation dialog. Also:
- Simplified SudoElevationResult.
- Renamed SudoDialogDelegate to ElevatedSessionDelegate so that it makes more sense
  for projects not referencing WinForms.
- Call directly the RoleElevationDialog within XenAdmin without using the ElevatedSessionDelegate.
- Minor modernisation in AsyncAction.
- Launch GraphDetailsDialog in a using block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-04 14:30:24 +01:00
Konstantina Chremmou
5927d52349 CA-336024, CA-322705: Rewrote the LVMoISCI frontend of the NewSR wizard
This fixes various workflow bugs and disallows re-attaching GFS2 SR if clustering
is disabled.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-01 15:27:18 +01:00
Konstantina Chremmou
5b6bd343dd CA-322705: Disallow re-attaching GFS2 SR if clustering is not enabled. Minor refactoring.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-01 15:27:18 +01:00
Konstantina Chremmou
bf5c66598c Merge remote-tracking branch 'upstream/master' into feature/REQ-716
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.cs
2020-04-29 16:47:48 +01:00
Konstantina Chremmou
17b6c28978 Merged master into feature/REQ-453 and resolved conflicts.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdminTests/UnitTests/TimeUtilTests.cs
#	XenCenterLib/TimeUtil.cs
2020-04-26 04:11:14 +01:00