Commit Graph

3357 Commits

Author SHA1 Message Date
Gabor Apati-Nagy
feb3ca0df0 Merge pull request #1213 from kc284/master
Merged CAR-2226; undid change for CP-17750 as the latter is replaced by CP-18417.
2016-10-17 14:03:02 +01:00
Mihaela Stoica
e6fbcfdb5d CA-224567: PVS Site renaming plus some other improvements
- Correction in the text on the PVS Cache configuration page
- Added help IDs for all new dialogs and the PVS tab
- Help button on the Enable PVS read caching dialog, plus some adjustments in the controls sizes on this dialog
- Removed minimize and maximize buttons from the PVS servers dialog, and added the help button

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-17 13:02:59 +01:00
Konstantina Chremmou
08e1b2c1b7 CP-18417: Removed flag forbidding update; was added for CP-17750, but is no longer applicable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-17 11:16:16 +01:00
Konstantina Chremmou
cff98908b3 Merge remote-tracking branch 'upstream/CAR-2226' 2016-10-17 11:07:15 +01:00
Gabor Apati-Nagy
2bf2f4fcf0 Merge pull request #1206 from MihaelaStoica/CAR-2184
CA-224666: Things in PVS tab constantly refreshing
2016-10-14 16:36:55 +01:00
Konstantina Chremmou
7a74096d3b CA-157786: Added general tab for VDIs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-14 13:51:51 +01:00
Konstantina Chremmou
0b3d3abfcc Code repetition.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-14 12:21:59 +01:00
Konstantina Chremmou
082e4693a8 CA-150412: Removed invocation of XenConnections_CollectionChanged with null parameters;
the objective is to mark the events as ready to fire, whcih can be done directly.
Also, added null checks where GetCollectionForType is used.
2016-10-14 10:32:20 +01:00
Konstantina Chremmou
bf08f9d875 Refactored old events which did not need to pass parameters when fired, but were
defined a long time ago, before C# obtained the Action delegates.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-13 22:59:06 +01:00
Konstantina Chremmou
fb281e65ac Merge pull request #1209 from MihaelaStoica/CA-225057
CA-225057: XenCenter throws an Exception when trying to copy somethin…
2016-10-13 19:28:34 +01:00
Mihaela Stoica
9ec9cf1aee CA-225057: Add a helper method for setting the Clipboard text and use in all places where Clipboard.SetText was used.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-13 16:16:16 +01:00
Konstantina Chremmou
3788edad0c Merge pull request #1203 from MihaelaStoica/CA-225015
CA-225015: XenCenter Allows VM migration to MemorySR
2016-10-13 15:54:00 +01:00
Mihaela Stoica
387c28dadc CA-225057: XenCenter throws an Exception when trying to copy something to the clipboard on the Network page
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-13 13:14:37 +01:00
Mihaela Stoica
abde6e9641 CA-224567: PVS Site renaming plus some other improvements
- Renamed Add/Remove PVS Site buttons
- Added a note on the PVS Cache configuration page, regarding the recommended cache size and the allowed size for "memory only"
- Added a warning about the Site configuration not being complete until the PVS part is done as well (only visible if PVS_uuid is not set for a PVS_site)
-  Added PVS Read Caching status on the VM's general tab
- The absolute maximum allowed for a cache size is 2TB
- Changed the rubric on the Enable PVS read caching dialog

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-13 12:47:32 +01:00
Konstantina Chremmou
dc5318010c Merge pull request #1196 from mcintyre94/CA-114492
[CA-114492] Stop GroupBy buttons remaining overlapped…
2016-10-12 20:24:36 +01:00
Mihaela Stoica
be668850a4 CP-19086: In the PVS Cache configuration dialog, we shouldn't try to save a "not configured" site if it was "not configured" before
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-12 17:10:39 +01:00
Mihaela Stoica
af680eb6eb CA-224666: Things in PVS tab constantly refreshing
- instead of repopulating the whole grid when a proxy or a site changes, we now refresh just the row that needs refreshing, and when the refresh is indeed needed.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-12 16:59:46 +01:00
Mihaela Stoica
47665f5323 CA-225015: XenCenter Allows VM migration to MemorySR
- We shouldn't include the hidden SRs in the list of available SRs in the Migration wizard
- Updated the SR.SupportsVdiCreate function to return false for the Memory SR; this fixes other places where the Memory SR might be visible (e.g. all places where SrPicker is used)
- Also fixed the same issue in the  Attach disk dialog

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-12 15:47:24 +01:00
Konstantina Chremmou
346656d53e Merge pull request #1200 from MihaelaStoica/CP-17932
CP-17932: Ensure that the correct units are displayed for the PVS cac…
2016-10-12 14:51:44 +01:00
Mihaela Stoica
a8c7aba673 CP-17932: Ensure that the correct units are displayed for the PVS cache stats
- For the PVS cache space utilization the multiplying factor should be 1 (the default value) because its values range from 0 to 100

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-12 14:19:32 +01:00
Konstantina Chremmou
cfddd6bbdf Merge pull request #1198 from MihaelaStoica/CA-223374
CA-223374: Able to unplug vCPUs from running VM when changing vCPU fr…
2016-10-12 12:58:18 +01:00
Mihaela Stoica
dabe77e0d0 CA-223374: Fix typo
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-12 12:53:30 +01:00
Mihaela Stoica
80df4a2681 CP-17932: Ensure that the correct units are displayed for the PVS cache stats
- plus resorting Messages.resx

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-11 13:13:50 +01:00
Mihaela Stoica
8a3fb07f12 Merge pull request #1199 from kc284/master
Changes to fix failing tests
2016-10-11 12:17:23 +01:00
Konstantina Chremmou
146c467c38 Fixed test issue where the MockConnectionManager was assigning the same opaque_ref
to all objects. Modified the migration related filter tests to reflect recent code
changes.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-11 10:12:12 +01:00
Konstantina Chremmou
6df0508c92 Enforce filetrs to be run with a target that is Pool or Host and a non-null VM selection.
Small refactoring for performance gain on Host extension method.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-11 09:45:37 +01:00
Mihaela Stoica
82c0f6d7a3 CA-224619: XenCenter cannot use Switch to Remote Desktop option for VMs connected to internal network
- correction to the previous commit: only collect the IP addreses if the PIF is connected or is null

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-10 15:28:00 +01:00
Mihaela Stoica
c0d5dd2d94 CA-224619: XenCenter cannot use Switch to Remote Desktop option for VMs connected to internal network
- include networks without PIFs in the list of networks to test for RDP (at the end of the list)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-10 15:28:00 +01:00
Mihaela Stoica
34a4d44987 CA-223374: Able to unplug vCPUs from running VM when changing vCPU from two iCenters concurrently
- check the current number of vCPUs (by getting the latest value from the cache) before trying to change it.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-10 12:37:11 +01:00
Callum McIntyre
baccb87d00 [CA-114492] Only do SetUp if the user was actually dragging a button (not for every click on the button)
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-10 10:11:30 +01:00
Gabor Apati-Nagy
6296277317 Merge pull request #1188 from kc284/vm_migration
CA-220218, CA-205799, CA-205791 plus one or two other issues and refactoring
2016-10-07 16:18:49 +01:00
Konstantina Chremmou
81869976d9 Removed accidentally added string.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-07 15:53:38 +01:00
Callum McIntyre
9f39bdfb23 [CA-114492] Stop GroupBy buttons remaining overlapped after a drag operation by ensuring they snap back to a correct setup on mouseup
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-07 14:16:06 +01:00
Mihaela Stoica
d6c735bd18 Merge pull request #1173 from kc284/migration
CA-220511, CA-187659, CA-220216 plus some refactoring and minor enhancements.
2016-10-07 10:11:07 +01:00
Konstantina Chremmou
7793e19462 Updated tests to reflect changes in the VDI migration logic.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-06 15:49:36 +01:00
Konstantina Chremmou
f36fa9ea2f Fixed regressed button height. Also, it seems VS designer has the bad habit of
removing event registration unless it's written out fully like the rest of the
autogenerated code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-06 09:13:52 +01:00
mcintyre94
e363dc0bef Merge pull request #1192 from MihaelaStoica/CAR-2184
CP-19086: Improvements to the PVS cache UI
2016-10-05 16:55:35 +01:00
Mihaela Stoica
c8d86baeee CP-19086: More improvements to the PVS cache UI
- in the ConfigurePvsSiteAction, we now check if a site still exists, before trying to configure it
- added a CollectionChanged event handler in the Cache configuration dialog, and if we observe that a site has been added, we add it to the dialog as a new page

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-05 14:12:24 +01:00
Mihaela Stoica
d827361acc CP-19086: Improvements to the PVS cache UI
- Removed the cache configuration gridview from the PVS tab. This tab now contains the button to configure PVS cache and the VMs grid
- Show the confirmation dialog even when deleting a new site
- Enabled the "View PVS servers" button only if the site has servers

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-05 09:51:23 +01:00
Mihaela Stoica
3532a49aa5 Merge pull request #1195 from sriharshak/master
L10N:TRanslations check-ins
2016-10-05 09:32:57 +01:00
sri harsha tagore k
77631ffb3e L10N:TRanslations check-ins 2016-10-05 10:58:50 +05:30
Stephen Turner
82de583e3d Merge pull request #1193 from ushamandya/master
CP-18445: Updated XC Help for WinServer 2016 support
2016-10-03 16:26:33 +01:00
Usha Mandya
596863c28b CP-18445: Updated XC Help for WinServer 2016 support 2016-10-03 16:17:19 +01:00
Mihaela Stoica
be66919627 CP-19086: Improvements to the PVS cache UI
- If the PVS site cannot be removed (it has running proxies) then popup a dialog stating the reason, instead of starting the action and failing there. We still have the same check in the action, just in case the situation changed in the meantime.
- Removed unused controls

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-03 10:51:56 +01:00
Konstantina Chremmou
b78f823b17 CA-220218: For halted VMs moving intra-pool, XenCenter does not need to assert migration
is possible, because what it actually does is move. When asserting migration use
an SR other than the VDI's current SR for the check to ensure that both source and
target SRs are checked to see whether they support migration. Also, use the VM's
Home() instead of resident_on to ensure the current server cannot be selected as
target server. Some refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-03 10:30:40 +01:00
Konstantina Chremmou
e6b2f9b293 Refactoring: removed three out of the classes deriving from the DelayLoadingOptionComboBoxItem
because the differentiation was in the filters, which can be passed in as parameters
to the base class, and other than this they were only adding complexity.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-02 22:04:58 +01:00
Mihaela Stoica
aebffe9b13 CP-19086: Improvements to the PVS cache UI
PVS Tab:
- Move the "View PVS sites" button inside the "Configure PVS Cache" dialog (next to Remove button) and make it per-site (showing only the PVS servers from that site)
- Remove "Currently attached" column from the VMs section
- Rename "Status" column to "Read caching status"

Configure PVS Cache" dialog:
- Make sure there is a scrollbar to accommodate all hosts in a pool
- Add a confirmation dialog when a site is removed. The action is executed when the Remove button is pressed.
- When Memory SR is selected, set the maximum value to the dom0-extra-memory..
- Allow empty configuration (but see next point): The OK button should only be disabled if the PVS site name is empty
- Add an extra option in the "Cache storage" combobox, with text "Not configured", selected by default on a new site. When this is selected, we will remove the existing entry in pvs_cache_storage and will not create a new one.
- When a PVS site is deleted (forgotten), we first delete all the associated PVS_servers, otherwise the site cannot be deleted.
2016-10-01 00:23:28 +01:00
Stephen Turner
e9b9e43c48 Merge pull request #1190 from MihaelaStoica/CAR-2184
CP-17932: Add friendly names for PVS Cache RRDs + merge master
2016-09-30 16:42:34 +01:00
Stephen Turner
3e8f052117 Merge pull request #1187 from MihaelaStoica/CP-19060
CP-19060: Port vCPU hotplug code to master and add license key
2016-09-30 16:33:56 +01:00
Mihaela Stoica
b84b82a2be Merge pull request #1189 from stephen-turner/Credits_201609
Update credits
2016-09-30 14:54:03 +01:00