Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-11-25 14:27:26 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,166 Commits 11 Branches 48 Tags 186 MiB
396bcb0e35
Commit Graph

3896 Commits

Author SHA1 Message Date
Danilo Del Busso
396bcb0e35
CP-36392: Make type field readonly in QueryElement.cs 
field is used in `GetHashCode`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:46:12 +00:00
Danilo Del Busso
494f78966d
CP-36392: Address logic issue in FilterLocationToolStripDropDownButton.cs 
As suggested during review:

> The check after the `&&` should go in a nested if block: if we are in a split second where the cache has not been populated yet, there should be no item added, however, this code will add a `p` item.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:43:50 +00:00
Danilo Del Busso
02439d5303
CP-36382: Replace _nameCell with ad-hoc _xenObject readonly field 
To ensure that the field in the `GetHasCode` call is `readonly`
Also remove unused constructor

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:36:42 +00:00
Danilo Del Busso
5d5d971c74
CP-36329: Remove redundant verbatim in WlbRecommendations.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:29:21 +00:00
Danilo Del Busso
47884376a3
CP-36392: Fix typo in VNCTabView.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:29:19 +00:00
Danilo Del Busso
caf608344e
CP-36392: remuve redundant iteration in ResumeVMOnHostToolStripMenuItem.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:24:17 +00:00
Danilo Del Busso
b6a70e2ffc
CP-36392: Add null check for _vmOptList in WlbOptimizePoolAction.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:18:55 +00:00
Danilo Del Busso
45512b4cde
CP-36392: Add removed null check in WlbOptiomizePool.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:18:09 +00:00
Danilo Del Busso
6ce0a4b49d
CP-36392: Remove repetitive count and null check 
Check is performed within the constructor of `WlbRecommendations`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-03 16:07:36 +00:00
Danilo Del Busso
2978f60f8a
CP-36392: Improve readability of latest changes 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-03 10:23:21 +00:00
Danilo Del Busso
38701d148e
Merge branch 'master' of https://github.com/xenserver/xenadmin into pr/2903 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenModel/Actions/GetDataSourcesAction.cs
 2021-10-27 13:24:23 +01:00
Konstantina Chremmou
c44f6496df CA-360011: Allow full disk copy only if all VDIs of the snapshot/custom template allow it. 2021-10-26 16:55:18 +01:00
Konstantina Chremmou
f2d81d5744
Merge pull request #2869 from danilo-delbusso/CP-36392 
CP-36392: Address Security Features and Code Smells
 2021-10-26 16:54:34 +01:00
Konstantina Chremmou
23ec669698 The message Messages.UPSELL_BLURB_TRIAL was displayed twice on the AD, HA, and Users tabpage for unlicensed pool. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-10-26 00:47:08 +01:00
Konstantina Chremmou
45fe1f436b CA-359795: Fixed issue whereby a double error was shown when a non-privileged user attempted to apply a licence. 
Removed ApplyLicenseEditionCommand as it was unnecessary (there was no
button/menuitem calling it). Use the ApplyLicenseEditionAction instead.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-10-26 00:47:08 +01:00
Konstantina Chremmou
5c66471db0 CA-359793: Fixed stray label showing while entering maintenance mode. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/EvacuateHostDialog.cs
 2021-10-26 00:47:08 +01:00
Konstantina Chremmou
588f976a9b CA-359744: Do not add a host label if the host has disappeared from the cache. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-10-26 00:47:08 +01:00
Konstantina Chremmou
6b7cd1d9e5 Corrected calculation of datasource units (CA-359068). New/Edit Graph dialog enhancements. 
- CA-359068¨Match the whole datasource name (previously the wrong one was picked
  for disk read/write latency).
- New/edit Graph dialog: differentiate between enabled/disabled datasources and
  visible/hidden (known/unknown units; the latter may mean no data).
- Some refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-10-12 12:28:42 +01:00
Danilo Del Busso
69722d93bd
CP-36392: Rename key constants in WlbReportSubscription.cs to avoid field clash 
Names are amibguous
Also made the fields `const`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-05 11:56:15 +01:00
Danilo Del Busso
3a69fa0f8c
CP-36392: Add readonly to fields used in GetHashCode 
Also tidy up some code

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-05 11:39:17 +01:00
Danilo Del Busso
2352dcc4bf
CP-36392: Remove unused KeySet.cs 
File isn't used and contains 2 minor bug SonarQube flags

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-05 10:13:25 +01:00
Danilo Del Busso
4e4747ecb8
CP-36392: Remove misleading readonly in collection/array fields 
`reaonly` should be used for items that can't be modified. The changed collections/arrays are modified, so `readonly` is misleading

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 16:27:42 +01:00
Danilo Del Busso
db2c00d54d
CP-36392: Cast operands of divisions to not lose precision 
Cast to `decimal` or `float` to keep floating-point precision

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 16:22:29 +01:00
Danilo Del Busso
dcbaf5d1a4
CP-36392: Amend calls that generate unused return values 
Mixture of correctly implementing `Trim()` calls, and removing calls that generate useless ephemeral variables.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:42:40 +01:00
Danilo Del Busso
a5ddcf1b97
CP-36392: Refactor loops into if blocks 
Loops are effectively used as if statements. Changed to improve readability.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:42:10 +01:00
Danilo Del Busso
408cf98add
CP-36392: Add miscellaneous null checks 
Also tidy up code
Also remove method in `SnapshotTreeView.cs` that wasn't used, which necessitated a null check

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:42:07 +01:00
Danilo Del Busso
02aa50f7a8
CP-36392: Refactor conditions that result in unreachable code blocks 
Also tidy up surrounding code

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:42:04 +01:00
Danilo Del Busso
cfc7bd0ef9
CP-36392: Update RebootPlanAction.cs to lock on a dedicated object instance 
Use dedicated instance to avoid deadlocks or lock contention
Also fix typo and rename `private` variable

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:42:03 +01:00
Danilo Del Busso
df53a4cd98
CP-36392: Refactor useless null checks in actions constructors 
Also remove useless `this` usage

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:41:59 +01:00
Danilo Del Busso
0623717627
CP-36392: Replace custom Utils method with direct calls 
`ThrowIfEnumerableParameterNullOrEmpty` adds complexity

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:09:00 +01:00
Danilo Del Busso
2d1e6dcb92 CP-36392: Remove base calls directly based on the object reference. 
Two objects will never have the same hash since base methods are based on direct object reference

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-01 11:56:36 +01:00
Danilo Del Busso
825c795ea4 CP-36392: Refactor for loop into FirstOrDefault expression 
Improves readability

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-01 11:56:36 +01:00
Danilo Del Busso
f908abe28d CP-36392: Refactor useless for loop into if statement in ConsolePanel.cs 
For loop is acting as if block

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-01 11:56:36 +01:00
Danilo Del Busso
3ffd370d81 CP-36392: Remove unused conditional structure in VNCTabView 
If check is virtually useless here

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-01 11:56:35 +01:00
Danilo Del Busso
aa038cf0fc CP-36392: Remove condition that always evaluates to false 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-01 11:56:35 +01:00
Danilo Del Busso
f7c6984e6c CP-36392: Update CanRunCore to reflect logic as described in comment 
Also addresses unreachable code block
Also use `var` keywoard to tidy up code

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-01 11:56:35 +01:00
Danilo Del Busso
3c70dacecc CP-36392: Change condition that always evaluates to false in WlbOptimizePoolAction 
Also tidy up code within constructor

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-01 11:56:34 +01:00
Danilo Del Busso
0ffee712b7 CP-36392: Add null check to connection call in ExternalPluginAction.cs 
Also remove `null` check that always resolves to true
Also tidy up code

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-01 11:56:34 +01:00
Konstantina Chremmou
a2d829b93c CA-359092: Clarify SMB storage option in NewSR wizard 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-09-24 11:20:13 +01:00
Danilo Del Busso
2f176caf46 CP-38219: Update RPU005 to version 3.0 
Also exclude Yangtze or greater from hotfix check

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-24 11:19:36 +01:00
Konstantina Chremmou
de8acfff24 Use the DEPRECATION_URL as the default value for the Details link of the DeprecationBanner 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/TabPages/BallooningPage.cs
 2021-09-23 10:44:43 +01:00
Konstantina Chremmou
cfbfea2830 Minor ProblemWithMoreInfo refactoring. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-09-23 10:44:43 +01:00
Konstantina Chremmou
d59a61991e CP-36908: Remove support for xscontainer supp-pack from stockholm. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Commands/PauseDockerContainerCommand.cs
#	XenAdmin/Commands/RestartDockerContainerCommand.cs
#	XenAdmin/Commands/ResumeDockerContainerCommand.cs
#	XenAdmin/Commands/StartDockerContainerCommand.cs
#	XenAdmin/Commands/StopDockerContainerCommand.cs
#	XenAdmin/Controls/DeprecationBanner.cs
#	XenAdmin/TabPages/GeneralTabPage.cs
#	XenModel/Utils/Helpers.cs
 2021-09-23 10:44:43 +01:00
Konstantina Chremmou
d740e83620 CP-38018: Report mismatch between pool and host certificate verification in an undismissable way 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-09-23 10:44:30 +01:00
Konstantina Chremmou
55fd07f8ba Minor refactoring. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-09-23 10:44:30 +01:00
Danilo Del Busso
f3d0b1f302
CP-36392: Rename _selectedNodes to _internalSelectedNodes 
To avoid getter naming confusion
Also rename `_seletedNodesWrapper` to `_selectedNodes`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-20 09:35:24 +01:00
Danilo Del Busso
bb765e2b0f
CP-36392: Dispose '_webClient' when it is no longer needed 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-20 09:35:23 +01:00
Danilo Del Busso
12faf4413b
CP-36392: Refactor getter so that it doesn't clash with private field 'selectedCD' 
- Remove private field
- Modify `SelectCD` call to take in parameter

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-20 09:35:22 +01:00
Danilo Del Busso
24e1b146ae
CP-36392: Refactor property names so they have unique names in SummaryPanel.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-20 09:35:21 +01:00
Danilo Del Busso
a61f61d66f
CP-36392: Remove duplicate field in MultipleDvdIsoList.cs 
Also remove `VM` from designer

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-20 09:35:19 +01:00