Commit Graph

24 Commits

Author SHA1 Message Date
Mihaela Stoica
6cd2e28754 CA-300760: Only create the action that moves a halted VM if there are actually disks that need to be moved
- with this change the user won't see the misleading "Moving VM to new storage" in History if they tried to move the VM inside the pool, but actually didn't select different SRs for the VM's disks.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-26 16:34:46 +00:00
Mihaela Stoica
88ec36ae5f CA-300760: Allow VM intra-pool migration through the wizard, even if the storage migration is not allowed
- if a VM can migrate inside a pool, then we will allow it in the wizard, even if storage migration is not allowed
- If it is a intra-pool migration (without moving the disks), then use the VM migrate action (which does a VM.pool_migrate), not the cross pool migrate action.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-26 16:34:46 +00:00
Konstantina Chremmou
1b4a862fd0 Further corrections to the load/leave page workflow and object selection ensuring correct enablement of the Next button.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:27:57 +01:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Callum McIntyre
6a096ebf07 [CA-226897] Move the VMCrossPoolMigrateAction to be a variable outside the block, and added SuppressHistory to the MultipleAction. 2016-11-08 16:05:51 +00:00
Callum McIntyre
9b1a3315f0 [CA-226897] Resume on Server option won't automatically resume the VM
The resume on server uses the CrossPoolMigrateCommand to implement the migration of the VM to the desired host. Before this change that command had no support for resuming a VM after migrating it, so the VM was not resumed. With this change, the CrossPoolMigrateWizard can take an optional (default false) parameter to restart the VM after migration. When this is true, the migrate action becomes a MultipleAction, first migrating and then restarting the VM.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-03 15:35:25 +00:00
Konstantina Chremmou
97278e88ad Refactoring: normally we create the actions in the wizard class obtaining the parameters
from the page properties; removed unnecessary field.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:04 +01:00
Callum McIntyre
3a5444ceb2 CA-217821: Specified home server in cross pool migration should behave as home server
Mostly just terminology changes from home server to target server in the CPM wizard. Changes in shared component SelectMultipleVMDestinationPage (shared with ImportWizard) to allow CPM wizard to rename the Home Server column (as it can the VM/template one - using the same pattern).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 14:22:18 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
Gabor Apati-Nagy
ed43975454 CA-201083: Incorrect help link in Copy VM wizard
Changed keys of help ids related to copy mode

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-01 18:12:16 +00:00
Gabor Apati-Nagy
bb592fc769 CA-201083: Incorrect help link in Copy VM wizard
Copy VM or Copy Templates wizard will point to the same help: "Copying VMs and Templates"
Migrate and Move VM will show: "Migrate Virtual Machines"

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-26 18:21:51 +00:00
Gabor Apati-Nagy
4bdc5ffa79 CA-197423: Incorrect UI text and help link in Copy Template wizard
Fixing UI text (template instead of VM where needed)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-24 10:44:37 +00:00
Gabor Apati-Nagy
16cd22f3db CA-186244: Cross-pool copy of a stopped VM allows selection of the current pool
Hide the pool instead

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-12-01 11:29:06 +00:00
Mihaela Stoica
22ba1544e2 CP-11292: Remove storage motion constraints: Wording changes in the cross pool migrate wizard
- changes to the text to be suitable for migrate and copy operations, where possible
- added different text for copy on some pages
- also different text for single and multiple selection
- changes to text alignment, tab order, hotkeys on the copy pages
- removed Finish page from the intra-pool copy wizard

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-04-21 14:30:41 +01:00
Mihaela Stoica
830d8f6f60 CP-11292: Remove storage motion constraints: changes following code review
- added some null checks
- in the Cross pool migrate wizard, add Transfer network page for all cases except intra-pool move (which is performed via VMMoveAction)
- added comments to VMCrossPoolMigrateAction constructor to make it cleared what the copy parameter means

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-04-15 09:37:12 +01:00
Mihaela Stoica
6d996c03a4 CP-11292: Remove storage motion constraints: Allow cross-pool copy for templates
- modified CopyTemplateCommand to launch a cross pool copy if permitted
- added CrossPoolCopyTemplateCommand which opens the Cross pool migration wizard in "copy" mode

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-03-31 17:40:05 +01:00
Mihaela Stoica
ef5249671c CP-11292: Remove storage motion constraints: Allow cross-pool copy for stopped VMs
- added a "copy mode" page to the Cross pool migrate wizard (when in copy mode) where the user can select intra-pool or cross-pool copy
- If intra-pool option is selected, then the wizard will display a page similar to what we currently have in the Copy VM dialog
- If cross-pool option is selected, then the wizard will display all the cross pool migration pages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-03-31 15:13:46 +01:00
Mihaela Stoica
e314a654f7 CP-11292: Remove storage motion constraints: Allow cross-pool copy for stopped VMs
- modified the VMCopyCommand to launch a cross pool copy if permitted
- added the CrossPoolCopyVMCommand which opens the Cross pool migration wizard in "copy" mode
- modified the cross pool migrate action with an extra "copy" parameter, which will add a copy option to the vm.migrate_send function call

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-03-31 14:27:04 +01:00
Mihaela Stoica
cbedbd43cd CP-11032: Allow cross-pool move of stopped and suspended VMs
Changes following code review:
- add static methods to the cross pool migrate and move commands to determine if the command can execute
- In the Cross Pool migrate wizard: add Transfer network page for cross-pool move (and copy) operation (as well as all migrate cases)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-03-24 17:14:03 +00:00
Mihaela Stoica
d616009824 CP-11032: Remove storage motion constraints: Allow cross-pool move of stopped and suspended VMs
- With these changes, a stopped or suspended VM can be moved across pools; this is performed as a vm migrate operation.
- The intra pool move will continue to be a vdi.copy + destroy operation for stopped VMs, but for suspended VMs we need to do it a as vm migrate operation.
- We use the Cross Pool migrate wizard for both intra and cross pool move operations, but introduced a wizard mode parameter in order to adapt the wizard to the specific operation we want to perform (migrate, move or copy)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-03-17 16:35:12 +00:00
Mihaela Stoica
e74ee1fa38 CA-110160: Cross Pool Migrate wizard: Showing an error message (instead of warning) when the selected VMs are no longer available for migration. Also added full stop at the end of message.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-12-19 14:30:38 +00:00
Mihaela Stoica
739c3d4837 CA-110160: Fixed uncaught exception in VM migrate wizard observed while concurrent migrate operation is triggered on same VM
- before leaving each page of the wizard, check if all selected VMs are still available for migration

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-11-19 17:02:02 +00:00
Mihaela Stoica
bd36a85bff CP-4816: Initial commit to git repo
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-06-24 12:41:48 +01:00