Commit Graph

393 Commits

Author SHA1 Message Date
Mihaela Stoica
ffe7ff9520 Merge pull request #1632 from xenserver/REQ-378
Feature "REQ-378: Support Chinese Language E-mail Performance Alerts"
2017-06-13 10:51:42 +01:00
Mihaela Stoica
cf1f630486 Merge pull request #1619 from xenserver/management-on-vlan
REQ-42 feature merge
2017-05-31 15:23:28 +01:00
Gabor Apati-Nagy
f1a20c279e Merge pull request #1603 from MihaelaStoica/CA-253936
CA-253936: Fix proxy authentication in the XenServerHealthCheck service
2017-05-31 14:37:02 +01:00
Mihaela Stoica
bd8ac0d769 Merge pull request #1617 from geosharath/management-on-VLAN-B2B
B2B master to management-on-vlan
2017-05-31 12:02:51 +01:00
Konstantina Chremmou
af647fbf52 Merge pull request #1608 from MihaelaStoica/removeVMPP
Remove vmpp
2017-05-31 08:43:12 +01:00
Mihaela Stoica
2197b40db8 CA-242134: Remove the VMPP code: move actions into the VMSS folder
and rename the CreateVMSS file to match the action's name

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-30 15:17:20 +01:00
Mihaela Stoica
f9b7f71b18 Fix the HealthCheck tests - cont.
- restore the "empty credential" test and update HealthCheck to ignore null or empty username and password
- also update XenCenter so it doesn't send null or empty username and password

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-26 16:54:38 +01:00
Mihaela Stoica
f752f05a1d CA-242134: Remove the VMPP code
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-25 15:37:05 +01:00
Mihaela Stoica
ad6631f698 CA-253936: Fix proxy authentication in the XenServerHealthCheck service
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-23 16:57:38 +01:00
Mihaela Stoica
443f01fa55 Merge pull request #1601 from xenserver/master
Merge master into management-on-vlan
2017-05-22 10:38:26 +01:00
Mihaela Stoica
68aa91bcaa CA-242134: Remove code targeting pre-Clearwater hosts and unnecessary ClearwaterOrGreater checks
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-05 15:35:25 +01:00
Mihaela Stoica
78ad827cc4 CA-242134: Remove TampaOrGreater, its usages and unreachable code
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-05 14:31:43 +01:00
Mihaela Stoica
54c7ff3c29 Merge pull request #1570 from xenserver/master
Merge master into REQ-378
2017-05-03 09:43:42 +01:00
Letsibogo Ramadi
6fdc18e64f Merge pull request #1561 from MihaelaStoica/master
CA-249860: Local root user can not restart the toolstack from XenCent…
2017-05-02 15:06:51 +01:00
Mihaela Stoica
76b3c05b9a CA-250145: XenCenter cannot shutdown VM as VmPowerAdmin user if HA is enabled
The error was happening because of the Pool.sync_database call (when HA is enabled and the VM has a saved restart priority other than DoNotRestart) which requires pool admin or pool operator roles.
This call is not needed, so removing it.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-04-28 09:08:44 +01:00
Mihaela Stoica
ebbed16f54 CA-249860: Local root user can not restart the toolstack from XenCenter with AD enabled
Use the NewSession function which returns a session using the elevated credentials if they exist, otherwise using the connection's credentials

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-04-27 12:58:16 +01:00
Gabor Apati-Nagy
141b670964 CA-249056: Add a unique ID to XenCenter Check For Update (#1537)
* CA-249056: Add a unique ID to XenCenter Check For Update

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CA-249056: Add a unique ID to XenCenter Check For Update

Fixed the format of the User-Agent to comply with [1].

[1] https://tools.ietf.org/html/rfc7231#section-5.5.3

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CA-249056: Add a unique ID to XenCenter Check For Update

Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CA-249056: Add a unique ID to XenCenter Check For Update

Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CA-249056: Add a unique ID to XenCenter Check For Update

Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-26 12:45:49 +01:00
Mihaela Stoica
6549b9173b Merge pull request #1525 from makunterry/private/kunm/CP-19639
Feature REQ-378 XenCenter part
2017-04-25 14:16:18 +01:00
Kun Ma
c007194e06 CP-21658: Expose UI of feature REQ-378 to user when the XenServer support the feature
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-04-17 15:27:50 +08:00
Mihaela Stoica
8650f5880b CA-249824: Unable to create vlan, bond using XenCenter
- set managed=true, otherwise the network creation fails with the error "The network is not managed by xapi"

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-04-10 07:49:51 -04:00
Mihaela Stoica
456cef1125 CA-249624: [XSO-707] Convert VM to Template from XenCenter is not working if connected as an AD user
- Reset the action's Session after the PureAsyncAction is run to collect the RBAC method list.

Also fixes the bug where AD users cannot do multiple operations on the VMs [SCTX-2517]

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-04-04 11:26:16 +01:00
Kun Ma
6dc10c1490 CP-19453: XenCenter: Add mail-language to other-config parameters when configure e-mail options
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-04-01 11:21:21 +08:00
Sharath Babu
06c6a33ad8 Incoporated below review comments
1. Added pool.management_reconfigure to RBAC check
2. Time out is enhanced to check host.IsLive metric()
3. Assert for down management and null check for new management is added
4. Updated comments in the code as suggested by Mihaela Stoica

Signed-Off-By: Sharath Babu <sharath.babu@citrix.com>
2017-03-30 13:04:02 +05:30
Gabor Apati-Nagy
6d6a9ed147 Merge pull request #1490 from MihaelaStoica/CA-152101
CA-152101: Incorrect error when trying to license pool with old licen…
2017-03-28 14:31:58 +01:00
Gabor Apati-Nagy
40074d5969 Merge pull request #1491 from MihaelaStoica/CA-242918
CA-242918: Improve the exception shown in XenCenter if the hotfix upl…
2017-03-22 11:05:51 +00:00
Mihaela Stoica
19f1460865 CA-137249: Strange 'Completed' text shows while enabling or disabling HA
Suppress updates to the status when the PureAsyncAction runs the action to populate the ApiMethodsToRoleCheck

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-16 13:31:51 +00:00
Mihaela Stoica
6b26093303 CA-242918: Improve the exception shown in XenCenter if the hotfix upload fails
When a TargetInvocationException is raised, its InnerException property holds the underlying exception, which is what we should display.
Also ellipsise the action description (which could be an error thrown by the upload action) that is displayed on the Upload page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-16 11:41:14 +00:00
Mihaela Stoica
37a287edd1 CA-152101: Incorrect error when trying to license pool with old license server
Try to match the alerts by message type, not by title, because for pooled hosts the title contains the host name followed by the friendly name, while for standalone hosts the host name is not included

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-16 10:40:41 +00:00
Mihaela Stoica
174eb6c67f CA-230621: Disk space calculation is logged incorrectly in the XenCenter log
Only log the cleanup message if the available space is less than the required space

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-10 16:33:50 +00:00
Sharath Babu
e2d6e6624e Use pool level api for changing Pool's management interface 2017-03-02 16:00:09 +05:30
Gabor Apati-Nagy
c96bb94583 CA-245545: The proxy server is no longer bypassed by the check-for-updates when it shouldn't be
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-02 10:15:41 +00:00
Mihaela Stoica
7a04e5186e Merge remote-tracking branch 'upstream/CAR-2214' into master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	Jenkinsfile
	XenModel/Actions/Updates/DownloadAndUnzipXenServerPatchAction.cs
	XenModel/Actions/Updates/DownloadUpdatesXmlAction.cs
2017-02-28 10:30:02 +00:00
Stephen Turner
f3a64fc54b Merge pull request #1433 from geosharath/feature_merge
Scheduled Snapshots feature merge
2017-02-14 10:09:17 +00:00
Gabor Apati-Nagy
6693570b11 Merge pull request #1428 from MihaelaStoica/CA-238265
CA-238265: Add the action title to the error message displayed on the…
2017-02-08 11:47:38 +00:00
Mihaela Stoica
ef331986c7 CA-238265: Add the action title to the error message displayed on the Install Update page of the patching wizard.
Also changed  ApplyPatchAction and ApplyUpdateAction to install a single update to a single host, so that the appropriate action title can be displayed if an action fails. And replaced 2 hardcoded strings with resource strings.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-06 13:04:07 +00:00
Sharath Babu
0800e361c6 Merge branch 'master' of https://github.com/xenserver/xenadmin into VMSS 2017-02-04 13:59:58 +05:30
Gabor Apati-Nagy
bab50d9fe9 CA-241431: Using standard .net WebClient to download updates.xml
A bit of improvement to prevent leaks

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-02-02 18:35:02 +00:00
Gabor Apati-Nagy
266197ba01 CA-241431: Fixed DownloadAndUnzipXenServerPatchAction to use proxy settings
When working on this ticket (see previous commit), I noticed that the WebClient object used in DownloadAndUnzipXenServerPatchAction did not use XenCenter's proxy settings. This commit fixes this issue. By default (with no proxy being set) the proxy variable will be null as expected.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-02-02 18:29:19 +00:00
Gabor Apati-Nagy
28fe0de0c6 CA-241431: Using standard .net WebClient to download updates.xml
Using standard .NET Framework functionality instead of the custom implementation of the HTTP stack. (To download a single file.)
Note that this .net class WebClient is already being used to download hotfixes. However, in that code the proxy is not set, I am fixing that in a new commit on the same ticket.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-02-02 18:18:54 +00:00
Sharath Babu
b984c56661 CA-241883: [VMSS] Pool Operator/Pool Admin - VMSS Policy creation raises an assertion error in XC
A wrong api was being tested against the RBAC roles. Removed
vmss.protect_now and added vmss.snapshot_now.

Signed-Of-By: Sharath Babu <sharath.babu@citrix.com>
2017-02-02 08:04:03 +05:30
Mihaela Stoica
73293c7e4b Merge pull request #1401 from letsboogey/master
CA-239951 - Patching wizard allows selection of unreachable hosts
2017-01-30 11:02:38 +00:00
Letsibogo Ramadi
045c405f92 CA-239951 - Patching wizard allows selection of unreachable hosts
Disabled the ability to select unreachable hosts and in addition
added a try/catch block to hide error message resulting from trying
to clean up an unreachable host.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-25 10:28:11 +00:00
Sharath Babu
4833565ec6 Fixing copyright check failures at build time
Signed-Off-by: Sharath Babu <sharath.babu@citrix.com>
2017-01-25 14:11:24 +05:30
Sharath Babu
ee4b2818f6 Merge remote-tracking branch 'xenserver/CAR-2205' into xenserver/VMSS
Signed-Off-by: Sharath Babu <Sharath.Babu@citrix.com>
2017-01-25 13:01:54 +05:30
Konstantina Chremmou
489d8684e4 Merge remote-tracking branch 'upstream/master' into CAR-2214
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/branding.sh
#	mk/archive-unsigned.sh
#	mk/build.sh
#	mk/bumpBuildNumber.sh
#	mk/copy-build-output.sh
#	mk/declarations.sh
#	mk/tests-checks-cover.sh
#	mk/tests-checks.sh
2017-01-24 14:46:57 +00:00
Sharath Babu
af182d9e7e CA-213512: [VMSS] XC mentions VMPR instead of VMSS on failure of snapshot
Signed-Off-by: Sharath Babu <sharath.babu@citrix.com>
2017-01-23 16:25:16 +05:30
Konstantina Chremmou
88b4104dac Moved the ProxyAuthenticationMethod enum to the HTTP class so the VNCControl can compile.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-01-20 14:47:04 +00:00
Mihaela Stoica
74885674c3 CA-238901: PVS proxy not setup for imported VM
For ElyOrGreater hosts, we try move the existing VIFs to the desired networks. We will only destroy and create new ones for older hosts or when a corresponding VIF cannot be found in the network mapping.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-20 12:54:13 +00:00
Konstantina Chremmou
a59e4f4ad3 Merge pull request #1382 from GaborApatiNagy/master_CA-176169
CA-176169: Copyright statement checking
2017-01-19 15:14:25 +00:00
Frederico Mazzone
76fd266913 Merge branch 'master' into CAR-2214
Conflicts:
	XenAdmin/Properties/Settings.Designer.cs
	XenAdmin/Properties/Settings.settings
	XenAdmin/app.config
	XenModel/Actions/Updates/DownloadAndUnzipXenServerPatchAction.cs

Signed-off-by: Frederico Mazzone <frederico.mazzone@citrix.com>
2017-01-19 14:16:51 +00:00