Commit Graph

728 Commits

Author SHA1 Message Date
Konstantina Chremmou
eb73a9f106 Show the DownloadUpdatesXmlAction only when it is run by the user or it has failed.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-20 15:27:22 +01:00
Konstantina Chremmou
9c61f64ec5 Show the status of the DownloadUpdatesXmlAction on the Events tab (previously it was shown on the Updates tab).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-16 11:47:54 +01:00
CitrixChris
ffa7f28c12
Merge pull request #3019 from xenserver/feature/REQ-622
REQ-622: Citrix Hypervisor Center quick-update mechanism
2022-06-13 14:57:15 +01:00
Konstantina Chremmou
2f30ef1e19 CP-38687: Improved the speed of deleting multiple alerts.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-25 11:29:25 +01:00
Konstantina Chremmou
20cf55c19f Revert "CA-366140: Run data source operations on VMs only if they are allowed."
This reverts commit dd56f744e8.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Actions/GUIActions/SaveDataSourceStateAction.cs
2022-05-19 11:18:52 +01:00
CitrixChris
1d003da4c7
CP-39720: Enable auth tokens (#3002)
* CP-39720 adds a auth token to updates.xml download and chc.msi download if it exists in the registry keys

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 adds definition of GetInternalStageAuthToken() to XenServerHealthCheckConfigProvider.cs

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 updates token name to be more consistent

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 updates token name in missed request

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 reads token name from registry

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-05-10 12:22:28 +01:00
Konstantina Chremmou
dd56f744e8 CA-366140: Run data source operations on VMs only if they are allowed.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-09 13:36:49 +01:00
Konstantina Chremmou
188cfdda22 CP-39571: Removed spaces from the name of the log files.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-22 14:32:14 +01:00
Konstantina Chremmou
59486541a5
Merge pull request #2985 from kc284/sonarqube
CP-36392: Improvement of sonarqube score
2022-04-20 10:25:23 +01:00
Konstantina Chremmou
889ef5adce Renamed fields.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-14 11:45:21 +01:00
Danilo Del Busso
d90abfd1b6
[CHC] CA-366069 & XSI-1222: Fix incorrect capitalisation of value in Japanese version + add some case insensitive checks (#2986)
* CA-366069: Fix incorrect capitalization of value in Japanese invisible messages `resx`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Add case insensitive checks on code around usage of `ISO_UPDATE`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Remove changes in string capitalisation

Move capitalisation invariance to checks only

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Remove `ISO_UPDATE` from `InvisibleMessages.resx`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Add remaining `ToLowerInvariant()` calls

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-04-14 11:36:55 +01:00
Konstantina Chremmou
3858320cc4
CA-366115 & CA-366116: Quick Update Feature - FQP Bug fixes (#2988)
* CA-366115: Release the installer when cancelling the installation because of pending tasks.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* CA-366116: Use always the same filename for the temporary downloaded installer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Allow to cancel while retrying to download the installer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-12 12:09:44 +01:00
Konstantina Chremmou
558897740d Reworked instantiation of dummy actions that complete immediately.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-11 21:59:29 +01:00
Konstantina Chremmou
038de3ca62 Use consistent variable names.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-11 19:43:09 +01:00
CitrixChris
5b0b27eca1
CP-39382: Lock msi file while verifying and launching install process (#2973)
* CP-39382 adds lock around msi file while being verified and launched. Improves naming of variables in line with conventions.

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-39382 removes unnessessary usings, fixes background tasks running check. Tidies up structure.

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* Further modifications.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* CP-39382 adds back in messages lost in merge conflict resolution

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-11 10:11:33 +01:00
Konstantina Chremmou
04ac8249a6 CP-36392: Refactored to avoid having unused object instantiations of the ActionBase class.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:35 +01:00
Konstantina Chremmou
dce02a2562 Renamed AsyncAction.RunExternal to AsyncAction.RunSync so it is more descriptive.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:34 +01:00
Konstantina Chremmou
84ad7054ea Compacted the ActionBase constructors and renamed file to match the class name.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:33 +01:00
Konstantina Chremmou
ec33caf4b5 CP-36392: Refactored so that GetHashCode() does not call the homonymous base class method.
This required refactoring the OVF.AddVirtualSystem() method to accept the
system ID as a parameter. Also, removed some unused methods that were
calling OVF.AddVirtualSystem().

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:33 +01:00
Konstantina Chremmou
ef86be5347
Merge pull request #2978 from kc284/actions
Compacted ParallelAction and MultipleAction constructors.
2022-04-01 16:07:30 +01:00
Konstantina Chremmou
51a400bf70 CA-365717: Two corrections on VM import (from XVA):
- Do not suppress failures when polling the import task.
- When the imported VM is suspended, try resuming instead of starting it.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-01 11:21:41 +01:00
Konstantina Chremmou
5920691ea4 Merge branch 'master' into feature/REQ-622
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/Branding.resx
#	Jenkinsfile
#	XenAdmin/Commands/DisconnectCommand.cs
#	XenAdmin/MainWindow.cs
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx
2022-03-30 15:17:13 +01:00
CitrixChris
e951aa5268
Changes the confimation dialog to one that actually shows background … (#2959)
* Changes the confimation dialog to one that actually shows background tasks

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Removes unused messages

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Seperates Download and Install Logic so background task checker only happens after msi is downloaded

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Allows download to be canceled

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Some corrections.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-28 15:25:32 +01:00
Konstantina Chremmou
81d5c508a1 Refactoring suggested by code review (largely naming conventions).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-28 13:43:24 +01:00
Konstantina Chremmou
a91dd6398d Compacted ParallelAction and MultipleAction constructors.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:50:27 +00:00
Konstantina Chremmou
2110607cc1 CA-365143: Correction when changing a VM's memory settings:
- Corrected the logic deducing whether shutting down and restart is needed.
- Fixed crash when starting a VM without a home host.
- Also, renamed some fields for better compliance with C# naming conventions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:10:40 +00:00
Konstantina Chremmou
eb58973497 Fixed crash when retrieving pool info from DR metadata.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-14 17:31:48 +00:00
CitrixChris
f0f0de0076
CA-364330 wraps cyptoexception in try catch to show appropriate message (#2968)
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-03-10 14:16:13 +00:00
Konstantina Chremmou
b2dc968ab1 CP-38895: Check version annotations when using API fields or methods.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-03 14:35:45 +00:00
Danilo Del Busso
a310fa60cf CP-36392: Remove all unnecessary using s
Ignores XenAPI

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-02-24 11:53:44 +00:00
Konstantina Chremmou
a342adc859 CA-364152: Do not calculate completed percentage if there are no actions to run.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-23 12:38:02 +00:00
Danilo Del Busso
a578b6924c CA-361078: Parse OVFs without a Limit element in the vCPUs section
VMWare OVFs don't export the value

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-02-18 10:28:38 +00:00
CitrixChris
59e45f40c6
Update alert test fixes (#2953)
* CP-31587 made checksum comparison case insensitive as well as culture insensative

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Fixes not null assertion

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* Merges internal classes to be in same file

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
2022-02-18 10:24:33 +00:00
Konstantina Chremmou
29189873a3 CA-363610: OVF import: fixed upload of OS fixup ISO.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 13:17:57 +00:00
Konstantina Chremmou
493ed4cabe CP-38526/XSI-1055: Improved import performance for OVF/OVA packages with .vhd disks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 13:17:57 +00:00
Konstantina Chremmou
99452959c3 Further tweaks as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 12:52:30 +00:00
Konstantina Chremmou
b050adaeaa Some corrections and tidy up.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
0d9a204661 CP-31587 moves validate msi exception messages to messages.resx. Sets update client button to hidden on launch.
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
5845bab13f CP-31587 Implements reviewer's comments.
Moves dialog strings to messages.resx. Corrects button colours, hides update client option to avoid highlighting when disabled. Revmoves unessessary comments.

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
d8b1d5737d CP-31587 added comfirmation dialog to manageupdates page
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
755411a970 CP-31587 implements confirmation check before updating client
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
75f9b402ec CP-31587 added a checksum check to download and install client action
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
0a0533a59f CP-31587 improved DownloadAnUpdateClientAction
Made variables more accurate, removed unnessessary code

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
aa59e8f475 CP-31587 Created new download and install action that downloads the file from updates.xml url and stores in in temp folder with progress dialog
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Konstantina Chremmou
ca37331c8d CA-362709, CA-362711: Reworked the logic for allowing full disk copy when creating a VM from a snapshot or custom template.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-14 14:35:51 +00:00
Konstantina Chremmou
6aec4ea281 CP-38893: Make internal roles unavailable for selection.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-03 11:59:17 +00:00
Konstantina Chremmou
8f9afafb7a Use Tick() when setting both the PercentComplete and the Description to avoid firing OnChanged() twice.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-24 15:23:02 +00:00
Konstantina Chremmou
1225e98225 Improved logging and reporting percentage when importing an XVA.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-24 15:23:02 +00:00
Danilo Del Busso
48dd60486a
Merge pull request #2889 from danilo-delbusso/CA-359124
CA-359124 & CA-360426: Add snapshot VIFs to mapping during cross pool migration & fix VIF mapping in cross pool migration
2022-01-05 12:13:40 +01:00
Danilo Del Busso
d33f90aaf3
CA-361078: vCPUs count isn't exported/imported within OVFs (#2913)
* CA-361078: Export max vCPUs when generating OVF

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-361078: Populate max vCPUs when importing OVFs

Also keeps backwards compatibility with old import

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-361078: Tidy up `SetCPUs` method in `OVF.cs`

Also fixes whitespace using automatic formatter in VS2019

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-04 10:56:16 +00:00