Commit Graph

488 Commits

Author SHA1 Message Date
Konstantina Chremmou
243f3a209d CA-302807: Fixed issue where the server selection on the Patching wizard was
lost when leaving and returning back to the SelectServers page.
Also, the list of SelectedServers does not need to be re-evaluated every time
it is accessed but rather once when we move away from the page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-22 13:58:19 +00:00
Aaron Robson
c597b2f795 CP-290940: Dundee is the earliest version to support Automated Updates, show a Server up to date tooltip for Dundee and later, where there are no updates to perform.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-22 10:47:23 +00:00
Konstantina Chremmou
f5174e5bfe Fixed issue where the patching wizard offered to re-apply an already applied
update if the user selected it from the disk.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-13 11:08:10 +00:00
Konstantina Chremmou
b7fd97af11 Removed obsolete UpdateType.Existing and associated properties and methods.
Also, simplified the logic selecting the single update when we leave the
SelectPatchPage so as to avoid ambiguities in which properties are to be set
and refactored the error handling methods to avoid duplicate checks and
provide the right error message (for example, the error message was misleading
for a non-existent path; or, the level of detail provided in the case of
invalid zip content was of lesser relevance to the user).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-13 11:08:10 +00:00
Konstantina Chremmou
67cc929f91 Fixed crash occurring on closing the PatchingWizard if the user uploaded a
legacy patch and then went back to select and install an update.

The code was removing all the uploaded legacy patches except the installed
ones. In this case the installed legacy patch is null hence all the already
uploaded patches need to be removed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-13 11:08:10 +00:00
Darren Matthews
599d4ea7df L10N: Translation updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-11-12 10:29:10 +00:00
Joey
6d2c3541f5 CP-29768: Add Skip functionality for RPU supp pack installation (#2283)
* CP-29768: Add Skip functionality for RPU supp pack installation

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>

* Minor corrections

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* Revert unnecessary layout changes

Also changed the title of the confirmation dialog to the wizard title, as it could be shown in either RPU or the Patching wizard

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-07 18:07:53 +02:00
Konstantina Chremmou
9751de6d5e Fixed crash occurring when the user selected a single legacy patch, moved to
the Prechecks page, then back to select a single iso update, and forwards again
to the Prechecks page. The cause was that the values of Patch and PoolUpdate
were not always propagated from the Upload page to the following pages, hence
on that occasion they were both non-null, while the logic of the following
pages expects only one of the two to be non-null.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-01 13:12:09 +02:00
Konstantina Chremmou
3e0a958783 Removed accessors that were set but never used. Removed unused constructors.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-01 13:12:09 +02:00
Konstantina Chremmou
e63ca825e4 Fixed crash caused by code redundancy.
One of the PatchGridViewRow constructors was obsoleted, hence the _image and
_status cells and the row's PathPatch were always null. When a user selected a
patch, moved to the Prechecks page, back to the Select page, and the host got
disconnected, on moving to the SelectServers page and closing the warning pop-up,
XenCenter crashed because it was trying to update details of null cells. Also,
removed obsoleted toggling expanded state functionality.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-01 13:12:09 +02:00
Konstantina Chremmou
8b107c86e8 Renamed UpdateType NewRetail to Legacy.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-01 13:12:09 +02:00
Aaron Robson
1e7b99c5c3 CA-299065: Duplicate host name in error message resolving in the Patching Wizard as well.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-24 14:25:24 +01:00
Ji Jiang
6a421173cc CP-29276: Implement update/supp pack application in RPU wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-10-08 12:32:01 +01:00
Ji Jiang
539d1850d0 CA-298913 + CA-297215: Fix KeyNotFoundException
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-10-08 11:12:50 +01:00
Ji Jiang
c31778c3fe CA-298913 CA-297215: Fix restartHost and restartXapi bugs after patching
With this change, following are working:
1) After applying XS75E003-5 only restart host, no restart toolstack
2) After applying vGPU driver on 7.4, restart host happens

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-10-05 15:45:05 +01:00
Aaron Robson
a6d1ad9bfa CA-297666: Wait for host to become enabled before resuming a VM in the patching wizard. (#2233)
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-04 13:55:50 +01:00
Darren Matthews
2ce509efb3 L10N: Translation updates along with Interface resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-28 14:00:14 +01:00
Michael Z
9034c5a57a REQ-680: Merge master to feature branch.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-17 20:00:30 +10:00
Konstantina Chremmou
ad773d8f75 Fixed null reference exception in tests.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-29 10:25:47 +01:00
Darren Matthews
0e7057d067 L10N: Translation updates and Re-Sync JA & CN resx files to match the new English resx
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-08-22 09:02:08 +01:00
Tim Liu
d432cf5477 CA-293776: The order in which a single update is applied on the slave… (#2180)
* CA-293776: The order in which a single update is applied on the slaves is not the same as the order in which they are displayed

Apply the same Hosts sorting rules for all the PatchingWizard Pages .

Signed-off-by: Tim Liu <tim.liu@citrix.com>

* CA-293776: The order in which a single update is applied on the slaves is not the same as the order in which they are displayed

Place orderby clause after where clause

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-20 15:46:58 +01:00
Konstantina Chremmou
b36534c157 CA-293813: Patch pools in parallel when installing a single update/patch or supplemental package. (#2183)
* CA-293813: Patch pools in parallel when installing a single update/patch or supplemental package.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Corrections as per code review.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 12:05:16 +01:00
Mihaela Stoica
b8168eed28 CA-292626: Consider the contains-livepatch flag of all the applicable… (#2165)
* CA-292626: Consider the contains-livepatch flag of all the applicable updates when doing the prechecks in the automated updates mode.

Instead of looking at the minimal patches, we look at all applicable patches for that host (i.e. all the updates on the host's version that are not already installed) and we say that the host won't need a reboot only if all these are marked as contains-livepatch.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-03 16:11:06 +01:00
timliu55
51ba3a82ce CA-293854: Patching wizard updates list loses selection and resizes c… (#2164)
* CA-293854: Patching wizard updates list loses selection and resizes columns when resorted
Remove the redundant code
Change the AutoSize mode from DisplayedCells to AllCells.
Fix the date column sorting
Disable column header AutoSizing

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-03 11:32:51 +01:00
Mihaela Stoica
9dc0d77ef6 CA-292626: Consider the contains-livepatch flag when doing prechecks in the automated updates mode.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-30 14:33:22 +01:00
Jisheng Xing
6cf48a9125 CA-293680: Tasks to be performed after upgrade in XC don't quite fit within the box
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-07-30 12:21:58 +01:00
jishengx
260ec2d013 CA-284914: Prechecks are re-run every time the 'Hide successful prech… (#2088)
* CA-284914: Prechecks are re-run every time the 'Hide successful prechecks' is ticked/unticked

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* fix some comments
2018-07-26 16:11:53 +01:00
vetrivelc
8ef1764c84 L10N: Translation Updates & CA-293780 2018-07-19 11:05:16 +01:00
Michael
8c4727d67b CP-28787: Change some "XenServer" to neutral references. (#2142)
* CP-28787: Change some XenServer to neutral references.

Signed-off-by: Michael Zhao <fengyang.zhao@citrix.com>
2018-07-19 10:50:49 +01:00
Konstantina Chremmou
d639708781 CA-293863: Do not update the done and in-progress actions on the worker thread.
Also, do not log error every time the output panel is updated.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-16 11:50:42 +01:00
Mihaela Stoica
9accb3c69f Merge branch 'master' into REQ-672
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenAdmin/XenAdmin.csproj
2018-07-13 13:14:36 +01:00
Konstantina Chremmou
9157db94ac CA-293764: Added new property XenObject to the Checks, which returns the Pool
or Host accordingly. Extended comparison of Problems to also take account of
the XenObject the Check was performed on, otherwise the Problems get mixed
up when there are homonymous members across pools.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-13 12:39:33 +01:00
Mihaela Stoica
15aee105f0 CA-293669:Code optimisation
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-12 14:45:23 +01:00
Mihaela Stoica
f09683be7c CA-293669: Block the installation of an old-format patch if the pool is partially upgraded and the master is Ely or greater
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-12 14:45:23 +01:00
serencorbett1
63d09dd117 CP-28431: Block updates/upgrades from Kolkata if clustering enabled (#2124)
* CP-28431: Block updates and upgrades from Kolkata onwards if clustering enabled
* CP-28431: Rename files and change from Pool Check to [Host] Check
* CP-28431: Change description message

Signed-off-by: Seren Corbett <seren.corbett@citrix.com>
2018-07-09 10:59:09 +01:00
Konstantina Chremmou
624a228715 Corrected the logic deciding whether a supplemental pack is applicable on a host.
(This looks like a better fix for CA-236547 too).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-08 22:43:21 +01:00
Konstantina Chremmou
c11b692958 CA-293158: Reworked the logic enabling/disabling and selecting servers depending
on the update mode, so that the right set of hosts is passed on to the prechecks
page for partially upgraded pools that are to be updated to a new version with
hotfixes. Also, corrected code that was mixing the logic of changing the enabled
 state of a row with the checked state.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-08 22:43:21 +01:00
Konstantina Chremmou
91563ebd54 No need to catch and rethrow exception as it's logged anyway; a couple of more optimisations.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-08 22:43:21 +01:00
Konstantina Chremmou
0aa43018a4 Removed ManualModeSelected property in favour of the existing ManualUpgrade; moved the latter in the class using it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-08 22:43:21 +01:00
Mihaela Stoica
7c1484d6c7 CA-293099: If the update that we are trying to apply is already applied, then show that in the wizard.
Also sort Messages.resx and call ReplaceProgressStep instead of AddProgressStep in the DownloadPatchPlanAction class (when the download is skipped)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-04 16:08:22 +01:00
Konstantina Chremmou
b08e91a470 Do not create a new background worker every time the checks are refreshed; queue
a new check on the existing one instead. Moved the background worker to the designer
of the class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-04 12:09:37 +01:00
Mihaela Stoica
167c5132a3 CA-293099: When installing updates in the automated updates mode (including new version and RPU), ignore the UPDATE_ALREADY_APPLIED errors and allow the process to continue witth the remaining actions.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-03 11:09:14 +01:00
Konstantina Chremmou
54e341c315 Added some null safety checks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-02 17:37:52 +01:00
Konstantina Chremmou
80aef805bf CA-293046: If a host has been updated and eventually rebooted, toolstack does not need to be restarted.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-02 17:37:52 +01:00
Konstantina Chremmou
6b2a9c3944 CA-293153: Moved the logic calculating the resolved precheck actions to be
reverted to the new class UpdateUpgradeWizard which serves as base for the
Patching and the RPU wizards. Pass the list of resolved problems to the
automated updates page and not the actions, so as to prevent premature (i.e.
on creation as opposed to on start) addition to the global list shown on
the Events page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-02 17:37:52 +01:00
Konstantina Chremmou
5728a84e33 Renamed method UnwindChanges to CreateUnwindChangesAction to avoid cofusion, because the method only creates the action and does not run it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-02 17:37:52 +01:00
Konstantina Chremmou
8ff639bfe9 Reset the background workers list when the page is loaded, but not when it's cancelled. Dispose of them when the page is disposed.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-02 17:37:52 +01:00
Konstantina Chremmou
3107c111f0 CA-293153: The logic calculating the resolved precheck actions to be reverted
is now in one place, namely the PatchingWizard_PrecheckPage.UnwindChangesActions.
The pages following this page use now this list instead of the problems
encountered, so we ensure that the update/upgrade plans do not include the
unwind action if no resolution of problems took place on the prechecks page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-02 17:37:52 +01:00
Konstantina Chremmou
741bfaa864 CA-293092: Enhanced the logic of the SuccessfulDescription in the defining
class so the caller won't have to worry about it.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-02 17:37:52 +01:00
Konstantina Chremmou
7ea811e942 Renamed method SolveImmediately to GetSolutionAction because the old name was misleading: the method creates the action, it doesn't run it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-02 17:37:52 +01:00