Commit Graph

413 Commits

Author SHA1 Message Date
Michael
a375c8a119 CP-25081: Set platform parameters. (#1820)
* CP-25081: Set platform parameters.

* Optimize qemu-upstream handling code.

* Support Enter/Esc keyboard handling in AttachUsbDialog.

* Fix a logic error in showing qemu-upstream warning.

* Update bindings from REQ-158 XenServer build 129.
2017-10-18 12:52:53 +01:00
Michael
e8cb4ad7d6 CP-24412 & CP-24333: USB device list filter in Attach dialog. (#1789)
* CP-24412: Apply a filter before adding USBs to candidate list in Attach Dialog.

* CP-24333: Apply HA restraint.

* CP-24412: Fix a merge error.

* CP-24412: implement actions to attach/detach/passthrough.

* CP-24412: Add license check before making UI components visible.

* CP-24412: Change layout of new components to Dpi.

* Fixed all comments.

* Fix comments.

* fixed comments
2017-10-10 09:05:22 +01:00
Konstantina Chremmou
37e3810d73 Removed the background worker and added an async action to retrieve the local
server time (previously on the UI  thread) and also update the message list
for each snapshot schedule. Preserve column sorting and multiple selection
when the list is rebuilt. Do not enforce minimum size on the form since it
is not resizable.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-11 13:22:12 +01:00
Konstantina Chremmou
514c33140b Converted remaining extension get and set properties of the API classes to methods
in order to prevent them from being serialised alongside the API properties.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-05 02:15:38 +01:00
Konstantina Chremmou
71301eb332 Removed the extension Properties from the VMSS class. Removed the GetVMSSAlertsAction;
it's not needed as it does not make server calls. Some more refactoring and corrections
here and there.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-04 23:07:22 +01:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Stephen Turner
89f51e90a1 CA-258782 Remove thin provisioning code (#1728)
* CA-258782 Remove thin provisioning code

* Revert file that shouldn't have been touched

* Remove line that was only present for debugging
2017-08-22 16:40:08 +01:00
Gabor Apati-Nagy
48134dfd14 Merge pull request #1723 from xenserver/REQ-473
Merge from REQ-473
2017-08-09 10:47:01 +01:00
Letsibogo Ramadi
c44f89bf05 CA-249823 - Accept zip files in Updates Wizard (#1667)
* CA-249823 - Accept zip files in Updates Wizard
* CA-258326 - Improve implementation of CA-248823(Accept zip files in Updates Wizard)
* Small unrelated bugfix: Stop selectFromDiskRadioButton being checked when
restoring dismissed updates.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-07-21 15:56:27 +01:00
Gabor Apati-Nagy
4878e5e3ac CA-257922: Cancelling Server Status Report does not clean up
Fixed code to do the cleanup even if the saving has been cancelled

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-07-06 12:08:34 +01:00
Gabor Apati-Nagy
51c08c7433 Merge pull request #1666 from MihaelaStoica/CP-21161
CP-21161: Do not call the disk-space plugin cleanup functions on Ely …
2017-07-04 15:37:34 +01:00
Mihaela Stoica
0fbe225fa4 CP-22472: Add new XenCenter metadata file to the server status report: changes following code review
- Add an empty string (instead of 'null') if the IP address is null
- Only include the XC uptime in the SSR produced in XenCenter
- Also changed the name of the metadata file that is included in the SSR

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Mihaela Stoica
713f84cf54 CP-22472: Add new XenCenter metadata file to the server status report: changes following code review
- Added more items to the metadata; the content is now slightly different between the SSR produced in XenCenter and the one from the HealthCheck;
- Encode the metadata string before sending it to the Health Check;
- Always suppress history for the action that sends the proxy settings;
- Renamed some of the new classes;
- Also refactored the actions that send data to the HealthCheck service.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Mihaela Stoica
54ab9307d2 CP-22472: Add new XenCenter metadata file to the server status report
- XenCenter sends its telemetry info to the HealthCheck service
- The HealthCheck service saves this metadata in its settings file and includes it in the health check upload

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Mihaela Stoica
2c37367155 CP-22472: Add new XenCenter metadata file to the server status report
- this adds the telemetry file to the server status report produced in XenCenter

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Mihaela Stoica
c061b0f57d CA-257574: Manage vApps dialog is unusable with a vApp containing a l… (#1664)
* CA-257574: Manage vApps dialog is unusable with a vApp containing a large number of VMs

- In the VMAppliancesDialog, change event handlers to reduce the number of refreshes when something changes: only reload the appliances when the VM_appliance collection change; if a relevant property is changed (in VM_appliance or VM), then update only the affected rows.
- Improve the way we assign VMs to a group (AssignVMsToVMApplianceAction and AssignVMsToPolicyAction): only update the VMs that really changed.
- Also improve the way we update the VM startup options and HA restart priorities on a set of VMs

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-257574: Manage vApps dialog is unusable with a vApp containing a large number of VMs: changes following code review

- reverted the changes to the AssignVMsToGroup actions that added the additional constructor
- changed the AssignVMsToGroup actions to calculate the set difference between two lists more efficiently
- added code to deregister PropertyChanged events on VM_appliances
- removed getCurrentSettings() method as it is not needed, GetChangedSettings can be used in all cases

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-27 17:32:46 +01:00
Mihaela Stoica
537e569a62 CP-21161: Do not call the disk-space plugin cleanup functions on Ely and above hosts
- Ensure that the disk-space plugin functions are not called on Ely or greater hosts, except for the 'get_avail_host_disk_space' function, which is still needed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-27 13:48:54 +01:00
Stephen Turner
eda73f1dff Fix several usage errors identified by Lexica 2017-06-20 14:29:22 +01:00
Mihaela Stoica
5783904d0a Merge pull request #1656 from stephen-turner/UpdateRoot
Remove case that is no longer hit, and that causes confusion because …
2017-06-19 13:38:24 +01:00
Mihaela Stoica
ffe7ff9520 Merge pull request #1632 from xenserver/REQ-378
Feature "REQ-378: Support Chinese Language E-mail Performance Alerts"
2017-06-13 10:51:42 +01:00
Mihaela Stoica
cf1f630486 Merge pull request #1619 from xenserver/management-on-vlan
REQ-42 feature merge
2017-05-31 15:23:28 +01:00
Gabor Apati-Nagy
f1a20c279e Merge pull request #1603 from MihaelaStoica/CA-253936
CA-253936: Fix proxy authentication in the XenServerHealthCheck service
2017-05-31 14:37:02 +01:00
Mihaela Stoica
bd8ac0d769 Merge pull request #1617 from geosharath/management-on-VLAN-B2B
B2B master to management-on-vlan
2017-05-31 12:02:51 +01:00
Konstantina Chremmou
af647fbf52 Merge pull request #1608 from MihaelaStoica/removeVMPP
Remove vmpp
2017-05-31 08:43:12 +01:00
Mihaela Stoica
2197b40db8 CA-242134: Remove the VMPP code: move actions into the VMSS folder
and rename the CreateVMSS file to match the action's name

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-30 15:17:20 +01:00
Mihaela Stoica
f9b7f71b18 Fix the HealthCheck tests - cont.
- restore the "empty credential" test and update HealthCheck to ignore null or empty username and password
- also update XenCenter so it doesn't send null or empty username and password

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-26 16:54:38 +01:00
Mihaela Stoica
f752f05a1d CA-242134: Remove the VMPP code
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-25 15:37:05 +01:00
Mihaela Stoica
ad6631f698 CA-253936: Fix proxy authentication in the XenServerHealthCheck service
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-23 16:57:38 +01:00
Mihaela Stoica
443f01fa55 Merge pull request #1601 from xenserver/master
Merge master into management-on-vlan
2017-05-22 10:38:26 +01:00
Mihaela Stoica
68aa91bcaa CA-242134: Remove code targeting pre-Clearwater hosts and unnecessary ClearwaterOrGreater checks
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-05 15:35:25 +01:00
Mihaela Stoica
78ad827cc4 CA-242134: Remove TampaOrGreater, its usages and unreachable code
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-05 14:31:43 +01:00
Stephen Turner
85d13bdbb6 Remove case that is no longer hit, and that causes confusion because updates.xensource.com shouldn't be in the source 2017-05-03 16:02:31 +01:00
Mihaela Stoica
54c7ff3c29 Merge pull request #1570 from xenserver/master
Merge master into REQ-378
2017-05-03 09:43:42 +01:00
Letsibogo Ramadi
6fdc18e64f Merge pull request #1561 from MihaelaStoica/master
CA-249860: Local root user can not restart the toolstack from XenCent…
2017-05-02 15:06:51 +01:00
Mihaela Stoica
76b3c05b9a CA-250145: XenCenter cannot shutdown VM as VmPowerAdmin user if HA is enabled
The error was happening because of the Pool.sync_database call (when HA is enabled and the VM has a saved restart priority other than DoNotRestart) which requires pool admin or pool operator roles.
This call is not needed, so removing it.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-04-28 09:08:44 +01:00
Mihaela Stoica
ebbed16f54 CA-249860: Local root user can not restart the toolstack from XenCenter with AD enabled
Use the NewSession function which returns a session using the elevated credentials if they exist, otherwise using the connection's credentials

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-04-27 12:58:16 +01:00
Gabor Apati-Nagy
141b670964 CA-249056: Add a unique ID to XenCenter Check For Update (#1537)
* CA-249056: Add a unique ID to XenCenter Check For Update

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CA-249056: Add a unique ID to XenCenter Check For Update

Fixed the format of the User-Agent to comply with [1].

[1] https://tools.ietf.org/html/rfc7231#section-5.5.3

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CA-249056: Add a unique ID to XenCenter Check For Update

Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CA-249056: Add a unique ID to XenCenter Check For Update

Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CA-249056: Add a unique ID to XenCenter Check For Update

Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-26 12:45:49 +01:00
Mihaela Stoica
6549b9173b Merge pull request #1525 from makunterry/private/kunm/CP-19639
Feature REQ-378 XenCenter part
2017-04-25 14:16:18 +01:00
Kun Ma
c007194e06 CP-21658: Expose UI of feature REQ-378 to user when the XenServer support the feature
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-04-17 15:27:50 +08:00
Mihaela Stoica
8650f5880b CA-249824: Unable to create vlan, bond using XenCenter
- set managed=true, otherwise the network creation fails with the error "The network is not managed by xapi"

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-04-10 07:49:51 -04:00
Mihaela Stoica
456cef1125 CA-249624: [XSO-707] Convert VM to Template from XenCenter is not working if connected as an AD user
- Reset the action's Session after the PureAsyncAction is run to collect the RBAC method list.

Also fixes the bug where AD users cannot do multiple operations on the VMs [SCTX-2517]

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-04-04 11:26:16 +01:00
Kun Ma
6dc10c1490 CP-19453: XenCenter: Add mail-language to other-config parameters when configure e-mail options
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-04-01 11:21:21 +08:00
Sharath Babu
06c6a33ad8 Incoporated below review comments
1. Added pool.management_reconfigure to RBAC check
2. Time out is enhanced to check host.IsLive metric()
3. Assert for down management and null check for new management is added
4. Updated comments in the code as suggested by Mihaela Stoica

Signed-Off-By: Sharath Babu <sharath.babu@citrix.com>
2017-03-30 13:04:02 +05:30
Gabor Apati-Nagy
6d6a9ed147 Merge pull request #1490 from MihaelaStoica/CA-152101
CA-152101: Incorrect error when trying to license pool with old licen…
2017-03-28 14:31:58 +01:00
Gabor Apati-Nagy
40074d5969 Merge pull request #1491 from MihaelaStoica/CA-242918
CA-242918: Improve the exception shown in XenCenter if the hotfix upl…
2017-03-22 11:05:51 +00:00
Mihaela Stoica
19f1460865 CA-137249: Strange 'Completed' text shows while enabling or disabling HA
Suppress updates to the status when the PureAsyncAction runs the action to populate the ApiMethodsToRoleCheck

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-16 13:31:51 +00:00
Mihaela Stoica
6b26093303 CA-242918: Improve the exception shown in XenCenter if the hotfix upload fails
When a TargetInvocationException is raised, its InnerException property holds the underlying exception, which is what we should display.
Also ellipsise the action description (which could be an error thrown by the upload action) that is displayed on the Upload page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-16 11:41:14 +00:00
Mihaela Stoica
37a287edd1 CA-152101: Incorrect error when trying to license pool with old license server
Try to match the alerts by message type, not by title, because for pooled hosts the title contains the host name followed by the friendly name, while for standalone hosts the host name is not included

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-16 10:40:41 +00:00
Mihaela Stoica
174eb6c67f CA-230621: Disk space calculation is logged incorrectly in the XenCenter log
Only log the cleanup message if the available space is less than the required space

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-10 16:33:50 +00:00
Sharath Babu
e2d6e6624e Use pool level api for changing Pool's management interface 2017-03-02 16:00:09 +05:30