Commit Graph

112 Commits

Author SHA1 Message Date
Danilo Del Busso
44d4482513
Specify caching policy for XML/MSI downloads
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-04-13 11:44:23 +01:00
Danilo Del Busso
dc1e001a8a
Use full URL when downloading updates XML
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-04-13 09:58:23 +01:00
Danilo Del Busso
7b18b3b105
Update DownloadAndUpdateClientAction to not prepend param name when downloading
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-04-12 08:43:42 +01:00
Danilo Del Busso
1b3b4b218d
Move AddAuthTokenToQueryString to Helpers
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-04-12 08:31:05 +01:00
Danilo Del Busso
16ce163e7f
Remove whitespace only keys from query string
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-30 13:31:58 +01:00
Danilo Del Busso
a888ed9274
Only add InternalStageAuthToken if URI isn't pointing to a file
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-30 13:31:06 +01:00
Danilo Del Busso
732d1f4a30
Do not pre-pend key to InternalStageAuthToken query parameters
Use of `InternalStageAuthToken=foo` is not needed anymore. Furthermore, we can now provide any token format.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-27 09:28:21 +01:00
Danilo Del Busso
ea9669ce1b
CP-42186: Update XML tag name in DownloadUpdatesXmlAction
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-22 10:30:05 +00:00
Konstantina Chremmou
d7b519a53c Updated copyright notice on files.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-30 16:24:16 +00:00
Konstantina Chremmou
e29b8b39d5 Removed dependency on IonicZip. Use the corresponding classes of .NET Framework.
Also renamed the archive classes because they were named after the 3rd
party library used and were confusing.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-18 16:53:30 +00:00
Konstantina Chremmou
eb73a9f106 Show the DownloadUpdatesXmlAction only when it is run by the user or it has failed.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-20 15:27:22 +01:00
Konstantina Chremmou
9c61f64ec5 Show the status of the DownloadUpdatesXmlAction on the Events tab (previously it was shown on the Updates tab).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-16 11:47:54 +01:00
CitrixChris
ffa7f28c12
Merge pull request #3019 from xenserver/feature/REQ-622
REQ-622: Citrix Hypervisor Center quick-update mechanism
2022-06-13 14:57:15 +01:00
CitrixChris
1d003da4c7
CP-39720: Enable auth tokens (#3002)
* CP-39720 adds a auth token to updates.xml download and chc.msi download if it exists in the registry keys

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 adds definition of GetInternalStageAuthToken() to XenServerHealthCheckConfigProvider.cs

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 updates token name to be more consistent

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 updates token name in missed request

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 reads token name from registry

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-05-10 12:22:28 +01:00
Danilo Del Busso
d90abfd1b6
[CHC] CA-366069 & XSI-1222: Fix incorrect capitalisation of value in Japanese version + add some case insensitive checks (#2986)
* CA-366069: Fix incorrect capitalization of value in Japanese invisible messages `resx`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Add case insensitive checks on code around usage of `ISO_UPDATE`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Remove changes in string capitalisation

Move capitalisation invariance to checks only

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Remove `ISO_UPDATE` from `InvisibleMessages.resx`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Add remaining `ToLowerInvariant()` calls

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-04-14 11:36:55 +01:00
Konstantina Chremmou
3858320cc4
CA-366115 & CA-366116: Quick Update Feature - FQP Bug fixes (#2988)
* CA-366115: Release the installer when cancelling the installation because of pending tasks.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* CA-366116: Use always the same filename for the temporary downloaded installer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Allow to cancel while retrying to download the installer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-12 12:09:44 +01:00
CitrixChris
5b0b27eca1
CP-39382: Lock msi file while verifying and launching install process (#2973)
* CP-39382 adds lock around msi file while being verified and launched. Improves naming of variables in line with conventions.

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-39382 removes unnessessary usings, fixes background tasks running check. Tidies up structure.

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* Further modifications.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* CP-39382 adds back in messages lost in merge conflict resolution

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-11 10:11:33 +01:00
CitrixChris
e951aa5268
Changes the confimation dialog to one that actually shows background … (#2959)
* Changes the confimation dialog to one that actually shows background tasks

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Removes unused messages

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Seperates Download and Install Logic so background task checker only happens after msi is downloaded

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Allows download to be canceled

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Some corrections.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-28 15:25:32 +01:00
CitrixChris
f0f0de0076
CA-364330 wraps cyptoexception in try catch to show appropriate message (#2968)
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-03-10 14:16:13 +00:00
CitrixChris
59e45f40c6
Update alert test fixes (#2953)
* CP-31587 made checksum comparison case insensitive as well as culture insensative

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Fixes not null assertion

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* Merges internal classes to be in same file

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
2022-02-18 10:24:33 +00:00
Konstantina Chremmou
99452959c3 Further tweaks as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 12:52:30 +00:00
Konstantina Chremmou
b050adaeaa Some corrections and tidy up.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
0d9a204661 CP-31587 moves validate msi exception messages to messages.resx. Sets update client button to hidden on launch.
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
5845bab13f CP-31587 Implements reviewer's comments.
Moves dialog strings to messages.resx. Corrects button colours, hides update client option to avoid highlighting when disabled. Revmoves unessessary comments.

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
d8b1d5737d CP-31587 added comfirmation dialog to manageupdates page
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
755411a970 CP-31587 implements confirmation check before updating client
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
75f9b402ec CP-31587 added a checksum check to download and install client action
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
0a0533a59f CP-31587 improved DownloadAnUpdateClientAction
Made variables more accurate, removed unnessessary code

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
aa59e8f475 CP-31587 Created new download and install action that downloads the file from updates.xml url and stores in in temp folder with progress dialog
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Danilo Del Busso
157fe77f8f
CP-36392: Add comment to ignored catch blocks
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CP-36392: Add missing comments to ignored catch blocks

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-09-20 09:35:17 +01:00
Konstantina Chremmou
1df1083a2d Use more generic names for client version updates, checks, alerts etc.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-09 15:52:10 +01:00
Konstantina Chremmou
dce5a0d1c1 CA-355163: Check the client branding matches the new client version alert.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-09 15:52:10 +01:00
Konstantina Chremmou
0598e6342d Merge remote-tracking branch 'upstream/master' into feature/REQ-797 2021-01-19 11:01:02 +00:00
Konstantina Chremmou
1c4178c7fe CA-347480: Improved ability to cancel an import/export while compressing/uncompressing the files, or packaging into/extracting from an OVA file.
Also, remove another couple of unused methods from the OVF class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-18 01:34:25 +00:00
Konstantina Chremmou
8d004401fb CA-343280: Removed metadata entry.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-07 15:57:26 +00:00
Konstantina Chremmou
80119e9411 CP-15790: Implementation improvement aimed to make manual testing easier.
- Ensure we read the updates.xml location anew from the registry, otherwise the
application has to be relaunched to pick a registry change. Look in both hives
HKCU and HKLM. To avoid performance impact on the UI, move the operation into
the action's Run() body.
- Some refactoring to improve OOP design and fix XmlReader leak.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-11-12 11:04:33 +00:00
Konstantina Chremmou
667e9e8caf Log the stack trace when an exception is encountered and don't use the *Format() counterpart of the logging method for it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
f4265732ca Do not localise log entries or ellipsise names. Log exception stack traces where applicable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
fb2edf99b8 Do not initialise a logger if a class does not use it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
61f6f89c25
Merge pull request #2510 from xenserver/feature/REQ-775
Merge REQ-775 into master
2019-09-06 12:08:23 +01:00
Mihaela Stoica
3f5125b293 CA-325846: Do not display invalid data in the hotfix eligibility warnings and alerts
- if a hotfix eligibility date field is invalid, then the hotfix eligibility warning does not include any reference to this date.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-03 08:52:40 +01:00
Mihaela Stoica
482c86a731 CP-31527: Add notifications in XenCenter for versions that are no lon… (#2486)
CP-31527: Add notifications in XenCenter for versions that are no longer eligible for hotfixes

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-08-21 11:43:11 +01:00
Konstantina Chremmou
e6da7045b6 Ensure we always dispose of the ArchiveIterator and ArchiveWriter after use.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-13 10:18:15 +01:00
Konstantina Chremmou
46b5efd15e Simplified event declaration.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 09:19:47 +01:00
Konstantina Chremmou
b7fd97af11 Removed obsolete UpdateType.Existing and associated properties and methods.
Also, simplified the logic selecting the single update when we leave the
SelectPatchPage so as to avoid ambiguities in which properties are to be set
and refactored the error handling methods to avoid duplicate checks and
provide the right error message (for example, the error message was misleading
for a non-existent path; or, the level of detail provided in the case of
invalid zip content was of lesser relevance to the user).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-13 11:08:10 +00:00
Aaron Robson
525034d233 CP-14807: Delete OEM in ServerVersion (#2270)
* CP-14807: Delete OEM in ServerVersion

* CP-14807: Removing unused IgnorePatchAction and IgnoreServerAction classes (moving their constants to the Updates class).

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-22 14:34:31 +01:00
Mihaela Stoica
9dc0d77ef6 CA-292626: Consider the contains-livepatch flag when doing prechecks in the automated updates mode.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-30 14:33:22 +01:00
Mihaela Stoica
ee6925beae CA-293923: Changed the sleep time between retries.
Also, there shouldn't be a sleep after the last try.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-19 16:12:50 +01:00
Mihaela Stoica
42c3a369a3 CA-293923: Use a NetworkAvailabilityChanged event to detect changes in the network connectivity and mark the download as failed when the network becomes unavailable
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-18 14:23:37 +01:00
Konstantina Chremmou
7188a79263 Added padding to the upload/download progress numbers to reduce left-right message "jumping".
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-02 17:37:52 +01:00