Commit Graph

327 Commits

Author SHA1 Message Date
Konstantina Chremmou
46faf191c5 Enforce focus on the radio button so when Enter is hit the wizard proceeds.
Otherwise, the focus may randomly go on the link opening the NewSR wizard; once
the latter is open the test times out.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-04 17:31:48 +00:00
Aaron Robson
e41f1b6e08 CA-303517: In XenCenter, if a VM has more than 1 IP address, it cannot be found using one of its IPs in the search box (#2331)
Refactored redundant IP Address parsing code from XenAPI-Extensions/VIF.IPAddresses and XenSeach/Common.IPAddressProperty into the FindIpAddresses method in the Helpers class to handle multiple networks on a single line with a separator. Added unit tests.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-29 09:47:39 +00:00
Konstantina Chremmou
ff708345fa Added functionality allowing renaming of folders. Fixed issue where the form
closed on double-clicking on the node expanded icon. Some improvement in the
use of the folder name prompt dialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-26 10:29:39 +00:00
Konstantina Chremmou
16c88cc7b7 CA-302791: Rewrote the ChangeFolder dialog to fix usability issues.
- Corrected folder selection; reduced clicks required to select folders;
  improved text; added delete button.
- Moved FolderChangeDialogTreeView to the same folder as the other TreeViews;
- Added missing null checks to the MutliSelectTreeView and hid properties
  HScrollPos and VScrollPos from VS's designer (the former was initialised
  to zero every time the designer was updated, causing the treeview images
  to disappear).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-26 10:29:39 +00:00
Aaron Robson
6353043b15 CP-27819: Switch to Visual Studio 2017 (into master) (#2305)
* CP-27819: Manually setting the ToolsVersion to 15.0 (VS2017) in all .csproj files for consistency and to attempt to enforce consistency of dev environments with the explicitness of the msbuild scripts as used in the build environments.
Auto updated as many of the .sln and .csproj files as VS2017 was willing to do https://docs.microsoft.com/en-us/visualstudio/ide/reference/upgrade-devenv-exe?view=vs-2017 and included changes to the gitignore to ensure that the update report and backup files are not included in the repo.

* CP-27819: Tidying up by removing FileUpgradeFlags, OldToolsVersion and UpgradeBackupLocation nodes from the .csproj files as they are produced as hints for how to revert project upgrades for which we can use version control.

* CP-27819: Removing redundant "ManifestCertificateThumbprint" and "ManifestTimestampUrl" nodes from project files "mk\sign.bat" has been used for this purpose for some time now.

* CP-27819: Updated readme to reflect that VS2017 is now in use.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-09 11:23:32 +00:00
Konstantina Chremmou
80608f971c CP-27924: Require RPU004 when upgrading from kolkata servers (RPU004 is unchanged).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-01 12:08:56 +02:00
Konstantina Chremmou
5b79b1dc94 Removed the label from the SrPicker because in half of the occasions it was
hidden and in all other cases it was set by the implementing control, i.e.
the label was not reusable, hence no reason to have it in the control and risk
layout issues. This means that the SrPicker does not need to be a control
encapsulating a CustomTreeVIew, but simply derive from the latter.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Aaron Robson
97cd8286b9 CA-203431: Host name is repeated twice in multipathing alert message in XC (#2272)
* CA-203431: Removed prefix comma and space from the start of the list of hosts in the multipathing alert message.

* CA-203431: Removed duplicate Host names from multipathing alert message.

* CA-203431: Unit tests for MessageAlert.FindHostUuids with tweaks to allow it to handle a null input as if it was an empty enumeration.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-23 14:50:28 +01:00
Aaron Robson
525034d233 CP-14807: Delete OEM in ServerVersion (#2270)
* CP-14807: Delete OEM in ServerVersion

* CP-14807: Removing unused IgnorePatchAction and IgnoreServerAction classes (moving their constants to the Updates class).

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-22 14:34:31 +01:00
Konstantina Chremmou
e8ff04d671 Removed HostMaintenanceModeCheck; simplified logic by having the HostLivenessCheck
verify, if required, whether the host is enabled.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-22 14:23:29 +01:00
Mihaela Stoica
ea7d522cf7 Fix the tests after changes in commit b6420b6c
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-10-19 10:25:54 +01:00
Konstantina Chremmou
988db0cbba Separated the MoveVirtualDiskDialog from the MigrateVirtualDiskDialog so it
is easier to understand which one is called from which command.
Removed superfluous TableLayoutPanel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 12:33:04 +01:00
Konstantina Chremmou
968701cf8e Removed property MenuShortcuts in favour of MenuShortcutsEnabled.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Mihaela Stoica
02075486ba
Merge pull request #2237 from xenserver/feature/REQ-488
Merge branch feature/REQ-488 into master
2018-10-05 09:41:21 +01:00
Aaron Robson
ca1113fbcc CA-287643: Replaced list view with data grid view to resolve column sizing issue and for consistency with the rest of the product. (#2226)
CA-287643: Replaced list view with data grid view to resolve column sizing issue and for consistency with the rest of the product.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-02 10:18:34 +01:00
Michael Z
9034c5a57a REQ-680: Merge master to feature branch.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-17 20:00:30 +10:00
Konstantina Chremmou
04b37092a6 CA-297020: Do not download imported appliance on a modal dialog (#2200)
* CA-297020: Do not download imported appliance on a modal dialog, but rather
asynchronously on the ImportSourcePage, so that the rest of XenCenter is usable
while the download is taking place; used the page's progress bar for this purpose
and removed the DownloadApplianceDialog.

* Corrections to the validation of the import source.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-14 15:55:05 +01:00
Michael Z
5e37264185 CA-297617: Change Citrix Hypervisor Tools to Citrix VM Tools.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-14 15:54:04 +01:00
Konstantina Chremmou
ad773d8f75 Fixed null reference exception in tests.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-29 10:25:47 +01:00
Konstantina Chremmou
12678f0afa CA-286882: Updated unit tests.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-24 16:18:44 +01:00
Konstantina Chremmou
b36534c157 CA-293813: Patch pools in parallel when installing a single update/patch or supplemental package. (#2183)
* CA-293813: Patch pools in parallel when installing a single update/patch or supplemental package.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Corrections as per code review.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 12:05:16 +01:00
Konstantina Chremmou
c67f85ebaa CA-210190: Fixed various layout and truncation issues on the VM/template memory
setting controls. Also removed the various types of ballooning dialogs since
the only thing changing was the contained memory settings control.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 08:23:04 +01:00
Konstantina Chremmou
c8c2ea448a CA-156828: Do not uncompress imported appliance on a modal dialog, but rather
asynchronously on the SelectImportSourcePage, so that the rest of XenCenter
is usable while the unzip is taking place; for this purpose a progress bar
was added on the page and the DecompressApplianceDialog was removed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-16 10:59:35 +01:00
Konstantina Chremmou
abec5c4aba CA-284090: Added a dedicated status bar on the TabPageFeature to resemble real
life browsers and allow the user to see the status even if other actions are taking
place. Removed webClient use from the browser; instead try sequentially to navigate
to all Uris until one succeeds; this avoids sending duplicate requests and allows
the user to see all endpoints tried out. Reworked the WebBrowser event handlers
to ensure the UI reflects correctly the browser state.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
518951d868 Deregister events and dispose of web clients when removing them from the list.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Ji Jiang
d0fc3be56e CA-294091: Fix two Update wizards co-exist bug
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-08-07 12:02:57 +01:00
serenc
8144061196 CP-28926: Fixed test issues caused by changes in CP-28926 branch
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-08-07 11:40:29 +01:00
Konstantina Chremmou
12fe9e9620 Store the domain and username rather than the whole AdPasswordPrompt.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
02eaac832a CA-294365: Replaced all references to pool or master except the necessary
with references to the connection; pool or master can be resolved from the
latter. This among others prevents the AD page from crashing when the master
and the pool change after master's entering maintenance mode.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Mihaela Stoica
f0952dbc88 Fix patching wizard tests
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-03 11:09:14 +01:00
Mihaela Stoica
f11d7933bb CP-28279: Fix the RPU wizard tests
- If the prechecks fail, try to resolve the problems

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-27 00:09:16 +01:00
Konstantina Chremmou
8a6c661f30 Fixed broken test. Small logging and window title improvements.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-26 22:15:11 +01:00
Mihaela Stoica
2023f93199 CP-28279:When installing the updates in the RPU wizard, we need to get the minimal patches for the first upgraded host (usualy the master), not for the whole pool, because the pool is of mixed versions at this stage.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-25 11:31:18 +01:00
Konstantina Chremmou
73fd7df880 Use existing extension method to retrieve the host's running VMs. Removed field
Dialogs needed only by test code; use existing wrappers of Windows APIs instead.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-25 11:31:18 +01:00
Mihaela Stoica
a99ae50f57 CP-28279: Change the upgrade page of the RPU wizard to inherit from the class AutomatedUpdatesBasePage
- Methods have been added to the base class to deal with the manual upgrade mode

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-25 11:31:18 +01:00
Mihaela Stoica
93a154e04f CP-28282: Unit tests fix + improved message
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-15 16:05:37 +01:00
Mihaela Stoica
15edb13997
Merge pull request #2089 from kc284/REQ-672
First batch of changes for CP-28281
2018-06-08 11:32:26 +01:00
Konstantina Chremmou
1b4a862fd0 Further corrections to the load/leave page workflow and object selection ensuring correct enablement of the Next button.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-07 12:27:57 +01:00
Konstantina Chremmou
723510b853 Removed class Updates.UpgradeSequence.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-05 11:50:34 +01:00
Mihaela Stoica
296739cfa4
CP-27751: Include new RPU003 and RPU004 plugins for CA-287020 (#2049)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-23 15:39:34 +01:00
Mihaela Stoica
e85954fb75 CP-27568: Update the RPU hotfix to version 5
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-05 11:01:04 +01:00
Mihaela Stoica
cab6a051b8 Merge branch 'REQ-477' into master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenModel/XenAPI/PCI.cs
#	XenModel/XenModel.csproj
2018-04-04 09:59:29 +01:00
Mihaela Stoica
d4c5a86698 Fix the SR wizard tests
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-04 08:03:28 +01:00
Konstantina Chremmou
7655011158 Compliance with C# conventions: normally interface names start with an I.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 13:00:27 +01:00
Konstantina Chremmou
4452318d1d Moved the classes FibreChannelDevice and FibreChannelProbeParsing to XenModel.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Mihaela Stoica
6d5e8116c4 CP-17099: Fix the usage of IscsiChoiceDialog in the tests
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-03 11:24:40 +01:00
Joey
48782eac44 CA-286458: Fix latestcr XC requirement when apply CR update (#2010)
* CA-286458: Fix latestcr XC requirement when apply CR update

Using minimum_xc_version attribute in xenserver version to
determine which xencenter version is required.

* CA-286458: change MinimumXcVersion type to Version

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-03-29 11:13:13 +01:00
Mihaela Stoica
ff05fb698c Merge remote-tracking branch 'upstream/master' into REQ-477
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenModel/XenAPI/Auth.cs
#	XenModel/XenAPI/Blob.cs
#	XenModel/XenAPI/Bond.cs
#	XenModel/XenAPI/Console.cs
#	XenModel/XenAPI/Converters.cs
#	XenModel/XenAPI/Crashdump.cs
#	XenModel/XenAPI/DR_task.cs
#	XenModel/XenAPI/Event.cs
#	XenModel/XenAPI/Feature.cs
#	XenModel/XenAPI/GPU_group.cs
#	XenModel/XenAPI/Host.cs
#	XenModel/XenAPI/Host_cpu.cs
#	XenModel/XenAPI/Host_crashdump.cs
#	XenModel/XenAPI/Host_metrics.cs
#	XenModel/XenAPI/Host_patch.cs
#	XenModel/XenAPI/JsonRpcClient.cs
#	XenModel/XenAPI/LVHD.cs
#	XenModel/XenAPI/Maps.cs
#	XenModel/XenAPI/Message.cs
#	XenModel/XenAPI/Network.cs
#	XenModel/XenAPI/PBD.cs
#	XenModel/XenAPI/PCI.cs
#	XenModel/XenAPI/PGPU.cs
#	XenModel/XenAPI/PIF.cs
#	XenModel/XenAPI/PIF_metrics.cs
#	XenModel/XenAPI/PUSB.cs
#	XenModel/XenAPI/PVS_cache_storage.cs
#	XenModel/XenAPI/PVS_proxy.cs
#	XenModel/XenAPI/PVS_server.cs
#	XenModel/XenAPI/PVS_site.cs
#	XenModel/XenAPI/Pool.cs
#	XenModel/XenAPI/Pool_patch.cs
#	XenModel/XenAPI/Pool_update.cs
#	XenModel/XenAPI/Role.cs
#	XenModel/XenAPI/SDN_controller.cs
#	XenModel/XenAPI/SM.cs
#	XenModel/XenAPI/SR.cs
#	XenModel/XenAPI/Secret.cs
#	XenModel/XenAPI/Session.cs
#	XenModel/XenAPI/Subject.cs
#	XenModel/XenAPI/Task.cs
#	XenModel/XenAPI/Tunnel.cs
#	XenModel/XenAPI/USB_group.cs
#	XenModel/XenAPI/User.cs
#	XenModel/XenAPI/VBD.cs
#	XenModel/XenAPI/VBD_metrics.cs
#	XenModel/XenAPI/VDI.cs
#	XenModel/XenAPI/VGPU.cs
#	XenModel/XenAPI/VGPU_type.cs
#	XenModel/XenAPI/VIF.cs
#	XenModel/XenAPI/VIF_metrics.cs
#	XenModel/XenAPI/VLAN.cs
#	XenModel/XenAPI/VM.cs
#	XenModel/XenAPI/VMPP.cs
#	XenModel/XenAPI/VMSS.cs
#	XenModel/XenAPI/VM_appliance.cs
#	XenModel/XenAPI/VM_guest_metrics.cs
#	XenModel/XenAPI/VM_metrics.cs
#	XenModel/XenAPI/VTPM.cs
#	XenModel/XenAPI/VUSB.cs
#	XenModel/XenModel.csproj
2018-02-27 17:42:18 +00:00
Konstantina Chremmou
20099263a8 Added basic unit tests for the JsonConverters.
In theory, these should be added on the SDK side, but at the moment it is
easier to add them in XenCenter because the SDK does not have infrastructure
for NUnit tests yet.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-02-14 11:10:03 +00:00
Konstantina Chremmou
123db499f5 Merge branch 'master' into REQ-420 2018-01-25 13:38:58 +00:00