Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-11-25 06:16:37 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,196 Commits 11 Branches 48 Tags 186 MiB
489069b36b
Commit Graph

3918 Commits

Author SHA1 Message Date
Konstantina Chremmou
489069b36b Control behaviour corrections: 
- When radio buttons share the same container, only one needs to be checked.
- Do not set the owning control to null, or the balloon does not hide when asked to.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-06 10:50:13 +00:00
Konstantina Chremmou
57b07a9c7b Set roaming to true. Corrected setting type. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-06 10:50:13 +00:00
Konstantina Chremmou
879191424c Added hotkeys. Corrected tab indices. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
b66685a927 CP-38529: Remove method calling PuTTY in GeneralTabPage 
Method is not useful anymore. This commit only removes the PuTTY-related code.

Other docker-related unused code is ignored as it should be removed separately.

Whitespace diffs are tabs -> spaces and automatic VS2019 reformatting

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
d27eaa3bbd CP-38529: Use pre-installed SSH clients to launch VM console 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
8801b6bdf9 CP-38529: Check SSH client settings on launch 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
495dcd66d4 CP-38529: Make PluginManager public in MainWindow.cs 
To allow to open the Options page from other forms

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
3956502063 CP-38529: Add External Tools options page 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
971ae0d064 CP-38529: Add SSH client settings 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
CitrixChris
8281ae5c05
CA-359809 improved illegal character message (#2898) 
* CA-359809 improved illegal character message

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 cleared whitespace, improve code readability

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 implemented reviewer comments.

Moved Path validator to XenModel Project where other language files have already been set up.
Improved error messages.

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 improved string localisation, Code tidy

Cannot became can not, messages file alphabetised, improved readability with using xenmodel as opposed to direct call

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 changed can not to cannot

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2021-11-22 12:02:26 +00:00
Konstantina Chremmou
c2f92aa02a
Merge pull request #2903 from danilo-delbusso/CP-36392-Bugs 
CP-36392: Address statically flagged trivial issues that can cause bugs
 2021-11-17 11:36:48 +00:00
Danilo Del Busso
f2fdf31a5a
CP-36392: Avoid multiple enumerations in LicenseStatus.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-17 09:01:25 +00:00
Danilo Del Busso
3e861411db
CP-36392: Invert if statements to reduce nesting in HostMemoryControls and changeControlDomainMemoryCommand 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-16 11:42:18 +00:00
Danilo Del Busso
47510f5b07
CP-36392: Reassign expiryGroups after ordering 
regression from db2c00d5

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-16 11:39:50 +00:00
Konstantina Chremmou
5078c4db0d CP-38086: Block upgrade for PV guests. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/Branding.resx
#	XenAdmin/Diagnostics/Checks/PVGuestsCheck.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenModel/BrandManager.cs
#	XenModel/Utils/Helpers.cs
 2021-11-15 15:49:39 +00:00
Danilo Del Busso
cfff0722c7
CP-36392: Limit ex-readonly public lists to {get;} usages only 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:11:41 +00:00
Danilo Del Busso
6f7faefce1
CP-36392: Replace complex method with single LINQ calls in DRFailoverWizardStoragePage 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:09:11 +00:00
Danilo Del Busso
68b54682ae
CP-36392: Move param checks outside of RepairSRDialog.cs's constructor 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:05:08 +00:00
Danilo Del Busso
31702c9e43
CP-36392: Add null checks for ControlDomainMemoryDialog's constructor params 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:00:50 +00:00
Danilo Del Busso
cc917e2a66
CP-36392: Simplify if and else if blocks to reduce nesting in AddServerDialog.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:57:08 +00:00
Danilo Del Busso
1acce3638c
CP-36392: Move vms null and Count checks outside of WlbRecommendations.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

damni

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:52:06 +00:00
Danilo Del Busso
396bcb0e35
CP-36392: Make type field readonly in QueryElement.cs 
field is used in `GetHashCode`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:46:12 +00:00
Danilo Del Busso
494f78966d
CP-36392: Address logic issue in FilterLocationToolStripDropDownButton.cs 
As suggested during review:

> The check after the `&&` should go in a nested if block: if we are in a split second where the cache has not been populated yet, there should be no item added, however, this code will add a `p` item.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:43:50 +00:00
Danilo Del Busso
02439d5303
CP-36382: Replace _nameCell with ad-hoc _xenObject readonly field 
To ensure that the field in the `GetHasCode` call is `readonly`
Also remove unused constructor

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:36:42 +00:00
Danilo Del Busso
5d5d971c74
CP-36329: Remove redundant verbatim in WlbRecommendations.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:29:21 +00:00
Danilo Del Busso
47884376a3
CP-36392: Fix typo in VNCTabView.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:29:19 +00:00
Danilo Del Busso
caf608344e
CP-36392: remuve redundant iteration in ResumeVMOnHostToolStripMenuItem.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:24:17 +00:00
Danilo Del Busso
b6a70e2ffc
CP-36392: Add null check for _vmOptList in WlbOptimizePoolAction.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:18:55 +00:00
Danilo Del Busso
45512b4cde
CP-36392: Add removed null check in WlbOptiomizePool.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:18:09 +00:00
Danilo Del Busso
6ce0a4b49d
CP-36392: Remove repetitive count and null check 
Check is performed within the constructor of `WlbRecommendations`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-03 16:07:36 +00:00
Danilo Del Busso
2978f60f8a
CP-36392: Improve readability of latest changes 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-03 10:23:21 +00:00
Konstantina Chremmou
688fe99e3e CA-359969: Do not rebuild the list if the scanning of the SRs has not finished yet. Removed unused code. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-02 16:53:48 +00:00
Danilo Del Busso
38701d148e
Merge branch 'master' of https://github.com/xenserver/xenadmin into pr/2903 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenModel/Actions/GetDataSourcesAction.cs
 2021-10-27 13:24:23 +01:00
Konstantina Chremmou
c44f6496df CA-360011: Allow full disk copy only if all VDIs of the snapshot/custom template allow it. 2021-10-26 16:55:18 +01:00
Konstantina Chremmou
f2d81d5744
Merge pull request #2869 from danilo-delbusso/CP-36392 
CP-36392: Address Security Features and Code Smells
 2021-10-26 16:54:34 +01:00
Konstantina Chremmou
23ec669698 The message Messages.UPSELL_BLURB_TRIAL was displayed twice on the AD, HA, and Users tabpage for unlicensed pool. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-10-26 00:47:08 +01:00
Konstantina Chremmou
45fe1f436b CA-359795: Fixed issue whereby a double error was shown when a non-privileged user attempted to apply a licence. 
Removed ApplyLicenseEditionCommand as it was unnecessary (there was no
button/menuitem calling it). Use the ApplyLicenseEditionAction instead.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-10-26 00:47:08 +01:00
Konstantina Chremmou
5c66471db0 CA-359793: Fixed stray label showing while entering maintenance mode. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/EvacuateHostDialog.cs
 2021-10-26 00:47:08 +01:00
Konstantina Chremmou
588f976a9b CA-359744: Do not add a host label if the host has disappeared from the cache. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-10-26 00:47:08 +01:00
Konstantina Chremmou
6b7cd1d9e5 Corrected calculation of datasource units (CA-359068). New/Edit Graph dialog enhancements. 
- CA-359068¨Match the whole datasource name (previously the wrong one was picked
  for disk read/write latency).
- New/edit Graph dialog: differentiate between enabled/disabled datasources and
  visible/hidden (known/unknown units; the latter may mean no data).
- Some refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-10-12 12:28:42 +01:00
Danilo Del Busso
69722d93bd
CP-36392: Rename key constants in WlbReportSubscription.cs to avoid field clash 
Names are amibguous
Also made the fields `const`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-05 11:56:15 +01:00
Danilo Del Busso
3a69fa0f8c
CP-36392: Add readonly to fields used in GetHashCode 
Also tidy up some code

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-05 11:39:17 +01:00
Danilo Del Busso
2352dcc4bf
CP-36392: Remove unused KeySet.cs 
File isn't used and contains 2 minor bug SonarQube flags

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-05 10:13:25 +01:00
Danilo Del Busso
4e4747ecb8
CP-36392: Remove misleading readonly in collection/array fields 
`reaonly` should be used for items that can't be modified. The changed collections/arrays are modified, so `readonly` is misleading

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 16:27:42 +01:00
Danilo Del Busso
db2c00d54d
CP-36392: Cast operands of divisions to not lose precision 
Cast to `decimal` or `float` to keep floating-point precision

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 16:22:29 +01:00
Danilo Del Busso
dcbaf5d1a4
CP-36392: Amend calls that generate unused return values 
Mixture of correctly implementing `Trim()` calls, and removing calls that generate useless ephemeral variables.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:42:40 +01:00
Danilo Del Busso
a5ddcf1b97
CP-36392: Refactor loops into if blocks 
Loops are effectively used as if statements. Changed to improve readability.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:42:10 +01:00
Danilo Del Busso
408cf98add
CP-36392: Add miscellaneous null checks 
Also tidy up code
Also remove method in `SnapshotTreeView.cs` that wasn't used, which necessitated a null check

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:42:07 +01:00
Danilo Del Busso
02aa50f7a8
CP-36392: Refactor conditions that result in unreachable code blocks 
Also tidy up surrounding code

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:42:04 +01:00
Danilo Del Busso
cfc7bd0ef9
CP-36392: Update RebootPlanAction.cs to lock on a dedicated object instance 
Use dedicated instance to avoid deadlocks or lock contention
Also fix typo and rename `private` variable

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:42:03 +01:00