Commit Graph

486 Commits

Author SHA1 Message Date
Gabor Apati-Nagy
48ef276c06 CA-216935: Fixed a bug that can occur when multiple pools are being updated with the same update and one of the prechecks happen before the other pool is finished applying the update
The PatchPrechecksOnMultipleHostsInAPoolPlanAction did not filter the patchmappings by masterhost, so with some probability, it could choose the wrong mapping (pool_patch object for the same update, but in different pool). This bug is being fixed in this commit, other changes only renamed (for more consistent naming) a class and removed an unused field.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-02 14:30:20 +01:00
Gabor Apati-Nagy
893275fb2f CA-215573: Batch updates: Install update wizard "Finish" button activated even when batch install still in progress
Trivial changeset

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-19 09:25:17 +01:00
Gabor Apati-Nagy
a007eec882 CA-216162: Batch updates: Wrong hover message on install update wizard when installing batch updates
Better messages on Select Server Page

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-19 09:12:30 +01:00
Gabor Apati-Nagy
bd26c7ac0e CA-215093: Batch updates: Update progress failed in a pool of mixed state hosts
Utilising default comparer on Host (This will makemaster first.)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 15:37:52 +01:00
Gabor Apati-Nagy
f8a7d97890 CA-215093: Batch updates: Update progress failed in a pool of mixed state hosts
Where (in code removed by this commit) we iterated through the planActionsByHost dictionary, the hosts were iterated through in the order how the dictionary was initialized. Despite the actions were added in the right order, they then were screwed up, because the Cache.Hosts can have the hosts randomly while we want the master to be first.

To fix the bug, I changed the data structure from a dictionary to a list that has the actions exactly in the (good) order, the order they were added, eliminating the risk of the actions being retrieved in the wrong order.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 14:35:31 +01:00
Gabor Apati-Nagy
1fe300c16d CA-214063: Batch Updates: Name of the master is shown
Removed unused field

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 11:00:40 +01:00
Gabor Apati-Nagy
504f73778f CA-214063: Batch Updates: Name of the master is shown instead of the pool's name on Select Servers Page
Code review changes: Showing server icon for standalone hosts instead the pool icon

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 10:42:49 +01:00
Gabor Apati-Nagy
55ff3794cf CA-214063: Batch Updates: Name of the master is shown instead of the pool's name on Select Servers Page
Fixed display issue, now showing pools (and standalone hosts at the same level), not masters.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-01 17:41:49 +01:00
Gabor Apati-Nagy
66be637878 Merging (upstream) master into REQ-156 branch caused a build error:
Fixed build error that was caused by changed visibility of a method.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-29 17:56:51 +01:00
Gabor Apati-Nagy
994f5b4811 Merge remote-tracking branch 'github_xenadmin/master' into master_batch_new2 2016-06-29 16:52:13 +01:00
Gabor Apati-Nagy
ee08e06f52 CA-214566: Upload succeeded, but Pool_patch hasn't been found
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-27 19:43:41 +01:00
Konstantina Chremmou
fd3393049c Code simplification: use Action delegate instead of EventHandler since the event is not sending any objects when triggered. 2016-06-27 10:20:23 +01:00
Mihaela Stoica
e87505e13d CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix a dialog return check changed by accident

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-23 15:47:15 +01:00
Gabor Apati-Nagy
a8445d5ed8 Fixed warning as an error in build
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-23 10:27:16 +01:00
Gabor Apati-Nagy
587c2b5f5d CA-214077: Typo in Messages.resx
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-22 14:43:22 +01:00
Gabor Apati-Nagy
39109d30a4 CA-214062: REQ-156 Batch Updates: In progress actions shown as done
Fixed trivial bug where in progress actions had done shown as their statuses

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-22 11:07:12 +01:00
Mihaela Stoica
da9e99b1cb CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix ActionProgressDialog usages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 13:17:42 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
Gabor Apati-Nagy
7a84b305ef CP-17699: Developer testing and improvements
for Batch Updating

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-17 14:15:59 +01:00
Mihaela Stoica
fcee4d8876 CA-77990: Report required actions for all VMs at once in the hotfix wizard / RPUW (#951)
* CA-77990: Report required actions for all VMs at once in the hotfix wizard / RPUW

* CA-77990: Resolve precheck problems in parallel in the Patching wizard

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-77990: Resolve precheck problems in parallel in the Patching wizard

Changes following code review: Made the ParallelAction work across connections and removed CrossConnectionParallelAction

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-77990: Modified ParallelAction to create queue on RunSubActions only, with the correct queue size

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-07 17:40:59 +01:00
Gabor Apati-Nagy
9ec512921b CP-15790: Prepare XenCenter for unit testing of Automatic Updates
Added support for defining custom update.xml location in Registry. This
can be either a local file or an URL. This will be beneficial when testing XenCenter.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-07 16:02:57 +01:00
Gabor Apati-Nagy
bd69aab6d2 CP-15719: UI: Implement error handling/reporting on Upload & Install page
Changes following code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-03 15:08:30 +01:00
Gabor Apati-Nagy
d449b153b3 Merge remote-tracking branch 'github_xenadmin/REQ-156' into master_batch_new2 2016-06-03 13:31:00 +01:00
Gabor Apati-Nagy
3561155d03 CP-15719: UI: Implement error handling/reporting on Upload & Install page
Some more on error handling, better displaying of errors

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-01 13:45:21 +01:00
Gabor Apati-Nagy
81a0bf20f9 CP-15714: UI: Change Select Servers Page
DownloadUpdatesXmlAction is called on PageLeave and not when the user selects Automatic Mode. This way we get the error message at the right time, also showing a progress dialog what makes the UX much better.
New tooltips for servers on the Select Server Page to to cover two more cases

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-31 19:00:35 +01:00
Gabor Apati-Nagy
73d67f407d CP-15719: UI: Implement error handling/reporting on Upload & Install page
Implemented error handling.
If there has been an error in a pool, we stop executing actions in that pool immediately, and report the error once every other actions have finished. Error in one pool will not affect the upgrade process of other pools.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-18 13:43:34 +01:00
Gabor Apati-Nagy
a05e92d001 UI: Implement parallel execution of the sequences
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-11 14:13:14 +01:00
Gabor Apati-Nagy
235ebe9b33 Merge branch 'master' of https://github.com/xenserver/xenadmin into master_batchupdate_new 2016-05-05 13:59:28 +01:00
Gabor Apati-Nagy
834c012fb8 Merge pull request #953 from MihaelaStoica/CA-206464
CA-206464: Add certificate validation to the VM export
2016-05-04 13:58:04 +01:00
Gabor Apati-Nagy
deb4d5724c CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
Fixes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 13:47:41 +01:00
Gabor Apati-Nagy
ae02594683 CP-15713: UI: Change Before You Start page
Removed the first item instead of changing it - it is more logical to not to have it displayed here.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 12:25:38 +01:00
Gabor Apati-Nagy
62d332bc45 CP-15713: UI: Change Before You Start page
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:37:39 +01:00
Gabor Apati-Nagy
fdb930bb19 CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
cleaned up code

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:21:23 +01:00
Gabor Apati-Nagy
72147734b5 CP-16513: UI: Apply licensing requirements 2016-05-04 11:08:08 +01:00
Gabor Apati-Nagy
fca591cd6f CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
intermediate commit

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:07:37 +01:00
Gabor Apati-Nagy
466f01b926 CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:06:39 +01:00
Gabor Apati-Nagy
d3914a2318 CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
intermediate commit

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:02:16 +01:00
CITRITE\sriharshak
809bf9161e L10N:Dundee translation changes 2016-04-26 16:39:21 +05:30
Mihaela Stoica
f9c52cd637 Merge pull request #962 from sriharshak/master
L10N:CA-205536 fix
2016-04-22 11:18:32 +01:00
CITRITE\sriharshak
f600cb53a5 L10N:CA-205536 fix 2016-04-21 23:14:03 +05:30
Gabor Apati-Nagy
e7d7661d51 CA-208720: Fix for: Can type text into the label in Bugtool wizard, Destination page
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-04-21 17:55:56 +01:00
CITRITE\sriharshak
7d5f20cf4e L10N:CA-206595 fix 2016-04-21 17:17:22 +05:30
CITRITE\sriharshak
9b6ecde8ab L10N:CA-169593 fix 2016-04-21 12:34:33 +05:30
Mihaela Stoica
ed7548e02a CA-206464: Add certificate validation to the VM export
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-04-20 15:17:48 +01:00
CITRITE\sriharshak
8c0623b8f2 L10N:Dundee:Translation check-ins 2016-04-20 19:16:33 +05:30
Mihaela Stoica
549e26ad94 CA-208495: XenCenter does not specify the NFS version when reattaching an existing SR
- Re-position the version radio-buttons, so that is clear that the selected version applies to both Create and Reattach
- Pass the selected version to the attach command in the device_config parameter

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-04-20 09:44:58 +01:00
Mihaela Stoica
64d9bece24 CA-207915: XenCenter does not display the correct supported NFS versions in the New SR wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-04-15 15:01:09 +01:00
Mihaela Stoica
6dcc00d017 CA-205204: Uncaught exception during RPU
When an exception is reported during the RPU, XenCenter tries to re-enable the host. But when this fails, we should just ignore it and report the original exception.

Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-03-24 17:18:53 +00:00
CITRITE\sriharshak
cf2fbe88e3 L10N:Dundee:Xencenter:ITR002 transltion check-ins 2016-03-23 23:58:30 +05:30
Gabor Apati-Nagy
6934e7fa3f Merge pull request #905 from MihaelaStoica/CA-204191
CA-204191: Trying to avoid Uncaught exception System.InvalidOperation…
2016-03-23 09:53:07 +00:00