Konstantina Chremmou
59486541a5
Merge pull request #2985 from kc284/sonarqube
...
CP-36392: Improvement of sonarqube score
2022-04-20 10:25:23 +01:00
Konstantina Chremmou
889ef5adce
Renamed fields.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-14 11:45:21 +01:00
Danilo Del Busso
d90abfd1b6
[CHC] CA-366069 & XSI-1222: Fix incorrect capitalisation of value in Japanese version + add some case insensitive checks ( #2986 )
...
* CA-366069: Fix incorrect capitalization of value in Japanese invisible messages `resx`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366069: Add case insensitive checks on code around usage of `ISO_UPDATE`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366069: Remove changes in string capitalisation
Move capitalisation invariance to checks only
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366069: Remove `ISO_UPDATE` from `InvisibleMessages.resx`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-366069: Add remaining `ToLowerInvariant()` calls
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-04-14 11:36:55 +01:00
Konstantina Chremmou
558897740d
Reworked instantiation of dummy actions that complete immediately.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-11 21:59:29 +01:00
Konstantina Chremmou
038de3ca62
Use consistent variable names.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-11 19:43:09 +01:00
Konstantina Chremmou
04ac8249a6
CP-36392: Refactored to avoid having unused object instantiations of the ActionBase class.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:35 +01:00
Konstantina Chremmou
d2548ae4c0
CP-36392: Do not create an action for changing the master password.
...
Generally we don't show events for saving applications options. Also,
renamed field and deleted comments that were not particularly enlightening.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:34 +01:00
Konstantina Chremmou
dce02a2562
Renamed AsyncAction.RunExternal to AsyncAction.RunSync so it is more descriptive.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:34 +01:00
Konstantina Chremmou
84ad7054ea
Compacted the ActionBase constructors and renamed file to match the class name.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:33 +01:00
Konstantina Chremmou
ec33caf4b5
CP-36392: Refactored so that GetHashCode() does not call the homonymous base class method.
...
This required refactoring the OVF.AddVirtualSystem() method to accept the
system ID as a parameter. Also, removed some unused methods that were
calling OVF.AddVirtualSystem().
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:33 +01:00
Konstantina Chremmou
492cd4dc88
CP-36392: Do not use a loop for only one iteration.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-04 21:07:09 +01:00
Konstantina Chremmou
acc5ed0210
CP-38542: Remove option to disable live patching.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-01 16:17:22 +01:00
Konstantina Chremmou
aaee939453
Some corrections on the DRWizard prechecks page:
...
- Re-arranged and re-worded controls so that this page looks more like
the precheck page of the patching and RPU wizards.
- Do not show the failure message unless issues are found.
- Do no enable the Resolve All button unless all issues are fixable.
- Fixed crash when the required SR is present in the pool but detached.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-01 16:07:43 +01:00
Konstantina Chremmou
ef86be5347
Merge pull request #2978 from kc284/actions
...
Compacted ParallelAction and MultipleAction constructors.
2022-04-01 16:07:30 +01:00
Konstantina Chremmou
51a400bf70
CA-365717: Two corrections on VM import (from XVA):
...
- Do not suppress failures when polling the import task.
- When the imported VM is suspended, try resuming instead of starting it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-01 11:21:41 +01:00
Konstantina Chremmou
81d5c508a1
Refactoring suggested by code review (largely naming conventions).
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-28 13:43:24 +01:00
Konstantina Chremmou
a91dd6398d
Compacted ParallelAction and MultipleAction constructors.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:50:27 +00:00
Konstantina Chremmou
dd978914cf
CA-365297: Fixed error shown when attempting live migration of DMC VM to non-DMC host.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:10:51 +00:00
Konstantina Chremmou
2110607cc1
CA-365143: Correction when changing a VM's memory settings:
...
- Corrected the logic deducing whether shutting down and restart is needed.
- Fixed crash when starting a VM without a home host.
- Also, renamed some fields for better compliance with C# naming conventions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:10:40 +00:00
Konstantina Chremmou
220ab25302
CA-365317: Updated warnings after disallowing connection to pre-yangtze servers.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:10:25 +00:00
Konstantina Chremmou
3453e84a0f
CA-365223: PVS accelerator is now part of the main install.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-14 17:33:03 +00:00
Konstantina Chremmou
25760b2bc6
CP-38814: Minor message improvement.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-14 17:32:11 +00:00
Konstantina Chremmou
eb58973497
Fixed crash when retrieving pool info from DR metadata.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-14 17:31:48 +00:00
Konstantina Chremmou
00c5285411
CP-39142: Add RPU pre-check in CHCenter to warn of DMC removal.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-03 14:36:06 +00:00
Konstantina Chremmou
dec2eead15
Renamed methods so they describe better what they do.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-03 14:36:06 +00:00
Konstantina Chremmou
b2dc968ab1
CP-38895: Check version annotations when using API fields or methods.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-03 14:35:45 +00:00
Darren Matthews
151841ce5e
L10N : Translation Updates & Resx sync
...
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2022-03-03 14:35:30 +00:00
Danilo Del Busso
a310fa60cf
CP-36392: Remove all unnecessary using
s
...
Ignores XenAPI
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-02-24 11:53:44 +00:00
Konstantina Chremmou
a342adc859
CA-364152: Do not calculate completed percentage if there are no actions to run.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-23 12:38:02 +00:00
Danilo Del Busso
a578b6924c
CA-361078: Parse OVFs without a Limit
element in the vCPUs section
...
VMWare OVFs don't export the value
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-02-18 10:28:38 +00:00
Konstantina Chremmou
8493ee5e90
CA-363819: Fixed issue where VM network usage data were not shown on the Search TabPage.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 13:17:57 +00:00
Konstantina Chremmou
29189873a3
CA-363610: OVF import: fixed upload of OS fixup ISO.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 13:17:57 +00:00
Konstantina Chremmou
493ed4cabe
CP-38526/XSI-1055: Improved import performance for OVF/OVA packages with .vhd disks.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 13:17:57 +00:00
Konstantina Chremmou
ca37331c8d
CA-362709, CA-362711: Reworked the logic for allowing full disk copy when creating a VM from a snapshot or custom template.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-14 14:35:51 +00:00
Konstantina Chremmou
321389455e
Refactoring: compacted Role.ValidRoleList() and Role.CanPerform() overloads.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-03 11:59:17 +00:00
Konstantina Chremmou
6aec4ea281
CP-38893: Make internal roles unavailable for selection.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-03 11:59:17 +00:00
Konstantina Chremmou
50dd22f4da
CA-362868: POOL_CA_CERTIFICATE_* alerts are issued on the certificate and not on the pool.
...
Also, moved the function retrieving the XenObject from the alert to the Message class extensions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-31 14:56:12 +00:00
Konstantina Chremmou
d6f91526d2
Restored friendly name and description for CVSM.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-31 14:56:12 +00:00
Konstantina Chremmou
713a61cead
Updated C# SDK (xapi 22.5.0-1.xs8).
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-28 14:19:34 +00:00
Danilo Del Busso
2bc25d72d5
CP-38814: Add friendly names to new xapi alerts
...
vm_migrated
vm_snapshotted
vm_snapshot_reverted
vm_checkpointed
vm_paused
vm_unpaused
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-24 15:46:37 +00:00
Danilo Del Busso
d7f1853562
Bump C# SDK to modified version of xapi 21.3.0/1.xs8
...
SDK update does not contain the removal of `evacuate` overloads
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-24 15:46:37 +00:00
Konstantina Chremmou
8f9afafb7a
Use Tick() when setting both the PercentComplete and the Description to avoid firing OnChanged() twice.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-24 15:23:02 +00:00
Konstantina Chremmou
1225e98225
Improved logging and reporting percentage when importing an XVA.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-24 15:23:02 +00:00
Danilo Del Busso
f07b3d4e05
CP-37850: Update RPU005 to version 4.0
...
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-24 15:22:07 +00:00
Konstantina Chremmou
ba8cf7f782
Merge pull request #2934 from xenserver/feature/CP-38483
...
CP-38483: Unbundle putty from Citrix Hypervisor Center
2022-01-24 15:21:32 +00:00
Konstantina Chremmou
f29e267670
Some corrections and refactoring on the external console feature.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-17 14:09:34 +00:00
Danilo Del Busso
c9bb9c1f0c
CA-362353: Add file existence check when launching SSH console
...
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-17 14:09:34 +00:00
Danilo Del Busso
34876461fc
CA-362354: Account for non-exe files when saving SSH client path
...
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-17 14:09:34 +00:00
Konstantina Chremmou
1e1bb8ddcd
Retry sorting .resx strings.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-10 14:39:38 +00:00
Darren Matthews
95667d3c80
L10N : Translations
...
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2022-01-10 10:13:24 +00:00