Commit Graph

153 Commits

Author SHA1 Message Date
Danilo Del Busso
4f14f3264d
CA-380355: Revert line endings to LF in metadata lines of WixToolset patch file
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-28 09:10:08 +01:00
Danilo Del Busso
ccce6b7ad8
CA-380355: Align Tree in CustomizeDlg with Box on its right
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-28 09:02:24 +01:00
Danilo Del Busso
23482a6be1
CA-380545: Do not use RemoveFolder for Desktop folder
It's meant to delete empty folders on uninstall but it's not applicable in this case, and caused issued if users don't have the correct rights.

Also rename the IDs to better match content

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-25 11:32:43 +01:00
Danilo Del Busso
675775cb01
CA-380355: Ensure shortcut is only created if user selects option in installer
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-25 08:30:10 +01:00
Danilo Del Busso
1d8391c9f9
CA-378489: Remove all remnants of previous installation when upgrading with Wix installer
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-10 13:48:09 +01:00
Danilo Del Busso
715f873329
CA-374325: Move shortcut to last page
Also update spacing of controls within the `CustomizeDlg` to take more advantage of the available space

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-10 13:48:09 +01:00
Danilo Del Busso
54c34b90b9
CA-374325: Add shortcut checkbox to custom setup dialog
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-04-21 15:20:25 +01:00
Danilo Del Busso
f01c48c8ba
Remove unused patch of WIXUI_EXITDIALOGOPTIONALTEXT
The text shown is the `Text` property of the `OptionalCheckBox` control

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-04-21 15:20:24 +01:00
Danilo Del Busso
15fcc02124
CA-376480: Prevent two instances from starting after running installer
When an instance of XenCenter is already running, the installer shows the `MsiRMFilesInUse` fragment. Pressing OK within that fragment with the `WixUIRMOption` property set to `UseRM` means that the `RMShutdownAndRestart` event kicks in at the end of the installation.

This happens at the same time as the existing "Launch XenCenter" event (if the matching checkbox is checked), causing in the executable being started twice at about the same time. My guess is that the pipe system is not initialised at that point, and that's how we get two applications.

To avoid this, this commit adds a new custom property: `XS_WixUIRMPressedOk`. This is set to `1` when the user clicks OK on the `WixUIRMOption`. It allows us to know whether or not that dialog was shown at all, as checking `WixUIRMOption` is not possible (it's already set to `UseRM` by default). By checking the value of this property we prevent the "Launch XenCenter" option to be shown if `MsiRMFilesInUse` was shown to the user (and they clicked OK). This applies both in case of a repair and an upgrade from a previous version.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-04-21 11:44:42 +01:00
Konstantina Chremmou
6cd1393161 Bumped branding to v4.15. Removed leftover references of branded components.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-30 10:22:12 +01:00
Konstantina Chremmou
3ee2e7e571 Removed obsolete code/hidden functionality and related outdated sample xapi databases.
- Removed sample databases. They are outdated, hence unloadable, and loading

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-03-21 15:51:59 +00:00
Danilo Del Busso
2585da8bb3
CA-375703: Remove leftover language mentions in XenCenter.wxs
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-03-08 09:35:27 +00:00
Danilo Del Busso
3edf31b7a2 CA-375346: Point to Wix Shell instead of executable when launching XenCenter
XenCenter executable was started with elevated privileges even with use of `Impersonate = "yes"`, and `WixShellExecTarget` was actually ignored.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-24 18:09:28 +00:00
Danilo Del Busso
c74f6169bf
CP-41748: Remove non-English locals from installer
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-22 14:29:50 +00:00
Konstantina Chremmou
3a71ff29eb CP-42155: Removed HealthCheck service leftovers from the build and the installer.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-21 16:05:09 +00:00
Konstantina Chremmou
d7b519a53c Updated copyright notice on files.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-30 16:24:16 +00:00
Konstantina Chremmou
372e70e95f Corrections are per code review.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-25 12:50:49 +00:00
Konstantina Chremmou
f7796582c3 CP-41433: Use the product name for the installation path, and the settings/logs parent folder.
Also, renamed the placeholder because msbuild converts spaces to underscores
and in debug mode the settings path is different from the one expected.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-25 12:50:49 +00:00
Konstantina Chremmou
af297508eb The home page htmls are not needed in the installer because they are now embedded in the resources.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-10 13:13:44 +00:00
Konstantina Chremmou
6f41019ad9 CP-41432: Replaced the HomePage .mht files with an html file.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2022-12-16 00:37:24 +00:00
Konstantina Chremmou
92e66a2eed
Merge pull request #3068 from kc284/ionic
Removed dependency on IonicZip.
2022-12-14 01:00:23 +00:00
Konstantina Chremmou
e29b8b39d5 Removed dependency on IonicZip. Use the corresponding classes of .NET Framework.
Also renamed the archive classes because they were named after the 3rd
party library used and were confusing.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-18 16:53:30 +00:00
Konstantina Chremmou
6644ef920a CP-41108: Replaced the separate splash screen executable with a form within the application executable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-14 09:45:33 +00:00
Danilo Del Busso
f8482e7502
CP-39818: Fix whitespace in installer localization files
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-06-09 16:04:25 +01:00
Danilo Del Busso
e4deda22b3
CP-39818: Show auto-launch option when repairing/changing the installation
New logic only hides the option when uninstalling the app

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-06-09 15:56:28 +01:00
Danilo Del Busso
a6113b26d8
CP-39818: Apply code review suggestions
- Use `BrandConsole` for the name of the app
- Use a localised value for the word `Launch`
- Use `asyncNoWait` when launching the CHC executable

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-06-09 15:55:07 +01:00
Danilo Del Busso
37c374155f
CP-39818: Auto-launch app after installation is finalized
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-06-06 13:00:12 +01:00
kishore Mengani
6b69496a39 L10n: Resx resync and trnslations updates
Signed-off-by: kishore Mengani <kishore.mengani@citrix.com>
2022-05-17 10:51:10 +01:00
Danilo Del Busso
6a52322035 CP-38530: Remove PuTTY from build scripts and wix installer
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-07 10:04:43 +00:00
Konstantina Chremmou
70af65e446 CA-355182: Removed obsolete RPU hotfixes.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-08 15:55:52 +01:00
Konstantina Chremmou
67d1ddd1d1 Merge remote-tracking branch 'upstream/master' into feature/hyperman
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/Branding.resx
#	Jenkinsfile
#	XenAdmin/Alerts/Types/GuiOldAlert.cs
#	XenAdmin/Alerts/Types/LicenseAlert.cs
#	XenAdmin/Commands/RestartToolstackCommand.cs
#	XenAdmin/Diagnostics/Problems/HostProblem/HostNotSafeToUpgradeWarning.cs
#	XenAdmin/Dialogs/AllowUpdatesDialog.cs
#	XenAdmin/Dialogs/OptionsPages/ConfirmationOptionsPage.cs
#	XenAdmin/Dialogs/RepairSRDialog.cs
#	XenAdmin/Dialogs/UpsellDialog.cs
#	XenAdmin/Plugins/UI/TabPageCredentialsDialog.cs
#	XenAdmin/Program.cs
#	XenAdmin/Wizards/ConversionWizard/ConversionNetworkPage.cs
#	XenAdmin/Wizards/CrossPoolMigrateWizard/CrossPoolMigrateDestinationPage.cs
#	XenAdmin/Wizards/NewSRWizard_Pages/SrWizardType.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_FirstPage.cs
#	XenCenterLib/XSVersionAttribute.cs
#	XenModel/BrandManager.cs
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx
2021-05-25 15:51:42 +01:00
Konstantina Chremmou
c485f8ee5e Licence and legacy update files are no longer relevant.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-17 14:52:38 +01:00
Mihaela Stoica
21aae840af CP-35471: Add the new version of RPU005 in the hotfix mapping
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2021-03-19 11:38:39 +00:00
Konstantina Chremmou
11ce488062 Merge branch 'master' into feature/hyperman
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Jenkinsfile
#	scripts/xenadmin-build.sh
2021-02-17 14:51:13 +00:00
Konstantina Chremmou
2b93c22d35 Minor corrections to enable local build without applying external branding.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-17 02:54:04 +00:00
Ji Jiang
dc466f245c CP-35478: Rebranding effort
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2021-01-26 15:44:43 +00:00
Konstantina Chremmou
23892df15d Moved the OVF actions to XenModel and removed what was left from XenOvfTransport.
Previously this was not possible due to XenModel-XenOvfTransport cyclical references.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
cd0135c7ff Removed unused code for .wim (not supported) and .xva (we use a different mechanism).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
d045d180a0
Merge pull request #2696 from xenserver/master
Bring branch dotnet48 up to date with master
2020-06-15 15:43:52 +01:00
Konstantina Chremmou
7a90d4e4f1 Sign localised resource dlls.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-12 09:11:46 +01:00
Konstantina Chremmou
41afa2a753 CP-32921: Target .NET Framework 4.8 and build using VS2019 tools.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-19 23:10:41 +01:00
Konstantina Chremmou
88fa402e21 Merged the projects XenAdmin and XenCenterVNC.
Since the standalone VNC control was removed, the VNC code has been used only by
the UI project. According to Microsoft's performance guidelines large single
assemblies are preferable to multiple smaller ones.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-19 23:10:41 +01:00
Konstantina Chremmou
9e458373b0 Missing copyright; typos found from spell check; added terms to ignore list.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-04 12:40:20 +00:00
Darren Matthews
7925bcae27 L10N : Translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-02-26 08:24:06 +00:00
Konstantina Chremmou
b0f4c9901a Corrected localisation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-02-12 12:12:37 +00:00
Konstantina Chremmou
164e2c5963 CA-334125: Restructured the feature selection tree. Localised some strings. UI tweaks.
- Changed warning and info icon to match XenCenter's.
- Corrected label margins.
- Made list controls flat.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-02-07 11:04:30 +00:00
Konstantina Chremmou
40fc989720 Moved scratch and output folders into the repo root.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-10 12:00:50 +00:00
Konstantina Chremmou
aca243dfa3 CP-32775: Make the installation of l10n resources optional.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-10 12:00:50 +00:00
Konstantina Chremmou
1d22100e01 CP-31105: Refactored installer branding. Sign only the combined msi file.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-10 12:00:50 +00:00
Konstantina Chremmou
ec298938c3 CP-32561: Upgraded WiX Toolset to 3.11.2. Also:
- Changed the verbosity of some commands.
- Do not compile the splash screen twice.
- Do not brand obsolete folder XenServer.
- Moved the WiX source patch to a more relevant folder.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-10 12:00:50 +00:00