Commit Graph

37 Commits

Author SHA1 Message Date
Michael
99af56ac94 REQ-720: Initial implementation of GPUEditPage and AddVgpuDialog. (#2422)
* CP-31063: Add support for multiple vGPU
(incomplete)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CP-31063: Add support for multiple vGPU
(part 2)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* AddVGPUDialog

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Update bindings.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* REQ-720: Initial implementation of AddVgpuDialog.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Improve the handling of buttons and combobox. Fix comments.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Fix comments.

Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Konstantina Chremmou
2a575b01a5 Fixed issue whereby VS kept toggling between SubType Component and User Control
for some custom controls.

In the case of DoubleBufferedPanel I removed the Designer attributes from
the class definition.
In the case of the EnableableComboBoxEditingControl I moved it to a new
file because the other classes it was sharing the old file with did not
derive from Component.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-09 16:23:29 +00:00
Konstantina Chremmou
14aa3f3f5d CA-289335: Do not check the NetworkComboBoxItem can be selected unless it has been added to the ComboBox.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-06 16:06:41 +01:00
Mihaela Stoica
c2b42fa107 CA-289335: Refactoring to avoid setting the SelectedItem twice
- also avoids iterating through the combobox items again to determine which item to select

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-24 16:23:04 +01:00
Konstantina Chremmou
fb8434819d Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-11-30 13:56:32 +00:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Stephen Turner
6d8c7b76df CA-95798: Limit size of LongStringComboBox 2017-03-10 17:29:58 +00:00
Mihaela Stoica
430b9e87ed CP-19607: More event handlers that needed to be deregistered 2017-01-31 14:35:59 +00:00
Gabor Apati-Nagy
978f85233c CA-176169: Added copyright statement to files which it was missing from
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-16 20:14:56 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Callum McIntyre
b3e334654f [CA-229350] PVS allows Memory Only even when no control domain memory available
We now disable the Memory Only option if the available dom0 memory is less than the minimum the spinner supports (1Gb)
2016-11-14 14:59:57 +00:00
Konstantina Chremmou
bdbd9e1f55 CP-17502: No directly related to this ticket, but I found myself in the ISO SR neighbourhood and did some minor refactoring. 2016-06-21 10:29:37 +01:00
Mihaela Stoica
3f7f33fc40 CA-210732: XenCenter VM properties GPU always shows "None" (#983)
* CA-210732: XenCenter VM properties GPU always shows "None"

The error occurs when there is a gpu group with only one vgpu type: When setting the selected item in the vGPU combobox, XenCenter tries to select the group header instead of the vGPU type; because the group header is not selectable, we then default to "None".
With this fix, we ensure that two items are not equal if one is a group header and the other is a subitem.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-210732: XenCenter VM properties GPU always shows "None"

Changes following code review: Added the reverse case in the Equals function

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-210732: XenCenter VM properties GPU always shows "None"

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-05-12 13:44:16 +01:00
CITRITE\sriharshak
8c0623b8f2 L10N:Dundee:Translation check-ins 2016-04-20 19:16:33 +05:30
Stephen Turner
5093ef677c CA-201421: tools ISO is missing in drop-down list 2016-02-25 17:18:48 +00:00
Stephen Turner
85c8cf0398 CA-198276: Restrict number of sockets to 16 2016-02-12 17:01:05 +00:00
Stephen Turner
8646a1ca3a CP-12966 GPU drop-down to behave correctly when there is one vGPU type and no passthrough 2015-07-13 16:27:18 +01:00
Gabor Apati-Nagy
aefed11165 Revert "CA-149867: Invoke on MainWindow instead of various controls"
This reverts commit 92f0499911.
2015-04-16 14:17:02 +01:00
Gabor Apati-Nagy
92f0499911 CA-149867: Invoke on MainWindow instead of various controls
We observed that some threads can reach deadlock-ish state after they have Invoked into a control's UI thread. When it happens they are all in a waiting for join or in sleep state for very long time, although there should not be any deadlock situations.
It seems this has something to do with multiple parent controls and with which control we invoked on. This should not make a difference, because we have got one UI thread (for MainWindow) they should wait for, but we have seen it does.

The solution that fixed this issue was to invoke on the MainWindow instead of various controls (see a4fe507adf ).

This changeset is changing all our Invokes to invoke into MainWindow
instead of a control itself. (MainWindow's UI thread is the only UI thread
all Control is using in XenCenter)
This changeset should be in place until we have found the root cause or the exact reason for the above.
2015-04-08 15:16:10 +01:00
Mihaela Stoica
a295ab0159 CA-157501: Fixing inconsistent GPU dialogs in XS "Standard" when compared with "Enterprise"
Changes following code review:
- Added VM.CanHaveVGpu function (at the moment just returns CanHaveGpu, but it will change in the future)
- Added vGPU_type.IsPassthrough function and used it everywhere we needed to test for passthrough (max-heads==0)
- Simplified code in Helpers.GpuCapability, Helpers.VGpuCapability, NewVMWizard (gpuCapability), MainWindow and GpuRow

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-01-21 10:04:47 +00:00
vetrivelc
6e2e1a214d Iteration_002 translation check-ins 2014-10-14 21:41:41 +05:30
vetrivelc
2ab95c7899 CreedenceLN: Updated the language resource files
New translation checki-ns and language file additions
2014-09-18 15:03:24 +05:30
Mihaela Stoica
8c6f9eebc1 CP-8120 Cores-per-socket: When building the topology list ignore the maximum number of cores-per-socket (i.e. number of cores per socket on the underlying server) if this is zero, for example because the socket information is not available on 6.1 servers.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-17 12:46:59 +01:00
Mihaela Stoica
963f21b074 CA-138293: Added CPU information (number of vCPUs and cores-per-socket) to the VM General tab
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-14 15:17:47 +01:00
Mihaela Stoica
17527eebe4 CP-8120 Set cores per socket through XenCenter. Added 'Topology' field to the VM properties Dialog
- Added Topology drop-down box with available values for sockets and cores per socket, so that the number of vCPUs is divisible by the number of cores per socket.
E.g. if user specified 8 vCPUs, Cores per socket can only be 1, 2, 4, or 8.
- This updates VM's platform:cores-per-socket property.
- Can only be set when the VM is shut down (similar to number of vCPUs).
- Text on CPU page - changed to include topology.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-05 13:00:14 +01:00
Konstantina Chremmou
c73dc6cbb8 CA-121659: If the pass-through is the only vGPU type available, then the GPU type list should show this type as the group name and selectable
# HG changeset patch
# User Mihaela Stoica <Mihaela.Stoica@citrix.com>
# Date 1385047350 0
#      Thu Nov 21 15:22:30 2013 +0000
# Node ID 6bbdd9b672dad33c9a4406c8d1acdb27b6d8f333
# Parent  196102f9e29ba724809d2c6a74b6a9187f17732a

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-12-11 10:26:54 +00:00
Konstantina Chremmou
1437c29f68 CA-121659: Fixed issue where GPU passthrough setting was not saved for a VM on a host without NVIDIA host drivers installed.
# HG changeset patch
# User Mihaela Stoica <Mihaela.Stoica@citrix.com>
# Date 1385031139 0
#      Thu Nov 21 10:52:19 2013 +0000
# Node ID 47ee07818c23a637d76eb911ef54c0d07825c2dd
# Parent  b230e1085671ce2e81e888aa0396b7adceef1e4c

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-12-11 10:23:02 +00:00
Konstantina Chremmou
a662268286 [CP-6856]: PR-1675: Visual tweaks and other final changes:
# HG changeset patch
# User Gabor Apati-Nagy <Gabor.Apati-Nagy@citrix.com>
# Date 1383736103 0
#      Wed Nov 06 11:08:23 2013 +0000
# Node ID f79a41a7c73e5555143a1f5cdf7bd3e8f27a8fba
# Parent  04c02de675af090f3171b6fbf3b21b023c645c24
GPU page:
5. put GPU page back at server level
7. Move Edit button of "Placement policy" closer to text and make the box smaller and fixed
8. Put Placement policy box within the scroll bar

VM properties dialog / New VM wizard:
9. gpu types should be shown in order 2-4-8
10. show types that are not allowed as disabled items in the combobox (instead of not showing at all)
11. increase the height of combobox (max no of items) so that all items are seen without scroll

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-14 11:44:05 +00:00
Konstantina Chremmou
6458a8f50e CP-6708: Show vGPU parameters at vGPU selection time (PR-1675)
# HG changeset patch
# User Mihaela Stoica <Mihaela.Stoica@citrix.com>
# Date 1383126814 0
#      Wed Oct 30 09:53:34 2013 +0000
# Node ID 8af833de348d090a0126ad2f922ba7679739b654
# Parent  35673b51503006bbbb1e6647b1e0eb1938bd72ef

- added Max displays and Video RAM
- videoRAM needs TO BE REPLACED with max_resolution when this becomes available in the API

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-14 11:27:33 +00:00
Konstantina Chremmou
5171d35130 CP-6085: Per-pool overview of vGPUs (PR-1675)
# HG changeset patch
# User Mihaela Stoica <Mihaela.Stoica@citrix.com>
# Date 1381928854 -3600
#      Wed Oct 16 14:07:34 2013 +0100
# Node ID d3728527c55c8e615dc2979a4ed412a244c73299
# Parent  500886f75c7f678b98ad5fab5902a0e87d1798ea

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-14 11:06:50 +00:00
Konstantina Chremmou
5acc022f1e CA-82957: Some code tidy and removal of unused method.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-27 16:57:59 +01:00
Konstantina Chremmou
c051f8de94 CA-82957: Refactoring to our custom ComboBoxes with regards to resource management and disposal.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-27 16:57:50 +01:00
Konstantina Chremmou
11fc4cdc22 CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
# Date 1378916844 -3600
# Node ID 0500f0579cb1ac5be16d46b33fb94ec3215afcbc
# Parent  cb7aab1ca88e76ca253a588935fad659ae794600
CA-115250: Corrected string drawing causing truncation on JA version.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 15:00:29 +01:00
Konstantina Chremmou
307646d0a9 CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
# Date 1377007835 -3600
# Node ID a1c6bcf2b4d3119cff54d87fb97bd2491c9d8f67
# Parent  41c2dfb11187cbc91b4f874b1df8c06524aad3c7
CA-113310: Corrected string measurement which was causing truncation on SC and a
lot of white space on EN and JA versions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 14:33:50 +01:00
Konstantina Chremmou
cab8dca36b CP-6083: Added vGPUs to the VM's property page.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-18 13:06:47 +01:00
Konstantina Chremmou
355fa30243 CP-6083: Preliminary refactoring: moved common code responsible for skipping non
selectable combobox items from the classes EnableableComboBox and ISODropDownBox
to a base class called NonSelectableComboBox.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-16 10:13:21 +01:00
Konstantina Chremmou
8c15bcc6d9 CP-6083: Preliminary tidy up: moved all custom comboboxes into a subfolder of the Controls folder.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-13 12:43:29 +01:00