Commit Graph

3448 Commits

Author SHA1 Message Date
Konstantina Chremmou
e6da7045b6 Ensure we always dispose of the ArchiveIterator and ArchiveWriter after use.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-13 10:18:15 +01:00
Konstantina Chremmou
38fcc83874 Fixed labels; removed unnecessary control disablement.
The blurbs should be user-centric rather than developer-centric.
No need to disable the page controls in the absence of signature/manifest
since the whole page becomes disabled in that case.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-13 10:18:15 +01:00
Konstantina Chremmou
fd95530e4f CA-294511: Rewrote the OVA appliance abstraction class to include:
- Verification of appliance files in chunks to avoid StreamTooLong exception.
- Disposal of HashAlgorithms and X509Certificates after use.
- General code simplification.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-13 10:18:15 +01:00
Konstantina Chremmou
4cacc422b8 Small improvement to abstract class design.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-13 10:18:15 +01:00
Darren Matthews
4162b19cfc L10N : Translation and resx updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-08-09 12:14:59 +01:00
Konstantina Chremmou
909ac731dd CA-287873: Make undock/redock console work when pressing Shift+Alt+U.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-09 09:11:26 +01:00
Konstantina Chremmou
c0d6b409e2 CA-324782: Select the right memory SR otherwise the PVS cache appears as not configured.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-06 10:43:01 +01:00
Konstantina Chremmou
366267a975 Fixed checked state display issue on ShowToolbarMenuItem.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-06 10:43:01 +01:00
Konstantina Chremmou
dd94ebaf3f Duplicate key. Use "Delete" instead of "Delete VM" to match menus for other objects.
Made Debug Assertion more detailed to aid us pick unique hotkeys.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-25 13:09:22 +01:00
Konstantina Chremmou
655b8eedf7 Fixed truncation issue introduced by the fix to CA-311165.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-25 13:09:22 +01:00
Mihaela Stoica
76c806c0b3 CA-322790: Fix unhandled exception when the host cannot be reached to execute an API call.
In the CrossPoolMigrateCanMigrateFilter a WebException can be raised if the host cannot be reached to execute the API call that asserts is the VM can be migrated there. With these changes, we catch any exception (not just Failure) and mark the VM as not migratable (because we couldn't assert if it can be migrated to that host).

Also fixed other places where the same error might occur.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-07-24 09:46:00 +01:00
Konstantina Chremmou
30226c590d CA-116060: Stop saving the expanded state of the New Search panel with the other Search metadata.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-23 14:00:38 +01:00
Konstantina Chremmou
e0f42a5205 CA-311165: Modified Display Options
- Removed option to show host only vs pool properties on the Search Tab
when selecting a host within a pool. It is out of place and confusing
because the items under the host don't follow suit. The same result can
be achieved using the filters on the Search Tab.
- Added option to disable remembering the last selected Tab per object
as it can be annoying when trying to compare data on the same Tab for
different objects.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-23 14:00:38 +01:00
Darren Matthews
8c59390de0 L10N : CA-207272 truncation issue fix
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-07-23 11:27:21 +01:00
Konstantina Chremmou
8f2794b89d Prevent crash and improve behaviour when the user tries to configure/disable HA in a pool that has lost the HA statefile.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-23 10:28:01 +01:00
Mihaela Stoica
c137b4a6ea CA-317752: Take live-patching qualification into consideration in the Install Update pre-checks
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-07-22 17:49:18 +01:00
Konstantina Chremmou
0e57e871b9 Removed unnecessary instance class SrPickerItemFactory.
Removed comments that did not provide further info than the class name
they were documenting. Removed unused code. Launch progress dialog within
a using block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-22 16:19:25 +01:00
Konstantina Chremmou
6e9ac153ca CA-323248: Allow VDI move to a local SR if the latter can be seen from the home hosts of the VMs the VDI is attached to.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-22 16:19:25 +01:00
Konstantina Chremmou
85654a4f36 CA-314720: Replaced "Still waiting" dialog popping up during RPU with a message displayed in the upgrade output.
Also, fixed issue where uploading a supp-pack resulted in a perpetually
pending action if the file had disappeared from the disk.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-22 13:15:59 +01:00
Mihaela Stoica
3d3a96fbe6 CA-323766: Show the upgrade version in the RPU wizard, if available
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-07-22 12:24:07 +01:00
Darren Matthews
bd846babb6 L10N: CA-169591 truncation issue fixed
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-07-18 14:49:51 +01:00
Darren Matthews
60b4282aba L10N : Resx resync and translation update
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-07-18 14:49:51 +01:00
Konstantina Chremmou
b533585a79 Renamed release. Updated bindings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-18 09:38:26 +01:00
Mihaela Stoica
79c9a7ecbc CA-320203: Fixed the update wizard failure when installing two cumula… (#2466)
CA-320203: Fixed the update wizard failure when installing two cumulative updates

The issue was that when installing 2 new versions in one go (e.g. two cumulative updates), the installation succeeds on master but it cannot continue on slaves, because it cannot find the first CU update anymore.
The fix is to refresh the update record before applying the update, with the record found in the cache. Also, if there is no update in the cache, try to re-introduce the update.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-07-12 14:43:48 +01:00
Konstantina Chremmou
4844bac1e8 CP-30451: Unit test restructuring and modifications for better use of the Nunit3 framework.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 16:34:59 +01:00
Konstantina Chremmou
866eae0edc Minor improvements on ImportWizard pages.
- Made storage selector blurb for XVA import a bit more informative.
- A simple checkbox for starting the new VMS on the finish page is adequate.
- Typos. Property modernisation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 11:25:37 +01:00
Konstantina Chremmou
db02d206cb Duplicate hotkey. Layout simplification trying to leverage CA-209149.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 11:11:47 +01:00
Lin Liu
52a9bbe257 CA-322735: Keep XenCenter showing the real device number used in the VM
Signed-off-by: Lin Liu <lin.liu@citrix.com>
2019-07-09 08:31:04 +01:00
Darren Matthews
a0aeeccee7 L10N : Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-07-03 12:16:09 +01:00
Mihaela Stoica
891d4d9223 CP-31529: Update RPU003 to the version 8
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-06-21 12:22:01 +01:00
Mihaela Stoica
71333fcf90 CA-304656: Stop users from applying automated updates that will bring the server to a verson incompatible with the current XenCenter version.
When running the XenCenter version precheck, calculate the higher server version that will be installed (by looking at the update sequence) and use this for checking the XenCenter version compatibility.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-06-11 09:34:25 +01:00
Mihaela Stoica
23b0517cb7 CA-314346: Fix Next button enablement on the Destination page of the VM migrate and VM import wizards.
- if there is only one host in the selected pool, then preselect it.
- make sure that  the Next button is enabled when a target host is selected.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-06-11 09:07:07 +01:00
Michael Z
a0e3649ba8 CA-320182: Error in adding vGPU in New VM wizard.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Michael Z
9a26478a16 CP-31400: Collection of improvements.
1. Update AddVGPUDialog title;
2. Add label above the combobox;
3. In the combobox, add text to the entry saying if multiple vGPU is supported;
4. When the dialog is open, focus on the combobox;
5. Preselect the vGPU type if there is only one option available;
6. Setup the Help ID for dialog;
7. Optimize vGPU adding and deleting in GpuAssignAction.

Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Michael Z
7f4ddc87e7 Change AutoScaleMode to Dpi.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Michael Z
b0e6e6216b Simplify more.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Michael Z
9c94e4ffd0 CP-30423: Update binding; Remove hardcode for device; Simplify combobox building calculation.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Mihaela Stoica
1145f20fe8 CP-31063: Add info regarding multiple vGPU support.
Also, update the text referring to vGPUs and hide the PCI slot number column on older hosts

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-06-10 14:49:31 +08:00
Michael
99af56ac94 REQ-720: Initial implementation of GPUEditPage and AddVgpuDialog. (#2422)
* CP-31063: Add support for multiple vGPU
(incomplete)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CP-31063: Add support for multiple vGPU
(part 2)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* AddVGPUDialog

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Update bindings.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* REQ-720: Initial implementation of AddVgpuDialog.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Improve the handling of buttons and combobox. Fix comments.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Fix comments.

Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Darren Matthews
1f2a729573 L10N : Translation Updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-06-09 17:04:28 +01:00
Konstantina Chremmou
c7b531ed80 CP-31105: Moved the Homepage to the Branding folder and added it to the project as a link.
Also, no need to include the homepage sources to the project.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-06-04 16:38:18 +01:00
Mihaela Stoica
aee265b85d CA-311255: Fix duplicated entries of latest CR
- the issue was that in one usage of PatchCanBeInstalledOnHost the wrong version was passed to the applicableVersion parameter (in CreateAlertForXenServerVersion)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-29 08:48:37 +01:00
Darren Matthews
0a6d66ce6d L10N : translation update and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-05-28 21:53:56 +01:00
Mihaela Stoica
cdd57df54d CA-316236 Rename the "save a a template" option from the Snapshot page
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-23 15:09:59 +01:00
Mihaela Stoica
ae5d8331e0 CA-316236 Rename the export option from Snapshot page
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-23 15:09:59 +01:00
Konstantina Chremmou
8b1e799c7b General TabPage layout modifications (includes CA-164372). (#2439)
- CA-164372: Added line breaks in the pool updates list for readability and to match the corresponding host list.
- Moved the updates, version and licence sections closer together.
- Removed unnecessary panels and placed top buttons on a TableLayoutPanel.
- Moved size hardcoded values from the code to the resource files.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-05-21 11:58:26 +01:00
Mihaela Stoica
aaa573dd21
Merge pull request #2438 from xenserver/feature/REQ-745
Merge feature/REQ-745 branch into master
2019-05-20 10:48:48 +01:00
Mihaela Stoica
36b1e44030 CA-310177: Use a new tooltip message when the selected iso is neither corrupted nor an update
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-17 12:37:02 +01:00
Mihaela Stoica
6075f5185d CA-310177: Check if the selected iso file contains a valid ISO file system.
Also removed unnecessary call to OnPageUpdated.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-17 12:37:02 +01:00
Mihaela Stoica
32a41236a8 CA-317856: Ensure that VMs are repatriated after all hotfixes are appl… (#2436)
* CA-317856: Ensure that VMs are repatriated after all hotfixes are applied and the host has been rebooted.
- there is no need to remove the "reboot host" plan actions from the delayed actions list, because the action itself has code to check if a reboot is actually needed.
* CA-317856: Only add the "Exit maintenance mode" progress step if the host is in maintenance mode at that point.
- moved the AddProgressStep() call inside the function that checks if anything needs to be done (i.e. is host needs to be enables)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-17 12:32:25 +01:00